[JBoss JIRA] (JGRP-2165) TP.receive() should also handle InputStreams
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2165?page=com.atlassian.jira.plugin.... ]
Bela Ban resolved JGRP-2165.
----------------------------
Resolution: Done
> TP.receive() should also handle InputStreams
> --------------------------------------------
>
> Key: JGRP-2165
> URL: https://issues.jboss.org/browse/JGRP-2165
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 4.0.2
>
>
> Currently, {{TP.receive()}} is passed a byte[] buffer as parameter. This is OK for UDP and TCP_NIO2, however, in TCP we're dealing with a socket input stream.
> TcpConnection reads the length, then copies {{length}} bytes into a byte[] buffer and finally calls TP.receive() with the byte[] buffer as argument.
> The byte[] buffer and the copying of read data into it is superfluous if TP.receive() could also accept input streams as argument.
> Therefore introduce an additional {{TP.receive(InputStream in, int offset, int length}}, which reads directly from the socket's input stream and gets rid of the intermediate byte buffer.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JGRP-2165) TP.receive() should also handle InputStreams
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2165?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2165:
--------------------------------
This change had wider implications that simply adding {{receive(InputStream)}} to {{TP}}: any class extending {{org.jgroups.blocks.cs.ReceiverAdapter}} and wanting to handle both TCP_NIO2 and TCP had to implement both {{receive(InputStream)}} (TCP) _and_ {{receive(byte[])}} (TCP_NIO2).
This required a common protocol format (e.g. length first) for both TCP and TCP_NIO2. Affected classes included PubServer, PubClient, GossipRouter and RouterStub (used by TCPGOSSIP and TUNNEL).
> TP.receive() should also handle InputStreams
> --------------------------------------------
>
> Key: JGRP-2165
> URL: https://issues.jboss.org/browse/JGRP-2165
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 4.0.2
>
>
> Currently, {{TP.receive()}} is passed a byte[] buffer as parameter. This is OK for UDP and TCP_NIO2, however, in TCP we're dealing with a socket input stream.
> TcpConnection reads the length, then copies {{length}} bytes into a byte[] buffer and finally calls TP.receive() with the byte[] buffer as argument.
> The byte[] buffer and the copying of read data into it is superfluous if TP.receive() could also accept input streams as argument.
> Therefore introduce an additional {{TP.receive(InputStream in, int offset, int length}}, which reads directly from the socket's input stream and gets rid of the intermediate byte buffer.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFLY-8458) NPE when MBean does not have no-arg constructor
by Chao Wang (JIRA)
[ https://issues.jboss.org/browse/WFLY-8458?page=com.atlassian.jira.plugin.... ]
Chao Wang updated WFLY-8458:
----------------------------
Git Pull Request: https://github.com/wildfly/wildfly/pull/9860, https://github.com/wildfly/wildfly/pull/9864 (was: https://github.com/wildfly/wildfly/pull/9860)
> NPE when MBean does not have no-arg constructor
> -----------------------------------------------
>
> Key: WFLY-8458
> URL: https://issues.jboss.org/browse/WFLY-8458
> Project: WildFly
> Issue Type: Bug
> Components: JMX, Server
> Affects Versions: 11.0.0.Alpha1
> Reporter: Chao Wang
> Assignee: Chao Wang
> Fix For: 11.0.0.Beta1
>
>
> NPE when MBean does not have no-arg constructor, it should log an error message indicating the issue rather than NPE
> {code}
> 15:05:48,605 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-8) MSC000001: Failed to start service jboss.deployment.unit."jboss-helloworld-dynamicmbean-helloworld-mbean-service.sar".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."jboss-helloworld-dynamicmbean-helloworld-mbean-service.sar".INSTALL: WFLYSRV0153: Failed to process phase INSTALL of deployment "jboss-helloworld-dynamicmbean-helloworld-mbean-service.sar"
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:172)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:2032)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1955)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.IllegalArgumentException: WFLYSAR0004: Class not instantiated
> at org.jboss.as.service.ReflectionUtils.newInstance(ReflectionUtils.java:133)
> at org.jboss.as.service.ParsedServiceDeploymentProcessor.newInstance(ParsedServiceDeploymentProcessor.java:283)
> at org.jboss.as.service.ParsedServiceDeploymentProcessor.addServices(ParsedServiceDeploymentProcessor.java:129)
> at org.jboss.as.service.ParsedServiceDeploymentProcessor.deploy(ParsedServiceDeploymentProcessor.java:118)
> at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:165)
> ... 5 more
> Caused by: java.lang.NullPointerException
> at org.jboss.as.service.ReflectionUtils.newInstance(ReflectionUtils.java:131)
> ... 9 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFLY-8462) Improve feedback after invalid request for creating a datasource
by Karl-Philipp Richter (JIRA)
Karl-Philipp Richter created WFLY-8462:
------------------------------------------
Summary: Improve feedback after invalid request for creating a datasource
Key: WFLY-8462
URL: https://issues.jboss.org/browse/WFLY-8462
Project: WildFly
Issue Type: Enhancement
Affects Versions: 10.1.0.Final
Reporter: Karl-Philipp Richter
Assignee: Jason Greene
After creating a Non-XA datasource in the web frontend and pressing finish on the last dialog page, I get the message "Unknown error" and the data entered into the form is lost. Clicking on "Unknown error" a dialog is displayed with the content
```
Unexpected HTTP response: 500
Request
{
"name" => "jdbc/linuxtracker2",
"jta" => true,
"enabled" => true,
"user-name" => "APP",
"password" => "APP",
"jndi-name" => "java:/jdbc/linuxtracker2",
"use-ccm" => true,
"pool-name" => "jdbc/linuxtracker2_Pool",
"connection-url" => "jdbc:derby://localhost:1527/derby-pool",
"driver-class" => "org.apache.derby.jdbc.ClientDriver",
"driver-name" => "jdbc/linuxtracker2",
"operation" => "add",
"address" => [
("subsystem" => "datasources"),
("data-source" => "jdbc/linuxtracker2")
]
}
Response
Internal Server Error
{
"outcome" => "failed",
"failure-description" => {
"WFLYCTL0412: Required services that are not installed:" => ["jboss.jdbc-driver.jdbc/linuxtracker2"],
"WFLYCTL0180: Services with missing/unavailable dependencies" => [
"org.wildfly.data-source.jdbc/linuxtracker2 is missing [jboss.jdbc-driver.jdbc/linuxtracker2]",
"jboss.driver-demander.java:/jdbc/linuxtracker2 is missing [jboss.jdbc-driver.jdbc/linuxtracker2]"
]
},
"rolled-back" => true
}
```
which is extremely unhelpful given the fact that an error message listing and explaining the cause for the failure could be displayed (e.g. "the datasource xy couldn't be created because the name doesn't match the requirement yz").
It's hard to guess that clicking on the "Unknown error" popup opens a dialog.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFLY-8461) Improve feedback after invalid request for creating a datasource
by Karl-Philipp Richter (JIRA)
Karl-Philipp Richter created WFLY-8461:
------------------------------------------
Summary: Improve feedback after invalid request for creating a datasource
Key: WFLY-8461
URL: https://issues.jboss.org/browse/WFLY-8461
Project: WildFly
Issue Type: Enhancement
Affects Versions: 10.1.0.Final
Reporter: Karl-Philipp Richter
Assignee: Jason Greene
After creating a Non-XA datasource in the web frontend and pressing finish on the last dialog page, I get the message "Unknown error" and the data entered into the form is lost. Clicking on "Unknown error" a dialog is displayed with the content
```
Unexpected HTTP response: 500
Request
{
"name" => "jdbc/linuxtracker2",
"jta" => true,
"enabled" => true,
"user-name" => "APP",
"password" => "APP",
"jndi-name" => "java:/jdbc/linuxtracker2",
"use-ccm" => true,
"pool-name" => "jdbc/linuxtracker2_Pool",
"connection-url" => "jdbc:derby://localhost:1527/derby-pool",
"driver-class" => "org.apache.derby.jdbc.ClientDriver",
"driver-name" => "jdbc/linuxtracker2",
"operation" => "add",
"address" => [
("subsystem" => "datasources"),
("data-source" => "jdbc/linuxtracker2")
]
}
Response
Internal Server Error
{
"outcome" => "failed",
"failure-description" => {
"WFLYCTL0412: Required services that are not installed:" => ["jboss.jdbc-driver.jdbc/linuxtracker2"],
"WFLYCTL0180: Services with missing/unavailable dependencies" => [
"org.wildfly.data-source.jdbc/linuxtracker2 is missing [jboss.jdbc-driver.jdbc/linuxtracker2]",
"jboss.driver-demander.java:/jdbc/linuxtracker2 is missing [jboss.jdbc-driver.jdbc/linuxtracker2]"
]
},
"rolled-back" => true
}
```
which is extremely unhelpful given the fact that an error message listing and explaining the cause for the failure could be displayed (e.g. "the datasource xy couldn't be created because the name doesn't match the requirement yz").
It's hard to guess that clicking on the "Unknown error" popup opens a dialog.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFLY-8460) Improve feedback after invalid request for creating a datasource
by Karl-Philipp Richter (JIRA)
Karl-Philipp Richter created WFLY-8460:
------------------------------------------
Summary: Improve feedback after invalid request for creating a datasource
Key: WFLY-8460
URL: https://issues.jboss.org/browse/WFLY-8460
Project: WildFly
Issue Type: Enhancement
Affects Versions: 10.1.0.Final
Environment: Ubuntu 16.10 amd64 with OpenJDK 8
Reporter: Karl-Philipp Richter
Assignee: Jason Greene
After creating a Non-XA datasource in the web frontend and pressing finish on the last dialog page, I get the message "Unknown error" and the data entered into the form is lost. Clicking on "Unknown error" a dialog is displayed with the content
```
Unexpected HTTP response: 500
Request
{
"name" => "jdbc/linuxtracker2",
"jta" => true,
"enabled" => true,
"user-name" => "APP",
"password" => "APP",
"jndi-name" => "java:/jdbc/linuxtracker2",
"use-ccm" => true,
"pool-name" => "jdbc/linuxtracker2_Pool",
"connection-url" => "jdbc:derby://localhost:1527/derby-pool",
"driver-class" => "org.apache.derby.jdbc.ClientDriver",
"driver-name" => "jdbc/linuxtracker2",
"operation" => "add",
"address" => [
("subsystem" => "datasources"),
("data-source" => "jdbc/linuxtracker2")
]
}
Response
Internal Server Error
{
"outcome" => "failed",
"failure-description" => {
"WFLYCTL0412: Required services that are not installed:" => ["jboss.jdbc-driver.jdbc/linuxtracker2"],
"WFLYCTL0180: Services with missing/unavailable dependencies" => [
"org.wildfly.data-source.jdbc/linuxtracker2 is missing [jboss.jdbc-driver.jdbc/linuxtracker2]",
"jboss.driver-demander.java:/jdbc/linuxtracker2 is missing [jboss.jdbc-driver.jdbc/linuxtracker2]"
]
},
"rolled-back" => true
}
```
which is extremely unhelpful given the fact that an error message listing and explaining the cause for the failure could be displayed (e.g. "the datasource xy couldn't be created because the name doesn't match the requirement yz").
It's hard to guess that clicking on the "Unknown error" popup opens a dialog.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFCORE-2534) SlaveReconnectTestCase fails with security manager in WF core
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2534?page=com.atlassian.jira.plugi... ]
James Perkins reassigned WFCORE-2534:
-------------------------------------
Assignee: James Perkins
> SlaveReconnectTestCase fails with security manager in WF core
> -------------------------------------------------------------
>
> Key: WFCORE-2534
> URL: https://issues.jboss.org/browse/WFCORE-2534
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management, Test Suite
> Reporter: Jan Tymel
> Assignee: James Perkins
>
> *org.jboss.as.test.integration.domain.slavereconnect.SlaveReconnectTestCase#test01_OrderedExtensionsAndDeployments*
> *org.jboss.as.test.integration.domain.slavereconnect.SlaveReconnectTestCase#test02_DeploymentOverlays*
> {{cd testsuite/domain/}}
> {{mvn test -Dtest=SlaveReconnectTestCase -Dsecurity.manager -DtestLogToFile=false}}
> {code}
> [Server:server-affected] 13:16:12,425 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-7) MSC000001: Failed to start service test.deployment.one: org.jboss.msc.service.StartException in service test.deployment.one: Failed to start service
> [Server:server-affected] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1978) [jboss-msc-1.2.7.SP1-redhat-1.jar:1.2.7.SP1-redhat-1]
> [Server:server-affected] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1153) [rt.jar:1.8.0]
> [Server:server-affected] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [rt.jar:1.8.0]
> [Server:server-affected] at java.lang.Thread.run(Thread.java:785) [vm.jar:1.8.0]
> [Server:server-affected] Caused by: java.security.AccessControlException: WFSM000001: Permission check failed (permission "("java.util.PropertyPermission" "test.deployment.prop.one" "write")" in code source "(vfs:/content/reconnect-slave-depone.jar <no signer certificates>)" of "ModuleClassLoader for Module "deployment.reconnect-slave-depone.jar" from Service Module Loader")
> [Server:server-affected] at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278) [wildfly-elytron-1.1.0.Beta27-redhat-1.jar:1.1.0.Beta27-redhat-1]
> [Server:server-affected] at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175) [wildfly-elytron-1.1.0.Beta27-redhat-1.jar:1.1.0.Beta27-redhat-1]
> [Server:server-affected] at java.lang.System.setProperty(System.java:476) [vm.jar:1.8.0]
> [Server:server-affected] at org.jboss.as.test.integration.domain.slavereconnect.deployment.ServiceActivatorBaseDeployment.start(ServiceActivatorBaseDeployment.java:64)
> [Server:server-affected] at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:2032) [jboss-msc-1.2.7.SP1-redhat-1.jar:1.2.7.SP1-redhat-1]
> [Server:server-affected] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1955) [jboss-msc-1.2.7.SP1-redhat-1.jar:1.2.7.SP1-redhat-1]
> [Server:server-affected] ... 3 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month