[JBoss JIRA] (WFCORE-2566) Subsystem parsing tests ignores wrong END_ELEMENT
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2566?page=com.atlassian.jira.plugi... ]
Jan Kalina updated WFCORE-2566:
-------------------------------
Description:
Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
Tests will fail only if some next element follows - its parsing fails in such case correctly.
Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
Because this can stay bugs like https://github.com/wildfly-security-incubator/wildfly-core/pull/85/files unnoticed.
was:
Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
Tests will fail only if some next element follows - its parsing fails in such case correctly.
Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
Because this can stay bugs like https://github.com/wildfly-security-incubator/wildfly-core/pull/88 unnoticed.
> Subsystem parsing tests ignores wrong END_ELEMENT
> -------------------------------------------------
>
> Key: WFCORE-2566
> URL: https://issues.jboss.org/browse/WFCORE-2566
> Project: WildFly Core
> Issue Type: Bug
> Components: Test Suite
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Minor
>
> Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
> Tests will fail only if some next element follows - its parsing fails in such case correctly.
> Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
> Because this can stay bugs like https://github.com/wildfly-security-incubator/wildfly-core/pull/85/files unnoticed.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (ELY-923) Elytron LDAP caching realm should cache attributes and credentials
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-923?page=com.atlassian.jira.plugin.sy... ]
Jan Kalina reopened ELY-923:
----------------------------
Reopening: requested caching evidences too
> Elytron LDAP caching realm should cache attributes and credentials
> ------------------------------------------------------------------
>
> Key: ELY-923
> URL: https://issues.jboss.org/browse/ELY-923
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Realms
> Affects Versions: 1.1.0.Beta21
> Reporter: Ondrej Kotek
> Assignee: Jan Kalina
> Priority: Blocker
> Fix For: 1.1.0.Beta28
>
>
> Elytron {{caching-realm}} backed by {{ldap-realm}} provides caching for identity objects but not for related credentials and attributes. This is currently due to design of {{ldap-realm}} (like in case of {{filesystem-realm}}, see ELY-915).
> Credentials and attributes should not be loaded from LDAP for a cache hit.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFCORE-2518) Unable to configure Krb5LoginModule options in elytron kerberos implementation
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2518?page=com.atlassian.jira.plugi... ]
Darran Lofthouse resolved WFCORE-2518.
--------------------------------------
Resolution: Done
> Unable to configure Krb5LoginModule options in elytron kerberos implementation
> ------------------------------------------------------------------------------
>
> Key: WFCORE-2518
> URL: https://issues.jboss.org/browse/WFCORE-2518
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Affects Versions: 3.0.0.Beta7
> Reporter: Martin Choma
> Assignee: Darran Lofthouse
> Priority: Blocker
> Fix For: 3.0.0.Beta8
>
>
> Krb5LoginModule options are not configurable. I mean there are some of them exposed (debug, keytab, acceptor/initiator), but not all. In my opinion, sooner or later customers will hunt us to provide all of them. Because there are various use-cases out there needing to tweak kerberos configuration somehow. Legacy KerberosLoginModule exposed these options https://access.redhat.com/documentation/en/red-hat-jboss-enterprise-appli...
> {code:java}
> if (debug) {
> options.put("debug", "true");
> }
> options.put("principal", principal);
> final AppConfigurationEntry ace;
> if (IS_IBM) {
> options.put("noAddress", "true");
> options.put("credsType", isServer ? "acceptor" : "initiator");
> options.put("useKeytab", keyTab.toURI().toURL().toString());
> ace = new AppConfigurationEntry(IBMKRB5LoginModule, REQUIRED, options);
> } else {
> options.put("storeKey", "true");
> options.put("useKeyTab", "true");
> options.put("keyTab", keyTab.getAbsolutePath());
> options.put("isInitiator", isServer ? "false" : "true");
> ace = new AppConfigurationEntry(KRB5LoginModule, REQUIRED, options);
> }
> {code}
> ^ GSSCredentialSecurityFactory
> * http://docs.oracle.com/javase/8/docs/jre/api/security/jaas/spec/com/sun/s...
> * https://www.ibm.com/support/knowledgecenter/en/SSYKE2_8.0.0/com.ibm.java....
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFCORE-2518) Unable to configure Krb5LoginModule options in elytron kerberos implementation
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2518?page=com.atlassian.jira.plugi... ]
Darran Lofthouse reassigned WFCORE-2518:
----------------------------------------
Assignee: Darran Lofthouse (was: Jan Kalina)
> Unable to configure Krb5LoginModule options in elytron kerberos implementation
> ------------------------------------------------------------------------------
>
> Key: WFCORE-2518
> URL: https://issues.jboss.org/browse/WFCORE-2518
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Affects Versions: 3.0.0.Beta7
> Reporter: Martin Choma
> Assignee: Darran Lofthouse
> Priority: Blocker
> Fix For: 3.0.0.Beta8
>
>
> Krb5LoginModule options are not configurable. I mean there are some of them exposed (debug, keytab, acceptor/initiator), but not all. In my opinion, sooner or later customers will hunt us to provide all of them. Because there are various use-cases out there needing to tweak kerberos configuration somehow. Legacy KerberosLoginModule exposed these options https://access.redhat.com/documentation/en/red-hat-jboss-enterprise-appli...
> {code:java}
> if (debug) {
> options.put("debug", "true");
> }
> options.put("principal", principal);
> final AppConfigurationEntry ace;
> if (IS_IBM) {
> options.put("noAddress", "true");
> options.put("credsType", isServer ? "acceptor" : "initiator");
> options.put("useKeytab", keyTab.toURI().toURL().toString());
> ace = new AppConfigurationEntry(IBMKRB5LoginModule, REQUIRED, options);
> } else {
> options.put("storeKey", "true");
> options.put("useKeyTab", "true");
> options.put("keyTab", keyTab.getAbsolutePath());
> options.put("isInitiator", isServer ? "false" : "true");
> ace = new AppConfigurationEntry(KRB5LoginModule, REQUIRED, options);
> }
> {code}
> ^ GSSCredentialSecurityFactory
> * http://docs.oracle.com/javase/8/docs/jre/api/security/jaas/spec/com/sun/s...
> * https://www.ibm.com/support/knowledgecenter/en/SSYKE2_8.0.0/com.ibm.java....
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFCORE-2566) Subsystem parsing tests ignores wrong END_ELEMENT
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2566?page=com.atlassian.jira.plugi... ]
Jan Kalina updated WFCORE-2566:
-------------------------------
Description:
Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
Tests will fail only if some next element follows - its parsing fails in such case correctly.
Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
Because this can stay bugs like https://github.com/wildfly-security-incubator/wildfly-core/pull/88 unnoticed.
was:
Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
Tests will fail only if some next element follows - its parsing fails in such case correctly.
Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
> Subsystem parsing tests ignores wrong END_ELEMENT
> -------------------------------------------------
>
> Key: WFCORE-2566
> URL: https://issues.jboss.org/browse/WFCORE-2566
> Project: WildFly Core
> Issue Type: Bug
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Minor
>
> Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
> Tests will fail only if some next element follows - its parsing fails in such case correctly.
> Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
> Because this can stay bugs like https://github.com/wildfly-security-incubator/wildfly-core/pull/88 unnoticed.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFCORE-2518) Unable to configure Krb5LoginModule options in elytron kerberos implementation
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2518?page=com.atlassian.jira.plugi... ]
Jan Kalina reopened WFCORE-2518:
--------------------------------
Reopening - bug of parsing
> Unable to configure Krb5LoginModule options in elytron kerberos implementation
> ------------------------------------------------------------------------------
>
> Key: WFCORE-2518
> URL: https://issues.jboss.org/browse/WFCORE-2518
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Affects Versions: 3.0.0.Beta7
> Reporter: Martin Choma
> Assignee: Jan Kalina
> Priority: Blocker
> Fix For: 3.0.0.Beta8
>
>
> Krb5LoginModule options are not configurable. I mean there are some of them exposed (debug, keytab, acceptor/initiator), but not all. In my opinion, sooner or later customers will hunt us to provide all of them. Because there are various use-cases out there needing to tweak kerberos configuration somehow. Legacy KerberosLoginModule exposed these options https://access.redhat.com/documentation/en/red-hat-jboss-enterprise-appli...
> {code:java}
> if (debug) {
> options.put("debug", "true");
> }
> options.put("principal", principal);
> final AppConfigurationEntry ace;
> if (IS_IBM) {
> options.put("noAddress", "true");
> options.put("credsType", isServer ? "acceptor" : "initiator");
> options.put("useKeytab", keyTab.toURI().toURL().toString());
> ace = new AppConfigurationEntry(IBMKRB5LoginModule, REQUIRED, options);
> } else {
> options.put("storeKey", "true");
> options.put("useKeyTab", "true");
> options.put("keyTab", keyTab.getAbsolutePath());
> options.put("isInitiator", isServer ? "false" : "true");
> ace = new AppConfigurationEntry(KRB5LoginModule, REQUIRED, options);
> }
> {code}
> ^ GSSCredentialSecurityFactory
> * http://docs.oracle.com/javase/8/docs/jre/api/security/jaas/spec/com/sun/s...
> * https://www.ibm.com/support/knowledgecenter/en/SSYKE2_8.0.0/com.ibm.java....
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (WFCORE-2566) Subsystem parsing tests ignores wrong END_ELEMENT
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2566?page=com.atlassian.jira.plugi... ]
Jan Kalina updated WFCORE-2566:
-------------------------------
Steps to Reproduce:
* add some *requireNoContent* in the end of subsystem element parsing, where it should not be
* if there are only END_ELEMENTs after, test will be successful
* test will fail only if I add some (correct) START_ELEMENT after affected place (test should check this to fail without following elements too)
> Subsystem parsing tests ignores wrong END_ELEMENT
> -------------------------------------------------
>
> Key: WFCORE-2566
> URL: https://issues.jboss.org/browse/WFCORE-2566
> Project: WildFly Core
> Issue Type: Bug
> Reporter: Jan Kalina
> Assignee: Jan Kalina
> Priority: Minor
>
> Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
> Tests will fail only if some next element follows - its parsing fails in such case correctly.
> Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month