[JBoss JIRA] (DROOLS-1567) Threads in BLOCKED state in ProjectClassLoader and ParseTools
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1567?page=com.atlassian.jira.plugi... ]
Mario Fusco commented on DROOLS-1567:
-------------------------------------
On a side note let me also say that the static blacklist cache you added in your ProjectClassLoader is totally wrong because it will be shared by all CL in your app and different CLs with different configurations may or may not resolve the same class name.
> Threads in BLOCKED state in ProjectClassLoader and ParseTools
> -------------------------------------------------------------
>
> Key: DROOLS-1567
> URL: https://issues.jboss.org/browse/DROOLS-1567
> Project: Drools
> Issue Type: Enhancement
> Components: core engine
> Affects Versions: 6.5.0.Final
> Reporter: Arkady Syamtomov
> Assignee: Mario Fusco
>
> Building the knowledge bases in parallel threads does not scale due to the recurrent synchronised call of Class.forName, detected in ProjectClassLoader and org.mvel2.util.ParceTools.
> While in the org.drools.core.common.ProjectClassLoader the classes, if not found, are blacklisted, in the org.mvel2.util.ParceTools there is no blacklist logic implemented at all.
> Nevertheless, even with org.drools.core.common.ProjectClassLoader the issue remains, since the internal DRL conditions query are submitted as class names to resolve and with the number of rules growing in the system, the blacklisting of invalid class names is not enough any more: it would be desirable to have an internal hook to filter the names matching a configurable pattern.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 12 months
[JBoss JIRA] (DROOLS-1567) Threads in BLOCKED state in ProjectClassLoader and ParseTools
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1567?page=com.atlassian.jira.plugi... ]
Mario Fusco resolved DROOLS-1567.
---------------------------------
Resolution: Rejected
Hi [~arkadys], I investigated your reproducer but again I don't think that I can do anything about this. The problem you found is quite specific of your app and I don't want to pollute the ProjectClassLoader with configurable filter that (if misused) could also lead to very weird and difficult to track behaviours. Moreover the ProjectClassLoader already has a cache of non existing classes and this allow it to avoid the lookup more than once. Using your reproducer I verified that this cache is working as expected.
The only suggestion to hugely alleviate this problem that I can give you is avoid using the mvel dialect. In this way you'll avoid mvel's ParseTool to keep invoking the ClassLoader because the consequences will be internally implemented in pure Java. I hope this helps.
> Threads in BLOCKED state in ProjectClassLoader and ParseTools
> -------------------------------------------------------------
>
> Key: DROOLS-1567
> URL: https://issues.jboss.org/browse/DROOLS-1567
> Project: Drools
> Issue Type: Enhancement
> Components: core engine
> Affects Versions: 6.5.0.Final
> Reporter: Arkady Syamtomov
> Assignee: Mario Fusco
>
> Building the knowledge bases in parallel threads does not scale due to the recurrent synchronised call of Class.forName, detected in ProjectClassLoader and org.mvel2.util.ParceTools.
> While in the org.drools.core.common.ProjectClassLoader the classes, if not found, are blacklisted, in the org.mvel2.util.ParceTools there is no blacklist logic implemented at all.
> Nevertheless, even with org.drools.core.common.ProjectClassLoader the issue remains, since the internal DRL conditions query are submitted as class names to resolve and with the number of rules growing in the system, the blacklisting of invalid class names is not enough any more: it would be desirable to have an internal hook to filter the names matching a configurable pattern.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 12 months
[JBoss JIRA] (DROOLS-1567) Threads in BLOCKED state in ProjectClassLoader and ParseTools
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1567?page=com.atlassian.jira.plugi... ]
Mario Fusco updated DROOLS-1567:
--------------------------------
Issue Type: Enhancement (was: Bug)
> Threads in BLOCKED state in ProjectClassLoader and ParseTools
> -------------------------------------------------------------
>
> Key: DROOLS-1567
> URL: https://issues.jboss.org/browse/DROOLS-1567
> Project: Drools
> Issue Type: Enhancement
> Components: core engine
> Affects Versions: 6.5.0.Final
> Reporter: Arkady Syamtomov
> Assignee: Mario Fusco
>
> Building the knowledge bases in parallel threads does not scale due to the recurrent synchronised call of Class.forName, detected in ProjectClassLoader and org.mvel2.util.ParceTools.
> While in the org.drools.core.common.ProjectClassLoader the classes, if not found, are blacklisted, in the org.mvel2.util.ParceTools there is no blacklist logic implemented at all.
> Nevertheless, even with org.drools.core.common.ProjectClassLoader the issue remains, since the internal DRL conditions query are submitted as class names to resolve and with the number of rules growing in the system, the blacklisting of invalid class names is not enough any more: it would be desirable to have an internal hook to filter the names matching a configurable pattern.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 12 months
[JBoss JIRA] (ELY-1179) Support safe overriding of cipher suites defined for SSLContext
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-1179?page=com.atlassian.jira.plugin.s... ]
Darran Lofthouse updated ELY-1179:
----------------------------------
Summary: Support safe overriding of cipher suites defined for SSLContext (was: Support safe overriding of cipher suites deinfed for SSLContext)
> Support safe overriding of cipher suites defined for SSLContext
> ---------------------------------------------------------------
>
> Key: ELY-1179
> URL: https://issues.jboss.org/browse/ELY-1179
> Project: WildFly Elytron
> Issue Type: Task
> Components: SSL
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Fix For: 2.0.0.Alpha1
>
>
> Clients using a wrapped SSLContext may want to further restrict the cipher suites offered, we should allow this by mapping to a union of those enabled by our configuration and those specified by the calling client.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 12 months
[JBoss JIRA] (ELY-1179) Support safe overriding of cipher suites deinfed for SSLContext
by Darran Lofthouse (JIRA)
Darran Lofthouse created ELY-1179:
-------------------------------------
Summary: Support safe overriding of cipher suites deinfed for SSLContext
Key: ELY-1179
URL: https://issues.jboss.org/browse/ELY-1179
Project: WildFly Elytron
Issue Type: Task
Components: SSL
Reporter: Darran Lofthouse
Assignee: Darran Lofthouse
Fix For: 2.0.0.Alpha1
Clients using a wrapped SSLContext may want to further restrict the cipher suites offered, we should allow this by mapping to a union of those enabled by our configuration and those specified by the calling client.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 12 months
[JBoss JIRA] (WFLY-7192) 'name' attribute missing in XSD while required by web subsystem parser
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFLY-7192?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on WFLY-7192:
-----------------------------------------------
Petr Penicka <ppenicka(a)redhat.com> changed the Status of [bug 1365939|https://bugzilla.redhat.com/show_bug.cgi?id=1365939] from VERIFIED to CLOSED
> 'name' attribute missing in XSD while required by web subsystem parser
> ----------------------------------------------------------------------
>
> Key: WFLY-7192
> URL: https://issues.jboss.org/browse/WFLY-7192
> Project: WildFly
> Issue Type: Bug
> Reporter: Peter Palaga
> Assignee: Peter Palaga
> Labels: downstream_dependency
> Fix For: 11.0.0.Alpha1
>
>
> Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1365939 , originaly reported by [~paramjindal]
> While configuring the global valve using the following article :
> https://access.redhat.com/solutions/379813
> It is mandatory that the "name" attribute of valve must match the "auth-method" that is specified in the "WEB-INF/web.xml".
> So "name" attribute is mandatory to configure this valve.
> but it is not mentioned in the schema of valve as shown below :
> {code:xml}
> <xs:element name="valve">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="param" minOccurs="0" maxOccurs="unbounded" type="paramType" />
> </xs:sequence>
> <xs:attribute name="class-name" type="xs:string" use="required" />
> <xs:attribute name="module" type="xs:string" use="required" />
> <xs:attribute name="enabled" default="true" type="xs:boolean" />
> </xs:complexType>
> </xs:element>
> {code}
> Version-Release number of selected component (if applicable):
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 12 months