[JBoss JIRA] (WFCORE-2367) Misleading description of identity-realm
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2367?page=com.atlassian.jira.plugi... ]
Darran Lofthouse reassigned WFCORE-2367:
----------------------------------------
Assignee: (was: Darran Lofthouse)
> Misleading description of identity-realm
> ----------------------------------------
>
> Key: WFCORE-2367
> URL: https://issues.jboss.org/browse/WFCORE-2367
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Jan Tymel
>
> There is a misleading description of {{identity-realm}} in DMR [1]. It says _"A security realm definition where identities are represented in the management model."_ whereas an XSD documentation says _"Realm definition for a realm which contains a single pre-defined identity."_.
> In general, the XSD description looks clearer to me. Moreover, the {{identities}} word may be misleading since {{identity-realm}}'s purpose is to _"to store one identity, with one attribute and no credential"_ [3]. Thus I would suggest to also change the description of {{attribute-values}} from
> _"The values associated with the identities attribute."_ to something like _"The values associated with the identity attributes."_
> Suggestions for improvement:
> * Change description {{identity-realm}} according to XSD
> * Change description of {{attribute-values}} attr (in both DMR and XSD)
> * to consider: unify descriptions in XSD and DMR
> [1] /subsystem=elytron/identity-realm=somerealm:read-resource-description
> [2] https://github.com/wildfly-security/elytron-subsystem/blob/master/src/mai...
> [3] HipChats's WildFly Elytron chat room on Nov 21
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFCORE-2367) Misleading description of identity-realm
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2367?page=com.atlassian.jira.plugi... ]
Darran Lofthouse updated WFCORE-2367:
-------------------------------------
Fix Version/s: (was: 4.0.0.Alpha1)
> Misleading description of identity-realm
> ----------------------------------------
>
> Key: WFCORE-2367
> URL: https://issues.jboss.org/browse/WFCORE-2367
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Jan Tymel
> Assignee: Darran Lofthouse
>
> There is a misleading description of {{identity-realm}} in DMR [1]. It says _"A security realm definition where identities are represented in the management model."_ whereas an XSD documentation says _"Realm definition for a realm which contains a single pre-defined identity."_.
> In general, the XSD description looks clearer to me. Moreover, the {{identities}} word may be misleading since {{identity-realm}}'s purpose is to _"to store one identity, with one attribute and no credential"_ [3]. Thus I would suggest to also change the description of {{attribute-values}} from
> _"The values associated with the identities attribute."_ to something like _"The values associated with the identity attributes."_
> Suggestions for improvement:
> * Change description {{identity-realm}} according to XSD
> * Change description of {{attribute-values}} attr (in both DMR and XSD)
> * to consider: unify descriptions in XSD and DMR
> [1] /subsystem=elytron/identity-realm=somerealm:read-resource-description
> [2] https://github.com/wildfly-security/elytron-subsystem/blob/master/src/mai...
> [3] HipChats's WildFly Elytron chat room on Nov 21
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFCORE-2375) Definition Credential Store with existing storage file but with wrong store password causes ugly failure-description.
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2375?page=com.atlassian.jira.plugi... ]
Darran Lofthouse resolved WFCORE-2375.
--------------------------------------
Fix Version/s: 3.0.0.Beta29
(was: 4.0.0.Alpha1)
Resolution: Done
> Definition Credential Store with existing storage file but with wrong store password causes ugly failure-description.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-2375
> URL: https://issues.jboss.org/browse/WFCORE-2375
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Hynek Švábek
> Assignee: Darran Lofthouse
> Fix For: 3.0.0.Beta29
>
>
> Definition Credential Store with existing storage file but with wrong store password causes ugly failure-description.
> *How to reproduce*
> Prepare credential store file (the easiest way is create credential store from scratch)
> /subsystem=elytron/credential-store=cs_pass123:add(uri="cr-store://test/cs/ks-pass123.jceks?store.password=pass123;create.storage=true")
> /subsystem=elytron/credential-store=cs_pass123/alias=dbPass:add(secret-value=passwordToDB)
> Then I try to create Credential store with wrong store password to existing store file.
> /subsystem=elytron/credential-store=cs_wrong_store_pass:add(uri="cr-store://test/cs/ks-pass123.jceks?store.password=pass123wrong;key.password=pass123=true")
> *I can see this result:*
> {code}
> {
> "outcome" => "failed",
> "failure-description" => {
> "WFLYCTL0080: Failed services" => {"org.wildfly.security.credential-store-client.cs_wrong_key_pass" => "org.jboss.msc.service.StartException in service org.wildfly.security.credential-store-client.cs_wrong_key_pass: WFLYELY00004: Unable to start the service.
> Caused by: org.wildfly.security.credential.store.CredentialStoreException: ELY09506: Cannot read credential storage file '/home/hsvabek/securityworkspace/VERIFICATION/2016_11_02_UX_testing/jboss-eap-7.1.0.DR7/standalone/data/cs/ks-pass123.jceks' for the store named 'cs_wrong_key_pass'
> Caused by: java.io.IOException: Keystore was tampered with, or password was incorrect"},
> "WFLYCTL0412: Required services that are not installed:" => ["org.wildfly.security.credential-store-client.cs_wrong_key_pass"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => undefined
> },
> "rolled-back" => true
> }
> {code}
> *Suggestion for solution*
> failure-description must not contain Exception or snippet stacktrace.
> Description like that "Password to access credential store is incorrect."
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFCORE-2381) CS tool, review usage documentation
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2381?page=com.atlassian.jira.plugi... ]
Darran Lofthouse resolved WFCORE-2381.
--------------------------------------
Fix Version/s: 3.0.0.Beta29
Resolution: Done
> CS tool, review usage documentation
> -----------------------------------
>
> Key: WFCORE-2381
> URL: https://issues.jboss.org/browse/WFCORE-2381
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Martin Choma
> Assignee: Darran Lofthouse
> Priority: Critical
> Labels: credential-store
> Fix For: 3.0.0.Beta29
>
>
> Current usage output
> {code}
> usage: java -jar wildfly-elytron-tool.jar credential-store <sub-command>
> <options> -a <arg> | -e <arg> | -h | -r <arg> | -v [-c] [-f] [-i
> <arg>] [-l <arg>] [-p <arg>] [-s <arg>] [-t <arg>] [-u <arg>] [-x
> <arg>]
> -a,--add <arg> Add new alias to the credential store
> -c,--create Create credential store [true/false]
> -e,--exists <arg> Check if alias exists within the credential store
> -f,--summary Print summary, especially command how to create
> this credential store
> -h,--help Get help with usage of this command
> -i,--iteration <arg> Iteration count for for final masked password of
> the credential store
> -l,--location <arg> Location of credential store storage file
> -p,--password <arg> Password for credential store
> -r,--remove <arg> Remove alias from the credential store
> -s,--salt <arg> Salt to apply for final masked password of the
> credential store
> -t,--type <arg> Credential store type
> -u,--uri <arg> Configuration URI for credential store
> -v,--aliases Display all aliases
> -x,--secret <arg> Password credential value
> {code}
> IMO suffers with these issues:
> - it introduce misleading <sub-command> placeholder. It is not used now. It is prepared for future needs. Remove it please.
> - it is not obvious which options are required in conjuction with e.g. --add option
> - use GNU usage syntax. e.g. [] instead of <>
> - sometimes it will be more useful to replace <arg> with some meaningful name, e.g. --add alias
> I suggest something like
> {code}
> java -jar wildfly-elytron-tool.jar credential-store required_option [options]
> java -jar wildfly-elytron-tool.jar credential-store --add alias -u arg ... [-c] ...
> java -jar wildfly-elytron-tool.jar credential-store --remove alias -u arg [-c] ...
> ...
> One of these is required
> -a,--add alias Add new alias to the credential store
> -e,--exists alias Check if alias exists within the credential store
> -h,--help Get help with usage of this command
> -r,--remove alias Remove alias from the credential store
> -v,--aliases Display all aliases
> Options
> -c,--create Create credential store [true/false]
> -f,--summary Print summary, especially command how to create this credential store
> -i,--iteration count Iteration count for for final masked password of the credential store
> -l,--location file Location of credential store storage file
> -p,--password store_password Password for credential store
> -s,--salt arg Salt to apply for final masked password of the credential store
> -t,--type arg Credential store type
> -u,--uri arg Configuration URI for credential store
> -x,--secret value Password credential value
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months