[JBoss JIRA] (LOGMGR-167) Enable fallback on thread context ClassLoader for log context scanning
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/LOGMGR-167?page=com.atlassian.jira.plugin... ]
James Perkins commented on LOGMGR-167:
--------------------------------------
There is a {{ContextClassLoaderLogContextSelector}} in jboss-logmanager already. However WildFly uses it's own [{{LogContextSelector}}|https://github.com/wildfly/wildfly-core/blob/master/logging/src/main/java/org/jboss/as/logging/logmanager/WildFlyLogContextSelectorImpl.java].
Registering the {{LogContext}} on WildFly is happening during the deployment processing. Nothing in the deployment itself should be invoked until deployment processing is complete so in theory there shouldn't be a race condition.
Are the Spring dependencies included in the deployment or are they installed as a module?
> Enable fallback on thread context ClassLoader for log context scanning
> ----------------------------------------------------------------------
>
> Key: LOGMGR-167
> URL: https://issues.jboss.org/browse/LOGMGR-167
> Project: JBoss Log Manager
> Issue Type: Enhancement
> Reporter: James Netherton
>
> {{ClassLoaderLogContextSelector}} searches the call stack for a {{ClassLoader}} that's used as a map key to discover the appropriate {{LogContext}}.
> If the search fails, can we add an additional check that uses the ThreadContextClassLoader to lookup the {{LogContext}} from the {{contextMap}}?
> My reasoning for requesting this is described in this issue:
> https://github.com/wildfly-extras/wildfly-camel/issues/1919#issuecomment-...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFCORE-3181) Review CustomCredentialSecurityFactoryTestCase
by Darran Lofthouse (JIRA)
Darran Lofthouse created WFCORE-3181:
----------------------------------------
Summary: Review CustomCredentialSecurityFactoryTestCase
Key: WFCORE-3181
URL: https://issues.jboss.org/browse/WFCORE-3181
Project: WildFly Core
Issue Type: Bug
Components: Security, Test Suite
Reporter: Darran Lofthouse
Fix For: 4.0.0.Alpha1
The test case CustomCredentialSecurityFactoryTestCase appears to be testing that the 'code does what it does' rather than testing the 'code is doing what it should'.
The test is testing a custom credential security factory can be called but the test is using HTTP Basic authentication and relying on SPNEGO authentication being triggered as this is the only mechanism that currently uses this factory.
Should a minor change be required to the SPNEGO authentication mechanism which affects when this credential factory is called this test case could subsequently fail.
If possible it would be better to convert this test to be a SPNEGO test and then test the behaviour of the credential security factory affects the mechanism as expected.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months