[JBoss JIRA] (WFCORE-3259) ModelTestUtils isn't confirming the transformed boot ops work on the legacy slave
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3259?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-3259:
------------------------------------------
[~luck3y] Yes. Have a look at the CI run from the linked PR -- it resulted in failures in the undertow and connector modules in full. So we can't resolve this until those are fixed.
I found this when I was writing some new transformers for elytron work Jason is doing. The tests I was writing would fail in mysterious ways in checkFailedTransformedBootOperations, after the code I quoted in the description. They'd fail as the test moved on to testing write-attribute ops. The ops would fail with resource not found problems reporting there was no subsystem=elytron. That's because the problematic mainServices.executeOperation above with the boot ops was failing but the failure was ignored.
> ModelTestUtils isn't confirming the transformed boot ops work on the legacy slave
> ---------------------------------------------------------------------------------
>
> Key: WFCORE-3259
> URL: https://issues.jboss.org/browse/WFCORE-3259
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management, Test Suite
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
>
> In checkFailedTransformedBootOperations:
> {code}
> if (config.isTransformComposite()) {
> //Transform and execute the composite
> TransformedOperation transformedComposite = mainServices.transformOperation(modelVersion, legacyComposite);
> if (transformedComposite.rejectOperation(successResult())) {
> Assert.fail(transformedComposite.getFailureDescription());
> }
> mainServices.executeOperation(modelVersion, transformedComposite);
> }
> {code}
> The outcome of that "mainServices.executeOperation" is ignored, so if the transformation isn't actually producing good ops, we don't know that.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFCORE-3265) Transformer ValueConverter utilities for complex attributes
by Brian Stansberry (JIRA)
Brian Stansberry created WFCORE-3265:
----------------------------------------
Summary: Transformer ValueConverter utilities for complex attributes
Key: WFCORE-3265
URL: https://issues.jboss.org/browse/WFCORE-3265
Project: WildFly Core
Issue Type: Enhancement
Components: Domain Management
Reporter: Brian Stansberry
As we start to have more complex attributes in our model, we need better facilities for doing transformer work with the internals of those attributes, rather than just with the top level attribute.
For rejects we have a decent start with RejectAttributeChecker.ListRejectAttributeChecker and RejectAttributeChecker.ObjectFieldsRejectAttributeChecker. Maybe that is all that is needed. For discards, I don't think there is anything to do, or at least not as a priority, as discards are about the kernel deciding to toss the attribute as a whole. (Perhaps for some case would want to toss an entire attribute based on a value of a field, but that seems like a real edge case.)
Where we are lacking is with AttributeConverters. For a complex attribute, a AttributeConverter could do something much like what a discard does -- remove a new field if it is set to some value that the legacy slave would do without configuration. (See WFCORE-3260 for why this kind of removal is important.)
We should have
AttributeConverter.ListAttributeConverter -- takes an AttributeConverter as a constructor param and applies it to elements, removing elements if the converter returns an undefined node.
AttributeConverter.ObjectFieldsConverter -- takes a Map<AD, AttributeConverter> as a constructor param and for each item in the map applies the converter to the corresponding field value, removing the field altogether if the converter returns an undefined node.
AttributeConverter.ObjectFieldsDiscarder -- takes a Map<AD, DiscardAttributeChecker> as a constructor param and for each item in the map applies the discard checker to the corresponding field value, removing the field altogether if the discarder says its discardable.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFLY-9324) Driver-name parameter should not be required
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9324?page=com.atlassian.jira.plugin.... ]
Brian Stansberry commented on WFLY-9324:
----------------------------------------
Fixing this will be a bit of a pain, or at least require a bit of custom code.
Really, driver-name should not be declared as a parameter of the :add op at all, as its value is ultimately ignored. But, simply dropping it as a declared parameter will result in the CLI rejecting existing scripts that use it, and scripts will use it since currently the server will fail ops that don't. The CLI can be configured to not do that kind of validation, but users shouldn't have to do that.
Fixes:
1) When iterating over the parameters in the add handler, check for driver-name and don't call validateAndSet on it.
or
2) Don't include driver-name in the array of ADs that the add handler iterates over. Fragile as now there will be two arrays to keep in sync.
> Driver-name parameter should not be required
> --------------------------------------------
>
> Key: WFLY-9324
> URL: https://issues.jboss.org/browse/WFLY-9324
> Project: WildFly
> Issue Type: Bug
> Components: JCA
> Affects Versions: 11.0.0.CR1
> Reporter: Michal Petrov
>
> Kind of a regression of AS7-4041. Currently the AttributeDefinition for {{driver-name}} is [marked as required|https://github.com/wildfly/wildfly/blob/5278ccf0cd392c2d82e96385...] which is unnecessary since the name is taken from the operation.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFLY-9310) Class loading hierarchie
by jaikiran pai (JIRA)
[ https://issues.jboss.org/browse/WFLY-9310?page=com.atlassian.jira.plugin.... ]
jaikiran pai commented on WFLY-9310:
------------------------------------
Please use the forums for discussing this question https://developer.jboss.org/en/wildfly. Add all relevant details including your application deployment packaging structure and any exception stacktraces.
> Class loading hierarchie
> -------------------------
>
> Key: WFLY-9310
> URL: https://issues.jboss.org/browse/WFLY-9310
> Project: WildFly
> Issue Type: Bug
> Components: Class Loading, JPA / Hibernate
> Affects Versions: 10.1.0.Final
> Environment: windows 7
> oracle jdk hotspot 8
> wildfly 10 final
> Reporter: stefano canu
> Assignee: David Lloyd
>
> Deployng an EAR application with hibernate 4.x jars in lib folders but is ignored and workning with AS module (hibernate 5.0.10) . i tried to do module exclusion by using jboss-deployment- structure but whitout any luck.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFLY-9310) Class loading hierarchie
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFLY-9310?page=com.atlassian.jira.plugin.... ]
David Lloyd updated WFLY-9310:
------------------------------
Attachment: (was: image-2017-09-07-12-57-52-827.png)
> Class loading hierarchie
> -------------------------
>
> Key: WFLY-9310
> URL: https://issues.jboss.org/browse/WFLY-9310
> Project: WildFly
> Issue Type: Bug
> Components: Class Loading, JPA / Hibernate
> Affects Versions: 10.1.0.Final
> Environment: windows 7
> oracle jdk hotspot 8
> wildfly 10 final
> Reporter: stefano canu
> Assignee: David Lloyd
>
> Deployng an EAR application with hibernate 4.x jars in lib folders but is ignored and workning with AS module (hibernate 5.0.10) . i tried to do module exclusion by using jboss-deployment- structure but whitout any luck.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months
[JBoss JIRA] (WFLY-9310) Class loading hierarchie
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFLY-9310?page=com.atlassian.jira.plugin.... ]
David Lloyd updated WFLY-9310:
------------------------------
Attachment: (was: image-2017-09-07-12-57-48-779.png)
> Class loading hierarchie
> -------------------------
>
> Key: WFLY-9310
> URL: https://issues.jboss.org/browse/WFLY-9310
> Project: WildFly
> Issue Type: Bug
> Components: Class Loading, JPA / Hibernate
> Affects Versions: 10.1.0.Final
> Environment: windows 7
> oracle jdk hotspot 8
> wildfly 10 final
> Reporter: stefano canu
> Assignee: David Lloyd
>
> Deployng an EAR application with hibernate 4.x jars in lib folders but is ignored and workning with AS module (hibernate 5.0.10) . i tried to do module exclusion by using jboss-deployment- structure but whitout any luck.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 10 months