[JBoss JIRA] (DROOLS-1811) [Guided Decision Table] Column Wizard usability improvements
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1811?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-1811:
-------------------------------------
[~tirelli] This jira is part of BAPL-807 that targets to RHDM-7.0.GA, could we cherry pick commit for DROOLS-1811 into 7.5.x brach?
> [Guided Decision Table] Column Wizard usability improvements
> ------------------------------------------------------------
>
> Key: DROOLS-1811
> URL: https://issues.jboss.org/browse/DROOLS-1811
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Affects Versions: 7.2.0.Final
> Reporter: Jozef Marko
> Assignee: Guilherme Carreiro
> Labels: UX
> Fix For: 7.6.0.Final
>
> Attachments: Screenshot from 2017-11-08 10-34-17.png
>
> Original Estimate: 3 days
> Remaining Estimate: 3 days
>
> On the _BRMS 7.0 - Getting Started Experience_ meeting, there were mentioned these points that could improve the column wizard:
> - Placement of input fields
> -- *Field binding* should be on the same page as *Field*
> -- Pages like *Operator* and *Field* could be merged or at least recapitulate what was selected on previous pages of the wizard
> - *[UPDATED SOLVED]* Input fields should be explained somehow. For newbies it is really hard to understand what is the *Calculation Type* or *Value List*. I liked concept of small _i_ in blue circle that shows hint after mouse is over this info sign.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (DROOLS-2222) Stunner: Ensure "copy/paste" (nodes) supports DMN's deep definition
by Michael Anstis (JIRA)
Michael Anstis created DROOLS-2222:
--------------------------------------
Summary: Stunner: Ensure "copy/paste" (nodes) supports DMN's deep definition
Key: DROOLS-2222
URL: https://issues.jboss.org/browse/DROOLS-2222
Project: Drools
Issue Type: Sub-task
Reporter: Michael Anstis
Assignee: Tiago Dolphine
As discussed on DROOLS-2214 Stunner needs to support (or provide extension points) for DMN's "copy/paste" of a {{Node}} to also deep-clone the definition. Please either (a) use this JIRA to record any changes needed in Stunner, (b) provide an explanation of how DMN can override the copy/paste to deep-clone definitions. Thanks.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (DROOLS-2214) [DMN Editor] Content of the decision node is not copied
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2214?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-2214:
----------------------------------------
[~tdolphine] A "DMN Editor" node is not just the Stunner {{Node}} and properties.
Each {{Node}} holds an object that needs to be deep-cloned too; when the User copy and pastes the {{Node}}.
This object is set with {{Node.getContent().setDefiniton(o)}} but {{o}} is the top-level of a object hierarchy that can be several layers deep.
DMN's use of Stunner should have exactly the same functionality as BPMN2 (or any other use of Stunner's "out of the box" features).
This JIRA represents the issue of cloning a DMN {{Node]}. I don't think we need to disable it; or record the issue elsewhere. When resolved; this JIRA can close.
> [DMN Editor] Content of the decision node is not copied
> -------------------------------------------------------
>
> Key: DROOLS-2214
> URL: https://issues.jboss.org/browse/DROOLS-2214
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.6.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Labels: Stunner
>
> User has possibility to copy a DRG node by a CTRL+C shortcut, however the problem is that content of the node is not copied.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1483) japicmp detects compatibility issues
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.s... ]
Martin Choma updated ELY-1483:
------------------------------
Description:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives because packages asn/x500 were not public in 1.1.7.final :
- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
was:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives:
- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util) -
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)-
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)-
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)-
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)-
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)-
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)-
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator) -
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)-
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)-
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
> japicmp detects compatibility issues
> ------------------------------------
>
> Key: ELY-1483
> URL: https://issues.jboss.org/browse/ELY-1483
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Priority: Critical
> Fix For: 1.2.0.Beta12
>
> Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
> {noformat}
> [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
> {noformat}
> But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
> False positives because packages asn/x500 were not public in 1.1.7.final :
> - removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1483) japicmp detects compatibility issues
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.s... ]
Martin Choma updated ELY-1483:
------------------------------
Description:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives:
-
- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
-
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
was:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives:
-- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)-
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
> japicmp detects compatibility issues
> ------------------------------------
>
> Key: ELY-1483
> URL: https://issues.jboss.org/browse/ELY-1483
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Priority: Critical
> Fix For: 1.2.0.Beta12
>
> Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
> {noformat}
> [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
> {noformat}
> But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
> False positives:
> -
> - removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> -
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1483) japicmp detects compatibility issues
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.s... ]
Martin Choma updated ELY-1483:
------------------------------
Description:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives:
-- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)-
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
-
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
was:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives:
-
- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
-
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
> japicmp detects compatibility issues
> ------------------------------------
>
> Key: ELY-1483
> URL: https://issues.jboss.org/browse/ELY-1483
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Priority: Critical
> Fix For: 1.2.0.Beta12
>
> Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
> {noformat}
> [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
> {noformat}
> But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
> False positives:
> -- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)-
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> -
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1483) japicmp detects compatibility issues
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.s... ]
Martin Choma updated ELY-1483:
------------------------------
Description:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives:
- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util) -
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)-
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)-
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)-
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)-
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)-
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)-
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator) -
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)-
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)-
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
was:
I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
{noformat}
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
{noformat}
But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
False positives:
-- removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)-
- removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
- removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
- constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
- method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
-
[1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
> japicmp detects compatibility issues
> ------------------------------------
>
> Key: ELY-1483
> URL: https://issues.jboss.org/browse/ELY-1483
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Priority: Critical
> Fix For: 1.2.0.Beta12
>
> Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:
> {noformat}
> [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
> {noformat}
> But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. [~honza889] wdyt?
> False positives:
> - removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util) -
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)-
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)-
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)-
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)-
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)-
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)-
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator) -
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)-
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)-
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months