[JBoss JIRA] (DROOLS-2181) Icons (Edit, Collapse, Delete etc) do not respond to mouse clicks
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2181?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-2181:
-------------------------------------
If we have code freeze and there is no RHDM/RHBA jira for that, I think it shouldn't be on 7.5.x. I see your point Michael, that if user will enable trees and try them, they will not work, however I think as we don't support trees officially is fine to keep fix just in master.
> Icons (Edit, Collapse, Delete etc) do not respond to mouse clicks
> -----------------------------------------------------------------
>
> Key: DROOLS-2181
> URL: https://issues.jboss.org/browse/DROOLS-2181
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Tree Editor
> Affects Versions: 7.5.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Fix For: 7.6.0.Final
>
>
> - Double-click on a node (object/action) to edit/delete/collapse.
> - Pop-up shows the icons/buttons.
> - Click on Edit/Delete/collapse icon. Icons are frozen.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1479) Coverity, Missing call to superclass in AbstractGssapiMechanism
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-1479?page=com.atlassian.jira.plugin.s... ]
Ilia Vassilev reassigned ELY-1479:
----------------------------------
Assignee: Ilia Vassilev
> Coverity, Missing call to superclass in AbstractGssapiMechanism
> ---------------------------------------------------------------
>
> Key: ELY-1479
> URL: https://issues.jboss.org/browse/ELY-1479
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Authentication Mechanisms
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
>
> super.getNegotiatedProperty() is not called in AbstractGssapiMechanism#getNegotiatedProperty, although it is called in similar cases in Gs2SaslServer, DigestSaslServer, AnonymousSaslClient.
> {code:java|title=AbstractGssapiMechanism.java}
> @Override
> public Object getNegotiatedProperty(String propName) {
> assertComplete();
> switch (propName) {
> case Sasl.QOP:
> return selectedQop.getName();
> case Sasl.MAX_BUFFER:
> return Integer.toString(actualMaxReceiveBuffer != 0 ? actualMaxReceiveBuffer : configuredMaxReceiveBuffer);
> case Sasl.RAW_SEND_SIZE:
> return Integer.toString(maxBuffer);
> }
> return null;
> }
> {code}
> This coverity report is not caused by recent change in AbstractGssapiMechanism but rather Gs2SaslServer and DigestSaslServer
> [1] https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=44847...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1480) Coverity, Explicit null dereferenced in FileSystemSecurityRealm
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-1480?page=com.atlassian.jira.plugin.s... ]
Ilia Vassilev reassigned ELY-1480:
----------------------------------
Assignee: Ilia Vassilev
> Coverity, Explicit null dereferenced in FileSystemSecurityRealm
> ---------------------------------------------------------------
>
> Key: ELY-1480
> URL: https://issues.jboss.org/browse/ELY-1480
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Authentication Client
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
>
> There are 2 occurences of call to PasswordFactory.getInstance(algorithm) in FileSystemSecurityRealm where algorithm can be null, because algorithm is optional in wildfly-config.xml
> {code:xml|title=elytron-1_0_1.xsd}
> <xsd:complexType name="credential-type">
> <xsd:simpleContent>
> <xsd:extension base="xsd:string">
> <xsd:attribute name="algorithm" type="xsd:string" use="optional"/>
> <xsd:attribute name="format" type="xsd:string" use="optional"/>
> </xsd:extension>
> </xsd:simpleContent>
> </xsd:complexType>
> <xsd:complexType name="otp-credential-type">
> <xsd:simpleContent>
> <xsd:extension base="xsd:string">
> <xsd:attribute name="algorithm" type="xsd:string" use="optional"/>
> <xsd:attribute name="hash" type="xsd:string" use="optional"/>
> <xsd:attribute name="seed" type="xsd:string" use="optional"/>
> <xsd:attribute name="sequence" type="xsd:string" use="optional"/>
> </xsd:extension>
> </xsd:simpleContent>
> </xsd:complexType>
> {code}
> Algorithm is dereferenced in PasswordFactory.getInstance(algorithm) down in
> {code:java|title=java.security.Provider$ServiceKey.java}
> private ServiceKey(String type, String algorithm, boolean intern) {
> this.type = type;
> this.originalAlgorithm = algorithm;
> algorithm = algorithm.toUpperCase(ENGLISH);
> this.algorithm = intern ? algorithm.intern() : algorithm;
> }
> {code}
> [1] https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=44847...
> [2] https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=44847...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1298) GssapiCompatibilitySuiteChild fails on IBM JDK
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-1298?page=com.atlassian.jira.plugin.s... ]
Jan Kalina edited comment on ELY-1298 at 1/8/18 9:06 AM:
---------------------------------------------------------
In the end will remove compatibility tests of GSSAPI - the output is mostly generated by backing GSS mechanism and it is very sensitive on its implementation. Even if the time mocking would be resolved, the test will be unsustainable.
I will only extend checking of negotiated MAX_BUFFER/RAW_SEND_SIZE in other tests, which is more or less only thing negotiated by the SASL mechanism itself.
was (Author: honza889):
In the end will remove compatibility tests of GSSAPI - the output is mostly generated by backing GSS mechanism and it is very sensitive on its implementation. I will only extend checking of negotiated MAX_BUFFER/RAW_SEND_SIZE, which is more or less only thing negotiated by the SASL mechanism itself.
> GssapiCompatibilitySuiteChild fails on IBM JDK
> ----------------------------------------------
>
> Key: ELY-1298
> URL: https://issues.jboss.org/browse/ELY-1298
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Testsuite
> Reporter: Peter Palaga
> Assignee: Jan Kalina
> Priority: Critical
> Labels: ibm-java
>
> A followup of ELY-1293
> {{System.currentTimeMillis()}} is native in IBM JDK and at the same time, IBM JDK does not support java.lang.instrument API for native methods. Therefore, {{System.currentTimeMillis()}} cannot be mocked on IBM JDK using jmockit.
> {code}
> export JAVA_HOME=path/to/ibm/java8
> $JAVA_HOME/bin/java -version
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp12-20160919_01(SR3 FP12))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References 20160915_318796 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20160915_0912_B318796
> JIT - tr.r14.java.green_20160818_122998
> GC - R28_Java8_SR3_20160915_0912_B318796_CMPRSS
> J9CL - 20160915_318796)
> JCL - 20160914_01 based on Oracle jdk8u101-b13
> mvn clean test
> {code}
> Expected: the tests mocking {{System.currentTimeMillis()}} should pass
> Actual: the tests mocking {{System.currentTimeMillis()}} throw the following exception or similar:
> {code}
> java.lang.UnsupportedOperationException: class redefinition failed: attempted to change method modifiers
> at org.wildfly.security.audit.PeriodicRotatingFileAuditEndpointTest$1.<init>(PeriodicRotatingFileAuditEndpointTest.java:212)
> at org.wildfly.security.audit.PeriodicRotatingFileAuditEndpointTest.mockTime(PeriodicRotatingFileAuditEndpointTest.java:212)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:508)
> at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
> at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
> at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
> at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
> {code}
> This is currently the case with
> * GssapiCompatibilitySuiteChild
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1436) Log jdbc-realm key-mapper processing
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-1436?page=com.atlassian.jira.plugin.s... ]
Ilia Vassilev reassigned ELY-1436:
----------------------------------
Assignee: Ilia Vassilev (was: Darran Lofthouse)
> Log jdbc-realm key-mapper processing
> ------------------------------------
>
> Key: ELY-1436
> URL: https://issues.jboss.org/browse/ELY-1436
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
> Fix For: 1.2.0.Beta12
>
>
> User reported problem with getting work jdbc_realm with bcrypt mapper. He had configured org.wildfly.security to log TRACE messages, but log does not provide any useful information regarding mapping password from DB.
> In this case seems problem was in mixing base64 vs. modular crypt format.
> Looking into PasswordKeyMapper there is a lot of logic and lot of steps which can get wrong. So logging some TRACE messages can hint user what is going on and what went wrong.
> Also I have noticed there is unhandled exception. Please at least log some TRACE message.
> {code:java|title=PasswordKeyMapper.java}
> } catch (InvalidKeySpecException e) {
> // fall out (unlikely but possible)
> }
> {code}
> [1] https://developer.jboss.org/message/977727
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1483) japicmp detects compatibility issues
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.s... ]
Darran Lofthouse commented on ELY-1483:
---------------------------------------
+1 that is something else we need to take into account, as at the point we released a 1.1.x Final we need the signatures based on what was public at the time to verify against 1.2.x - when we tag a Final of 1.2.x we will have a new definition of which packages are public to take forward.
> japicmp detects compatibility issues
> ------------------------------------
>
> Key: ELY-1483
> URL: https://issues.jboss.org/browse/ELY-1483
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Priority: Critical
> Fix For: 1.2.0.Beta12
>
> Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). These incompatibilities were detected:
> - removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1483) japicmp detects compatibility issues
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.s... ]
Martin Choma commented on ELY-1483:
-----------------------------------
Packages asn1 and x500 were included into check per Farah comment https://github.com/wildfly-security/wildfly-elytron/pull/1038#discussion_...
But thinking about it now, probably they should be not included in this stage, because they were private in 1.1.7.Final (weren't mentioned in module definition)?
They should be included once we will compare 1.2.x with 1.next
> japicmp detects compatibility issues
> ------------------------------------
>
> Key: ELY-1483
> URL: https://issues.jboss.org/browse/ELY-1483
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Priority: Critical
> Fix For: 1.2.0.Beta12
>
> Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). These incompatibilities were detected:
> - removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1483) japicmp detects compatibility issues
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-1483?page=com.atlassian.jira.plugin.s... ]
Darran Lofthouse commented on ELY-1483:
---------------------------------------
[~fjuma] Do you mind taking a look into this one? I think the ans1.util package was never public so that one may be a false positive but some of the other do seem to be popping up in our public javadoc, may need to check if they were also public in our module definition.
> japicmp detects compatibility issues
> ------------------------------------
>
> Key: ELY-1483
> URL: https://issues.jboss.org/browse/ELY-1483
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Affects Versions: 1.2.0.Beta11
> Reporter: Martin Choma
> Priority: Critical
> Fix For: 1.2.0.Beta12
>
> Attachments: japicmp.html
>
>
> I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). These incompatibilities were detected:
> - removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
> - removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
> - constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
> - method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
> [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months