[JBoss JIRA] (JGRP-2218) New payload interface
by Pedro Ruivo (Jira)
[ https://issues.jboss.org/browse/JGRP-2218?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo edited comment on JGRP-2218 at 10/29/18 7:57 AM:
-------------------------------------------------------------
I've created a small POC for ISPN with JGroups 5. You can find the changes here: https://github.com/pruivo/infinispan/tree/t_jgroups_5
IMO, It is trivial to update from 4.x to 5.
*Comments/Suggestions*
I've created a new custom {{Message}} class to replace an ISPN command. It can be found here: https://github.com/pruivo/infinispan/blob/t_jgroups_5/core/src/main/java/...
* The set/get...Array/Object must have a default implementation in the interface. I doubt that any custom implementation will ever implement those methods. Similar idea for {{hasArray()}}
* Probably the {{size()}} shouldn't be implemented in the base class. Initially, I forgot to implement it :). A {{headersSize()}} method would be needed.
* It would be nice to have an abstract method write/read payload instead of overriding the writeTo/readFrom
* {{copy()}} should be implemented in the base class and be final. Just add an abstract method {{copyPayload()}} that is invoked when the payload needs to be copied. The first parameter for {{copy()}} should have a better name, IMO.
* {{MessageFactory}} is kind of difficult to find. Can we have a method in the {{Channel}}? or {{getMessageFactory()}} or {{registerMessage(type, constructor)}}. Also, I found some protocol creating a new {{MessageFactory}}, they should use the same instance, right? And you allow to set a different {{MessageFactory}} that isn't propagated everywhere... is there a use case where an user needs to replace the {{MessageFactory}}? If not, just make it static somewhere :)
* I'm wondering if there is way to avoid conflict to register a new message type. Imagine that wildfly and ispn creates a set new messages type, the conflict will only be detected at runtime. Also, the type is a byte... there is no much room to add custom messages types.
* Can the {{Flag}} and {{TransientFlag}} use the same short? There are only 2 transient flags so far and they can be the last bits of short. You can use a mask to skip sending them through the network
* no perf-ack numbers :(
was (Author: pruivo):
I've created a small POC for ISPN with JGroups 5. You can't find the changes here: https://github.com/pruivo/infinispan/tree/t_jgroups_5
IMO, It is trivial to update from 4.x to 5.
*Comments/Suggestions*
I've created a new custom {{Message}} class to replace an ISPN command. It can be found here: https://github.com/pruivo/infinispan/blob/t_jgroups_5/core/src/main/java/...
* The set/get...Array/Object must have a default implementation in the interface. I doubt that any custom implementation will ever implement those methods. Similar idea for {{hasArray()}}
* Probably the {{size()}} shouldn't be implemented in the base class. Initially, I forgot to implement it :). A {{headersSize()}} method would be needed.
* It would be nice to have an abstract method write/read payload instead of overriding the writeTo/readFrom
* {{copy()}} should be implemented in the base class and be final. Just add an abstract method {{copyPayload()}} that is invoked when the payload needs to be copied. The first parameter for {{copy()}} should have a better name, IMO.
* {{MessageFactory}} is kind of difficult to find. Can we have a method in the {{Channel}}? or {{getMessageFactory()}} or {{registerMessage(type, constructor)}}. Also, I found some protocol creating a new {{MessageFactory}}, they should use the same instance, right? And you allow to set a different {{MessageFactory}} that isn't propagated everywhere... is there a use case where an user needs to replace the {{MessageFactory}}? If not, just make it static somewhere :)
* I'm wondering if there is way to avoid conflict to register a new message type. Imagine that wildfly and ispn creates a set new messages type, the conflict will only be detected at runtime. Also, the type is a byte... there is no much room to add custom messages types.
* Can the {{Flag}} and {{TransientFlag}} use the same short? There are only 2 transient flags so far and they can be the last bits of short. You can use a mask to skip sending them through the network
* no perf-ack numbers :(
> New payload interface
> ---------------------
>
> Key: JGRP-2218
> URL: https://issues.jboss.org/browse/JGRP-2218
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 5.0
>
> Attachments: jgrp-2218.jfr, master.jfr
>
>
> h3. Goal
> Change payload in {{Message}} from byte[] arrays to a {{Payload}} interface which can have multiple implementations.
> h3. Reason
> Currently, having to pass a byte[] array to a message leads to unnecessary copying:
> * When an application has a ref to an NIO (direct) {{ByteBuffer}}, the bytes in the byte buffer have to be copied into a byte[] array and then set in the message
> * When the application sends around byte[] arrays, but also wants to add some additional metadata, e.g. type (1000-byte requests/responses), it needs to create a new byte[] array of (say) 1001 bytes and copy the data (1000 bytes) plus the request type (1 byte) into the new copy. Example: {{MPerf}} and {{UPerf}}
> * When an object has to be sent (e.g. in Infinispan), the object has to be marshalled into a byte[] array (first allocation) and then added to the message. With the suggested {{ObjectPayload}} (below), marshalling of the object would occur late, and it would be marshalled directly into the output stream of the bundler, eliminating the byte[] array allocation made by the application.
> h3. Design
> Instead of copying, the application creates an instance of {{Payload}} and sets the payload in {{Message}}. The {{Payload}} is then passed all the way down into the transport where it is marshalled and sent. There can be a number of payload implementations, e.g.
> * {{ByteArrayPayload}}: wraps a byte[] array with an offset and length
> * {{NioDirectPayload}}: wraps an NIO direct {{ByteBuffer}}
> * {{NioHeapPayload}}: wraps an NIO heap-based {{ByteBuffer}}
> * {{CompositePayload}}: wraps multiple Buffers. E.g. type (1 byte) and data (1000 bytes) as described above
> * {{IntPayload}}: a single integer
> * {{ObjectPayload}}: has an Object and a ClassLoader (for reading), plus a Marshaller which know how to marshal the object, this allows for objects to be passed in payloads and they're only marshalled at the end (transport).
> * {{PartialPayload}}: a ref to a {{Payload}}, with an offset and length
> * {{InputStreamPayload}}: has a ref to an input stream and copies data from input- to output stream when marshalling
> The {{Payload}} interface has methods:
> * {{size()}}
> * {{writeTo(DataOutput)}}
> * {{readFrom(DataInput)}}
> * {{getInput()}}: this provides a {{DataInput}} stream for reading from the underlying payload
> and possibly also
> * {{acquire()}} and
> * {{release()}} (for ref-counting)
> * {{copy()}}
> Each payload impl has an ID and it should be possible to register new impls. A {{PayloadFactory}} maintains a mapping between IDs and impl classes.
> When marshalling a {{Payload}}, the ID is written first, followed by the payload's {{writeTo()}} method. When reading payloads, the {{PayloadFactory}} is used to create instances from IDs.
> h4. Fragmentation
> When fragmenting a buffer, the fragments are instances of {{PartialPayload}} which maintains an offset and length over an underlying payload. When marshalling a {{PartialPayload}}, only the part between offset and offset+length is written to the output stream.
> For fragmentation, method {{size()}} is crucial to determine whether a payload needs to be fragmented, or not. If, for example, a payload (e.g. an {{ObjectPayload}}) cannot determine the correct size, it may return {{-1}}. This leads to the {{ObjectPayload}} getting marshalled right away and getting wrapped into a {{ByteArrayPayload}}. So if {{size()}} cannot be determined, we have exactly the same behavior as what's currently done.
> h4. Reference counting
> If we implement ref-counting, then payloads can be reused as soon as the ref-count is 0. For example, when sending a message, the payload's ref-count could be incremented by the app calling {{acquire()}}. (Assuming the message is a unicast message), {{UNICAST3}} would increment the count to 2. This is needed because {{UNICAST3}} might have to retransmit the message if it was lost on the network, and meanwhile the payload cannot be reused (changed). The app calls {{release()}} when the {{JChannel.send()}} call returns, but the payload cannot be reused until {{UNICAST3}} calls {{release()}} as well. This will happen when an {{ACK}} for the given message has been received.
> h4. Payload factory
> When a request is received, the buffer is created from the bytes received on the network, based on the ID. This should be done by asking a {{PayloadFactory}} component for a new buffer. A naive implementation might create a new buffer every time, but a more sophisticated one might use a pool of payloads.
> The {{PayloadFactory}} instance could be replaced by one's own implementation; this allows for an application to control the lifecycle of payloads: thus the creation of buffers by the application and of payloads received over the network can be controlled by the same payload management impl.
> h4. Symmetry
> When sending a {{CompositePayload}} of a 500 byte {{ByteArrayPayload}} and a 1000 byte {{NioDirectPayload}}, would we want to also get the same {{CompositePayload}} consisting of 2 payloads on the receiver side, or would we want to combine the 2 payloads into one and make the 2 payloads refer to the same combined byte[] array (or NIO buffer)? Should this be made configurable?
> h4. ObjectPayload
> If ObjectPayload cannot determine the size of the serialized data, it should return {{-1}}. This means that {{Message.setPayload(ObjectPayload)}} would right away serialize {{ObjectPayload}} into {{ByteArrayPayload}}.
> This means we do have the {{byte[]}} array creation (same as now), but for object payloads which do implement {{size()}} correctly, we could still do late serialization.
> h5. ObjectPayload and fragmentation
> {{FRAG3}} could decorate {{ObjectPayload}} with a fragmentation payload, which generates fragments on serialization and sends them down the stack.
> h4. Misc
> * Since this issue includes API changes, the version will be 5.0
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3185) [DMN Designer] Change Literal Expression to Decision Table
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3185?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-3185:
-------------------------------------
[~manstis] [~tari_manga] Hi I have question about collection fields. I attached [^a1.dmn] and [^a2.dmn] .
*a1* has three item definitions, two of them are collections and used in the remaining one as fields
*a2* has one item definition and two fields are marked as collection
Could you please have a look on produced xmls and say if they are correct? (except of known bugs)
[~manstis] please especially have a look on UI in *a1* case, shouldn't be *InputData-1.friends* column data type *tSmurfs* instead of *tSmurf*?
> [DMN Designer] Change Literal Expression to Decision Table
> ----------------------------------------------------------
>
> Key: DROOLS-3185
> URL: https://issues.jboss.org/browse/DROOLS-3185
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 14-40-06.png, Screenshot from 2018-10-29 12-25-14.png, Screenshot from 2018-10-29 12-25-31.png, a1.dmn, a2.dmn, screenshot-1.png
>
>
> When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
> h2. Manual Acceptance Test
> Check steps to reproduce, while InputData node has data type
> - Built in type (/)
> - Custom type that has constraint (/)
> - Custom type that is collection (?)
> - Custom type that is recursive (/)
> - Multiple InputData nodes (/)
> - -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3185) [DMN Designer] Change Literal Expression to Decision Table
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3185?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3185:
--------------------------------
Attachment: Screenshot from 2018-10-29 12-25-31.png
Screenshot from 2018-10-29 12-25-14.png
> [DMN Designer] Change Literal Expression to Decision Table
> ----------------------------------------------------------
>
> Key: DROOLS-3185
> URL: https://issues.jboss.org/browse/DROOLS-3185
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 14-40-06.png, Screenshot from 2018-10-29 12-25-14.png, Screenshot from 2018-10-29 12-25-31.png, a1.dmn, a2.dmn, screenshot-1.png
>
>
> When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
> h2. Manual Acceptance Test
> Check steps to reproduce, while InputData node has data type
> - Built in type (/)
> - Custom type that has constraint (/)
> - Custom type that is collection (?)
> - Custom type that is recursive (/)
> - Multiple InputData nodes (/)
> - -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3185) [DMN Designer] Change Literal Expression to Decision Table
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3185?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3185:
--------------------------------
Attachment: a2.dmn
a1.dmn
> [DMN Designer] Change Literal Expression to Decision Table
> ----------------------------------------------------------
>
> Key: DROOLS-3185
> URL: https://issues.jboss.org/browse/DROOLS-3185
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 14-40-06.png, a1.dmn, a2.dmn, screenshot-1.png
>
>
> When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
> h2. Manual Acceptance Test
> Check steps to reproduce, while InputData node has data type
> - Built in type (/)
> - Custom type that has constraint (/)
> - Custom type that is collection (?)
> - Custom type that is recursive (/)
> - Multiple InputData nodes (/)
> - -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3185) [DMN Designer] Change Literal Expression to Decision Table
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3185?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3185:
--------------------------------
Description:
When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
h2. Manual Acceptance Test
Check steps to reproduce, while InputData node has data type
- Built in type (/)
- Custom type that has constraint (/)
- Custom type that is collection
- Custom type that is recursive (/)
- Multiple InputData nodes (/)
- -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
was:
When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
h2. Manual Acceptance Test
Check steps to reproduce, while InputData node has data type
- Built in type (/)
- Custom type that has constraint (/)
- Custom type that is collection
- Custom type that is recursive
- Multiple InputData nodes
- -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
> [DMN Designer] Change Literal Expression to Decision Table
> ----------------------------------------------------------
>
> Key: DROOLS-3185
> URL: https://issues.jboss.org/browse/DROOLS-3185
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 14-40-06.png, screenshot-1.png
>
>
> When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
> h2. Manual Acceptance Test
> Check steps to reproduce, while InputData node has data type
> - Built in type (/)
> - Custom type that has constraint (/)
> - Custom type that is collection
> - Custom type that is recursive (/)
> - Multiple InputData nodes (/)
> - -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3185) [DMN Designer] Change Literal Expression to Decision Table
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3185?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3185:
--------------------------------
Description:
When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
h2. Manual Acceptance Test
Check steps to reproduce, while InputData node has data type
- Built in type (/)
- Custom type that has constraint (/)
- Custom type that is collection (?)
- Custom type that is recursive (/)
- Multiple InputData nodes (/)
- -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
was:
When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
h2. Manual Acceptance Test
Check steps to reproduce, while InputData node has data type
- Built in type (/)
- Custom type that has constraint (/)
- Custom type that is collection
- Custom type that is recursive (/)
- Multiple InputData nodes (/)
- -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
> [DMN Designer] Change Literal Expression to Decision Table
> ----------------------------------------------------------
>
> Key: DROOLS-3185
> URL: https://issues.jboss.org/browse/DROOLS-3185
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 14-40-06.png, screenshot-1.png
>
>
> When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
> h2. Manual Acceptance Test
> Check steps to reproduce, while InputData node has data type
> - Built in type (/)
> - Custom type that has constraint (/)
> - Custom type that is collection (?)
> - Custom type that is recursive (/)
> - Multiple InputData nodes (/)
> - -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3185) [DMN Designer] Change Literal Expression to Decision Table
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3185?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3185:
--------------------------------
Description:
When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
h2. Manual Acceptance Test
Check steps to reproduce, while InputData node has data type
- Built in type (/)
- Custom type that has constraint (/)
- Custom type that is collection
- Custom type that is recursive
- Multiple InputData nodes
- -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
was:
When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
h2. Manual Acceptance Test
Check steps to reproduce, while InputData node has data type
- Built in type (/)
- Custom type that has constraint
- Custom type that is collection
- Custom type that is recursive
- Multiple InputData nodes
- -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
> [DMN Designer] Change Literal Expression to Decision Table
> ----------------------------------------------------------
>
> Key: DROOLS-3185
> URL: https://issues.jboss.org/browse/DROOLS-3185
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2018-10-25 14-40-06.png, screenshot-1.png
>
>
> When user changes Decision node top level expression from literal expression to decision table, that decision table misses InputClause columns.
> h2. Manual Acceptance Test
> Check steps to reproduce, while InputData node has data type
> - Built in type (/)
> - Custom type that has constraint (/)
> - Custom type that is collection
> - Custom type that is recursive
> - Multiple InputData nodes
> - -Multiple input nodes, mixed InputData and Decision- doesn't work, not supported
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months