[JBoss JIRA] (DROOLS-3309) Code cleanup
by Gabriele Cardosi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3309?page=com.atlassian.jira.plugi... ]
Gabriele Cardosi updated DROOLS-3309:
-------------------------------------
Description:
Clean up code
# 1) replace GIVEN/EXPECT Strings with Enum
# 2) move classes to proper packages
# 3) remove get(0) used to set background color
# 4) remove injection of ScenarioSimulationDocksHandler from ScenarioSimulationEditorPresenter
## a) inject ScenarioSimulationDocksHandler inside CommandExecutor
## b) create one specific GWT event with four Enum to decide which action to execute
## c) register CommandExecutor for that event
## d) inside ScenarioSimulationEditorPresenter fire the required event when necessary instead of direct calls top DocksHandler
## e) let CommandExecutor manage the event
was:
Clean up code
1) replace GIVEN/EXPECT Strings with Enum
2) move classes to proper packages
> Code cleanup
> ------------
>
> Key: DROOLS-3309
> URL: https://issues.jboss.org/browse/DROOLS-3309
> Project: Drools
> Issue Type: Enhancement
> Components: Scenario Simulation and Testing
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Minor
>
> Clean up code
> # 1) replace GIVEN/EXPECT Strings with Enum
> # 2) move classes to proper packages
> # 3) remove get(0) used to set background color
> # 4) remove injection of ScenarioSimulationDocksHandler from ScenarioSimulationEditorPresenter
> ## a) inject ScenarioSimulationDocksHandler inside CommandExecutor
> ## b) create one specific GWT event with four Enum to decide which action to execute
> ## c) register CommandExecutor for that event
> ## d) inside ScenarioSimulationEditorPresenter fire the required event when necessary instead of direct calls top DocksHandler
> ## e) let CommandExecutor manage the event
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3309) Code cleanup
by Gabriele Cardosi (Jira)
Gabriele Cardosi created DROOLS-3309:
----------------------------------------
Summary: Code cleanup
Key: DROOLS-3309
URL: https://issues.jboss.org/browse/DROOLS-3309
Project: Drools
Issue Type: Enhancement
Components: Scenario Simulation and Testing
Reporter: Gabriele Cardosi
Assignee: Gabriele Cardosi
Clean up code
1) replace GIVEN/EXPECT Strings with Enum
2) move classes to proper packages
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3235) [DMN Designer] Runtime issues [7.2.0.Final]
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3235?page=com.atlassian.jira.plugi... ]
Michael Anstis resolved DROOLS-3235.
------------------------------------
Fix Version/s: 7.15.0.Final
Resolution: Done
> [DMN Designer] Runtime issues [7.2.0.Final]
> -------------------------------------------
>
> Key: DROOLS-3235
> URL: https://issues.jboss.org/browse/DROOLS-3235
> Project: Drools
> Issue Type: Epic
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Fix For: 7.15.0.Final
>
>
> An umbrella for the issues we're encountering with _using_ DMN models authored with _our_ editor. A lot of issues are being reported as comments on PRs or as separate JIRA. In reality, in preparation for our MVP we need to be confident all such issues are captured, fixed and re-tested.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3249) [DMN Designer] Add support for optional typeRefs
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3249?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3249:
----------------------------------------
[~dadossan] Please cherry-pick this to {{7.14.x}} and update the commit comment to reference https://issues.jboss.org/browse/RHPAM-1682. Thanks
> [DMN Designer] Add support for optional typeRefs
> ------------------------------------------------
>
> Key: DROOLS-3249
> URL: https://issues.jboss.org/browse/DROOLS-3249
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Blocker
> Labels: drools-tools
> Fix For: 7.15.0.Final
>
>
> At the moment {{TypeRef}} is a mandatory field within the editor.
> This is a hard limitation of use of the Properties Panel bean-binding (it cannot bind to {{null}} values). However the DMN Specification states that {{TypeRef}} are optional (and we are working around by changing the _default_ to {{Any}} - see [DROOLS-3248|https://issues.jboss.org/browse/DROOLS-3248]).
> We need to change the UI and marshaller to be able to support _optional_ {{TypeRef}}. This would (probably) require adding a _magic_ value to {{BuiltInType}} representing a "null" selection. It would need to:
> - Appear at the top of the "Data Type selector" widget (with label "<None>" or similar)
> - Be the _selected_ option when the {{TypeRef}} is the new _magic_ value (this should happen automatically, but worth checking!)
> - The marshaller should set the {{TypeRef}} to the _magic_ {{BuiltInType}} if the DMN model (coming from XML->{{kie-dmn-model}}->workbench model) has a {{null}} {{TypeRef}} - the _magic_ value is only to be used _client-side_.
> - The marshaller should set the {{TypeRef}} to {{null}} when converting from the workbench model to {{kie-dmn-model}} and the workbench model {{TypeRef}} is the _magic_ value - again, the _magic_ value is only to be used _client-side_.
> - Check that creating new data-types does not show the _magic_ value (it uses a different widget, but population of the widget probably iterates all {{BuiltInType}}.
> [~tari_manga] [~karreiro] seem reasonable to you?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3249) [DMN Designer] Add support for optional typeRefs
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3249?page=com.atlassian.jira.plugi... ]
Michael Anstis edited comment on DROOLS-3249 at 11/12/18 4:52 AM:
------------------------------------------------------------------
[~dadossan] Please cherry-pick this to {{7.14.x}} and update the commit comment to reference [RHPAM-1682|https://issues.jboss.org/browse/RHPAM-1682]. Thanks
was (Author: manstis):
[~dadossan] Please cherry-pick this to {{7.14.x}} and update the commit comment to reference https://issues.jboss.org/browse/RHPAM-1682. Thanks
> [DMN Designer] Add support for optional typeRefs
> ------------------------------------------------
>
> Key: DROOLS-3249
> URL: https://issues.jboss.org/browse/DROOLS-3249
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Blocker
> Labels: drools-tools
> Fix For: 7.15.0.Final
>
>
> At the moment {{TypeRef}} is a mandatory field within the editor.
> This is a hard limitation of use of the Properties Panel bean-binding (it cannot bind to {{null}} values). However the DMN Specification states that {{TypeRef}} are optional (and we are working around by changing the _default_ to {{Any}} - see [DROOLS-3248|https://issues.jboss.org/browse/DROOLS-3248]).
> We need to change the UI and marshaller to be able to support _optional_ {{TypeRef}}. This would (probably) require adding a _magic_ value to {{BuiltInType}} representing a "null" selection. It would need to:
> - Appear at the top of the "Data Type selector" widget (with label "<None>" or similar)
> - Be the _selected_ option when the {{TypeRef}} is the new _magic_ value (this should happen automatically, but worth checking!)
> - The marshaller should set the {{TypeRef}} to the _magic_ {{BuiltInType}} if the DMN model (coming from XML->{{kie-dmn-model}}->workbench model) has a {{null}} {{TypeRef}} - the _magic_ value is only to be used _client-side_.
> - The marshaller should set the {{TypeRef}} to {{null}} when converting from the workbench model to {{kie-dmn-model}} and the workbench model {{TypeRef}} is the _magic_ value - again, the _magic_ value is only to be used _client-side_.
> - Check that creating new data-types does not show the _magic_ value (it uses a different widget, but population of the widget probably iterates all {{BuiltInType}}.
> [~tari_manga] [~karreiro] seem reasonable to you?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (WFCORE-4205) unused optional dependencies in io and remoting
by Jean-Francois Denise (Jira)
[ https://issues.jboss.org/browse/WFCORE-4205?page=com.atlassian.jira.plugi... ]
Jean-Francois Denise closed WFCORE-4205.
----------------------------------------
Release Notes Text: I actually overlooked the security optional dependencies. Without such optional dependencies, when security subsystem is enabled, security is not conveyed.
Resolution: Rejected
> unused optional dependencies in io and remoting
> -----------------------------------------------
>
> Key: WFCORE-4205
> URL: https://issues.jboss.org/browse/WFCORE-4205
> Project: WildFly Core
> Issue Type: Bug
> Components: IO, Remoting
> Reporter: Jean-Francois Denise
> Assignee: Yeray Borges
> Priority: Minor
>
> org.picketbox and org.jboss.as.security optional deps are not used in org.wildfly.extension.io and org.jboss.as.remoting
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months