[JBoss JIRA] (DROOLS-3241) [DMN Editor] Add support to define data-types (7.3)
by Guilherme Carreiro (Jira)
[ https://issues.jboss.org/browse/DROOLS-3241?page=com.atlassian.jira.plugi... ]
Guilherme Carreiro updated DROOLS-3241:
---------------------------------------
Summary: [DMN Editor] Add support to define data-types (7.3) (was: [DMN Editor] Add support to define data-types)
> [DMN Editor] Add support to define data-types (7.3)
> ---------------------------------------------------
>
> Key: DROOLS-3241
> URL: https://issues.jboss.org/browse/DROOLS-3241
> Project: Drools
> Issue Type: Epic
> Components: DMN Editor
> Reporter: Guilherme Carreiro
> Assignee: Guilherme Carreiro
> Priority: Major
> Labels: drools-tools
>
> As a practitioner, I want to be able to define Data Types in the UI, so that when the DMN engine evaluates a decision table input/output it will check if the type of the value matches the specified type.
> Verification conditions:
> Support added for the User to define data-types ({{ItemDefinition}}).
> This may become a top-level task when I get to work on it; as the requirement is quite large and encompasses nested data-types (a whole new grid will be required); and definition of enums, constrains on values etc.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-2563) [DMN Editor] Add support to define data-types
by Guilherme Carreiro (Jira)
[ https://issues.jboss.org/browse/DROOLS-2563?page=com.atlassian.jira.plugi... ]
Guilherme Carreiro resolved DROOLS-2563.
----------------------------------------
Resolution: Done
> [DMN Editor] Add support to define data-types
> ---------------------------------------------
>
> Key: DROOLS-2563
> URL: https://issues.jboss.org/browse/DROOLS-2563
> Project: Drools
> Issue Type: Epic
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Guilherme Carreiro
> Priority: Major
> Labels: drools-tools
>
> As a practitioner, I want to be able to define Data Types in the UI, so that when the DMN engine evaluates a decision table input/output it will check if the type of the value matches the specified type.
> Verification conditions:
> Support added for the User to define data-types ({{ItemDefinition}}).
> This may become a top-level task when I get to work on it; as the requirement is quite large and encompasses nested data-types (a whole new grid will be required); and definition of enums, constrains on values etc.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3228) Rules don't produce the correct result anymore after a session reset
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3228?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3228:
-----------------------------------
Sprint: 2018 Week 42-44, 2018 Week 45-47 (was: 2018 Week 42-44)
> Rules don't produce the correct result anymore after a session reset
> --------------------------------------------------------------------
>
> Key: DROOLS-3228
> URL: https://issues.jboss.org/browse/DROOLS-3228
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.13.0.Final
> Reporter: Christian Liebhardt
> Assignee: Mario Fusco
> Priority: Major
>
> Hello,
> A while ago I've created a test project to compare the different possibilities of session types and session polling/reusing. After an update to Drools 7.13.0.Final I found a performance improvement but also three issues. I would summarize all issues in this ticket, let me know if you have a different preference. I have also created a PR which helped me to continue with my tests: https://github.com/kiegroup/drools/pull/2135
> *1. Incorrect results*
> If you clone the project and execute [StatefulDroolsEngineUnitTest.java|https://github.com/liebharc/JavaRules/b...] then you will see test failures with 7.13.0.Final while the tests pass with 7.12.0.Final. I could trace the issue back to a recent change in ConcurrentNodeMemories. If I revert this change on a snapshot build of 7.14.0 then the tests pass again.
> *2. Reset doesn't bring a disposed session back to life*
> With 7.12.0.Final it was possible to bring a disposed session back to life by calling the reset method. In 7.13.0.Final that doesn't work anymore because the checkAlive validation then fails.
> The new session pools seem to deal with that by just setting the alive flag back to true if a session is reused. While the new session pools are great, we would like to stick with our existing and simpler session pooling which makes use of the reset method. So would it be possible to set the alive flag to true on a session reset?
> *3. A stateless sequential session doesn't execute any rules after a reset*
> https://github.com/liebharc/JavaRules/blob/master/src/test/java/com/githu... fails as a stateless sequential session skips all adds to its agenda group queue after the session has been reset.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3112) FEEL Compiler: modularize FEELImpl compiler/interpreter vs. DMNFEELHelper
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3112?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3112:
-----------------------------------
Sprint: 2018 Week 42-44, 2018 Week 45-47 (was: 2018 Week 42-44)
> FEEL Compiler: modularize FEELImpl compiler/interpreter vs. DMNFEELHelper
> --------------------------------------------------------------------------
>
> Key: DROOLS-3112
> URL: https://issues.jboss.org/browse/DROOLS-3112
> Project: Drools
> Issue Type: Enhancement
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core
>
> Code in FEELImpl could be reused in the DMNFEELHelper, but it cannot be shared, because FEELImpl exposes an interface to evaluate expressions, while DMNFEELHelper needs access to the compiler backend.
> Solution: separate the compilation pipeline and the interpreter pipeline from the public FEEL interface to promote code reuse. In particular, CompilerBytecodeLoader can be probably split between some kind of CompiledUnit+CompiledUnaryTest impls that provide methods to retrieve Java source code and/or JVM bytecode.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3088) FEEL Compiler: refactor to AST-based tree walk
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3088?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3088:
-----------------------------------
Sprint: 2018 Week 42-44, 2018 Week 45-47 (was: 2018 Week 42-44)
> FEEL Compiler: refactor to AST-based tree walk
> ----------------------------------------------
>
> Key: DROOLS-3088
> URL: https://issues.jboss.org/browse/DROOLS-3088
> Project: Drools
> Issue Type: Task
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core
>
> Current implementation of the compiler walks the parse tree generated by ANTLR, which is a bit cumbersome because of the way the grammar has to be written to deal with priorities/ambiguities. Luckily, many of such issues are solved by the interpreter implementation, which walks the parse tree and generates a neat, simpler Abstract Syntax Tree.
> This tasks is to refactor our current compiler to walk that AST, instead of the larger parse tree.
> Benefits:
> - less "visit" cases in the visitor
> - more opportunities to "optimize" the tree (e.g, tree rewrites, constant folding)
> - more opportunities to refactor tree walking phases (e.g. we could add a "type-evaluation" phase)
> - a chance to refactor code gen utilities to support classes, and simplify the code in general
> - cons: it takes a bit of time, but the AST nodes are really a handful, so it should not take that much
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3154) Minor UI improvements/bugfixes for Scenario
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3154?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3154:
-----------------------------------
Sprint: 2018 Week 42-44, 2018 Week 45-47 (was: 2018 Week 42-44)
> Minor UI improvements/bugfixes for Scenario
> -------------------------------------------
>
> Key: DROOLS-3154
> URL: https://issues.jboss.org/browse/DROOLS-3154
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Daniele Zonca
> Assignee: Daniele Zonca
> Priority: Major
> Labels: UX-CSS
> Attachments: Screen Shot 2018-10-25 at 9.53.57 PM.png, test-editor-margin.png
>
>
> This item contains a list of general UI bugs to be fixed:
> -Use grey borders for all the grid and not only for the header- Fixed in DROOLS-2684
> -Add some padding to the cells of the grid- Fixed in DROOLS-2684
> Add some padding to right panel the tab titles
> -Remove scrolling bar from right panel- Fixed in DROOLS-3170
> Review expression editor component HTML/CSS (paddings, indents, etc)
> Review right panel padding (now it is hardcoded)
> Use text area inputs instead of text box for inline editing
> -Reduce the width of Index column- Fixed in DROOLS-3167
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months