[JBoss JIRA] (DROOLS-2911) Update Scenario Simulation command to use the new module
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-2911?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-2911:
-----------------------------------
Sprint: 2018 Week 45-47, 2018 Week 48-50 (was: 2018 Week 45-47)
> Update Scenario Simulation command to use the new module
> --------------------------------------------------------
>
> Key: DROOLS-2911
> URL: https://issues.jboss.org/browse/DROOLS-2911
> Project: Drools
> Issue Type: Task
> Components: Scenario Simulation and Testing
> Reporter: Daniele Zonca
> Assignee: Gabriele Cardosi
> Priority: Major
>
> Use new kie-wb-common-command-api for Scenario Simulation commands
> *Specs:*
> Preliminary steps:
> * Add dependency to the new module containing AbstractCommand
> * Split CommandExecutor class into two classes: a pure executor and a general event handler that accepts all the events
> * Refactor ScenarioGridMode.bindContent and ScenarioSimulationViewImpl.refreshContent to be able to refresh internal model and grid model in a simple way (for now it refreshes only the errors from the internal model)
> * Refactor remaining actions with no commands (for instance flush of inline editing should fire an event instead of update directly the code). More or less all the methods that work with ScenarioGridModel should be inside a command
> Move to common API:
> * Implement ScenarioCommandManager extending org.kie.workbench.common.command.impl.CommandManagerImpl
> * Refactor all commands to extend org.kie.workbench.common.command.AbstractCommand
> * Implement a default undo strategy that dump the model and restore it when needed (we should consider how to *preserve selections, columns width and right panel status*)
> * Implement ScenarioCommandRegistry extending org.kie.workbench.common.command.registry.command.CommandRegistryImpl
> * Implement ScenarioCommandController (or with a better name :) ) that wrap ScenarioCommandRegistry and ScenarioCommandManager and exposes some API for safe command execute (for instance undo only of the last executed method). This class should be the entry point to manage commands (probably it should be declared as @Dependent and injected into the Presenter)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3274) [DMN Designer] Invocation: Improve header
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3274?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3274:
-----------------------------------
Sprint: 2018 Week 45-47, 2018 Week 48-50 (was: 2018 Week 45-47)
> [DMN Designer] Invocation: Improve header
> -----------------------------------------
>
> Key: DROOLS-3274
> URL: https://issues.jboss.org/browse/DROOLS-3274
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Minor
> Labels: drools-tools
> Attachments: DROOLS-3274-FEEL.png, DROOLS-3274-no-FEEL.png
>
>
> Requested by [~tirelli]:
> {quote}
> On the function invocation, it is not clear where and how to set the function name for the invocation.
> {quote}
> The _header_ has two empty cells; the top right should not even be there and the other is where the function name should be entered. Think about changing the renderer to more correctly render the header - according to the DMN specification - and put a hint/place-holder for where the function should be entered.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3282) Should not move to next AgendaGroup even if current is empty
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3282?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3282:
-----------------------------------
Sprint: 2018 Week 45-47, 2018 Week 48-50 (was: 2018 Week 45-47)
> Should not move to next AgendaGroup even if current is empty
> ------------------------------------------------------------
>
> Key: DROOLS-3282
> URL: https://issues.jboss.org/browse/DROOLS-3282
> Project: Drools
> Issue Type: Bug
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core
>
> Current implementation moves to next agend group if current agenda group is empty. This is unexpected, and in part detrimental in the impl of units: it is not possible to suspend execution of rules by switching to an empty group, because the engine will move to the next group anyway:
> {code}
> return nextRule != null && (!ruleAgendaItem.getAgendaGroup().equals( nextRule.getAgendaGroup() ) || !isHigherSalience(nextRule));
> {code}
> because the change in behavior is potentially backwards incompatible we add a flag {{keepWhenEmpty}} that must be set to {{true}} when we want to enable this new behavior
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-2932) [DMN Designer] keyboard navigation in context grid editor
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-2932?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-2932:
-----------------------------------
Sprint: 2018 Week 42-44, 2018 Week 45-47, 2018 Week 48-50 (was: 2018 Week 42-44, 2018 Week 45-47)
> [DMN Designer] keyboard navigation in context grid editor
> ---------------------------------------------------------
>
> Key: DROOLS-2932
> URL: https://issues.jboss.org/browse/DROOLS-2932
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.11.0.Final
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Priority: Major
> Labels: drools-tools
>
> User should be able to navigate between context grid editor cells by keyboard. We should implement standard navigation:
> - Move up: *arrow up*
> - Move left: *arrow left*
> - Move down: *arrow down*
> - Move right: *arrow right*
> Corner cases we need to address:
> - No cell selected
> -- -Select Top left cell if any arrow pressed?- left top cell selected by default
> - Multiple cells selected
> -- -Select Top left cell of current selected if any arrow pressed?- selection adjusted, no error thrown
> - Selected cell on the corner, no other cells in demanded way
> -- Keep selected the current cell
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months