[JBoss JIRA] (DROOLS-3286) [DMN Designer] FunctionGrid: Move F, J, P selector to header
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3286?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-3286:
-------------------------------------
[~manstis] [~dadossan] I am sorry for my English, I meant _data types_ of _method name_ and _class_ should be readonly. At least it was my understanding on meeting. I thought _data type_ of _class_ and _method name_ should be always _string_. Am I missing something please?
> [DMN Designer] FunctionGrid: Move F, J, P selector to header
> -------------------------------------------------------------
>
> Key: DROOLS-3286
> URL: https://issues.jboss.org/browse/DROOLS-3286
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
>
> The {{FunctionGrid}} allows switching between FEEL, Java and PMML function definitions using the context menu. [~tirelli] has requested this be changed to a selector in the header. A new column needs to be added with the F, J, P selector in the new column header. The header should display F, J or P accordingly. Do not include row numbers (i.e. don't just add a {{RowNumberColumn}}!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months
[JBoss JIRA] (DROOLS-3286) [DMN Designer] FunctionGrid: Move F, J, P selector to header
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3286?page=com.atlassian.jira.plugi... ]
Michael Anstis edited comment on DROOLS-3286 at 12/5/18 6:04 AM:
-----------------------------------------------------------------
[~jomarko] The _class_ and _method name_ cells are already read-only (obviously their _values_ are not read-only).
was (Author: manstis):
[~jomarko] The _class_ and _method name_ cells are already read-only.
> [DMN Designer] FunctionGrid: Move F, J, P selector to header
> -------------------------------------------------------------
>
> Key: DROOLS-3286
> URL: https://issues.jboss.org/browse/DROOLS-3286
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
>
> The {{FunctionGrid}} allows switching between FEEL, Java and PMML function definitions using the context menu. [~tirelli] has requested this be changed to a selector in the header. A new column needs to be added with the F, J, P selector in the new column header. The header should display F, J or P accordingly. Do not include row numbers (i.e. don't just add a {{RowNumberColumn}}!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months
[JBoss JIRA] (DROOLS-3286) [DMN Designer] FunctionGrid: Move F, J, P selector to header
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3286?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3286:
----------------------------------------
[~jomarko] The _class_ and _method name_ cells are already read-only.
> [DMN Designer] FunctionGrid: Move F, J, P selector to header
> -------------------------------------------------------------
>
> Key: DROOLS-3286
> URL: https://issues.jboss.org/browse/DROOLS-3286
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
>
> The {{FunctionGrid}} allows switching between FEEL, Java and PMML function definitions using the context menu. [~tirelli] has requested this be changed to a selector in the header. A new column needs to be added with the F, J, P selector in the new column header. The header should display F, J or P accordingly. Do not include row numbers (i.e. don't just add a {{RowNumberColumn}}!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months
[JBoss JIRA] (DROOLS-3395) [DMN Designer] Two copies of node are created
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3395?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3395:
----------------------------------------
[~jomarko] I've worked around the problem and submitted a PR (it's arguable that the original approach of overriding a {{@PostConstruct}} method with another {{@PostConstruct}} method is flawed... and to be honest the fix is simple enough to not really warrant further investigation).
> [DMN Designer] Two copies of node are created
> ---------------------------------------------
>
> Key: DROOLS-3395
> URL: https://issues.jboss.org/browse/DROOLS-3395
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
>
> Spotted during DROOLS-3371 review, however it is probably not related.
> If user copies diagram node by CTRL+C and CTRL+V it results two copies of the given node are created.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months
[JBoss JIRA] (DROOLS-3395) [DMN Designer] Two copies of node are created
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3395?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-3395:
-------------------------------------
[~manstis] you are awesome, are you able to find place in errai project where the fix is needed? Furthermore this was not palned to your sprint originally and seems kind of difficult to solve, probably good to postpone?
> [DMN Designer] Two copies of node are created
> ---------------------------------------------
>
> Key: DROOLS-3395
> URL: https://issues.jboss.org/browse/DROOLS-3395
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
>
> Spotted during DROOLS-3371 review, however it is probably not related.
> If user copies diagram node by CTRL+C and CTRL+V it results two copies of the given node are created.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months
[JBoss JIRA] (DROOLS-3286) [DMN Designer] FunctionGrid: Move F, J, P selector to header
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3286?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-3286:
-------------------------------------
[~dadossan][~manstis] We mentioned on meeting that _class_ and _method name_ should be also read only, will we do this in this jira or in a separate one?
> [DMN Designer] FunctionGrid: Move F, J, P selector to header
> -------------------------------------------------------------
>
> Key: DROOLS-3286
> URL: https://issues.jboss.org/browse/DROOLS-3286
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.14.0.Final
> Reporter: Michael Anstis
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
>
> The {{FunctionGrid}} allows switching between FEEL, Java and PMML function definitions using the context menu. [~tirelli] has requested this be changed to a selector in the header. A new column needs to be added with the F, J, P selector in the new column header. The header should display F, J or P accordingly. Do not include row numbers (i.e. don't just add a {{RowNumberColumn}}!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months
[JBoss JIRA] (DROOLS-3395) [DMN Designer] Two copies of node are created
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3395?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3395:
----------------------------------------
Errai is generating two invocations of a CDI Beans' {{@PostConstruct}} method:
{code}
package org.jboss.errai.ioc.client;
..
public class Type_factory__o_k_w_c_d_p_c_s_DMNEditorSessionCommands__quals__j_e_i_Any_o_k_w_c_d_a_q_DMNEditor extends Factory<DMNEditorSessionCommands> { public Type_factory__o_k_w_c_d_p_c_s_DMNEditorSessionCommands__quals__j_e_i_Any_o_k_w_c_d_a_q_DMNEditor() {
super(new FactoryHandleImpl(DMNEditorSessionCommands.class, "Type_factory__o_k_w_c_d_p_c_s_DMNEditorSessionCommands__quals__j_e_i_Any_o_k_w_c_d_a_q_DMNEditor", Dependent.class, false, null, true));
handle.setAssignableTypes(new Class[] { DMNEditorSessionCommands.class, EditorSessionCommands.class, Object.class });
handle.setQualifiers(new Annotation[] { QualifierUtil.ANY_ANNOTATION, new DMNEditor() {
public Class annotationType() {
return DMNEditor.class;
}
public String toString() {
return "@org.kie.workbench.common.dmn.api.qualifiers.DMNEditor()";
}
} });
}
public DMNEditorSessionCommands createInstance(final ContextManager contextManager) {
final ManagedClientSessionCommands _commands_0 = (ManagedClientSessionCommands) contextManager.getInstance("Type_factory__o_k_w_c_s_c_c_s_c_ManagedClientSessionCommands__quals__j_e_i_Any_j_e_i_Default");
final DMNEditorSessionCommands instance = new DMNEditorSessionCommands(_commands_0);
registerDependentScopedReference(instance, _commands_0);
setIncompleteInstance(instance);
setIncompleteInstance(null);
return instance;
}
public void invokePostConstructs(final DMNEditorSessionCommands instance) {
instance.init();
instance.init(); // <-- Oh dear!
}
}
{code}
> [DMN Designer] Two copies of node are created
> ---------------------------------------------
>
> Key: DROOLS-3395
> URL: https://issues.jboss.org/browse/DROOLS-3395
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.16.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
>
> Spotted during DROOLS-3371 review, however it is probably not related.
> If user copies diagram node by CTRL+C and CTRL+V it results two copies of the given node are created.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months
[JBoss JIRA] (DROOLS-3400) [DMN Designer] Data Types - Validate the Data Type name using the logic that the marshaller implements
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3400?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3400:
--------------------------------
Description:
Validate the Data Type name (in the UI) using the same logic as the marshaller(in the backend).
h2. Acceptance test
- Do not use *--* as default name for itemDefinitions and itemComponents
was:Validate the Data Type name (in the UI) using the same logic as the marshaller(in the backend).
> [DMN Designer] Data Types - Validate the Data Type name using the logic that the marshaller implements
> ------------------------------------------------------------------------------------------------------
>
> Key: DROOLS-3400
> URL: https://issues.jboss.org/browse/DROOLS-3400
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Guilherme Carreiro
> Assignee: Guilherme Carreiro
> Priority: Major
> Labels: drools-tools
>
> Validate the Data Type name (in the UI) using the same logic as the marshaller(in the backend).
> h2. Acceptance test
> - Do not use *--* as default name for itemDefinitions and itemComponents
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 5 months