[JBoss JIRA] (DROOLS-2381) DMN Validator raising a NPE for the <drools:decisionServices> extension element
by Edson Tirelli (JIRA)
Edson Tirelli created DROOLS-2381:
-------------------------------------
Summary: DMN Validator raising a NPE for the <drools:decisionServices> extension element
Key: DROOLS-2381
URL: https://issues.jboss.org/browse/DROOLS-2381
Project: Drools
Issue Type: Bug
Components: dmn engine
Affects Versions: 7.6.0.Final
Reporter: Edson Tirelli
Assignee: Edson Tirelli
Priority: Critical
Fix For: 7.7.0.Final
The DMN Validator is raising a NPE and the following error message when the following element is present:
<drools:decisionServices xmlns:drools="http://www.drools.org/kie/dmn/1.1"/>
Error message:
DMNMessage{ severity=ERROR, type=INVALID_NAME, message='Invalid name 'null': Name cannot be null or empty', sourceId='null', exception='', feelEvent=''}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (DROOLS-2380) DMN Validator is not using the DMN Profiles
by Edson Tirelli (JIRA)
Edson Tirelli created DROOLS-2380:
-------------------------------------
Summary: DMN Validator is not using the DMN Profiles
Key: DROOLS-2380
URL: https://issues.jboss.org/browse/DROOLS-2380
Project: Drools
Issue Type: Bug
Components: dmn engine
Affects Versions: 7.6.0.Final
Reporter: Edson Tirelli
Assignee: Edson Tirelli
Priority: Critical
Fix For: 7.7.0.Final
The DMN validator is instantiating the DMN compiler directly, and that does not load the default extension profiles, nor any possibly configured profile.
We need to unify the compiler instantiation code so that it is consistent for both the validator and the runtime.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (DROOLS-2380) DMN Validator is not using the DMN Profiles
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2380?page=com.atlassian.jira.plugi... ]
Edson Tirelli reassigned DROOLS-2380:
-------------------------------------
Assignee: Matteo Mortari (was: Edson Tirelli)
> DMN Validator is not using the DMN Profiles
> -------------------------------------------
>
> Key: DROOLS-2380
> URL: https://issues.jboss.org/browse/DROOLS-2380
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.6.0.Final
> Reporter: Edson Tirelli
> Assignee: Matteo Mortari
> Priority: Critical
> Fix For: 7.7.0.Final
>
>
> The DMN validator is instantiating the DMN compiler directly, and that does not load the default extension profiles, nor any possibly configured profile.
> We need to unify the compiler instantiation code so that it is consistent for both the validator and the runtime.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (DROOLS-2379) DMN Validator raising false positive errors for type resolution
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2379?page=com.atlassian.jira.plugi... ]
Edson Tirelli commented on DROOLS-2379:
---------------------------------------
[~tzimanyi] can I ask your help please to add tests for each of the cases in the linked PR:
{code:drl}
rule TYPEREF_NOT_FEEL_NOT_DEF_p1
when
$o: Expression( typeRef != null, typeRef.prefix == null || getNamespaceURI( typeRef.prefix ) != DMNModelInstrumentedBase.URI_FEEL, $typeRef : typeRef )
not( ItemDefinition( name == $typeRef.getLocalPart() ) )
then
reporter.report( DMNMessage.Severity.ERROR, $o , Msg.UNKNOWN_TYPE_REF_ON_NODE, $typeRef, $o.getParentDRDElement().getIdentifierString() );
end
rule TYPEREF_NOT_FEEL_NOT_DEF_p2
when
$o: InformationItem( typeRef != null, typeRef.prefix == null || getNamespaceURI( typeRef.prefix ) != DMNModelInstrumentedBase.URI_FEEL, $typeRef : typeRef )
not( ItemDefinition( name == $typeRef.getLocalPart() ) )
then
reporter.report( DMNMessage.Severity.ERROR, $o , Msg.UNKNOWN_TYPE_REF_ON_NODE, $typeRef, $o.getParentDRDElement().getIdentifierString() );
end
rule TYPEREF_NOT_FEEL_NOT_DEF_p3
when
$o: ItemDefinition( typeRef != null, typeRef.prefix == null || getNamespaceURI( typeRef.prefix ) != DMNModelInstrumentedBase.URI_FEEL, $typeRef : typeRef )
not( ItemDefinition( name == $typeRef.getLocalPart() ) )
then
reporter.report( DMNMessage.Severity.ERROR, $o , Msg.UNKNOWN_TYPE_REF_ON_NODE, $typeRef, $o.getParentDRDElement().getIdentifierString() );
end
rule TYPEREF_NOT_FEEL_NOT_DEF_p4
when
$o: OutputClause( typeRef != null, typeRef.prefix == null || getNamespaceURI( typeRef.prefix ) != DMNModelInstrumentedBase.URI_FEEL, $typeRef : typeRef )
not( ItemDefinition( name == $typeRef.getLocalPart() ) )
then
reporter.report( DMNMessage.Severity.ERROR, $o , Msg.UNKNOWN_TYPE_REF_ON_NODE, $typeRef, $o.getParentDRDElement().getIdentifierString() );
end
{code}
> DMN Validator raising false positive errors for type resolution
> ---------------------------------------------------------------
>
> Key: DROOLS-2379
> URL: https://issues.jboss.org/browse/DROOLS-2379
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.6.0.Final
> Reporter: Edson Tirelli
> Assignee: Tibor Zimányi
> Priority: Critical
> Fix For: 7.7.0.Final
>
>
> DMN Validator is raising false positives for errors on type resolution. It looks like it is happening since the following commit was done:
> https://github.com/kiegroup/drools/commit/9e2fdc4b5e83bb9b5350a37fd89dab8...
> The problem is that the .toString() call on the QName will return the full name, including the namespace:
> {http://www.trisotech.com/definitions/_6cfe7d88-6741-45d1-968c-b61a597d0964}tDailyPrice
> And that will always fail the constraint:
> ItemDefinition( name == $typeRef.toString() )
> I believe the correct would be to change the constraint to:
> ItemDefinition( name == $typeRef.getLocalPart() )
> But we might also need to check the namespace somehow.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (DROOLS-2379) DMN Validator raising false positive errors for type resolution
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2379?page=com.atlassian.jira.plugi... ]
Edson Tirelli reassigned DROOLS-2379:
-------------------------------------
Assignee: Tibor Zimányi (was: Edson Tirelli)
> DMN Validator raising false positive errors for type resolution
> ---------------------------------------------------------------
>
> Key: DROOLS-2379
> URL: https://issues.jboss.org/browse/DROOLS-2379
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.6.0.Final
> Reporter: Edson Tirelli
> Assignee: Tibor Zimányi
> Priority: Critical
> Fix For: 7.7.0.Final
>
>
> DMN Validator is raising false positives for errors on type resolution. It looks like it is happening since the following commit was done:
> https://github.com/kiegroup/drools/commit/9e2fdc4b5e83bb9b5350a37fd89dab8...
> The problem is that the .toString() call on the QName will return the full name, including the namespace:
> {http://www.trisotech.com/definitions/_6cfe7d88-6741-45d1-968c-b61a597d0964}tDailyPrice
> And that will always fail the constraint:
> ItemDefinition( name == $typeRef.toString() )
> I believe the correct would be to change the constraint to:
> ItemDefinition( name == $typeRef.getLocalPart() )
> But we might also need to check the namespace somehow.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (DROOLS-2379) DMN Validator raising false positive errors for type resolution
by Edson Tirelli (JIRA)
Edson Tirelli created DROOLS-2379:
-------------------------------------
Summary: DMN Validator raising false positive errors for type resolution
Key: DROOLS-2379
URL: https://issues.jboss.org/browse/DROOLS-2379
Project: Drools
Issue Type: Bug
Components: dmn engine
Affects Versions: 7.6.0.Final
Reporter: Edson Tirelli
Assignee: Edson Tirelli
Priority: Critical
Fix For: 7.7.0.Final
DMN Validator is raising false positives for errors on type resolution. It looks like it is happening since the following commit was done:
https://github.com/kiegroup/drools/commit/9e2fdc4b5e83bb9b5350a37fd89dab8...
The problem is that the .toString() call on the QName will return the full name, including the namespace:
{http://www.trisotech.com/definitions/_6cfe7d88-6741-45d1-968c-b61a597d0964}tDailyPrice
And that will always fail the constraint:
ItemDefinition( name == $typeRef.toString() )
I believe the correct would be to change the constraint to:
ItemDefinition( name == $typeRef.getLocalPart() )
But we might also need to check the namespace somehow.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (ELY-1540) Build fails on Java 9.0.4
by David Lloyd (JIRA)
David Lloyd created ELY-1540:
--------------------------------
Summary: Build fails on Java 9.0.4
Key: ELY-1540
URL: https://issues.jboss.org/browse/ELY-1540
Project: WildFly Elytron
Issue Type: Bug
Components: Build
Reporter: David Lloyd
Priority: Critical
The build fails at the last step with this exception:
{noformat}
[INFO] --- japicmp-maven-plugin:0.11.0:cmp (default) @ wildfly-elytron ---
[INFO] Written file '/home/david/src/java/wildfly-elytron/target/japicmp/japicmp.diff'.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:50 min
[INFO] Finished at: 2018-03-09T10:05:46-06:00
[INFO] Final Memory: 62M/206M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Execution default of goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp failed: A required class was missing while executing com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp: javax/xml/bind/JAXBException
[ERROR] -----------------------------------------------------
[ERROR] realm = plugin>com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/david/.m2/repository/com/github/siom79/japicmp/japicmp-maven-plugin/0.11.0/japicmp-maven-plugin-0.11.0.jar
[ERROR] urls[1] = file:/home/david/.m2/repository/org/sonatype/aether/aether-util/1.11/aether-util-1.11.jar
[ERROR] urls[2] = file:/home/david/.m2/repository/org/sonatype/sisu/sisu-inject-bean/2.1.1/sisu-inject-bean-2.1.1.jar
[ERROR] urls[3] = file:/home/david/.m2/repository/org/sonatype/sisu/sisu-guice/2.9.4/sisu-guice-2.9.4-no_aop.jar
[ERROR] urls[4] = file:/home/david/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
[ERROR] urls[5] = file:/home/david/.m2/repository/org/codehaus/plexus/plexus-utils/2.0.6/plexus-utils-2.0.6.jar
[ERROR] urls[6] = file:/home/david/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
[ERROR] urls[7] = file:/home/david/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
[ERROR] urls[8] = file:/home/david/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
[ERROR] urls[9] = file:/home/david/.m2/repository/com/github/siom79/japicmp/japicmp/0.11.0/japicmp-0.11.0.jar
[ERROR] urls[10] = file:/home/david/.m2/repository/org/javassist/javassist/3.22.0-GA/javassist-3.22.0-GA.jar
[ERROR] urls[11] = file:/home/david/.m2/repository/com/google/guava/guava/18.0/guava-18.0.jar
[ERROR] urls[12] = file:/home/david/.m2/repository/org/apache/maven/reporting/maven-reporting-impl/2.3/maven-reporting-impl-2.3.jar
[ERROR] urls[13] = file:/home/david/.m2/repository/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
[ERROR] urls[14] = file:/home/david/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar
[ERROR] urls[15] = file:/home/david/.m2/repository/org/apache/maven/shared/maven-shared-utils/0.6/maven-shared-utils-0.6.jar
[ERROR] urls[16] = file:/home/david/.m2/repository/com/google/code/findbugs/jsr305/2.0.1/jsr305-2.0.1.jar
[ERROR] urls[17] = file:/home/david/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.2/doxia-sink-api-1.2.jar
[ERROR] urls[18] = file:/home/david/.m2/repository/org/apache/maven/doxia/doxia-core/1.2/doxia-core-1.2.jar
[ERROR] urls[19] = file:/home/david/.m2/repository/commons-lang/commons-lang/2.4/commons-lang-2.4.jar
[ERROR] urls[20] = file:/home/david/.m2/repository/org/apache/httpcomponents/httpclient/4.0.2/httpclient-4.0.2.jar
[ERROR] urls[21] = file:/home/david/.m2/repository/org/apache/httpcomponents/httpcore/4.0.1/httpcore-4.0.1.jar
[ERROR] urls[22] = file:/home/david/.m2/repository/commons-codec/commons-codec/1.3/commons-codec-1.3.jar
[ERROR] urls[23] = file:/home/david/.m2/repository/org/apache/maven/doxia/doxia-site-renderer/1.2/doxia-site-renderer-1.2.jar
[ERROR] urls[24] = file:/home/david/.m2/repository/org/apache/maven/doxia/doxia-decoration-model/1.2/doxia-decoration-model-1.2.jar
[ERROR] urls[25] = file:/home/david/.m2/repository/org/apache/maven/doxia/doxia-module-xhtml/1.2/doxia-module-xhtml-1.2.jar
[ERROR] urls[26] = file:/home/david/.m2/repository/org/apache/maven/doxia/doxia-module-fml/1.2/doxia-module-fml-1.2.jar
[ERROR] urls[27] = file:/home/david/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar
[ERROR] urls[28] = file:/home/david/.m2/repository/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar
[ERROR] urls[29] = file:/home/david/.m2/repository/org/apache/velocity/velocity/1.5/velocity-1.5.jar
[ERROR] urls[30] = file:/home/david/.m2/repository/oro/oro/2.0.8/oro-2.0.8.jar
[ERROR] urls[31] = file:/home/david/.m2/repository/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar
[ERROR] urls[32] = file:/home/david/.m2/repository/commons-validator/commons-validator/1.3.1/commons-validator-1.3.1.jar
[ERROR] urls[33] = file:/home/david/.m2/repository/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar
[ERROR] urls[34] = file:/home/david/.m2/repository/commons-digester/commons-digester/1.6/commons-digester-1.6.jar
[ERROR] urls[35] = file:/home/david/.m2/repository/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar
[ERROR] urls[36] = file:/home/david/.m2/repository/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar
[ERROR] urls[37] = file:/home/david/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.2.1/maven-reporting-api-2.2.1.jar
[ERROR] urls[38] = file:/home/david/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.jar
[ERROR] urls[39] = file:/home/david/.m2/repository/org/codehaus/groovy/groovy-jsr223/2.4.6/groovy-jsr223-2.4.6.jar
[ERROR] urls[40] = file:/home/david/.m2/repository/org/codehaus/groovy/groovy/2.4.6/groovy-2.4.6.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import from realm ClassRealm[maven.api, parent: null]]
[ERROR]
[ERROR] -----------------------------------------------------
[ERROR] : javax.xml.bind.JAXBException
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException
{noformat}
Maybe because JAXB is not an included module by default on Java 9. Might need an {{--add-module}} somewhere?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months