[JBoss JIRA] (WFLY-10043) [Artemis 2.x Upgrade] Last value queues do not work
by Martin Styk (JIRA)
[ https://issues.jboss.org/browse/WFLY-10043?page=com.atlassian.jira.plugin... ]
Martin Styk commented on WFLY-10043:
------------------------------------
[~clebert.suconic], in this case there are all messages in the queue instead of the single message (as expected from LVQ with all messages with the same LVQ property value).
Message counters show all messages are in the queue, and also client receives them all.
> [Artemis 2.x Upgrade] Last value queues do not work
> ---------------------------------------------------
>
> Key: WFLY-10043
> URL: https://issues.jboss.org/browse/WFLY-10043
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Reporter: Martin Styk
> Assignee: Martyn Taylor
> Priority: Blocker
> Labels: activemq, feature-branch-blocker
>
> Last value queues are not working as expected.
> # Set {{last-value-queue="true"}} for an address settings {{#}}
> # Send 10 messages with {{message.setStringProperty("_AMQ_LVQ_NAME", "myProperty");}}
> # Receiver receives 10 messages. (it is expected to receive the single message)
> This looks like broker related regression against Artemis 1.5.
> Wildfly: {{https://github.com/jmesnil/wildfly/tree/WFLY-9407_upgrade_artemis_2.4.0_with_prefix}} (c692e8327023f9bc40699a6863b4197cc7c1b3c8)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (WFLY-10131) [Artemis 2.x upgrade] Missing message JMS bridge with DUPS_OK quality of service
by Miroslav Novak (JIRA)
[ https://issues.jboss.org/browse/WFLY-10131?page=com.atlassian.jira.plugin... ]
Miroslav Novak updated WFLY-10131:
----------------------------------
Steps to Reproduce:
*Steps to reproduce (not 100% reproducer)*:
{code}
git clone git://git.app.eng.bos.redhat.com/jbossqe/eap-tests-hornetq.git
cd eap-tests-hornetq/scripts/
groovy -DEAP_ZIP_URL=https://eap-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/early-testing-messaging-prepare/273//artifact/jboss-eap.zip PrepareServers7.groovy
export WORKSPACE=$PWD
export JBOSS_HOME_1=$WORKSPACE/server1/jboss-eap
export JBOSS_HOME_2=$WORKSPACE/server2/jboss-eap
export JBOSS_HOME_3=$WORKSPACE/server3/jboss-eap
export JBOSS_HOME_4=$WORKSPACE/server4/jboss-eap
cd ../jboss-hornetq-testsuite/
mvn clean test -Dtest=DedicatedFailoverCoreBridges#testFailoverKillWithBridgeWithStaticConnectors -Deap7.org.jboss.qa.hornetq.apps.clients.version=7.1521544306-SNAPSHOT -DfailIfNoTests=false -Deap=7x | tee log
{code}
> [Artemis 2.x upgrade] Missing message JMS bridge with DUPS_OK quality of service
> --------------------------------------------------------------------------------
>
> Key: WFLY-10131
> URL: https://issues.jboss.org/browse/WFLY-10131
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Reporter: Miroslav Novak
> Assignee: Martyn Taylor
> Labels: activemq
>
> There is missing one message in scenario where JMS bridge (with DUPS_OK) resending messages from one server to another. Durint resending target server is killed and bridge does failover to backup.
> After failover in server logs there are lots of warns/errors:
> {code}
> 05:39:01,697 WARN [org.apache.activemq.artemis.jms.bridge] (Thread-144) AMQ342009: JMS Bridge N/A failed to send + acknowledge batch, closing JMS objects: javax.jms.JMSException: Duplicate message detected - me
> ssage will not be routed. Message information:LargeServerMessage[messageID=2147485500,durable=true,userID=d8ea8e0a-326b-11e8-b74b-fa163e64a220,priority=4, timestamp=Wed Mar 28 05:39:01 EDT 2018,expiration=0, dur
> able=true, address=jms.queue.OutQueue,size=410263,properties=TypedProperties[__AMQ_CID=bd95a355-326b-11e8-b74b-fa163e64a220,_AMQ_ROUTING_TYPE=1,AMQ_BRIDGE_MSG_ID_LIST=ID:c13a41dc-326b-11e8-949b-fa163e64a220,JMSX
> DeliveryCount=10,count=989,color=RED,counter=990,_AMQ_DUPL_ID=fde672e0-e858-4c50-a148-a0b7a4a223591522229901951,_AMQ_LARGE_SIZE=409615]]@1304406481
> at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:423) [artemis-core-client-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:319) [artemis-core-client-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.simpleCommit(ActiveMQSessionContext.java:381) [artemis-core-client-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.commit(ClientSessionImpl.java:862) [artemis-core-client-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.commit(ClientSessionImpl.java:835) [artemis-core-client-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.jms.client.ActiveMQSession.commit(ActiveMQSession.java:231) [artemis-jms-client-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.jms.bridge.impl.JMSBridgeImpl.sendBatchNonTransacted(JMSBridgeImpl.java:1338) [artemis-jms-server-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.jms.bridge.impl.JMSBridgeImpl.sendBatch(JMSBridgeImpl.java:1298) [artemis-jms-server-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.jms.bridge.impl.JMSBridgeImpl.access$1700(JMSBridgeImpl.java:74) [artemis-jms-server-2.5.0.jar:2.5.0]
> at org.apache.activemq.artemis.jms.bridge.impl.JMSBridgeImpl$SourceReceiver.run(JMSBridgeImpl.java:1694) [artemis-jms-server-2.5.0.jar:2.5.0]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [rt.jar:1.8.0_162]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [rt.jar:1.8.0_162]
> at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_162]
> Caused by: ActiveMQDuplicateIdException[errorType=DUPLICATE_ID_REJECTED message=Duplicate message detected - message will not be routed. Message information:LargeServerMessage[messageID=2147485500,durable=true,u
> serID=d8ea8e0a-326b-11e8-b74b-fa163e64a220,priority=4, timestamp=Wed Mar 28 05:39:01 EDT 2018,expiration=0, durable=true, address=jms.queue.OutQueue,size=410263,properties=TypedProperties[__AMQ_CID=bd95a355-326b
> -11e8-b74b-fa163e64a220,_AMQ_ROUTING_TYPE=1,AMQ_BRIDGE_MSG_ID_LIST=ID:c13a41dc-326b-11e8-949b-fa163e64a220,JMSXDeliveryCount=10,count=989,color=RED,counter=990,_AMQ_DUPL_ID=fde672e0-e858-4c50-a148-a0b7a4a2235915
> 22229901951,_AMQ_LARGE_SIZE=409615]]@1304406481]
> ... 13 more
> 05:39:01,699 WARN [org.apache.activemq.artemis.core.server] (Thread-23 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@2076a02)) AMQ222149: Message Reference[3056]:RELIABLE:Co
> reMessage[messageID=3056,durable=true,userID=c1347573-326b-11e8-949b-fa163e64a220,priority=4, timestamp=Wed Mar 28 05:38:21 EDT 2018,expiration=0, durable=true, address=jms.queue.InQueue,size=10673,properties=Ty
> pedProperties[__AMQ_CID=be528a5c-326b-11e8-949b-fa163e64a220,_AMQ_ROUTING_TYPE=1,count=980,counter=981,_AMQ_DUPL_ID=13adf1ec-581f-42e4-835b-0e6e33a4e1191522229901913,color=GREEN]]@511432790 has reached maximum d
> elivery attempts, sending it to Dead Letter Address jms.queue.DLQ from jms.queue.InQueue
> 05:39:01,700 WARN [org.apache.activemq.artemis.core.server] (Thread-23 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@2076a02)) AMQ222149: Message Reference[3058]:RELIABLE:CoreMessage[messageID=3058,durable=true,userID=c1349c84-326b-11e8-949b-fa163e64a220,priority=4, timestamp=Wed Mar 28 05:38:21 EDT 2018,expiration=0, durable=true, address=jms.queue.InQueue,size=20914,properties=TypedProperties[__AMQ_CID=be528a5c-326b-11e8-949b-fa163e64a220,_AMQ_ROUTING_TYPE=1,count=981,counter=982,_AMQ_DUPL_ID=6feb66cd-8616-4dff-8775-3f85a4b9bdbb1522229901914,color=RED]]@1150646585 has reached maximum delivery attempts, sending it to Dead Letter Address jms.queue.DLQ from jms.queue.InQueue
> ....
> 05:39:01,706 WARN [org.apache.activemq.artemis.core.server] (Thread-23 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@2076a02)) AMQ222149: Message Reference[3082]:RELIABLE:CoreMessage[messageID=3082,durable=true,userID=c13d4f1d-326b-11e8-949b-fa163e64a220,priority=4, timestamp=Wed Mar 28 05:38:21 EDT 2018,expiration=0, durable=true, address=jms.queue.InQueue,size=10673,properties=TypedProperties[__AMQ_CID=be528a5c-326b-11e8-949b-fa163e64a220,_AMQ_ROUTING_TYPE=1,count=990,counter=991,_AMQ_DUPL_ID=f802f4b7-e0a1-4dee-acc7-0b11963bec401522229901971,color=GREEN]]@2708478 has reached maximum delivery attempts, sending it to Dead Letter Address jms.queue.DLQ from jms.queue.InQueue
> {code}
> So the missing message ended up in DLQ as it could not be delivered to target queue. It looks like that _AMQ_DUPL_ID might trigger dup message detection in target queueu however such message did not get there.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (WFLY-10043) [Artemis 2.x Upgrade] Last value queues do not work
by Martin Styk (JIRA)
[ https://issues.jboss.org/browse/WFLY-10043?page=com.atlassian.jira.plugin... ]
Martin Styk updated WFLY-10043:
-------------------------------
Description:
Last value queues are not working as expected.
# Set {{last-value-queue="true"}} for an address settings {{#}}
# Send 10 messages with {{message.setStringProperty("_AMQ_LVQ_NAME", "myProperty");}}
# Receiver receives 10 messages. (it is expected to receive the single message)
This looks like broker related regression against Artemis 1.5.
Wildfly: {{https://github.com/jmesnil/wildfly/tree/WFLY-9407_upgrade_artemis_2.4.0_with_prefix}} (c692e8327023f9bc40699a6863b4197cc7c1b3c8)
was:
Last value queues are not working as expected.
# Set {{last-value-queue="true"}} for an address settings {{#}}
# Send 10 messages with {{message.setStringProperty("_AMQ_LVQ_NAME", "myProperty");}}
# Receiver receives 10 messages. (it is expected to receive the single message)
This looks like broker related regression against Artemis 1.5.
Wildfly: {{https://github.com/jmesnil/wildfly/tree/WFLY-9407_upgrade_artemis_2.4.0_with_prefix}} (06c878a313d3cad323889d017e60fd5533204d1a)
Artemis: upstreadm master (577b62d5210cdcc0f86ab9bb1b24e944c877dfe7)
> [Artemis 2.x Upgrade] Last value queues do not work
> ---------------------------------------------------
>
> Key: WFLY-10043
> URL: https://issues.jboss.org/browse/WFLY-10043
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Reporter: Martin Styk
> Assignee: Martyn Taylor
> Priority: Blocker
> Labels: activemq, feature-branch-blocker
>
> Last value queues are not working as expected.
> # Set {{last-value-queue="true"}} for an address settings {{#}}
> # Send 10 messages with {{message.setStringProperty("_AMQ_LVQ_NAME", "myProperty");}}
> # Receiver receives 10 messages. (it is expected to receive the single message)
> This looks like broker related regression against Artemis 1.5.
> Wildfly: {{https://github.com/jmesnil/wildfly/tree/WFLY-9407_upgrade_artemis_2.4.0_with_prefix}} (c692e8327023f9bc40699a6863b4197cc7c1b3c8)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (WFLY-10043) [Artemis 2.x Upgrade] Last value queues do not work
by Martin Styk (JIRA)
[ https://issues.jboss.org/browse/WFLY-10043?page=com.atlassian.jira.plugin... ]
Martin Styk updated WFLY-10043:
-------------------------------
Steps to Reproduce:
{noformat}
git clone git://git.app.eng.bos.redhat.com/jbossqe/eap-tests-hornetq.git
cd eap-tests-hornetq/scripts/
groovy -DEAP_ZIP_URL=https://eap-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/early-testing-messaging-prepare/355//artifact/jboss-eap.zip PrepareServers7.groovy
export WORKSPACE=$PWD
export JBOSS_HOME_1=$WORKSPACE/server1/jboss-eap
export JBOSS_HOME_2=$WORKSPACE/server2/jboss-eap
export JBOSS_HOME_3=$WORKSPACE/server3/jboss-eap
export JBOSS_HOME_4=$WORKSPACE/server4/jboss-eap
cd ../jboss-hornetq-testsuite/
mvn clean test -Dtest=LastValueQueuesTestCase#lastValueQueueTest -Deap7.org.jboss.qa.hornetq.apps.clients.version=7.1523427376-SNAPSHOT | tee log
{noformat}
was:
{noformat}
git clone git://git.app.eng.bos.redhat.com/jbossqe/eap-tests-hornetq.git
cd eap-tests-hornetq/scripts/
groovy -DEAP_ZIP_URL=<CURRENT_DIST_URL> PrepareServers7.groovy
export WORKSPACE=$PWD
export JBOSS_HOME_1=$WORKSPACE/server1/jboss-eap
export JBOSS_HOME_2=$WORKSPACE/server2/jboss-eap
export JBOSS_HOME_3=$WORKSPACE/server3/jboss-eap
export JBOSS_HOME_4=$WORKSPACE/server4/jboss-eap
cd ../jboss-hornetq-testsuite/
mvn clean test -Dtest=LastValueQueuesTestCase#lastValueQueueTest -Deap7.org.jboss.qa.hornetq.apps.clients.version=<CLIENT_VERSION> | tee log
{noformat}
> [Artemis 2.x Upgrade] Last value queues do not work
> ---------------------------------------------------
>
> Key: WFLY-10043
> URL: https://issues.jboss.org/browse/WFLY-10043
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Reporter: Martin Styk
> Assignee: Martyn Taylor
> Priority: Blocker
> Labels: activemq, feature-branch-blocker
>
> Last value queues are not working as expected.
> # Set {{last-value-queue="true"}} for an address settings {{#}}
> # Send 10 messages with {{message.setStringProperty("_AMQ_LVQ_NAME", "myProperty");}}
> # Receiver receives 10 messages. (it is expected to receive the single message)
> This looks like broker related regression against Artemis 1.5.
> Wildfly: {{https://github.com/jmesnil/wildfly/tree/WFLY-9407_upgrade_artemis_2.4.0_with_prefix}} (06c878a313d3cad323889d017e60fd5533204d1a)
> Artemis: upstreadm master (577b62d5210cdcc0f86ab9bb1b24e944c877dfe7)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (WFCORE-3734) [Coverity] Operation - Potential Resource Leak
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3734?page=com.atlassian.jira.plugi... ]
Brian Stansberry resolved WFCORE-3734.
--------------------------------------
Resolution: Rejected
Rejected.
1) Two unrelated pieces of code in a single bug report.
2) No reproducer for either showing an actual problem. I want proof that the attachments are not actually closed in a real use case. Just because a class can be helpful and close things for you doesn't mean you have to take advantage of its help.
> [Coverity] Operation - Potential Resource Leak
> -----------------------------------------------
>
> Key: WFCORE-3734
> URL: https://issues.jboss.org/browse/WFCORE-3734
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Reporter: Martin Choma
> Assignee: Brian Stansberry
> Priority: Critical
>
> Closeable Operation is not closed in:
> * {code:java|title=ModelControllerClientFactoryImpl.java}
> private OperationResponse runOperation(final ModelNode operation, final OperationMessageHandler messageHandler,
> final OperationAttachments attachments, boolean inVmCall) {
> Operation op = attachments == null ? Operation.Factory.create(operation) : Operation.Factory.create(operation, attachments.getInputStreams(),
> attachments.isAutoCloseStreams());
> if (inVmCall) {
> return SecurityActions.runInVm(() -> modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT));
> } else {
> return modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT);
> }
> }
> {code}
> * {code:java|title=AffectedDeploymentOverlay.java}
> final ModelNode slave = opBuilder.build().getOperation();
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (LOGMGR-136) java.util.logging.LogManager removed deprecated property change listeners
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/LOGMGR-136?page=com.atlassian.jira.plugin... ]
James Perkins updated LOGMGR-136:
---------------------------------
Fix Version/s: 2.1.2.Final
(was: 2.1.1.Final)
> java.util.logging.LogManager removed deprecated property change listeners
> -------------------------------------------------------------------------
>
> Key: LOGMGR-136
> URL: https://issues.jboss.org/browse/LOGMGR-136
> Project: JBoss Log Manager
> Issue Type: Sub-task
> Reporter: James Perkins
> Fix For: 2.1.2.Final
>
>
> Both the {{addPropertyChangeListener(PropertyChangeListener}} and {{removePropertyChangeListener(PropertyChangeListener}} were deprecated in Java 8 and removed in Java 9. There are two new replacement methods {{addConfigurationListener(Runnable)}} and {{removeConfigurationListener(Runnable)}} that have been added as replacements.
> For the JBoss Log Manager these could likely be no-ops like the originals were.
> In Java 9 to {{updateConfiguration()}} methods were added as well. These should also be overridden with no-ops.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months