[JBoss JIRA] (WFLY-9622) Eliminate uses of ModelNode.resolve()
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-9622?page=com.atlassian.jira.plugin.... ]
Radoslav Husar commented on WFLY-9622:
--------------------------------------
[~brian.stansberry] Yes, that's exactly what I am doing in my branch. :-)
> Eliminate uses of ModelNode.resolve()
> -------------------------------------
>
> Key: WFLY-9622
> URL: https://issues.jboss.org/browse/WFLY-9622
> Project: WildFly
> Issue Type: Task
> Components: Clustering, JCA, JMS, JPA / Hibernate, Management, mod_cluster
> Reporter: Brian Stansberry
>
> Code inspection shows there are 16 uses of ModelNode.resolve() in WildFly's own code base, 12 in production code and 4 in test code. We should eliminate these, as WildFly's expression resolution is more complex than the ModelNode.resolve() contract, including vault support for which its' hard to imagine us wanting support in DMR itself. So these uses should switch to resolution from the OperationContext or, if that's not feasible, e.g. in test code, use something like ExpressionResolver.TEST_RESOLVER.
> Current uses:
> {code}
> Method
> resolve()
> Found usages (16 usages found)
> Production (12 usages found)
> Unclassified usage (12 usages found)
> wildfly-connector (3 usages found)
> org.jboss.as.connector.subsystems.common.pool (2 usages found)
> PoolConfigurationRWHandler.PoolConfigurationWriteHandler (1 usage found)
> revertUpdateToRuntime(OperationContext, ModelNode, String, ModelNode, ModelNode, List<PoolConfiguration>) (1 usage found)
> 126 updatePoolConfigs(handback, parameterName, valueToRestore.resolve());
> PoolStatisticsRuntimeAttributeWriteHandler (1 usage found)
> execute(OperationContext, ModelNode) (1 usage found)
> 58 final ModelNode resolvedValue = newValue.resolve();
> org.jboss.as.connector.subsystems.datasources (1 usage found)
> Constants (1 usage found)
> 297 validateParameter(parameterName, value.resolve());
> wildfly-jpa (4 usages found)
> org.jboss.as.jpa.management (1 usage found)
> ManagementResourceDefinition (1 usage found)
> registerAttributes(ManagementResourceRegistration) (1 usage found)
> 154 final ModelNode value = operation.get(ModelDescriptionConstants.VALUE).resolve();
> org.jboss.as.jpa.subsystem (3 usages found)
> JPASubSystemAdd (3 usages found)
> performBoottime(OperationContext, ModelNode, ModelNode) (3 usages found)
> 78 runtimeValidator.validate(operation.resolve());
> 125 final String dataSourceName = defaultDSNode.resolve().asString();
> 131 ExtendedPersistenceInheritance.valueOf(defaultExtendedPersistenceInheritanceNode.resolve().asString());
> wildfly-messaging-activemq (4 usages found)
> org.wildfly.extension.messaging.activemq.deployment (4 usages found)
> MessagingXmlInstallDeploymentUnitProcessor (4 usages found)
> deploy(DeploymentPhaseContext) (4 usages found)
> 76 final ModelNode entries = topic.getDestination().resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 97 final ModelNode entries = destination.resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 100 final String selector = destination.hasDefined(SELECTOR.getName()) ? destination.get(SELECTOR.getName()).resolve().asString() : null;
> 101 final boolean durable = destination.hasDefined(DURABLE.getName()) ? destination.get(DURABLE.getName()).resolve().asBoolean() : false;
> wildfly-mod_cluster-extension (1 usage found)
> org.wildfly.extension.mod_cluster (1 usage found)
> ProxyListValidator (1 usage found)
> validateResolvedParameter(String, ModelNode) (1 usage found)
> 59 validateParameter(parameterName, value.resolve());
> Test (4 usages found)
> Unclassified usage (4 usages found)
> wildfly-clustering-jgroups-extension (4 usages found)
> org.jboss.as.clustering.jgroups.subsystem (4 usages found)
> OperationsTestCase (4 usages found)
> testSubsystemReadWriteOperations() (1 usage found)
> 52 Assert.assertEquals("ee", result.get(RESULT).resolve().asString());
> testTransportReadWriteOperation() (1 usage found)
> 75 Assert.assertEquals("rack1", result.get(RESULT).resolve().asString());
> testTransportPropertyReadWriteOperation() (1 usage found)
> 114 Assert.assertEquals("true", result.get(RESULT).resolve().asString());
> testProtocolPropertyReadWriteOperation() (1 usage found)
> 195 Assert.assertEquals("value", result.get(RESULT).resolve().asString());
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10391) ArrayIndexOutOfBoundsException on server using scattered cache
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-10391?page=com.atlassian.jira.plugin... ]
Radoslav Husar resolved WFLY-10391.
-----------------------------------
Fix Version/s: 13.0.0.CR1
Assignee: Radoslav Husar (was: Paul Ferraro)
Resolution: Done
> ArrayIndexOutOfBoundsException on server using scattered cache
> ---------------------------------------------------------------
>
> Key: WFLY-10391
> URL: https://issues.jboss.org/browse/WFLY-10391
> Project: WildFly
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 13.0.0.Beta1
> Reporter: Michal Vinkler
> Assignee: Radoslav Husar
> Fix For: 13.0.0.CR1
>
>
> We hit ArrayIndexOutOfBoundsException when running tests for RFE EAP7-867.
> EAP distribution was built from {{https://github.com/pferraro/wildfly/tree/scattered}} .
> Test description: Positive stress test (no failover), 4-node EAP cluster, clients: starting with 400 clients in the beginning, raising the number of clients to 6000 in the end of the test.
> Error occured on server dev215 around 7th iteration (can be seen in the performance report, link below):
> {code}
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) Exception in thread "transport-thread--p15-t25" java.lang.ArrayIndexOutOfBoundsException: 129
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at org.infinispan.scattered.impl.ScatteredVersionManagerImpl.lambda$tryRegularInvalidations$4(ScatteredVersionManagerImpl.java:413)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at org.wildfly.clustering.service.concurrent.ClassLoaderThreadFactory.lambda$newThread$0(ClassLoaderThreadFactory.java:47)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at java.lang.Thread.run(Thread.java:748)
> {code}
> Clients were getting "SocketTimeoutException: Read timed out" exceptions even before the ArrayIndexOutOfBoundsException ocurred, but also after.
> Performance report (accessible only when connected to VPN):
> http://download.eng.brq.redhat.com/scratch/mvinkler/reports/2018-04-19_15...
> One can observe that dev215 CPU usage and network usage dropped after 7th iteration.
> dev215 server log link:
> https://jenkins.hosts.mwqe.eng.bos.redhat.com/hudson/job/eap-7x-stress-se...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10391) ArrayIndexOutOfBoundsException on server using scattered cache
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-10391?page=com.atlassian.jira.plugin... ]
Radoslav Husar updated WFLY-10391:
----------------------------------
Git Pull Request: https://github.com/wildfly/wildfly/pull/11289
> ArrayIndexOutOfBoundsException on server using scattered cache
> ---------------------------------------------------------------
>
> Key: WFLY-10391
> URL: https://issues.jboss.org/browse/WFLY-10391
> Project: WildFly
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 13.0.0.Beta1
> Reporter: Michal Vinkler
> Assignee: Radoslav Husar
> Fix For: 13.0.0.CR1
>
>
> We hit ArrayIndexOutOfBoundsException when running tests for RFE EAP7-867.
> EAP distribution was built from {{https://github.com/pferraro/wildfly/tree/scattered}} .
> Test description: Positive stress test (no failover), 4-node EAP cluster, clients: starting with 400 clients in the beginning, raising the number of clients to 6000 in the end of the test.
> Error occured on server dev215 around 7th iteration (can be seen in the performance report, link below):
> {code}
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) Exception in thread "transport-thread--p15-t25" java.lang.ArrayIndexOutOfBoundsException: 129
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at org.infinispan.scattered.impl.ScatteredVersionManagerImpl.lambda$tryRegularInvalidations$4(ScatteredVersionManagerImpl.java:413)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at org.wildfly.clustering.service.concurrent.ClassLoaderThreadFactory.lambda$newThread$0(ClassLoaderThreadFactory.java:47)
> [JBossINF] [0m[31m04:26:11,708 ERROR [stderr] (transport-thread--p15-t25) at java.lang.Thread.run(Thread.java:748)
> {code}
> Clients were getting "SocketTimeoutException: Read timed out" exceptions even before the ArrayIndexOutOfBoundsException ocurred, but also after.
> Performance report (accessible only when connected to VPN):
> http://download.eng.brq.redhat.com/scratch/mvinkler/reports/2018-04-19_15...
> One can observe that dev215 CPU usage and network usage dropped after 7th iteration.
> dev215 server log link:
> https://jenkins.hosts.mwqe.eng.bos.redhat.com/hudson/job/eap-7x-stress-se...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFCORE-3748) Copying lot of commands into CLI prompt fails
by Kabir Khan (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3748?page=com.atlassian.jira.plugi... ]
Kabir Khan resolved WFCORE-3748.
--------------------------------
Fix Version/s: 5.0.0.Beta1
Resolution: Done
> Copying lot of commands into CLI prompt fails
> ---------------------------------------------
>
> Key: WFCORE-3748
> URL: https://issues.jboss.org/browse/WFCORE-3748
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Affects Versions: 5.0.0.Alpha3
> Reporter: Martin Choma
> Assignee: Jean-Francois Denise
> Fix For: 5.0.0.Beta1
>
>
> Running commands with --file option works OK. Copying commands one by one works OK
> Seems to me as something is beeing overflowed.
> {code}
> [standalone@localhost:9990 /] # prepare server and client key materials
> [standalone@localhost:9990 /] # generate server keystore
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=server_keystore:add(type=PKCS12, credential-reference={clear-text=secret},path=/tmp/server.keystore)
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=server_keystore:generate-key-pair(alias=server, distinguished-name="CN=server")
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=server_keystore:export-certificate(alias=server,path=/tmp/server.certificate.pem,pem=true)
> {"outcome" => "success"}
> [standalone@localhost:9990 /] # generate client keystore
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=client_keystore:add(type=PKCS12, credential-reference={clear-text=secret},path=/tmp/client.keystore)
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=client_keystore:generate-key-pair(alias=client, distinguished-name="CN=client")
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=client_keystore:export-certificate(alias=clieytron/key-store=client_truststore:import-certificate(alias=server,path=/tmp/server.certificate.pem,validate=false
> Closing ')' is missing.
> [standalone@localhost:9990 /] # save it all
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=server_keystore:store()
> {
> "outcome" => "success",
> "result" => undefined
> }
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=client_keystore:store()
> {
> "outcome" => "success",
> "result" => undefined
> }
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=server_truststore:store()
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0216: Management resource '[
> (\"subsystem\" => \"elytron\"),
> (\"key-store\" => \"server_truststore\")
> ]' not found",
> "rolled-back" => true
> }
> [standalone@localhost:9990 /] /subsystem=elytron/key-store=client_truststore:store()
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFCORE-3875) [jdk10] PatchModuleInvalidationWithRenamingFailureTestCase#test failure
by Alexey Loubyansky (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3875?page=com.atlassian.jira.plugi... ]
Alexey Loubyansky commented on WFCORE-3875:
-------------------------------------------
Looks like this is the cause:
Corrupted STDOUT by directly writing to native stream in forked JVM 1. Stream 'AccessManager:init Initialising JDK9 AccessManager'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command 'AccessManager:init Initialising JDK9 AccessManager'.
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:511)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:209)
at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:176)
at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:844)
> [jdk10] PatchModuleInvalidationWithRenamingFailureTestCase#test failure
> -----------------------------------------------------------------------
>
> Key: WFCORE-3875
> URL: https://issues.jboss.org/browse/WFCORE-3875
> Project: WildFly Core
> Issue Type: Bug
> Components: Patching , Test Suite
> Affects Versions: 5.0.0.Beta4
> Reporter: Petr Kremensky
> Assignee: Alexey Loubyansky
>
> org.jboss.as.patching.tests.PatchModuleInvalidationWithRenamingFailureTestCase#test from patching module of wildfly-core fails with JDK10, works fine with JDK9.
>
> *reproduce*
> {noformat}
> wildfly-core]$ mvn test -Dtest=PatchModuleInvalidationWithRenamingFailureTestCase#test -pl patching
> ...
> [INFO] Running org.jboss.as.patching.tests.PatchModuleInvalidationWithRenamingFailureTestCase
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.363 s <<< FAILURE! - in org.jboss.as.patching.tests.PatchModuleInvalidationWithRenamingFailureTestCase
> [ERROR] test(org.jboss.as.patching.tests.PatchModuleInvalidationWithRenamingFailureTestCase) Time elapsed: 0.359 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: is <false>
> but: was <true>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at org.jboss.as.patching.tests.PatchModuleInvalidationWithRenamingFailureTestCase.test(PatchModuleInvalidationWithRenamingFailureTestCase.java:97)
> ...
> {noformat}
>
> Environment:
> {noformat}
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T20:49:05+01:00)
> Maven home: /usr/lib/maven
> Java version: 10.0.1, vendor: Oracle Corporation
> {noformat}
> Byteman is being involved in the test.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (JGRP-2269) probe.sh is not working on Ubuntu
by Diego Lovison (JIRA)
Diego Lovison created JGRP-2269:
-----------------------------------
Summary: probe.sh is not working on Ubuntu
Key: JGRP-2269
URL: https://issues.jboss.org/browse/JGRP-2269
Project: JGroups
Issue Type: Bug
Reporter: Diego Lovison
Assignee: Bela Ban
Priority: Minor
Clone the JGroups project using the branch master
diego@diego-note:/storage/git/JGroups/bin$ ./probe.sh
./probe.sh: 8: ./probe.sh: jgroups.sh: not found
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-9892) Upgrade org.apache.santuario.xmlsec to 2.1.1. caused regression in PicketLinkSTS
by Kabir Khan (JIRA)
[ https://issues.jboss.org/browse/WFLY-9892?page=com.atlassian.jira.plugin.... ]
Kabir Khan commented on WFLY-9892:
----------------------------------
[~olukas] are you ok with documenting this one?
> Upgrade org.apache.santuario.xmlsec to 2.1.1. caused regression in PicketLinkSTS
> --------------------------------------------------------------------------------
>
> Key: WFLY-9892
> URL: https://issues.jboss.org/browse/WFLY-9892
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 12.0.0.Beta1
> Reporter: Ondrej Lukas
> Assignee: Pedro Igor
> Priority: Blocker
> Attachments: ejb-security-picketlink.zip, ejb-test.jar, picketlink-sts.war, sts-config.properties
>
>
> When token from PicketLink STS is issued and signed then it is not able to be used for authentication through Remoting in WildFly 12 (i.e. it cannot be set as {{remote.connection.main.password}} property which can be used in PicketLink {{org.picketlink.identity.federation.bindings.jboss.auth.SAML2STSLoginModule}}). It seems it is caused by upgrade of org.apache.santuario.xmlsec to version 2.1.1. [1]. When WILDFLY11_HOME/modules/system/layers/base/org/apache/santuario/xmlsec/main/xmlsec-2.0.8.jar is placed to WildFly 12 modules then it works correctly.
> We report it as a blocker since it is regression - application which works correctly on WildFly 11 stops to work on WildFly 12 - users are not able to authenticate through Remoting with signed tokens from PicketLink STS correctly.
> Remoting fails due to following exception:
> {code}
> java.lang.IllegalArgumentException: ELY05131: Invalid ASCII control "0xA"
> at org.wildfly.security.sasl.util.StringPrep.forbidAsciiControl(StringPrep.java:117)
> at org.wildfly.security.sasl.util.StringPrep.encode(StringPrep.java:295)
> at org.wildfly.security.sasl.util.StringPrep.encode(StringPrep.java:196)
> at org.wildfly.security.sasl.plain.PlainSaslClient.evaluateChallenge(PlainSaslClient.java:95)
> at org.wildfly.security.sasl.util.AbstractDelegatingSaslClient.evaluateChallenge(AbstractDelegatingSaslClient.java:54)
> at org.wildfly.security.sasl.util.PrivilegedSaslClient.lambda$evaluateChallenge$0(PrivilegedSaslClient.java:55)
> at java.security.AccessController.doPrivileged(Native Method)
> at org.wildfly.security.sasl.util.PrivilegedSaslClient.evaluateChallenge(PrivilegedSaslClient.java:55)
> at org.jboss.remoting3.remote.ClientConnectionOpenListener$Capabilities.lambda$handleEvent$1(ClientConnectionOpenListener.java:460)
> at org.jboss.remoting3.EndpointImpl$TrackingExecutor.lambda$execute$0(EndpointImpl.java:926)
> at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1481)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1374)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> It is caused by different formating value of SignatureValue in assertion. In WildFly 11 SignatureValue looks like:
> {code}
> <dsig:SignatureValue xmlns:dsig="http://www.w3.org/2000/09/xmldsig#">nFVkKrXTyYEQ9cwc9OOgySYebEtwzw4alVYP0viXzvqZAUAKtAXEBAfDB8xIOms78twlDdq79MiSvk8OrOdf126Kw/IR8JRn1fYyZ5tsIRcNoTXMgGaTqhrn/HKlLqqqHhVHrJURunqkSzTTxylA2AEPhEDD5Y7hS0W2ZZCeSvuri+PRDSTrRnuedz0yQuHQu1mZ0gjoEFbHh4Wkkn5Ac1R4gmewmmzPud+ZE6Ux4YpeHzQ8rAvZ4bDk6j+eQIRsSxFTLo5RSA3FWN8+lUNV/CSRqBPXsK7QxOaTdBgF+4NXWeExrNJ9SeVFcf9yelvReAtR2JNZ6DUY8u45KtXmLw==</dsig:SignatureValue>
> {code}
> In WildFly 12 it looks like (there are end of lines):
> {code}
> <dsig:SignatureValue xmlns:dsig="http://www.w3.org/2000/09/xmldsig#">cUNpFJIZlLYrBDZtQSTDrq2K6PbnAHyg2qbx/D5FuB4XMjdQ5oxQjkMejLyelnA7s4GFusoLhahl
> qlTOT8UrOyxrR4yYAmJ/e5s+f4gys926+tbiraT/3/wG8wM/Lvcjvk5Ap69zODuRYpypsWfA4jrI
> 7TTBXVPGy8g4KUdnFviUiTuFTc2Ghgxp53AmUuLis/THyP28jE7+28//q8bi/bQrFwHC6tWX67+N
> K1duFCOcQ6IPIKeVrePZz55Ivgl+WWdkF6uYCz5IdMzurhzmeQ3K8DAMIxz/MG67VWJIOnuGNWF7
> nmdye5zd9AFcRsr1XadvZJCbGNfuc89AL5inCg==</dsig:SignatureValue>
> {code}
> [1] https://github.com/wildfly/wildfly/commit/536de514829f2187abf1126c8916a04...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months