[JBoss JIRA] (WFLY-9939) Eliminate the need to override the org.jboss.as.clustering.jgroups module in our openshift images
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9939?page=com.atlassian.jira.plugin.... ]
Brian Stansberry resolved WFLY-9939.
------------------------------------
Resolution: Migrated to another ITS
> Eliminate the need to override the org.jboss.as.clustering.jgroups module in our openshift images
> -------------------------------------------------------------------------------------------------
>
> Key: WFLY-9939
> URL: https://issues.jboss.org/browse/WFLY-9939
> Project: WildFly
> Issue Type: Enhancement
> Components: Clustering
> Reporter: Brian Stansberry
> Assignee: Paul Ferraro
>
> Our openshift images are overriding the org.jboss.as.clustering.jgroups module.xml in order to include a dependency on the org.openshift.ping module. This is fragile because any update to the overridden module.xml needs to be applied to the override file as well, and that can easily break.
> Let's make the need for this go away. Possibilities:
> 1) Add an optional dependency on module "org.openshift.ping" to the org.jboss.as.clustering.jgroups module. The openshift images then just add that module. In bare metal installations the module is not present.
> 2) Change the standalone-openshift.xml configs such that whatever is using this module declares a "module" attribute, removing the need for the module.xml dependency. (If this is the correct solution, please move this issue to the CLOUD JIRA project where we can use it to track making the config change and removing the override.)
> 3) Ship whatever's needed from org.openshift.ping in WF itself, eliminating the need for that module. This may already be in progress as I've seen some relevant JIRAs. (If this is the correct solution, please move this issue to the CLOUD JIRA project where we can use it to track removing the override and the installation of the org.openshift.ping module.)
> [~luck3y] FYI.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month
[JBoss JIRA] (ELY-1593) Coverity static analysis, Resource leak on the exceptional path of setFile in FileAuditEndpoint
by Ilia Vassilev (JIRA)
Ilia Vassilev created ELY-1593:
----------------------------------
Summary: Coverity static analysis, Resource leak on the exceptional path of setFile in FileAuditEndpoint
Key: ELY-1593
URL: https://issues.jboss.org/browse/ELY-1593
Project: WildFly Elytron
Issue Type: Bug
Components: Audit
Affects Versions: 1.3.2.Final
Reporter: Ilia Vassilev
Assignee: Ilia Vassilev
Coverity static analysis found possible occurrence of resource leak.
https://scan7.coverity.com/reports.htm#v20225/p11778/fileInstanceId=53592...
When {{fos.getFD()}} will throw exception {{FileOutputStream fos}} won't be closed.
{code:java|title=FileAuditEndpoint.java}
void setFile(final File file) throws IOException {
boolean ok = false;
final FileOutputStream fos = new FileOutputStream(file, true);
try {
final OutputStream bos = new BufferedOutputStream(fos);
try {
this.fileDescriptor = fos.getFD();
this.outputStream = bos;
this.file = file;
ok = true;
} finally {
if (! ok) {
safeClose(bos);
}
}
} finally {
if (! ok) {
safeClose(fos);
}
}
}
{code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month
[JBoss JIRA] (WFLY-9802) Minimize WildFly-specific stuff in welcome-content
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9802?page=com.atlassian.jira.plugin.... ]
Brian Stansberry reassigned WFLY-9802:
--------------------------------------
Assignee: (was: Brian Stansberry)
> Minimize WildFly-specific stuff in welcome-content
> --------------------------------------------------
>
> Key: WFLY-9802
> URL: https://issues.jboss.org/browse/WFLY-9802
> Project: WildFly
> Issue Type: Task
> Components: Web (Undertow)
> Reporter: Brian Stansberry
>
> There are a number of welcome-content things that result in the need for overly complicated changes to convert the welcome-content for other branches (e.g. EAP).
> 1) Get rid of copyright headers.
> 2) Use HTML 5 DOCTYPE tag instead of 4.
> 3) -Rename files like wildfly.css to something generic so the same file name can be used elsewhere, just with different content.- (This is probably a bad idea as looking at the css the files are so different that they aren't really different variations of the same thing. Using the same file name will just lead to spurious merge conflicts.)
> 4) Add this:
> {code}
> <!-- proper charset -->
> <meta http-equiv="content-type" content="text/html;charset=utf-8" />
> <meta http-equiv="X-UA-Compatible" content="IE=EmulateIE8" />
> {code}
> 5) Clean up various whitespace etc stuff.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month
[JBoss JIRA] (WFCORE-3887) Smarter range validation error messages
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3887?page=com.atlassian.jira.plugi... ]
Brian Stansberry moved WFLY-9602 to WFCORE-3887:
------------------------------------------------
Project: WildFly Core (was: WildFly)
Key: WFCORE-3887 (was: WFLY-9602)
Component/s: Management
(was: Management)
> Smarter range validation error messages
> ---------------------------------------
>
> Key: WFCORE-3887
> URL: https://issues.jboss.org/browse/WFCORE-3887
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Management
> Reporter: Brian Stansberry
> Priority: Minor
>
> A message like this is kind of silly: "Value must be between 0 and 9007199254740991".
> Smarter would be the ParameterValidator code that detects the message checking if the range max is Integer.MAX_INT (for an int) or Long.MAX_LONG (for a long) and if the bad value is below the max, just saying the equivalent of "Value must be greater than %d".
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month
[JBoss JIRA] (WFLY-9622) Eliminate uses of ModelNode.resolve()
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9622?page=com.atlassian.jira.plugin.... ]
Brian Stansberry reassigned WFLY-9622:
--------------------------------------
Assignee: (was: Brian Stansberry)
> Eliminate uses of ModelNode.resolve()
> -------------------------------------
>
> Key: WFLY-9622
> URL: https://issues.jboss.org/browse/WFLY-9622
> Project: WildFly
> Issue Type: Task
> Components: Clustering, JCA, JMS, JPA / Hibernate, Management, mod_cluster
> Reporter: Brian Stansberry
>
> Code inspection shows there are 16 uses of ModelNode.resolve() in WildFly's own code base, 12 in production code and 4 in test code. We should eliminate these, as WildFly's expression resolution is more complex than the ModelNode.resolve() contract, including vault support for which its' hard to imagine us wanting support in DMR itself. So these uses should switch to resolution from the OperationContext or, if that's not feasible, e.g. in test code, use something like ExpressionResolver.TEST_RESOLVER.
> Current uses:
> {code}
> Method
> resolve()
> Found usages (16 usages found)
> Production (12 usages found)
> Unclassified usage (12 usages found)
> wildfly-connector (3 usages found)
> org.jboss.as.connector.subsystems.common.pool (2 usages found)
> PoolConfigurationRWHandler.PoolConfigurationWriteHandler (1 usage found)
> revertUpdateToRuntime(OperationContext, ModelNode, String, ModelNode, ModelNode, List<PoolConfiguration>) (1 usage found)
> 126 updatePoolConfigs(handback, parameterName, valueToRestore.resolve());
> PoolStatisticsRuntimeAttributeWriteHandler (1 usage found)
> execute(OperationContext, ModelNode) (1 usage found)
> 58 final ModelNode resolvedValue = newValue.resolve();
> org.jboss.as.connector.subsystems.datasources (1 usage found)
> Constants (1 usage found)
> 297 validateParameter(parameterName, value.resolve());
> wildfly-jpa (4 usages found)
> org.jboss.as.jpa.management (1 usage found)
> ManagementResourceDefinition (1 usage found)
> registerAttributes(ManagementResourceRegistration) (1 usage found)
> 154 final ModelNode value = operation.get(ModelDescriptionConstants.VALUE).resolve();
> org.jboss.as.jpa.subsystem (3 usages found)
> JPASubSystemAdd (3 usages found)
> performBoottime(OperationContext, ModelNode, ModelNode) (3 usages found)
> 78 runtimeValidator.validate(operation.resolve());
> 125 final String dataSourceName = defaultDSNode.resolve().asString();
> 131 ExtendedPersistenceInheritance.valueOf(defaultExtendedPersistenceInheritanceNode.resolve().asString());
> wildfly-messaging-activemq (4 usages found)
> org.wildfly.extension.messaging.activemq.deployment (4 usages found)
> MessagingXmlInstallDeploymentUnitProcessor (4 usages found)
> deploy(DeploymentPhaseContext) (4 usages found)
> 76 final ModelNode entries = topic.getDestination().resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 97 final ModelNode entries = destination.resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 100 final String selector = destination.hasDefined(SELECTOR.getName()) ? destination.get(SELECTOR.getName()).resolve().asString() : null;
> 101 final boolean durable = destination.hasDefined(DURABLE.getName()) ? destination.get(DURABLE.getName()).resolve().asBoolean() : false;
> wildfly-mod_cluster-extension (1 usage found)
> org.wildfly.extension.mod_cluster (1 usage found)
> ProxyListValidator (1 usage found)
> validateResolvedParameter(String, ModelNode) (1 usage found)
> 59 validateParameter(parameterName, value.resolve());
> Test (4 usages found)
> Unclassified usage (4 usages found)
> wildfly-clustering-jgroups-extension (4 usages found)
> org.jboss.as.clustering.jgroups.subsystem (4 usages found)
> OperationsTestCase (4 usages found)
> testSubsystemReadWriteOperations() (1 usage found)
> 52 Assert.assertEquals("ee", result.get(RESULT).resolve().asString());
> testTransportReadWriteOperation() (1 usage found)
> 75 Assert.assertEquals("rack1", result.get(RESULT).resolve().asString());
> testTransportPropertyReadWriteOperation() (1 usage found)
> 114 Assert.assertEquals("true", result.get(RESULT).resolve().asString());
> testProtocolPropertyReadWriteOperation() (1 usage found)
> 195 Assert.assertEquals("value", result.get(RESULT).resolve().asString());
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month
[JBoss JIRA] (WFLY-9622) Eliminate uses of ModelNode.resolve()
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9622?page=com.atlassian.jira.plugin.... ]
Brian Stansberry updated WFLY-9622:
-----------------------------------
Component/s: Clustering
JCA
JMS
JPA / Hibernate
mod_cluster
> Eliminate uses of ModelNode.resolve()
> -------------------------------------
>
> Key: WFLY-9622
> URL: https://issues.jboss.org/browse/WFLY-9622
> Project: WildFly
> Issue Type: Task
> Components: Clustering, JCA, JMS, JPA / Hibernate, Management, mod_cluster
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
>
> Code inspection shows there are 16 uses of ModelNode.resolve() in WildFly's own code base, 12 in production code and 4 in test code. We should eliminate these, as WildFly's expression resolution is more complex than the ModelNode.resolve() contract, including vault support for which its' hard to imagine us wanting support in DMR itself. So these uses should switch to resolution from the OperationContext or, if that's not feasible, e.g. in test code, use something like ExpressionResolver.TEST_RESOLVER.
> Current uses:
> {code}
> Method
> resolve()
> Found usages (16 usages found)
> Production (12 usages found)
> Unclassified usage (12 usages found)
> wildfly-connector (3 usages found)
> org.jboss.as.connector.subsystems.common.pool (2 usages found)
> PoolConfigurationRWHandler.PoolConfigurationWriteHandler (1 usage found)
> revertUpdateToRuntime(OperationContext, ModelNode, String, ModelNode, ModelNode, List<PoolConfiguration>) (1 usage found)
> 126 updatePoolConfigs(handback, parameterName, valueToRestore.resolve());
> PoolStatisticsRuntimeAttributeWriteHandler (1 usage found)
> execute(OperationContext, ModelNode) (1 usage found)
> 58 final ModelNode resolvedValue = newValue.resolve();
> org.jboss.as.connector.subsystems.datasources (1 usage found)
> Constants (1 usage found)
> 297 validateParameter(parameterName, value.resolve());
> wildfly-jpa (4 usages found)
> org.jboss.as.jpa.management (1 usage found)
> ManagementResourceDefinition (1 usage found)
> registerAttributes(ManagementResourceRegistration) (1 usage found)
> 154 final ModelNode value = operation.get(ModelDescriptionConstants.VALUE).resolve();
> org.jboss.as.jpa.subsystem (3 usages found)
> JPASubSystemAdd (3 usages found)
> performBoottime(OperationContext, ModelNode, ModelNode) (3 usages found)
> 78 runtimeValidator.validate(operation.resolve());
> 125 final String dataSourceName = defaultDSNode.resolve().asString();
> 131 ExtendedPersistenceInheritance.valueOf(defaultExtendedPersistenceInheritanceNode.resolve().asString());
> wildfly-messaging-activemq (4 usages found)
> org.wildfly.extension.messaging.activemq.deployment (4 usages found)
> MessagingXmlInstallDeploymentUnitProcessor (4 usages found)
> deploy(DeploymentPhaseContext) (4 usages found)
> 76 final ModelNode entries = topic.getDestination().resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 97 final ModelNode entries = destination.resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 100 final String selector = destination.hasDefined(SELECTOR.getName()) ? destination.get(SELECTOR.getName()).resolve().asString() : null;
> 101 final boolean durable = destination.hasDefined(DURABLE.getName()) ? destination.get(DURABLE.getName()).resolve().asBoolean() : false;
> wildfly-mod_cluster-extension (1 usage found)
> org.wildfly.extension.mod_cluster (1 usage found)
> ProxyListValidator (1 usage found)
> validateResolvedParameter(String, ModelNode) (1 usage found)
> 59 validateParameter(parameterName, value.resolve());
> Test (4 usages found)
> Unclassified usage (4 usages found)
> wildfly-clustering-jgroups-extension (4 usages found)
> org.jboss.as.clustering.jgroups.subsystem (4 usages found)
> OperationsTestCase (4 usages found)
> testSubsystemReadWriteOperations() (1 usage found)
> 52 Assert.assertEquals("ee", result.get(RESULT).resolve().asString());
> testTransportReadWriteOperation() (1 usage found)
> 75 Assert.assertEquals("rack1", result.get(RESULT).resolve().asString());
> testTransportPropertyReadWriteOperation() (1 usage found)
> 114 Assert.assertEquals("true", result.get(RESULT).resolve().asString());
> testProtocolPropertyReadWriteOperation() (1 usage found)
> 195 Assert.assertEquals("value", result.get(RESULT).resolve().asString());
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month
[JBoss JIRA] (WFLY-9622) Eliminate uses of ModelNode.resolve()
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9622?page=com.atlassian.jira.plugin.... ]
Brian Stansberry updated WFLY-9622:
-----------------------------------
Description:
Code inspection shows there are 16 uses of ModelNode.resolve() in WildFly's own code base, 12 in production code and 4 in test code. We should eliminate these, as WildFly's expression resolution is more complex than the ModelNode.resolve() contract, including vault support for which its' hard to imagine us wanting support in DMR itself. So these uses should switch to resolution from the OperationContext or, if that's not feasible, e.g. in test code, use something like ExpressionResolver.TEST_RESOLVER.
Current uses:
{code}
Method
resolve()
Found usages (16 usages found)
Production (12 usages found)
Unclassified usage (12 usages found)
wildfly-connector (3 usages found)
org.jboss.as.connector.subsystems.common.pool (2 usages found)
PoolConfigurationRWHandler.PoolConfigurationWriteHandler (1 usage found)
revertUpdateToRuntime(OperationContext, ModelNode, String, ModelNode, ModelNode, List<PoolConfiguration>) (1 usage found)
126 updatePoolConfigs(handback, parameterName, valueToRestore.resolve());
PoolStatisticsRuntimeAttributeWriteHandler (1 usage found)
execute(OperationContext, ModelNode) (1 usage found)
58 final ModelNode resolvedValue = newValue.resolve();
org.jboss.as.connector.subsystems.datasources (1 usage found)
Constants (1 usage found)
297 validateParameter(parameterName, value.resolve());
wildfly-jpa (4 usages found)
org.jboss.as.jpa.management (1 usage found)
ManagementResourceDefinition (1 usage found)
registerAttributes(ManagementResourceRegistration) (1 usage found)
154 final ModelNode value = operation.get(ModelDescriptionConstants.VALUE).resolve();
org.jboss.as.jpa.subsystem (3 usages found)
JPASubSystemAdd (3 usages found)
performBoottime(OperationContext, ModelNode, ModelNode) (3 usages found)
78 runtimeValidator.validate(operation.resolve());
125 final String dataSourceName = defaultDSNode.resolve().asString();
131 ExtendedPersistenceInheritance.valueOf(defaultExtendedPersistenceInheritanceNode.resolve().asString());
wildfly-messaging-activemq (4 usages found)
org.wildfly.extension.messaging.activemq.deployment (4 usages found)
MessagingXmlInstallDeploymentUnitProcessor (4 usages found)
deploy(DeploymentPhaseContext) (4 usages found)
76 final ModelNode entries = topic.getDestination().resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
97 final ModelNode entries = destination.resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
100 final String selector = destination.hasDefined(SELECTOR.getName()) ? destination.get(SELECTOR.getName()).resolve().asString() : null;
101 final boolean durable = destination.hasDefined(DURABLE.getName()) ? destination.get(DURABLE.getName()).resolve().asBoolean() : false;
wildfly-mod_cluster-extension (1 usage found)
org.wildfly.extension.mod_cluster (1 usage found)
ProxyListValidator (1 usage found)
validateResolvedParameter(String, ModelNode) (1 usage found)
59 validateParameter(parameterName, value.resolve());
Test (4 usages found)
Unclassified usage (4 usages found)
wildfly-clustering-jgroups-extension (4 usages found)
org.jboss.as.clustering.jgroups.subsystem (4 usages found)
OperationsTestCase (4 usages found)
testSubsystemReadWriteOperations() (1 usage found)
52 Assert.assertEquals("ee", result.get(RESULT).resolve().asString());
testTransportReadWriteOperation() (1 usage found)
75 Assert.assertEquals("rack1", result.get(RESULT).resolve().asString());
testTransportPropertyReadWriteOperation() (1 usage found)
114 Assert.assertEquals("true", result.get(RESULT).resolve().asString());
testProtocolPropertyReadWriteOperation() (1 usage found)
195 Assert.assertEquals("value", result.get(RESULT).resolve().asString());
{code}
was:Code inspection shows there are 23 uses of ModelNode.resolve() in WildFly's own code base, 12 in production code and 11 in test code. We should eliminate these, as WildFly's expression resolution is more complex than the ModelNode.resolve() contract, including vault support for which its' hard to imagine us wanting support in DMR itself. So these uses should switch to resolution from the OperationContext or, if that's not feasible, e.g. in test code, use something like ExpressionResolver.TEST_RESOLVER.
> Eliminate uses of ModelNode.resolve()
> -------------------------------------
>
> Key: WFLY-9622
> URL: https://issues.jboss.org/browse/WFLY-9622
> Project: WildFly
> Issue Type: Task
> Components: Management
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
>
> Code inspection shows there are 16 uses of ModelNode.resolve() in WildFly's own code base, 12 in production code and 4 in test code. We should eliminate these, as WildFly's expression resolution is more complex than the ModelNode.resolve() contract, including vault support for which its' hard to imagine us wanting support in DMR itself. So these uses should switch to resolution from the OperationContext or, if that's not feasible, e.g. in test code, use something like ExpressionResolver.TEST_RESOLVER.
> Current uses:
> {code}
> Method
> resolve()
> Found usages (16 usages found)
> Production (12 usages found)
> Unclassified usage (12 usages found)
> wildfly-connector (3 usages found)
> org.jboss.as.connector.subsystems.common.pool (2 usages found)
> PoolConfigurationRWHandler.PoolConfigurationWriteHandler (1 usage found)
> revertUpdateToRuntime(OperationContext, ModelNode, String, ModelNode, ModelNode, List<PoolConfiguration>) (1 usage found)
> 126 updatePoolConfigs(handback, parameterName, valueToRestore.resolve());
> PoolStatisticsRuntimeAttributeWriteHandler (1 usage found)
> execute(OperationContext, ModelNode) (1 usage found)
> 58 final ModelNode resolvedValue = newValue.resolve();
> org.jboss.as.connector.subsystems.datasources (1 usage found)
> Constants (1 usage found)
> 297 validateParameter(parameterName, value.resolve());
> wildfly-jpa (4 usages found)
> org.jboss.as.jpa.management (1 usage found)
> ManagementResourceDefinition (1 usage found)
> registerAttributes(ManagementResourceRegistration) (1 usage found)
> 154 final ModelNode value = operation.get(ModelDescriptionConstants.VALUE).resolve();
> org.jboss.as.jpa.subsystem (3 usages found)
> JPASubSystemAdd (3 usages found)
> performBoottime(OperationContext, ModelNode, ModelNode) (3 usages found)
> 78 runtimeValidator.validate(operation.resolve());
> 125 final String dataSourceName = defaultDSNode.resolve().asString();
> 131 ExtendedPersistenceInheritance.valueOf(defaultExtendedPersistenceInheritanceNode.resolve().asString());
> wildfly-messaging-activemq (4 usages found)
> org.wildfly.extension.messaging.activemq.deployment (4 usages found)
> MessagingXmlInstallDeploymentUnitProcessor (4 usages found)
> deploy(DeploymentPhaseContext) (4 usages found)
> 76 final ModelNode entries = topic.getDestination().resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 97 final ModelNode entries = destination.resolve().get(CommonAttributes.DESTINATION_ENTRIES.getName());
> 100 final String selector = destination.hasDefined(SELECTOR.getName()) ? destination.get(SELECTOR.getName()).resolve().asString() : null;
> 101 final boolean durable = destination.hasDefined(DURABLE.getName()) ? destination.get(DURABLE.getName()).resolve().asBoolean() : false;
> wildfly-mod_cluster-extension (1 usage found)
> org.wildfly.extension.mod_cluster (1 usage found)
> ProxyListValidator (1 usage found)
> validateResolvedParameter(String, ModelNode) (1 usage found)
> 59 validateParameter(parameterName, value.resolve());
> Test (4 usages found)
> Unclassified usage (4 usages found)
> wildfly-clustering-jgroups-extension (4 usages found)
> org.jboss.as.clustering.jgroups.subsystem (4 usages found)
> OperationsTestCase (4 usages found)
> testSubsystemReadWriteOperations() (1 usage found)
> 52 Assert.assertEquals("ee", result.get(RESULT).resolve().asString());
> testTransportReadWriteOperation() (1 usage found)
> 75 Assert.assertEquals("rack1", result.get(RESULT).resolve().asString());
> testTransportPropertyReadWriteOperation() (1 usage found)
> 114 Assert.assertEquals("true", result.get(RESULT).resolve().asString());
> testProtocolPropertyReadWriteOperation() (1 usage found)
> 195 Assert.assertEquals("value", result.get(RESULT).resolve().asString());
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month
[JBoss JIRA] (WFLY-9007) The bin/product.conf and the org.jboss.as.product:<xxx> module should come in via an FP
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9007?page=com.atlassian.jira.plugin.... ]
Brian Stansberry resolved WFLY-9007.
------------------------------------
Resolution: Out of Date
The move to Galleon build has dealt with the product stuff as part of the regular feature packs.
A separate f-p for this is not workable as it likely won't end up in most dists because people would not see the need to include it in their provisioning spec.
> The bin/product.conf and the org.jboss.as.product:<xxx> module should come in via an FP
> ---------------------------------------------------------------------------------------
>
> Key: WFLY-9007
> URL: https://issues.jboss.org/browse/WFLY-9007
> Project: WildFly
> Issue Type: Task
> Components: Server
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
>
> For WFLY-4692 we moved the "product" stuff out of [servlet-]feature-pack and into [servlet-]dist. But this means it doesn't end up in the skinny dist produced by the "[servlet-]build" module. Plus it makes the "dist" a kind of FP of its own.
> The stuff in [servlet-]dist/src/distribution should be its own FP. That one *perhaps* depends on the related normal feature-pack. Then build and dist use the new FP in addition to or instead of the regular feature-pack.
> So, the regular feature-pack is independently usable, in other dists, but our offiical build/dist, which has our official product module, picks up the new FP.
> Whether the new "product" FP depends on the regular feature-pack depends on how we want to use it; i.e. can this bin/product.conf and module be used in some other flavor of dist besides the official one.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 1 month