[JBoss JIRA] (DROOLS-2756) KieContainer.verify(kBaseName) throws NPE when kBaseName is wrong
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2756?page=com.atlassian.jira.plugi... ]
Edson Tirelli reassigned DROOLS-2756:
-------------------------------------
Assignee: Luca Molteni (was: Edson Tirelli)
> KieContainer.verify(kBaseName) throws NPE when kBaseName is wrong
> -----------------------------------------------------------------
>
> Key: DROOLS-2756
> URL: https://issues.jboss.org/browse/DROOLS-2756
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.8.0.Final
> Environment: Not relevant
> Reporter: Luca Buraggi
> Assignee: Luca Molteni
> Priority: Minor
> Labels: NPE
> Attachments: drooltestjar.zip
>
>
> This snippet:
> {code:java}
> // Using a wrong KB name causes a NPE
> KieContainer kc = DroolsUtils.getAndVerifyKieContainer("WrongKBName");
> {code}
> throws a NPE with thr following stacktrace
> {code:java}
> testSomeMethod(org.mydomain.drooltestjar.DroolsUtilsTest) Time elapsed: 1.065 sec <<< ERROR!
> java.lang.NullPointerException
> at org.drools.compiler.kie.builder.impl.AbstractKieProject.buildKnowledgePackages(AbstractKieProject.java:207)
> at org.drools.compiler.kie.builder.impl.AbstractKieProject.verify(AbstractKieProject.java:80)
> at org.drools.compiler.kie.builder.impl.AbstractKieProject.verify(AbstractKieProject.java:68)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.verify(KieContainerImpl.java:343)
> ...
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2753) SNAPSHOT KJars are always reloaded
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2753?page=com.atlassian.jira.plugi... ]
Edson Tirelli commented on DROOLS-2753:
---------------------------------------
[~nilsm] I am afraid I don't quite understand what you mean. If you can provide the test case, it would be great.
[~mfusco] FYI.
> SNAPSHOT KJars are always reloaded
> ----------------------------------
>
> Key: DROOLS-2753
> URL: https://issues.jboss.org/browse/DROOLS-2753
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.8.0.Final
> Reporter: Nils Meyer
> Assignee: Mario Fusco
>
> The fix provided in DROOLS-2591 filled the snapshotVersion of the ReleaseId Object in org.drools.compiler.kproject.ReleaseIdImpl.adapt(AFReleaseId) using org.appformer.maven.support.AFReleaseId.getVersion(). This seems to be not correct, as the snapshotVersion is filled with a version of the pattern 1.0.0-SNAPSHOT by this means.
> Later the destinction wether to reload a SNAPSHOT version or not is made by comparing this version to a version of the pattern 1.0.0-20180718.102926-4 retrieved from org.eclipse.aether.artifact.Artifact.getVersion()
> The corresponding tests did not reveal this issue, as they do not test that a non-newer version is not loaded.
> I'll try to provide an updated test and potentially a solution idea, too.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2754) Provide public access to KJar snapshot version
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2754?page=com.atlassian.jira.plugi... ]
Edson Tirelli reassigned DROOLS-2754:
-------------------------------------
Assignee: Mario Fusco (was: Edson Tirelli)
> Provide public access to KJar snapshot version
> ----------------------------------------------
>
> Key: DROOLS-2754
> URL: https://issues.jboss.org/browse/DROOLS-2754
> Project: Drools
> Issue Type: Enhancement
> Affects Versions: 7.8.0.Final
> Reporter: Nils Meyer
> Assignee: Mario Fusco
>
> When working with KJar SNAPSHOTS being retrieved from a Maven Repo it's often interesting to know the exact version that is currently in use. Therefore having access to the version in a pattern like 1.0.0-20180718.102926-4 would be interesting.
> Currently org.kie.api.builder.ReleaseId returned by org.kie.api.runtime.KieContainer.getReleaseId() does provide a method getVersion that probably is intended to return a version in the format 1.0.0-SNAPSHOT. The underlying implementation org.drools.compiler.kproject.ReleaseIdImpl provides a method getSnapshotVersion that could be used to retrieve the exact version (if it was filled correctly, see DROOLS-2753).
> Solution ideas
> * Enhance the ReleaseId Interface with the getSnapshotVersion method (would need adjustments in org.kie.api.management.GAV)
> * Change the toString method of ReleaseIdImpl to build the 1.0.0-20180718.102926-4 version type for SNAPSHOT versions
> * Live with the current state an do ugly casts from the interface to the implementation to retrieve the snapshot version
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2753) SNAPSHOT KJars are always reloaded
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2753?page=com.atlassian.jira.plugi... ]
Edson Tirelli reassigned DROOLS-2753:
-------------------------------------
Assignee: Mario Fusco (was: Edson Tirelli)
> SNAPSHOT KJars are always reloaded
> ----------------------------------
>
> Key: DROOLS-2753
> URL: https://issues.jboss.org/browse/DROOLS-2753
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.8.0.Final
> Reporter: Nils Meyer
> Assignee: Mario Fusco
>
> The fix provided in DROOLS-2591 filled the snapshotVersion of the ReleaseId Object in org.drools.compiler.kproject.ReleaseIdImpl.adapt(AFReleaseId) using org.appformer.maven.support.AFReleaseId.getVersion(). This seems to be not correct, as the snapshotVersion is filled with a version of the pattern 1.0.0-SNAPSHOT by this means.
> Later the destinction wether to reload a SNAPSHOT version or not is made by comparing this version to a version of the pattern 1.0.0-20180718.102926-4 retrieved from org.eclipse.aether.artifact.Artifact.getVersion()
> The corresponding tests did not reveal this issue, as they do not test that a non-newer version is not loaded.
> I'll try to provide an updated test and potentially a solution idea, too.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2750) [DMN Designer] Default cell symbols
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2750?page=com.atlassian.jira.plugi... ]
Edson Tirelli commented on DROOLS-2750:
---------------------------------------
For input columns in decision tables, we can consider auto-filling the dash ("-") symbol as the default value, but for every other type of boxed expression, I don't think there is any sensible default. It will have to be a blank (empty) cell.
> [DMN Designer] Default cell symbols
> -----------------------------------
>
> Key: DROOLS-2750
> URL: https://issues.jboss.org/browse/DROOLS-2750
> Project: Drools
> Issue Type: Epic
> Components: DMN Editor
> Affects Versions: 7.9.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Minor
> Labels: drools-tools
>
> As a citizen developer, I want to build my decision logic with as small effort as possible. Especially I want to build the *valid* expressions with minimal interaction with the designer. For this reason the designer should fill in default values/symbols into cells where possible. This should help with DMN designer getting started experience.
> In this epic we should discuss where is possible to fill some default values/symbols into expression cells.
> h3. Context
> I think no appropriate default value exists. Maybe with exception of the last row?
> h3. Literal Expressions
> My proposal would be:
> - empty cell, if it is valid value for literal expression cell, if not
> - value according to the column data type, 0 for number, today for date ...
> h3. Decision table
> - symbol *-* due to trisotext samples
> h3. Function
> Really not sure
> h3. Relation
> Really not sure
> h3. Invocation
> Really not sure
> [~manstis] [~tirelli] [~tari_manga] could you please put your thoughts into comments? I filed this epic to follow agile process. Not saying something from description will happen. However if we will agree on some default values we can then file separate tasks for this epic. I f we agree it is not good idea, we will close the epic.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2751) Workbench does not show correct message for DecisionTables with variables out of range
by Alessandro Lazarotti (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2751?page=com.atlassian.jira.plugi... ]
Alessandro Lazarotti updated DROOLS-2751:
-----------------------------------------
Attachment: Applicant Annual Income.png
> Workbench does not show correct message for DecisionTables with variables out of range
> --------------------------------------------------------------------------------------
>
> Key: DROOLS-2751
> URL: https://issues.jboss.org/browse/DROOLS-2751
> Project: Drools
> Issue Type: Bug
> Components: decision tables, Guided Decision Table Editor
> Affects Versions: 7.8.0.Final
> Reporter: Alessandro Lazarotti
> Assignee: Toni Rikkola
> Attachments: 1-decision-table.png, 2-dt-source.png, 3-workbench-message.png, Applicant Annual Income.png, MortgageDecisionTable.gdst, Property.png
>
>
> When it is defined a Decision Table with rows don't covering all possible ranges, the message reported by workbench isn't clear, in fact it is a wrong message:
> "Deficient row.
> Affected rows:1
> "Deficient rule has *actions which conflict with another rule* and conditions that do not overlap with the other rule."
> "Since *the deficient rule can fire at the same time as an another rule*, it is impossible to know which actions end up activating last. This causes the rule set to be inconsistent. To fix this, please either remove the deficient rule or make the conditions more strict."
> The message above seems generic for cases that two rules can fire while it is expect them to be exclusive, but it is confuse for rows out-of-range.
> See attachments.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2751) Workbench does not show correct message for DecisionTables with variables out of range
by Alessandro Lazarotti (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2751?page=com.atlassian.jira.plugi... ]
Alessandro Lazarotti updated DROOLS-2751:
-----------------------------------------
Attachment: (was: Applicant Annual Income.png)
> Workbench does not show correct message for DecisionTables with variables out of range
> --------------------------------------------------------------------------------------
>
> Key: DROOLS-2751
> URL: https://issues.jboss.org/browse/DROOLS-2751
> Project: Drools
> Issue Type: Bug
> Components: decision tables, Guided Decision Table Editor
> Affects Versions: 7.8.0.Final
> Reporter: Alessandro Lazarotti
> Assignee: Toni Rikkola
> Attachments: 1-decision-table.png, 2-dt-source.png, 3-workbench-message.png, MortgageDecisionTable.gdst, Property.png
>
>
> When it is defined a Decision Table with rows don't covering all possible ranges, the message reported by workbench isn't clear, in fact it is a wrong message:
> "Deficient row.
> Affected rows:1
> "Deficient rule has *actions which conflict with another rule* and conditions that do not overlap with the other rule."
> "Since *the deficient rule can fire at the same time as an another rule*, it is impossible to know which actions end up activating last. This causes the rule set to be inconsistent. To fix this, please either remove the deficient rule or make the conditions more strict."
> The message above seems generic for cases that two rules can fire while it is expect them to be exclusive, but it is confuse for rows out-of-range.
> See attachments.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years