[JBoss JIRA] (DROOLS-2661) Fix blocker findbugs issues
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2661?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2661:
--------------------------------
Description: In the [report|https://sonarcloud.io/project/issues?id=org.drools%3Adrools-wb&resolved=false&severities=BLOCKER&types=BUG] can be seen blocker issues revealed by the finbugs in the drools-wb repository. The issues are caused by not closed InputStreams. All of them could be fixed by try-with-resources. (was: In the [report|https://sonarcloud.io/project/issues?id=org.drools%3Adrools-wb&resolved=false&severities=BLOCKER&types=BUG] can be seen blocker issues revealed by the finbugs in the drools-wb repository. The issues are caused by not closed InputStreams. ALl could be fixed by try-with-resources.)
> Fix blocker findbugs issues
> ---------------------------
>
> Key: DROOLS-2661
> URL: https://issues.jboss.org/browse/DROOLS-2661
> Project: Drools
> Issue Type: Task
> Affects Versions: 7.8.0.Final
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Labels: drools-tools
>
> In the [report|https://sonarcloud.io/project/issues?id=org.drools%3Adrools-wb&resolved=false&severities=BLOCKER&types=BUG] can be seen blocker issues revealed by the finbugs in the drools-wb repository. The issues are caused by not closed InputStreams. All of them could be fixed by try-with-resources.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2049) Remove private void checkMarshallingUsingDsl method
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2049?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2049:
--------------------------------
Labels: drools-tools (was: )
> Remove private void checkMarshallingUsingDsl method
> ---------------------------------------------------
>
> Key: DROOLS-2049
> URL: https://issues.jboss.org/browse/DROOLS-2049
> Project: Drools
> Issue Type: Task
> Components: DSLs Editor
> Affects Versions: 7.3.0.Final
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Labels: drools-tools
>
> The [testclass|https://github.com/kiegroup/drools/blob/master/drools-workbench...] contains methods shown bellow. There is potential error in tests that expect checkMarshallingUsingDsl will behave differently from checkMarshalling. This checkMarshallingUsingDsl should be removed and tests which use it should be rewritten.
> {code:java}
> private void checkMarshalling(String expected,
> RuleModel m) {
> String drl = ruleModelPersistence.marshal(m);
> assertNotNull(drl);
> if (expected != null) {
> assertEqualsIgnoreWhitespace(expected,
> drl);
> }
> }
> private void checkMarshallingUsingDsl(String expected,
> RuleModel m) {
> String drl = ruleModelPersistence.marshal(m);
> assertNotNull(drl);
> if (expected != null) {
> assertEqualsIgnoreWhitespace(expected,
> drl);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-1955) [DMN Editor] Check information requirements mapping to BKM parameters
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1955?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-1955:
--------------------------------
Labels: drools-tools reported-by-qe (was: reported-by-qe)
> [DMN Editor] Check information requirements mapping to BKM parameters
> ---------------------------------------------------------------------
>
> Key: DROOLS-1955
> URL: https://issues.jboss.org/browse/DROOLS-1955
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Labels: drools-tools, reported-by-qe
>
> Is some decision node is connected with BKM node, information requirements of the decision should be mapped to BKM parameters. Check that these two kind of issues are revealed by DMN editor:
> # Different count of information requirements and BKM parameters
> # Incompatible data types of information requirements and BKM parameters
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years