[JBoss JIRA] (WFLY-10877) Jaeger-thrift jar dependency is quite chubby
by Juraci Paixão Kröhling (JIRA)
[ https://issues.jboss.org/browse/WFLY-10877?page=com.atlassian.jira.plugin... ]
Juraci Paixão Kröhling commented on WFLY-10877:
-----------------------------------------------
This library shadows some dependencies, like Apache Thrift client and OkHttp, among others.
We do have plans on reducing the number of dependencies, though: https://github.com/jaegertracing/jaeger/issues/995
> Jaeger-thrift jar dependency is quite chubby
> --------------------------------------------
>
> Key: WFLY-10877
> URL: https://issues.jboss.org/browse/WFLY-10877
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Reporter: Jan Stourac
> Assignee: Juraci Paixão Kröhling
>
> Jaeger-thrift dependency file is quite chubby:
> {code}
> -rw-rw-r--. 1 jstourac jstourac 123K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-core-0.30.4.jar
> -rw-rw-r--. 1 jstourac jstourac 2.8M Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
> {code}
> Is there any possibility to shrink it's size somehow?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10877) Jaeger-thrift jar dependency is quite chubby
by Jan Stourac (JIRA)
[ https://issues.jboss.org/browse/WFLY-10877?page=com.atlassian.jira.plugin... ]
Jan Stourac commented on WFLY-10877:
------------------------------------
Okay, raising the priority to major as it seems that jaeger-thrift file is one of the biggest ones in the dist :)
{code}
$ find . -name "*.jar" | xargs ls -lhS | head -n 15
-rw-rw-r--. 1 jstourac jstourac 18M Aug 16 15:13 ./bin/client/jboss-client.jar
-rw-rw-r--. 1 jstourac jstourac 8.7M Aug 16 15:13 ./modules/system/layers/base/org/jboss/as/console/main/hal-console-3.0.3.Final-resources.jar
-rw-rw-r--. 1 jstourac jstourac 8.1M Aug 16 15:13 ./bin/client/jboss-cli-client.jar
-rw-rw-r--. 1 jstourac jstourac 6.7M Aug 16 15:13 ./modules/system/layers/base/org/hibernate/main/hibernate-core-5.3.5.Final.jar
-rw-rw-r--. 1 jstourac jstourac 4.2M Aug 16 15:13 ./modules/system/layers/base/org/infinispan/main/infinispan-core-9.3.1.Final.jar
-rw-rw-r--. 1 jstourac jstourac 4.0M Aug 16 15:13 ./modules/system/layers/base/javax/orb/api/main/openjdk-orb-8.1.2.Final.jar
-rw-rw-r--. 1 jstourac jstourac 3.7M Aug 16 15:13 ./modules/system/layers/base/io/netty/main/netty-all-4.1.25.Final.jar
-rw-rw-r--. 1 jstourac jstourac 3.3M Aug 16 15:13 ./modules/system/layers/base/org/bouncycastle/main/bcprov-jdk15on-1.56.jar
-rw-rw-r--. 1 jstourac jstourac 3.2M Aug 16 15:13 ./modules/system/layers/base/org/apache/xalan/main/xalan-2.7.1.jbossorg-4.jar
-rw-rw-r--. 1 jstourac jstourac 2.9M Aug 16 15:13 ./modules/system/layers/base/net/bytebuddy/main/byte-buddy-1.8.17.jar
-rw-rw-r--. 1 jstourac jstourac 2.8M Aug 16 15:13 ./modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
-rw-rw-r--. 1 jstourac jstourac 2.7M Aug 16 15:13 ./modules/system/layers/base/com/sun/jsf-impl/main/jsf-impl-2.3.5.SP1.jar
-rw-rw-r--. 1 jstourac jstourac 2.7M Aug 16 15:13 ./modules/system/layers/base/com/google/guava/main/guava-25.0-jre.jar
-rw-rw-r--. 1 jstourac jstourac 2.6M Aug 16 15:13 ./modules/system/layers/base/org/eclipse/jgit/main/org.eclipse.jgit-5.0.2.201807311906-r.jar
-rw-rw-r--. 1 jstourac jstourac 2.4M Aug 16 15:13 ./bin/wildfly-elytron-tool.jar
{code}
> Jaeger-thrift jar dependency is quite chubby
> --------------------------------------------
>
> Key: WFLY-10877
> URL: https://issues.jboss.org/browse/WFLY-10877
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Reporter: Jan Stourac
> Assignee: Juraci Paixão Kröhling
> Priority: Minor
>
> Jaeger-thrift dependency file is quite chubby:
> {code}
> -rw-rw-r--. 1 jstourac jstourac 123K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-core-0.30.4.jar
> -rw-rw-r--. 1 jstourac jstourac 2.8M Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
> {code}
> Is there any possibility to shrink it's size somehow?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10877) Jaeger-thrift jar dependency is quite chubby
by Jan Stourac (JIRA)
[ https://issues.jboss.org/browse/WFLY-10877?page=com.atlassian.jira.plugin... ]
Jan Stourac updated WFLY-10877:
-------------------------------
Priority: Major (was: Minor)
> Jaeger-thrift jar dependency is quite chubby
> --------------------------------------------
>
> Key: WFLY-10877
> URL: https://issues.jboss.org/browse/WFLY-10877
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Reporter: Jan Stourac
> Assignee: Juraci Paixão Kröhling
>
> Jaeger-thrift dependency file is quite chubby:
> {code}
> -rw-rw-r--. 1 jstourac jstourac 123K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-core-0.30.4.jar
> -rw-rw-r--. 1 jstourac jstourac 2.8M Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
> {code}
> Is there any possibility to shrink it's size somehow?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFWIP-67) [Artemis 2.x upgrade] IndexOutOfBoundsException during receiving messages in remote JCA scenario between Artemis 1.5 and 2.x
by Clebert Suconic (JIRA)
[ https://issues.jboss.org/browse/WFWIP-67?page=com.atlassian.jira.plugin.s... ]
Clebert Suconic resolved WFWIP-67.
----------------------------------
Resolution: Done
> [Artemis 2.x upgrade] IndexOutOfBoundsException during receiving messages in remote JCA scenario between Artemis 1.5 and 2.x
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: WFWIP-67
> URL: https://issues.jboss.org/browse/WFWIP-67
> Project: WildFly WIP
> Issue Type: Bug
> Components: Artemis
> Reporter: Martin Styk
> Assignee: Martyn Taylor
> Priority: Blocker
>
> *Scenario:*
> Nodes A and B are in cluster. Destinations InQueue and OutQueue are deployed on them.
> MDBs are deployed on node C and D. These MDBs read messages from InQueue of nodes A, B and sends them to OutQueue on A and B.
> Nodes A,B are running Artemis 1.5. Nodes C,D are using Artemis 2.6.
> # Client sends messages to InQueue on node A
> # MDBs on nodes C,D read messages from remote InQueue and send them to remote OutQueue on nodes A,B
> # During processing of messages nodes A and C are killed
> # Client reads messages from OutQueue on node B.
> *Issue*
> At the end of the test, client is not able to read message
> {code}
> java.lang.IndexOutOfBoundsException: readerIndex(9) + length(128) exceeds writerIndex(133): UnpooledDuplicatedByteBuf(ridx: 9, widx: 133, cap: 606, unwrapped: UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 0, widx: 606, cap: 606))
> at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1405)
> at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1392)
> at io.netty.buffer.AbstractByteBuf.readBytes(AbstractByteBuf.java:872)
> at io.netty.buffer.AbstractByteBuf.readBytes(AbstractByteBuf.java:880)
> at io.netty.buffer.WrappedByteBuf.readBytes(WrappedByteBuf.java:649)
> at org.apache.activemq.artemis.api.core.SimpleString.readSimpleString(SimpleString.java:183)
> at org.apache.activemq.artemis.api.core.SimpleString.readSimpleString(SimpleString.java:171)
> at org.apache.activemq.artemis.api.core.SimpleString.readNullableSimpleString(SimpleString.java:158)
> at org.apache.activemq.artemis.core.buffers.impl.ChannelBufferWrapper.readNullableSimpleString(ChannelBufferWrapper.java:69)
> at org.apache.activemq.artemis.reader.TextMessageUtil.readBodyText(TextMessageUtil.java:37)
> at org.apache.activemq.artemis.jms.client.ActiveMQTextMessage.doBeforeReceive(ActiveMQTextMessage.java:112)
> at org.apache.activemq.artemis.jms.client.ActiveMQMessageConsumer.getMessage(ActiveMQMessageConsumer.java:224)
> at org.apache.activemq.artemis.jms.client.ActiveMQMessageConsumer.receive(ActiveMQMessageConsumer.java:132)
> at org.jboss.qa.hornetq.apps.clients.Receiver11.receiveMessage(Receiver11.java:151)
> at org.jboss.qa.hornetq.apps.clients.ReceiverTransAck.run(ReceiverTransAck.java:89)
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10877) Jaeger-thrift jar dependency is quite chubby
by Jan Stourac (JIRA)
Jan Stourac created WFLY-10877:
----------------------------------
Summary: Jaeger-thrift jar dependency is quite chubby
Key: WFLY-10877
URL: https://issues.jboss.org/browse/WFLY-10877
Project: WildFly
Issue Type: Bug
Components: MP OpenTracing
Reporter: Jan Stourac
Assignee: Juraci Paixão Kröhling
Priority: Minor
Jaeger-thrift dependency file is quite chubby:
{code}
-rw-rw-r--. 1 jstourac jstourac 123K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-core-0.30.4.jar
-rw-rw-r--. 1 jstourac jstourac 2.8M Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
{code}
Is there any possibility to shrink it's size somehow?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10847) Multiple service modules in single EAR use same tracer instance
by Gary Brown (JIRA)
[ https://issues.jboss.org/browse/WFLY-10847?page=com.atlassian.jira.plugin... ]
Gary Brown commented on WFLY-10847:
-----------------------------------
I think we might need to get some real world examples of how EARs are used.
My interpretation was that the EAR was a convenient way to package various components (e.g. services) that formed an application - so we may still want to see the interactions between the components of the application as separate services (or possibly a scoped name, e.g. <EARname>:<WARname>?).
So might be worth trying to get some understanding of how they are used by customers?
> Multiple service modules in single EAR use same tracer instance
> ---------------------------------------------------------------
>
> Key: WFLY-10847
> URL: https://issues.jboss.org/browse/WFLY-10847
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Reporter: Michal Jurc
> Assignee: Juraci Paixão Kröhling
> Priority: Blocker
> Fix For: 14.0.0.CR1
>
>
> When deploying an EAR with two stand-alone JAX-RS services in stand-alone WAR modules, both of the services use the same {{Tracer}} instance.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (DROOLS-2798) [DMN Designer] Data-types: Grid: Invocation
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2798?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-2798:
-----------------------------------
Description:
*_Invocation_*
- (/) Grid header _could_ show Output Data Type
- (/) Editing Output Data Type is possible via Properties panel
was:
*_Invocation_*
- (x) Grid header _could_ show Output Data Type
- (/) Editing Output Data Type is possible via Properties panel
> [DMN Designer] Data-types: Grid: Invocation
> -------------------------------------------
>
> Key: DROOLS-2798
> URL: https://issues.jboss.org/browse/DROOLS-2798
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Reporter: Michael Anstis
> Assignee: Michael Anstis
>
> *_Invocation_*
> - (/) Grid header _could_ show Output Data Type
> - (/) Editing Output Data Type is possible via Properties panel
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10876) Align jar file provided for MP OpenTracing into right modules
by Juraci Paixão Kröhling (JIRA)
[ https://issues.jboss.org/browse/WFLY-10876?page=com.atlassian.jira.plugin... ]
Juraci Paixão Kröhling commented on WFLY-10876:
-----------------------------------------------
The first draft of the subsystem had indeed a more granular set of modules, but I ran into CDI problems. Perhaps I'll be able to solve them now that I got a base working.
In any case, I don't think the following is desirable:
{quote}
wildfly-microprofile-opentracing-smallrye-14.0.0.CR1-SNAPSHOT.jar should be moved to new modules/system/layers/base/org/wildfly/extension/microprofile/opentracing-smallrye module so it matches what is done for health-smallrye and config-smallrye in extension subdir
{quote}
During the review, I was explicitly asked to keep the code that is added to the deployment away from the extension code: https://github.com/wildfly/wildfly/pull/11454#discussion_r207984046
> Align jar file provided for MP OpenTracing into right modules
> -------------------------------------------------------------
>
> Key: WFLY-10876
> URL: https://issues.jboss.org/browse/WFLY-10876
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Affects Versions: 14.0.0.Beta2
> Reporter: Jan Stourac
> Assignee: Juraci Paixão Kröhling
> Priority: Critical
>
> With recent addition of MicroProfile OpenTracing implementation we currently have following set of jar files that are in the build to provide various MicroProfile features:
> {code}
> $ find modules | grep smallrye | grep jar$ | xargs ls -hl
> -rw-rw-r--. 1 jstourac jstourac 39K Aug 16 15:13 modules/system/layers/base/io/smallrye/config/main/smallrye-config-1.3.3.jar
> -rw-rw-r--. 1 jstourac jstourac 8.9K Aug 16 15:13 modules/system/layers/base/io/smallrye/health/main/smallrye-health-1.0.2.jar
> -rw-rw-r--. 1 jstourac jstourac 38K Aug 16 15:13 modules/system/layers/base/org/wildfly/extension/microprofile/config-smallrye/main/wildfly-microprofile-config-smallrye-14.0.0.CR1-SNAPSHOT.jar
> -rw-rw-r--. 1 jstourac jstourac 27K Aug 16 15:13 modules/system/layers/base/org/wildfly/extension/microprofile/health-smallrye/main/wildfly-microprofile-health-smallrye-14.0.0.CR1-SNAPSHOT.jar
> -rw-rw-r--. 1 jstourac jstourac 228K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/gson-2.8.2.jar
> -rw-rw-r--. 1 jstourac jstourac 123K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-core-0.30.4.jar
> -rw-rw-r--. 1 jstourac jstourac 2.8M Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
> -rw-rw-r--. 1 jstourac jstourac 14K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-api-0.31.0.jar
> -rw-rw-r--. 1 jstourac jstourac 7.5K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-concurrent-0.1.0.jar
> -rw-rw-r--. 1 jstourac jstourac 41K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-jaxrs2-0.1.6.jar
> -rw-rw-r--. 1 jstourac jstourac 11K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-noop-0.31.0.jar
> -rw-rw-r--. 1 jstourac jstourac 7.4K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-tracerresolver-0.1.5.jar
> -rw-rw-r--. 1 jstourac jstourac 7.9K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-util-0.31.0.jar
> -rw-rw-r--. 1 jstourac jstourac 13K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-web-servlet-filter-0.1.0.jar
> -rw-rw-r--. 1 jstourac jstourac 5.4K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/smallrye-opentracing-1.1.1.jar
> -rw-rw-r--. 1 jstourac jstourac 11K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/wildfly-microprofile-opentracing-smallrye-14.0.0.CR1-SNAPSHOT.jar
> {code}
> It looks like the opentracing-smallrye module could be split up into a few separate modules. There at least two motivations:
> # particular implementation into its own module separate from the e.g. microprofile specification
> # because of the way how current patching mechanism works in WildFly, if we leave current {{opentracing-smallrye}} module as is, in case of a one-off patch it would mean to replace all files in the module - currently 3.3MB:
> {code}
> $ du -h modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/
> 3.3M modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/
> {code}
> My proposal how to align the jar files is following:
> # jaeger specific files should go into separate jaeger module
> # {{wildfly-microprofile-opentracing-smallrye-14.0.0.CR1-SNAPSHOT.jar}} should be moved to new {{modules/system/layers/base/org/wildfly/extension/microprofile/opentracing-smallrye}} module so it matches what is done for {{health-smallrye}} and {{config-smallrye}} in extension subdir
> # {{smallrye-opentracing-1.1.1.jar}} should be moved to {{base/io}} as is done for {{config}} and {{health}} - {{modules/system/layers/base/io/smallrye/opentracing/main/smallrye-opentracing-1.1.1.jar}}
> # what about that {{gson-2.8.2.jar}} dependency? Shall it be moved to some more generic place?
> This would give us following structure:
> {code}
> modules/system/layers/base/io/smallrye/config/main/smallrye-config-1.3.3.jar
> modules/system/layers/base/io/smallrye/health/main/smallrye-health-1.0.2.jar
> modules/system/layers/base/io/smallrye/opentracing/main/smallrye-opentracing-1.1.1.jar
> modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-api-0.31.0.jar
> modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-jaxrs2-0.1.6.jar
> modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-concurrent-0.1.0.jar
> modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-web-servlet-filter-0.1.0.jar
> modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-noop-0.31.0.jar
> modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-tracerresolver-0.1.5.jar
> modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-util-0.31.0.jar
> modules/system/layers/base/org/wildfly/extension/microprofile/health-smallrye/main/wildfly-microprofile-health-smallrye-14.0.0.CR1-SNAPSHOT.jar
> modules/system/layers/base/org/wildfly/extension/microprofile/config-smallrye/main/wildfly-microprofile-config-smallrye-14.0.0.CR1-SNAPSHOT.jar
> modules/system/layers/base/org/wildfly/extension/microprofile/opentracing-smallrye/main/wildfly-microprofile-opentracing-smallrye-14.0.0.CR1-SNAPSHOT.jar
> ---- I have no idea how this module for jaeger should be named...
> modules/system/layers/base/org/wildfly/microprofile/jaeger/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
> modules/system/layers/base/org/wildfly/microprofile/jaeger/opentracing-smallrye/main/jaeger-core-0.30.4.jar
> ---- I have no idea how this module for gson should be named...
> modules/system/layers/base/org/wildfly/gson/main/gson-2.8.2.jar
> {code}
> One additional piece for consideration - maybe we should also split up jar files that are just the microprofile-opentracing specification (api at least I guess) apart from the others in the {{modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/}}
> What do you think?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-10876) Align jar file provided for MP OpenTracing into right modules
by Jan Stourac (JIRA)
Jan Stourac created WFLY-10876:
----------------------------------
Summary: Align jar file provided for MP OpenTracing into right modules
Key: WFLY-10876
URL: https://issues.jboss.org/browse/WFLY-10876
Project: WildFly
Issue Type: Bug
Components: MP OpenTracing
Affects Versions: 14.0.0.Beta2
Reporter: Jan Stourac
Assignee: Juraci Paixão Kröhling
Priority: Critical
With recent addition of MicroProfile OpenTracing implementation we currently have following set of jar files that are in the build to provide various MicroProfile features:
{code}
$ find modules | grep smallrye | grep jar$ | xargs ls -hl
-rw-rw-r--. 1 jstourac jstourac 39K Aug 16 15:13 modules/system/layers/base/io/smallrye/config/main/smallrye-config-1.3.3.jar
-rw-rw-r--. 1 jstourac jstourac 8.9K Aug 16 15:13 modules/system/layers/base/io/smallrye/health/main/smallrye-health-1.0.2.jar
-rw-rw-r--. 1 jstourac jstourac 38K Aug 16 15:13 modules/system/layers/base/org/wildfly/extension/microprofile/config-smallrye/main/wildfly-microprofile-config-smallrye-14.0.0.CR1-SNAPSHOT.jar
-rw-rw-r--. 1 jstourac jstourac 27K Aug 16 15:13 modules/system/layers/base/org/wildfly/extension/microprofile/health-smallrye/main/wildfly-microprofile-health-smallrye-14.0.0.CR1-SNAPSHOT.jar
-rw-rw-r--. 1 jstourac jstourac 228K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/gson-2.8.2.jar
-rw-rw-r--. 1 jstourac jstourac 123K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-core-0.30.4.jar
-rw-rw-r--. 1 jstourac jstourac 2.8M Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
-rw-rw-r--. 1 jstourac jstourac 14K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-api-0.31.0.jar
-rw-rw-r--. 1 jstourac jstourac 7.5K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-concurrent-0.1.0.jar
-rw-rw-r--. 1 jstourac jstourac 41K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-jaxrs2-0.1.6.jar
-rw-rw-r--. 1 jstourac jstourac 11K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-noop-0.31.0.jar
-rw-rw-r--. 1 jstourac jstourac 7.4K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-tracerresolver-0.1.5.jar
-rw-rw-r--. 1 jstourac jstourac 7.9K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-util-0.31.0.jar
-rw-rw-r--. 1 jstourac jstourac 13K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-web-servlet-filter-0.1.0.jar
-rw-rw-r--. 1 jstourac jstourac 5.4K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/smallrye-opentracing-1.1.1.jar
-rw-rw-r--. 1 jstourac jstourac 11K Aug 16 15:13 modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/wildfly-microprofile-opentracing-smallrye-14.0.0.CR1-SNAPSHOT.jar
{code}
It looks like the opentracing-smallrye module could be split up into a few separate modules. There at least two motivations:
# particular implementation into its own module separate from the e.g. microprofile specification
# because of the way how current patching mechanism works in WildFly, if we leave current {{opentracing-smallrye}} module as is, in case of a one-off patch it would mean to replace all files in the module - currently 3.3MB:
{code}
$ du -h modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/
3.3M modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/
{code}
My proposal how to align the jar files is following:
# jaeger specific files should go into separate jaeger module
# {{wildfly-microprofile-opentracing-smallrye-14.0.0.CR1-SNAPSHOT.jar}} should be moved to new {{modules/system/layers/base/org/wildfly/extension/microprofile/opentracing-smallrye}} module so it matches what is done for {{health-smallrye}} and {{config-smallrye}} in extension subdir
# {{smallrye-opentracing-1.1.1.jar}} should be moved to {{base/io}} as is done for {{config}} and {{health}} - {{modules/system/layers/base/io/smallrye/opentracing/main/smallrye-opentracing-1.1.1.jar}}
# what about that {{gson-2.8.2.jar}} dependency? Shall it be moved to some more generic place?
This would give us following structure:
{code}
modules/system/layers/base/io/smallrye/config/main/smallrye-config-1.3.3.jar
modules/system/layers/base/io/smallrye/health/main/smallrye-health-1.0.2.jar
modules/system/layers/base/io/smallrye/opentracing/main/smallrye-opentracing-1.1.1.jar
modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-api-0.31.0.jar
modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-jaxrs2-0.1.6.jar
modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-concurrent-0.1.0.jar
modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-web-servlet-filter-0.1.0.jar
modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-noop-0.31.0.jar
modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-tracerresolver-0.1.5.jar
modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/opentracing-util-0.31.0.jar
modules/system/layers/base/org/wildfly/extension/microprofile/health-smallrye/main/wildfly-microprofile-health-smallrye-14.0.0.CR1-SNAPSHOT.jar
modules/system/layers/base/org/wildfly/extension/microprofile/config-smallrye/main/wildfly-microprofile-config-smallrye-14.0.0.CR1-SNAPSHOT.jar
modules/system/layers/base/org/wildfly/extension/microprofile/opentracing-smallrye/main/wildfly-microprofile-opentracing-smallrye-14.0.0.CR1-SNAPSHOT.jar
---- I have no idea how this module for jaeger should be named...
modules/system/layers/base/org/wildfly/microprofile/jaeger/opentracing-smallrye/main/jaeger-thrift-0.30.4.jar
modules/system/layers/base/org/wildfly/microprofile/jaeger/opentracing-smallrye/main/jaeger-core-0.30.4.jar
---- I have no idea how this module for gson should be named...
modules/system/layers/base/org/wildfly/gson/main/gson-2.8.2.jar
{code}
One additional piece for consideration - maybe we should also split up jar files that are just the microprofile-opentracing specification (api at least I guess) apart from the others in the {{modules/system/layers/base/org/wildfly/microprofile/opentracing-smallrye/main/}}
What do you think?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months