[JBoss JIRA] (DROOLS-2845) Extend the existing verifier to support DMN tables
by Liz Clayton (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2845?page=com.atlassian.jira.plugi... ]
Liz Clayton updated DROOLS-2845:
--------------------------------
Labels: UX drools-tools (was: drools-tools)
> Extend the existing verifier to support DMN tables
> --------------------------------------------------
>
> Key: DROOLS-2845
> URL: https://issues.jboss.org/browse/DROOLS-2845
> Project: Drools
> Issue Type: Epic
> Components: DMN Editor, verifier
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Labels: UX, drools-tools
>
> h1. Goal
> Reuse the V&V created for Guided Decision Tables on the DMN tables.
> h1. Workload divided to steps
> I propose the work goes in the following steps. After each step I should be able to merge into master.
> Steps:
> # Move Verifier core to kie-wb-common
> # Move V&V reporting UI to kie-wb-common
> # Make the web worker connector reusable for different V&V types
> # Make a servlet module for DMN that allows the download of the Web Worker.
> # Create an adapter for DMN tables
> # Add support for ranges ( these are given in DMN so no need to use JSR303 )
> # Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense
> h1. Time and risks
> h2. #1, #2, #3, #4 and #7 moving, copying code or doing refactoring
> Most of the work items are just about moving, copying code or doing refactoring. These are easy to estimate and I think they are doable in one sprint along with everything else I do. Already started few of these so it is easier for me to estimate how long they take.
> h2. 5. Create an adapter for DMN tables
> Adapters job is to take the model ( DMN or dtable ) and tear it down into smaller bits that the Verifier actually inspects. The core Verifier basically only sees rules or rows as collections of conditions and actions. This is why I feel once the adapter is done, the verifier will automatically work for DMN tables. This adapter also keeps track of the cell to action/condition connections.
> This area is where most of the work is that is hard to estimate, since there is some unknowns here. In theory DMN adapter is a lot easier to do than the DTable adapter was. Due to the unknown I will have to say 3 weeks.
> h2. 6. Add support for ranges
> Mario helped to get the range checks in order. The V&V now works with unlimited ranges, but adding known range limitation is in a way just about adding in the data of a mock rule that checks for the area that is outside of the range. I’ll play it safe here and say one week, but at the moment this feels really easy.
> h1. Just to make it clear
> This work only targets the DMN table in the similar format that it is in the Guided Decision Table. So it does not cover a Verification of the entire DMN diagram that can have several tables that possibly complete each other. We have the same situation if we have multiple DRL Tables in a ksession.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFCORE-3180) ElytronSubsystemMessages uses double quotes to surround string literals
by Justin Cook (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3180?page=com.atlassian.jira.plugi... ]
Justin Cook reassigned WFCORE-3180:
-----------------------------------
Assignee: Justin Cook
> ElytronSubsystemMessages uses double quotes to surround string literals
> -----------------------------------------------------------------------
>
> Key: WFCORE-3180
> URL: https://issues.jboss.org/browse/WFCORE-3180
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Brian Stansberry
> Assignee: Justin Cook
> Priority: Minor
>
> Lots of things like this:
> @Message(id = 910, value = "Password cannot be resolved for key-store \"%s\"")
> Use ' instead of \". If the string ends up in a DMR ModelNode, which it often does, the output looks bad when double quotes are present.
> For this ModelNode
> ModelNode node = new ModelNode("Password cannot be resolved for key-store \"%s\"");
>
> A call to node.toString() produces
> "Password cannot be resolved for key-store \"%s\""
> node.asString() is better, but that requires a special call vs the standard Object.toString
> Password cannot be resolved for key-store "%s"
> This is minor since we can try to ensure asString is used or perhaps even consider changing how toString works. But I think single quotes are a better practice.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months
[JBoss JIRA] (WFLY-9058) Inconsistent attribute desription of security domain
by Justin Cook (JIRA)
[ https://issues.jboss.org/browse/WFLY-9058?page=com.atlassian.jira.plugin.... ]
Justin Cook reassigned WFLY-9058:
---------------------------------
Assignee: Justin Cook
> Inconsistent attribute desription of security domain
> ----------------------------------------------------
>
> Key: WFLY-9058
> URL: https://issues.jboss.org/browse/WFLY-9058
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Juraj Duráni
> Assignee: Justin Cook
> Priority: Minor
> Fix For: Awaiting Volunteers
>
>
> Some attributes have inconsistent description (obtained using 'read-resource-description' operation):
> - Missing module attribute:
> {code:plain|title=Missing module attribute}
> [standalone@localhost:9990 /] /subsystem=security/security-domain=other/mapping=classic:read-resource-description
> {
> "outcome" => "success",
> "result" => {
> "description" => "Mapping configuration. Configures a list of mapping modules to be used for principal, role, attribute and credential mapping.",
> "deprecated" => {
> "since" => "1.3.0",
> "reason" => "The Security subsystem is deprecated and may be removed, significantly revised, or limited to managed domain legacy server use in future versions."
> },
> "access-constraints" => {
> "sensitive" => {"security-domain" => {"type" => "core"}},
> "application" => {"security-domain" => {"type" => "security"}}
> },
> "attributes" => {"mapping-modules" => {
> "type" => LIST,
> "description" => "List of modules that map principal, role, and credential information",
> "expressions-allowed" => false,
> "nillable" => true,
> "deprecated" => {
> "since" => "1.2.0",
> "reason" => "Use of this attribute is deprecated, use resource"
> },
> "value-type" => {
> "code" => {
> "description" => "Class name of the module to be instantiated.",
> "type" => STRING,
> "nillable" => false,
> "min-length" => 1
> },
> "type" => {
> "description" => "Type of mapping this module performs. Allowed values are principal, role, attribute or credential..",
> "type" => STRING,
> "nillable" => false
> },
> "module-options" => {
> "description" => "List of module options containing a name/value pair.",
> "type" => OBJECT,
> "value-type" => STRING,
> "nillable" => true
> }
> },
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "all-services"
> }},
> "operations" => undefined,
> "notifications" => undefined,
> "children" => {"mapping-module" => {
> "description" => "List of modules that map principal, role, and credential information",
> "model-description" => undefined
> }}
> }
> }
> {code}
> - Module description in policy-module refers to "login module"
> {code:plain|title=Inaccurate description}
> [standalone@localhost:9990 /] /subsystem=security/security-domain=other/authorization=classic/policy-module=a:read-resource-description
> {
> "outcome" => "success",
> "result" => {
> "description" => "List of authentication modules",
> "access-constraints" => {
> "sensitive" => {"security-domain" => {"type" => "core"}},
> "application" => {"security-domain" => {"type" => "security"}}
> },
> "attributes" => {
> "code" => {
> "type" => STRING,
> "description" => "Class name of the module to be instantiated.",
> "expressions-allowed" => false,
> "nillable" => false,
> "min-length" => 1L,
> "max-length" => 2147483647L,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "no-services"
> },
> "flag" => {
> "type" => STRING,
> "description" => "The flag controls how the module participates in the overall procedure. Allowed values are requisite, required, sufficient or optional.",
> "expressions-allowed" => true,
> "nillable" => false,
> "allowed" => [
> "required",
> "requisite",
> "sufficient",
> "optional"
> ],
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "no-services"
> },
> "module" => {
> "type" => STRING,
> "description" => "Name of JBoss Module where the login module is located.",
> "expressions-allowed" => false,
> "nillable" => true,
> "min-length" => 1L,
> "max-length" => 2147483647L,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "no-services"
> },
> "module-options" => {
> "type" => OBJECT,
> "description" => "List of module options containing a name/value pair.",
> "expressions-allowed" => true,
> "nillable" => true,
> "value-type" => STRING,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "no-services"
> }
> },
> "operations" => undefined,
> "notifications" => undefined,
> "children" => {}
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 11 months