[JBoss JIRA] (DROOLS-2892) Session reset doesn't clear path memory
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2892?page=com.atlassian.jira.plugi... ]
Mario Fusco updated DROOLS-2892:
--------------------------------
Sprint: 2018 Week 33-35
> Session reset doesn't clear path memory
> ---------------------------------------
>
> Key: DROOLS-2892
> URL: https://issues.jboss.org/browse/DROOLS-2892
> Project: Drools
> Issue Type: Bug
> Reporter: Christian Liebhardt
> Assignee: Mario Fusco
>
> As discussed in https://groups.google.com/forum/#!topic/drools-usage/V8ypP1o5SwM :
> In order to reduce memory allocations we are calling _StatefulKnowledgeSessionImpl.reset()_ to bring a disposed session back into life. From our understanding this is the same method which the Drools session cache would use. During our tests we found that some of our rules don't trigger if we use this approach. We also found that the reset method leaves _PathMemory_ instances behind in the memory. As soon as we cleared the memory explicitly by calling _session.getNodeMemories().clear()_ after every _session.reset()_ the rules fired again as usual. So we are wondering if the current implementation of _session.reset()_ is incomplete.
> We are aware that _session.reset()_ is an internal method. However this issue should also affect the session cache feature of Drools. At the same time it would be nice to have a public interface to _session.reset()_ since in our application reusing a session is beneficial but we don't need the session cache as we can easily remember the last session which we used for processing and it seems more straightforward to just bring that one back to life instead of storing and retrieving it from a cache.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (DROOLS-2549) [DMN Designer] Add support for 'parent' to DMNModelInstrumentedBase
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2549?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-2549:
-----------------------------------
Description:
{{DMNModelInstrumentedBase}} needs to support {{parent}} (like {{org.kie.dmn.model.v1_1.DMNModelInstrumentedBase}}) in order to correctly implement {{getPrefixForNamespaceURI(..)}} that is needed to set the {{QName}} prefix when setting data-types on nodes.
At the moment the {{QName}} for data-types in the UI is using the {{namespaceURI}} instead of the {{prefix}} as it is currently impossible to lookup a {{prefix}} from the {{namespaceURI}} (of the nodes' parents up to {{Definitions}}).
Changes required for this JIRA (split into sub-tasks when work starts):-
* Update XML->(kie)DMN->(ui)DMN model mapping in the marshaller (/)
* Update the UI to set {{parent}} when adding nodes to the {{DRGElement}} and children (/)
* Update code relating to "setting data-type" to lookup {{prefix}} for {{QName}} (/)
* When creating a new Diagram we need to set up the basic default NameSpace contexts on the {{DMNDiagram}}'s {{Defintions}} (/)
was:
{{DMNModelInstrumentedBase}} needs to support {{parent}} (like {{org.kie.dmn.model.v1_1.DMNModelInstrumentedBase}}) in order to correctly implement {{getPrefixForNamespaceURI(..)}} that is needed to set the {{QName}} prefix when setting data-types on nodes.
At the moment the {{QName}} for data-types in the UI is using the {{namespaceURI}} instead of the {{prefix}} as it is currently impossible to lookup a {{prefix}} from the {{namespaceURI}} (of the nodes' parents up to {{Definitions}}).
Changes required for this JIRA (split into sub-tasks when work starts):-
* Update XML->(kie)DMN->(ui)DMN model mapping in the marshaller
* Update the UI to set {{parent}} when adding nodes to the {{DRGElement}} and children
* Update code relating to "setting data-type" to lookup {{prefix}} for {{QName}} (/)
* When creating a new Diagram we need to set up the basic default NameSpace contexts on the {{DMNDiagram}}'s {{Defintions}} (/)
> [DMN Designer] Add support for 'parent' to DMNModelInstrumentedBase
> -------------------------------------------------------------------
>
> Key: DROOLS-2549
> URL: https://issues.jboss.org/browse/DROOLS-2549
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.7.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Fix For: 7.11.0.Final
>
>
> {{DMNModelInstrumentedBase}} needs to support {{parent}} (like {{org.kie.dmn.model.v1_1.DMNModelInstrumentedBase}}) in order to correctly implement {{getPrefixForNamespaceURI(..)}} that is needed to set the {{QName}} prefix when setting data-types on nodes.
> At the moment the {{QName}} for data-types in the UI is using the {{namespaceURI}} instead of the {{prefix}} as it is currently impossible to lookup a {{prefix}} from the {{namespaceURI}} (of the nodes' parents up to {{Definitions}}).
> Changes required for this JIRA (split into sub-tasks when work starts):-
> * Update XML->(kie)DMN->(ui)DMN model mapping in the marshaller (/)
> * Update the UI to set {{parent}} when adding nodes to the {{DRGElement}} and children (/)
> * Update code relating to "setting data-type" to lookup {{prefix}} for {{QName}} (/)
> * When creating a new Diagram we need to set up the basic default NameSpace contexts on the {{DMNDiagram}}'s {{Defintions}} (/)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (DROOLS-2457) CamelEndpointWith* tests failing with IBM JAVA (SAXNotRecognizedException)
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2457?page=com.atlassian.jira.plugi... ]
Mario Fusco resolved DROOLS-2457.
---------------------------------
Resolution: Won't Fix
> CamelEndpointWith* tests failing with IBM JAVA (SAXNotRecognizedException)
> --------------------------------------------------------------------------
>
> Key: DROOLS-2457
> URL: https://issues.jboss.org/browse/DROOLS-2457
> Project: Drools
> Issue Type: Bug
> Components: integration
> Affects Versions: 7.7.0.Final
> Environment: RHEL 7.4 || Fedora 27
> IBM Java 1.8 ibm-java-x86_64-sdk-8.0.5.10
> Reporter: Martin Cimbalek
> Assignee: Mario Fusco
>
> {{org.kie.camel.embedded.camel.component.CamelEndpointWith*}} tests fail with
> {{org.xml.sax.SAXNotRecognizedException: http://javax.xml.XMLConstants/feature/secure-processing}} with IBM JAVA 1.8 (ibm-java-x86_64-sdk-8.0.5.10)
> +List of tests failing:+
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.testWorkingSetGlobalTestSessionSetAndGetGlobal
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testQuery
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testProcess
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testInsertElements
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionInsert
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testProcessInstanceSignalEvent
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionGetObject
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionRetractObject
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbXSDModelTest.testSessionInsert
> +Stacktrace (similar for other tests in fail):+
> java.lang.IllegalStateException: org.xml.sax.SAXNotRecognizedException: http://javax.xml.XMLConstants/feature/secure-processing
> at javax.xml.validation.SchemaFactory.setFeature(Unknown Source)
> at com.sun.xml.bind.v2.util.XmlFactory.createSchemaFactory(XmlFactory.java:102)
> at com.sun.tools.xjc.reader.xmlschema.parser.SchemaConstraintChecker.check(SchemaConstraintChecker.java:86)
> at com.sun.tools.xjc.ModelLoader.loadXMLSchema(ModelLoader.java:360)
> at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:174)
> at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:119)
> at org.drools.compiler.runtime.pipeline.impl.DroolsJaxbHelperProviderImpl.addXsdModel(DroolsJaxbHelperProviderImpl.java:121)
> at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addPackageFromXSD(KnowledgeBuilderImpl.java:918)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl$ResourceBuilder.lambda$static$2(CompositeKnowledgeBuilderImpl.java:283)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl$ResourceBuilder$$Lambda$21.000000002566C640.build(Unknown Source)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.buildResourceType(CompositeKnowledgeBuilderImpl.java:131)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.buildResources(CompositeKnowledgeBuilderImpl.java:121)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.build(CompositeKnowledgeBuilderImpl.java:98)
> at org.drools.compiler.kie.builder.impl.AbstractKieProject.buildKnowledgePackages(AbstractKieProject.java:247)
> at org.drools.compiler.kie.builder.impl.AbstractKieProject.verify(AbstractKieProject.java:74)
> at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildKieProject(KieBuilderImpl.java:353)
> at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildAll(KieBuilderImpl.java:265)
> at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildAll(KieBuilderImpl.java:209)
> at org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.registerKnowledgeRuntime(CamelEndpointWithJaxWrapperCollectionTest.java:139)
> at org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.configureDroolsContext(CamelEndpointWithJaxWrapperCollectionTest.java:112)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (DROOLS-2457) CamelEndpointWith* tests failing with IBM JAVA (SAXNotRecognizedException)
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2457?page=com.atlassian.jira.plugi... ]
Mario Fusco commented on DROOLS-2457:
-------------------------------------
By digging into IBM JDK sources I found that setting the following system property fixes all tests:
{code:java}
System.setProperty("javax.xml.validation.SchemaFactory:http://www.w3.org/2001/XMLSchema", "org.apache.xerces.jaxp.validation.XMLSchemaFactory");
{code}
However this is totally undocumented, so I wouldn't add this workaround to our codebase. At most we can add to our documentation that users need to set this system property to make this use to work on IBM JDK.
I believe that the issue I described in my former comment is a bug in IBM JDK and should be reported to them. Also I don't see (given the current situation) any other possible solution, so I will close this ticket.
> CamelEndpointWith* tests failing with IBM JAVA (SAXNotRecognizedException)
> --------------------------------------------------------------------------
>
> Key: DROOLS-2457
> URL: https://issues.jboss.org/browse/DROOLS-2457
> Project: Drools
> Issue Type: Bug
> Components: integration
> Affects Versions: 7.7.0.Final
> Environment: RHEL 7.4 || Fedora 27
> IBM Java 1.8 ibm-java-x86_64-sdk-8.0.5.10
> Reporter: Martin Cimbalek
> Assignee: Mario Fusco
>
> {{org.kie.camel.embedded.camel.component.CamelEndpointWith*}} tests fail with
> {{org.xml.sax.SAXNotRecognizedException: http://javax.xml.XMLConstants/feature/secure-processing}} with IBM JAVA 1.8 (ibm-java-x86_64-sdk-8.0.5.10)
> +List of tests failing:+
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.testWorkingSetGlobalTestSessionSetAndGetGlobal
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testQuery
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testProcess
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testInsertElements
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionInsert
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testProcessInstanceSignalEvent
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionGetObject
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbTest.testSessionRetractObject
> * org.kie.camel.embedded.camel.component.CamelEndpointWithJaxbXSDModelTest.testSessionInsert
> +Stacktrace (similar for other tests in fail):+
> java.lang.IllegalStateException: org.xml.sax.SAXNotRecognizedException: http://javax.xml.XMLConstants/feature/secure-processing
> at javax.xml.validation.SchemaFactory.setFeature(Unknown Source)
> at com.sun.xml.bind.v2.util.XmlFactory.createSchemaFactory(XmlFactory.java:102)
> at com.sun.tools.xjc.reader.xmlschema.parser.SchemaConstraintChecker.check(SchemaConstraintChecker.java:86)
> at com.sun.tools.xjc.ModelLoader.loadXMLSchema(ModelLoader.java:360)
> at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:174)
> at com.sun.tools.xjc.ModelLoader.load(ModelLoader.java:119)
> at org.drools.compiler.runtime.pipeline.impl.DroolsJaxbHelperProviderImpl.addXsdModel(DroolsJaxbHelperProviderImpl.java:121)
> at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addPackageFromXSD(KnowledgeBuilderImpl.java:918)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl$ResourceBuilder.lambda$static$2(CompositeKnowledgeBuilderImpl.java:283)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl$ResourceBuilder$$Lambda$21.000000002566C640.build(Unknown Source)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.buildResourceType(CompositeKnowledgeBuilderImpl.java:131)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.buildResources(CompositeKnowledgeBuilderImpl.java:121)
> at org.drools.compiler.builder.impl.CompositeKnowledgeBuilderImpl.build(CompositeKnowledgeBuilderImpl.java:98)
> at org.drools.compiler.kie.builder.impl.AbstractKieProject.buildKnowledgePackages(AbstractKieProject.java:247)
> at org.drools.compiler.kie.builder.impl.AbstractKieProject.verify(AbstractKieProject.java:74)
> at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildKieProject(KieBuilderImpl.java:353)
> at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildAll(KieBuilderImpl.java:265)
> at org.drools.compiler.kie.builder.impl.KieBuilderImpl.buildAll(KieBuilderImpl.java:209)
> at org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.registerKnowledgeRuntime(CamelEndpointWithJaxWrapperCollectionTest.java:139)
> at org.kie.camel.embedded.camel.component.CamelEndpointWithJaxWrapperCollectionTest.configureDroolsContext(CamelEndpointWithJaxWrapperCollectionTest.java:112)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (DROOLS-2931) DMN Designer - node names not generated when shortcuts used
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2931?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2931:
--------------------------------
Story Points: 1
> DMN Designer - node names not generated when shortcuts used
> -----------------------------------------------------------
>
> Key: DROOLS-2931
> URL: https://issues.jboss.org/browse/DROOLS-2931
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Labels: drools-tools
>
> If DMN node is added via shortcuts (see JBPM-6385), then the node name is not generated automatically. It is not consistent with addition nodes via palette or popup context menu.
> h3. Acceptance test
> - Node added via palette has autogenerated name
> - Node added via popu context menu has autogenerated name
> - Node added via keyboard shortcut has autogenerated name
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (DROOLS-2931) DMN Designer - node names not generated when shortcuts used
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2931?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2931:
--------------------------------
Sprint: 2018 Week 36-38
> DMN Designer - node names not generated when shortcuts used
> -----------------------------------------------------------
>
> Key: DROOLS-2931
> URL: https://issues.jboss.org/browse/DROOLS-2931
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Jozef Marko
> Assignee: Jozef Marko
> Labels: drools-tools
>
> If DMN node is added via shortcuts (see JBPM-6385), then the node name is not generated automatically. It is not consistent with addition nodes via palette or popup context menu.
> h3. Acceptance test
> - Node added via palette has autogenerated name
> - Node added via popu context menu has autogenerated name
> - Node added via keyboard shortcut has autogenerated name
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months