[JBoss JIRA] (WFLY-10808) Default Value of local-receiver-pass-by-value in jboss-ejb-client Descriptor is Not Respected
by Bartosz Baranowski (JIRA)
[ https://issues.jboss.org/browse/WFLY-10808?page=com.atlassian.jira.plugin... ]
Bartosz Baranowski commented on WFLY-10808:
-------------------------------------------
Cause: https://issues.jboss.org/browse/AS7-3330
Tad cryptic change.
For some reason I cant create PR
{quote}
diff --git a/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java b/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java
index 84786e7abb..b0d3ab6fdd 100644
--- a/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java
+++ b/ee/src/main/java/org/jboss/as/ee/structure/EJBClientDescriptor10Parser.java
@@ -129,7 +129,7 @@ class EJBClientDescriptor10Parser implements XMLElementReader<EJBClientDescripto
protected void parseEJBReceivers(final XMLExtendedStreamReader reader, final EJBClientDescriptorMetaData ejbClientDescriptorMetaData) throws XMLStreamException {
// initialize the local-receiver-pass-by-value to the default true
- Boolean localReceiverPassByValue = null;
+ Boolean localReceiverPassByValue = true;
final int count = reader.getAttributeCount();
for (int i = 0; i < count; i++) {
{quote}
> Default Value of local-receiver-pass-by-value in jboss-ejb-client Descriptor is Not Respected
> ---------------------------------------------------------------------------------------------
>
> Key: WFLY-10808
> URL: https://issues.jboss.org/browse/WFLY-10808
> Project: WildFly
> Issue Type: Bug
> Components: EE, EJB
> Affects Versions: 11.0.0.Final, 12.0.0.Final, 13.0.0.Final
> Reporter: Joshua Swett
> Assignee: Bartosz Baranowski
> Priority: Minor
> Attachments: TestWAR.war
>
>
> The jboss-ejb-client.xml deployment descriptor file can be used to configure the pass semantics of the local EJB receiver using the local-receiver-pass-by-value attribute.
> As per the EJB spec, the default behaviour should be to pass by value, and this is appropriately reflected in the jboss-ejb-client XSD. As of Wildfly 11, the *omission* of the local-receiver-pass-by-value attribute in a jboss-ejb-client deployment descriptor actually results in remote EJB parameters and the return value being passed by reference as opposed to the documented default of being passed by value.
> It appears that this bug is a result of changes made for WFLY-5403. The root cause is that the EJBClientDescriptorMetaDataProcessor.java class only uses the pass-by-value receiver if the local-receiver-pass-by-value attribute is Boolean.TRUE (line 177 in 13.0.0.Final), but EJBClientDescriptor10Parser.java defaults the value to null if it is not included in the jboss-ejb-client.xml (line 132 in 13.0.0.Final). The old and working behaviour was to fallback to the value configured at the ejb subsystem level if the jboss-ejb-client.xml excluded the attribute.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFLY-10861) MP Health - security enabled, no user yed added, user get info about adding user to access management interface, HTTP code is 200, should be 500
by Martin Švehla (JIRA)
[ https://issues.jboss.org/browse/WFLY-10861?page=com.atlassian.jira.plugin... ]
Martin Švehla commented on WFLY-10861:
--------------------------------------
[~rsvoboda] the fact property realm changes need server reload is documented, see JBEAP-8443 and JBEAP-11251. But I agree it's unfortunate it's changed behavior from legacy security.
[~dlofthouse] is it realistic to change that? I suppose it would mean change in caching so it'd mean redesigning the property realm. WDYT?
> MP Health - security enabled, no user yed added, user get info about adding user to access management interface, HTTP code is 200, should be 500
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WFLY-10861
> URL: https://issues.jboss.org/browse/WFLY-10861
> Project: WildFly
> Issue Type: Bug
> Components: Management, MP Health
> Reporter: Rostislav Svoboda
> Assignee: Kabir Khan
> Priority: Blocker
> Fix For: 14.0.0.CR1
>
>
> I do {{:write-attribute(name=security-enabled, value=true)}} ++ reload of the server
> Note: I didn't add user via {{bin/add-user.sh}}
> ----
> Kabir edit: the full command is:
> /subsystem=microprofile-health-smallrye:write-attribute(name=security-enabled,value=true)
> ----
> When I'm trying to access http://127.0.0.1:9990/health I receive page which is there primarily for web console:
> {code}
> <h3>Your WildFly Application Server is running.</h3>
> <p>However you have <strong>not</strong> yet <strong>added any users</strong> to be able
> to access the admin console.</p>
> <p>To add a new user execute the <code>add-user.sh</code> script within the bin folder of
> your WildFly installation and enter the requested information.</p>
> {code}
> Can /health endpoint get customized response in case no mgmt user is defined on server side ?
> Current response can be little confusing if user is not yet so familiar with WildFly.
> -I marked this as minor bug.- ... see comments
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (DROOLS-2923) DMN implement EvalHelper cache eviction PR #1997
by Matteo Mortari (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2923?page=com.atlassian.jira.plugi... ]
Matteo Mortari updated DROOLS-2923:
-----------------------------------
Description:
Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.
Before, baseline of reference:
!screenshot-1.png|thumbnail!
!screenshot-2.png|thumbnail!
After, with cache eviction as proposed by PR #1997
!screenshot-3.png|thumbnail!
!screenshot-4.png|thumbnail!
We can notice the EvalHelper method is no longer a "hot spot" and the 10K evaluations of the model takes less than the creation of the DMNRuntime hence is no longer the top expensive operation in the test.
was:
Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.
Baseline:
!screenshot-1.png|thumbnail!
!screenshot-2.png|thumbnail!
With cache eviction as proposed by PR #1997
!screenshot-3.png|thumbnail!
> DMN implement EvalHelper cache eviction PR #1997
> ------------------------------------------------
>
> Key: DROOLS-2923
> URL: https://issues.jboss.org/browse/DROOLS-2923
> Project: Drools
> Issue Type: Task
> Components: dmn engine
> Reporter: Matteo Mortari
> Assignee: Matteo Mortari
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, screenshot-4.png
>
>
> Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.
> Before, baseline of reference:
> !screenshot-1.png|thumbnail!
> !screenshot-2.png|thumbnail!
> After, with cache eviction as proposed by PR #1997
> !screenshot-3.png|thumbnail!
> !screenshot-4.png|thumbnail!
> We can notice the EvalHelper method is no longer a "hot spot" and the 10K evaluations of the model takes less than the creation of the DMNRuntime hence is no longer the top expensive operation in the test.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (DROOLS-2923) DMN implement EvalHelper cache eviction PR #1997
by Matteo Mortari (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2923?page=com.atlassian.jira.plugi... ]
Matteo Mortari updated DROOLS-2923:
-----------------------------------
Attachment: screenshot-2.png
> DMN implement EvalHelper cache eviction PR #1997
> ------------------------------------------------
>
> Key: DROOLS-2923
> URL: https://issues.jboss.org/browse/DROOLS-2923
> Project: Drools
> Issue Type: Task
> Components: dmn engine
> Reporter: Matteo Mortari
> Assignee: Matteo Mortari
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, screenshot-4.png
>
>
> Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.
> Baseline:
> !screenshot-1.png|thumbnail!
> !screenshot-2.png|thumbnail!
> With cache eviction as proposed by PR #1997
> !screenshot-3.png|thumbnail!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (DROOLS-2923) DMN implement EvalHelper cache eviction PR #1997
by Matteo Mortari (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2923?page=com.atlassian.jira.plugi... ]
Matteo Mortari updated DROOLS-2923:
-----------------------------------
Attachment: screenshot-4.png
> DMN implement EvalHelper cache eviction PR #1997
> ------------------------------------------------
>
> Key: DROOLS-2923
> URL: https://issues.jboss.org/browse/DROOLS-2923
> Project: Drools
> Issue Type: Task
> Components: dmn engine
> Reporter: Matteo Mortari
> Assignee: Matteo Mortari
> Attachments: screenshot-1.png, screenshot-3.png, screenshot-4.png
>
>
> Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.
> Baseline:
> !screenshot-1.png|thumbnail!
> !screenshot-2.png|thumbnail!
> With cache eviction as proposed by PR #1997
> !screenshot-3.png|thumbnail!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (DROOLS-2923) DMN implement EvalHelper cache eviction PR #1997
by Matteo Mortari (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2923?page=com.atlassian.jira.plugi... ]
Matteo Mortari updated DROOLS-2923:
-----------------------------------
Attachment: screenshot-1.png
> DMN implement EvalHelper cache eviction PR #1997
> ------------------------------------------------
>
> Key: DROOLS-2923
> URL: https://issues.jboss.org/browse/DROOLS-2923
> Project: Drools
> Issue Type: Task
> Components: dmn engine
> Reporter: Matteo Mortari
> Assignee: Matteo Mortari
> Attachments: screenshot-1.png, screenshot-3.png, screenshot-4.png
>
>
> Submitted PR #1997 proposes a cache lookup for Method accessor for FEEL (EvalHelper#getGenericAccessor) but missing cache eviction make the optimization incompatible with KieContainer upgrade. This JIRA will provide report on optimization and cache eviction mechanism.
> Baseline:
> !screenshot-1.png|thumbnail!
> !screenshot-2.png|thumbnail!
> With cache eviction as proposed by PR #1997
> !screenshot-3.png|thumbnail!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months