[JBoss JIRA] (WFLY-10991) Memory leak when deployment is redeployed multiple times
by Jan Stourac (JIRA)
[ https://issues.jboss.org/browse/WFLY-10991?page=com.atlassian.jira.plugin... ]
Jan Stourac commented on WFLY-10991:
------------------------------------
[~juraci.costa], yeah - the leak was 25MB for 100 re-deployments, so the fix you provided is probably the right-one.
Thank you for running our test against that version. I'll do that myself manually too but as test passed for you I believe that the fix is correct :)
> Memory leak when deployment is redeployed multiple times
> --------------------------------------------------------
>
> Key: WFLY-10991
> URL: https://issues.jboss.org/browse/WFLY-10991
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Affects Versions: 14.0.0.Beta2
> Reporter: Jan Stourac
> Assignee: Juraci Paixão Kröhling
> Priority: Blocker
> Attachments: memoryLeaks.war, problematic-wf-build-heap-diff-start-end-org-filter.png, problematic-wf-build-heap-diff-start-end.png, sane-wf-build-heap-diff-start-end-org-filter.png, sane-wf-build-heap-diff-start-end.png
>
>
> It looks like redeploying attached deployment [^memoryLeaks.war] multiple times (our automated test does it 100 times), there seems to be some memory leak in the WildFly. Using git bisect, the commit that started to fail is [651dc8a2f0d4ccad6a35f7b1d28626b43ebb2a5d in WildFly repository|https://github.com/wildfly/wildfly/commits/651dc8a2f0d4ccad6a3...]. That is why I selected MP OpenTracing component for this issue. Actual testing deployment is very simple and contains just some jsp file with some EJB classes that are used to call GC and check current heap usage.
> Brief description of the test:
> # attached deployment is deployed
> # System.gc() is called via EJB call
> # it checks initial heap usage at the beginning of the test via EJB call that checks all instances of ManagementFactory.getMemoryPoolMXBeans()
> # deployment is redeployed 100 times
> # calls System.gc() via EJP call again and checks heap usage again via EJB call and compares the results
> Size of the extra heap in use is about 25MB plus when compared to the initial size.
> I tried to check manually via [visualVM|https://visualvm.github.io/] tool. You can create a heapdump at the beginning of the test and at the end of the test. Then compare them easily and check the differences. Using a filter I can see quite a huge increase of instances of the {{org.jboss.modules.*}} classes. However, biggest memory footprint is huge increase of the instances of the {{java.util.HashMap$Node}}, {{char[]}}, {{java.util.HashMap$Node[]}} and few others. I don't see such huge increase of the instances of these classes when I use older build of WildFly prior to the problematic commit. To be honest I don't see direct link with the problematic commit I linked before. As the heapdumps are too big to be attached here, I am attaching some screenshots.
> Also, when microprofile-opentracing-smallrye subsystem is removed via:
> {code}
> /subsystem=microprofile-opentracing-smallrye:remove()
> {code}
> then no more memory leak is detected, after adding the subsystem back, the leak is present again. Thus opentracing is involved somehow into this indeed.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFLY-10832) Determine the primary provider of Singleton Service using CLI
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-10832?page=com.atlassian.jira.plugin... ]
Radoslav Husar updated WFLY-10832:
----------------------------------
Summary: Determine the primary provider of Singleton Service using CLI (was: Determine the primary provider of Singleton Service using CLI.)
> Determine the primary provider of Singleton Service using CLI
> -------------------------------------------------------------
>
> Key: WFLY-10832
> URL: https://issues.jboss.org/browse/WFLY-10832
> Project: WildFly
> Issue Type: Feature Request
> Components: Clustering
> Affects Versions: 13.0.0.Final
> Reporter: Brad Maxwell
> Assignee: Paul Ferraro
>
> Currently we do not expose any run-time metrics/statistics for singleton services , User needs to determine the primary provider of Singleton service and would like a CLI command to do so
> Currently from CLI we can see that the singleton application is deployed on all the instance of the cluster , but not determine from CLI which node/instance is operating as primary provider of Singleton Service , User would like to give to his operations team a way to check that a certain application is in ha singleton among others which can be in just cluster mode.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFLY-10991) Memory leak when deployment is redeployed multiple times
by Juraci Paixão Kröhling (JIRA)
[ https://issues.jboss.org/browse/WFLY-10991?page=com.atlassian.jira.plugin... ]
Juraci Paixão Kröhling commented on WFLY-10991:
-----------------------------------------------
I was able to run the test and it seems it passes when the fix is applied:
{code}
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.088 s - in org.jboss.qa.management.web.UndeployMemoryLeakIT
...
[INFO] jbossqe-eap-tests-management-parent ................ SUCCESS [ 0.217 s]
[INFO] jbossqe-eap-tests-management-common ................ SUCCESS [ 8.609 s]
[INFO] jbossqe-eap-tests-management-integration-tests ..... SUCCESS [02:28 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:37 min
{code}
Without this fix, I get:
{code}
[ERROR] UndeployMemoryLeakIT.undeployWithELTest:105 There was an increase in used heap size of 26521296 bytes. There is probably a leak, investigate. This might be caused by https://issues.jboss.org/browse/JBEAP-14901
{code}
> Memory leak when deployment is redeployed multiple times
> --------------------------------------------------------
>
> Key: WFLY-10991
> URL: https://issues.jboss.org/browse/WFLY-10991
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Affects Versions: 14.0.0.Beta2
> Reporter: Jan Stourac
> Assignee: Juraci Paixão Kröhling
> Priority: Blocker
> Attachments: memoryLeaks.war, problematic-wf-build-heap-diff-start-end-org-filter.png, problematic-wf-build-heap-diff-start-end.png, sane-wf-build-heap-diff-start-end-org-filter.png, sane-wf-build-heap-diff-start-end.png
>
>
> It looks like redeploying attached deployment [^memoryLeaks.war] multiple times (our automated test does it 100 times), there seems to be some memory leak in the WildFly. Using git bisect, the commit that started to fail is [651dc8a2f0d4ccad6a35f7b1d28626b43ebb2a5d in WildFly repository|https://github.com/wildfly/wildfly/commits/651dc8a2f0d4ccad6a3...]. That is why I selected MP OpenTracing component for this issue. Actual testing deployment is very simple and contains just some jsp file with some EJB classes that are used to call GC and check current heap usage.
> Brief description of the test:
> # attached deployment is deployed
> # System.gc() is called via EJB call
> # it checks initial heap usage at the beginning of the test via EJB call that checks all instances of ManagementFactory.getMemoryPoolMXBeans()
> # deployment is redeployed 100 times
> # calls System.gc() via EJP call again and checks heap usage again via EJB call and compares the results
> Size of the extra heap in use is about 25MB plus when compared to the initial size.
> I tried to check manually via [visualVM|https://visualvm.github.io/] tool. You can create a heapdump at the beginning of the test and at the end of the test. Then compare them easily and check the differences. Using a filter I can see quite a huge increase of instances of the {{org.jboss.modules.*}} classes. However, biggest memory footprint is huge increase of the instances of the {{java.util.HashMap$Node}}, {{char[]}}, {{java.util.HashMap$Node[]}} and few others. I don't see such huge increase of the instances of these classes when I use older build of WildFly prior to the problematic commit. To be honest I don't see direct link with the problematic commit I linked before. As the heapdumps are too big to be attached here, I am attaching some screenshots.
> Also, when microprofile-opentracing-smallrye subsystem is removed via:
> {code}
> /subsystem=microprofile-opentracing-smallrye:remove()
> {code}
> then no more memory leak is detected, after adding the subsystem back, the leak is present again. Thus opentracing is involved somehow into this indeed.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (DROOLS-2982) Create backend methods to pair with "duplicate row"
by Gabriele Cardosi (JIRA)
Gabriele Cardosi created DROOLS-2982:
----------------------------------------
Summary: Create backend methods to pair with "duplicate row"
Key: DROOLS-2982
URL: https://issues.jboss.org/browse/DROOLS-2982
Project: Drools
Issue Type: Task
Components: Scenario Simulation and Testing
Reporter: Gabriele Cardosi
Assignee: Daniele Zonca
Create a Simulation.insertScenario(Scenario, index) to insert a given Scenario at a specific index.
Create Scenario.clone method to have a new Scenario instance with same values of original one.
Check Scenario hashCode/equals methods so that SCENARIO_INSTANCE.equals(SCENARIO_INSTANCE.clone) = false
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (WFLY-10991) Memory leak when deployment is redeployed multiple times
by Juraci Paixão Kröhling (JIRA)
[ https://issues.jboss.org/browse/WFLY-10991?page=com.atlassian.jira.plugin... ]
Juraci Paixão Kröhling commented on WFLY-10991:
-----------------------------------------------
[~jstourac], are you getting 25MB extra for each deployment, or 25 MB after 100 re-deployments? I submitted a PR that solves a memory leak that I could find, but this is probably not the right fix if we are talking about 25 MB per deployment.
https://github.com/wildfly/wildfly/pull/11654
> Memory leak when deployment is redeployed multiple times
> --------------------------------------------------------
>
> Key: WFLY-10991
> URL: https://issues.jboss.org/browse/WFLY-10991
> Project: WildFly
> Issue Type: Bug
> Components: MP OpenTracing
> Affects Versions: 14.0.0.Beta2
> Reporter: Jan Stourac
> Assignee: Juraci Paixão Kröhling
> Priority: Blocker
> Attachments: memoryLeaks.war, problematic-wf-build-heap-diff-start-end-org-filter.png, problematic-wf-build-heap-diff-start-end.png, sane-wf-build-heap-diff-start-end-org-filter.png, sane-wf-build-heap-diff-start-end.png
>
>
> It looks like redeploying attached deployment [^memoryLeaks.war] multiple times (our automated test does it 100 times), there seems to be some memory leak in the WildFly. Using git bisect, the commit that started to fail is [651dc8a2f0d4ccad6a35f7b1d28626b43ebb2a5d in WildFly repository|https://github.com/wildfly/wildfly/commits/651dc8a2f0d4ccad6a3...]. That is why I selected MP OpenTracing component for this issue. Actual testing deployment is very simple and contains just some jsp file with some EJB classes that are used to call GC and check current heap usage.
> Brief description of the test:
> # attached deployment is deployed
> # System.gc() is called via EJB call
> # it checks initial heap usage at the beginning of the test via EJB call that checks all instances of ManagementFactory.getMemoryPoolMXBeans()
> # deployment is redeployed 100 times
> # calls System.gc() via EJP call again and checks heap usage again via EJB call and compares the results
> Size of the extra heap in use is about 25MB plus when compared to the initial size.
> I tried to check manually via [visualVM|https://visualvm.github.io/] tool. You can create a heapdump at the beginning of the test and at the end of the test. Then compare them easily and check the differences. Using a filter I can see quite a huge increase of instances of the {{org.jboss.modules.*}} classes. However, biggest memory footprint is huge increase of the instances of the {{java.util.HashMap$Node}}, {{char[]}}, {{java.util.HashMap$Node[]}} and few others. I don't see such huge increase of the instances of these classes when I use older build of WildFly prior to the problematic commit. To be honest I don't see direct link with the problematic commit I linked before. As the heapdumps are too big to be attached here, I am attaching some screenshots.
> Also, when microprofile-opentracing-smallrye subsystem is removed via:
> {code}
> /subsystem=microprofile-opentracing-smallrye:remove()
> {code}
> then no more memory leak is detected, after adding the subsystem back, the leak is present again. Thus opentracing is involved somehow into this indeed.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months