[JBoss JIRA] (DROOLS-3373) [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
by Brian Dellascio (Jira)
[ https://issues.jboss.org/browse/DROOLS-3373?page=com.atlassian.jira.plugi... ]
Brian Dellascio edited comment on DROOLS-3373 at 1/11/19 10:51 AM:
-------------------------------------------------------------------
[~manstis] Thanks for posting. It looks like the text inside the top half of the decision service node on the canvas is under the outline of the node? Also, is the outline of this node representative of the other nodes in this canvas? If so, it feels a bit heavy to me. It could probably be about 50% - 70% thinner. What is the outline currently set to?
was (Author: bdellasc):
[~manstis] It looks like the text inside the top half of the decision service node on the canvas is under the outline of the node? Also, is the outline of this node representative of the other nodes in this canvas? If so, it feels a bit heavy to me. It could probably be about 50% - 70% thinner. What is the outline currently set to?
> [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
> ----------------------------------------------------------------------------
>
> Key: DROOLS-3373
> URL: https://issues.jboss.org/browse/DROOLS-3373
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: VisualDesign, drools-tools, ux_needed, visualdesign
> Attachments: DMN_palette_icons.png, DecisionService-insitu.png, Screenshot from 2019-01-11 12-37-52.png, decision-service.svg, decision.svg, decision_palette.svg, decision_service_expanded_palette.svg, decision_service_palette.svg
>
>
> We need a new "Palette" icon and Canvas shape for "Decision Services".
> See Table 1: DRD components in the [DMN 1.2 Specification|https://www.omg.org/spec/DMN/1.2/Beta1/PDF].
> See also 6.2.5 Decision service for some narrative regarding the shape.
> {quote}
> A Decision Service is represented in a DRD as rectangle with rounded corners, drawn with a heavy solid border.... the Decision Service SHALL be divided into two parts with a straight solid line.
> {quote}
> We are currently adding support for the _expanded_ form however we will also require (at some stage) a Palette glyph/icon and Canvas shape for the _collapsed_ form too.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3373) [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
by Brian Dellascio (Jira)
[ https://issues.jboss.org/browse/DROOLS-3373?page=com.atlassian.jira.plugi... ]
Brian Dellascio commented on DROOLS-3373:
-----------------------------------------
[~manstis] It looks like the text inside the top half of the decision service node on the canvas is under the outline of the node? Also, is the outline of this node representative of the other nodes in this canvas? If so, it feels a bit heavy to me. It could probably be about 50% - 70% thinner. What is the outline currently set to?
> [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
> ----------------------------------------------------------------------------
>
> Key: DROOLS-3373
> URL: https://issues.jboss.org/browse/DROOLS-3373
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: VisualDesign, drools-tools, ux_needed, visualdesign
> Attachments: DMN_palette_icons.png, DecisionService-insitu.png, Screenshot from 2019-01-11 12-37-52.png, decision-service.svg, decision.svg, decision_palette.svg, decision_service_expanded_palette.svg, decision_service_palette.svg
>
>
> We need a new "Palette" icon and Canvas shape for "Decision Services".
> See Table 1: DRD components in the [DMN 1.2 Specification|https://www.omg.org/spec/DMN/1.2/Beta1/PDF].
> See also 6.2.5 Decision service for some narrative regarding the shape.
> {quote}
> A Decision Service is represented in a DRD as rectangle with rounded corners, drawn with a heavy solid border.... the Decision Service SHALL be divided into two parts with a straight solid line.
> {quote}
> We are currently adding support for the _expanded_ form however we will also require (at some stage) a Palette glyph/icon and Canvas shape for the _collapsed_ form too.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1791) ConditionInspectors for guided DT editor don't do checks for all allowed operators
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1791?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1791:
---------------------------------
Labels: reported-by-qe verifier (was: reported-by-qe)
> ConditionInspectors for guided DT editor don't do checks for all allowed operators
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-1791
> URL: https://issues.jboss.org/browse/DROOLS-1791
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Minor
> Labels: reported-by-qe, verifier
>
> For String fields, guided DT editor allows the following operators:
> ==, !=, <, >, <=, >=, matches, soundslike, == null, != null, in, not in
> StringConditionInspector pretty much only checks if the operator is ==, != or 'in'.
> This means that some issues won't be detected (Validation and Verification for Decision Tables). E.g. for rules/conditions like 'str > "a"' and 'str > "c"', the subsumption won't be detected (but a fact instance with str == "x" will fire both rules).
> ComparableConditionInspector checks for ==, !=, <, >, <=, >= ops, but:
> for Dates, guided DT editor allows:
> ==, !=, <, >, <=, >=, == null, != null, in, not in, after, before, coincides
> for numerical types, guided DT editor allows:
> ==, !=, <, >, <=, >=, == null, != null, in, not in
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1800) Verification & Validation: Subsumption not picked up correctly
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1800?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1800:
---------------------------------
Labels: verifier (was: )
> Verification & Validation: Subsumption not picked up correctly
> --------------------------------------------------------------
>
> Key: DROOLS-1800
> URL: https://issues.jboss.org/browse/DROOLS-1800
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
> Labels: verifier
>
> Example 1
> Rule1: when (attr1 == 'value11' , att2 == 'value22') then <something>
> Rule2: when (attr1 == 'value11' , att2 == 'value22') then <something>
> it will throw an error saying conflicting rules but when we have a attr like age where we want to match minAge and maxAge it dosen't detect a conflict properly.
> Example 2
> Rule1: when (minAge > '18' , maxAge < '50') then <something>
> Rule2: when (minAge > '25' , maxAge < '35') then <something>
> In the above example 2 age 30 will match both the rules but there is no conflict detected
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1797) Incorrect V&V results when operator is filled in the row (as opposed to column definition)
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1797?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1797:
---------------------------------
Labels: verifier (was: )
> Incorrect V&V results when operator is filled in the row (as opposed to column definition)
> ------------------------------------------------------------------------------------------
>
> Key: DROOLS-1797
> URL: https://issues.jboss.org/browse/DROOLS-1797
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Affects Versions: 6.4.0.Final
> Reporter: Anton Giertli
> Assignee: Toni Rikkola
> Priority: Major
> Labels: verifier
> Attachments: 6iOx.png
>
>
> Imagine data model Person with attribute age.
> If you create decision table and add two columns:
> - both are defined against "age" attribute
> - none of them have operator defined
> then you add one row, and you fill in the operator and the value directly inside the row.
> For example:
> >= 20
> <= 30
> The generated DRL looks like this:
> {code:java}
> package org;
> //from row number: 1
> rule "Row 1 AnotherTest"
> dialect "mvel"
> when
> p : Person( age >= 20 , age <= 30 )
> then
> p.setAgeGroup( "whatever" );
> end
> {code}
> The V&V will report this as conflicting row:
> !6iOx.png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1794) GDTable V&V reporting not working with numeric (optional) value lists
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1794?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1794:
---------------------------------
Labels: reported-by-qe verifier (was: reported-by-qe)
> GDTable V&V reporting not working with numeric (optional) value lists
> ---------------------------------------------------------------------
>
> Key: DROOLS-1794
> URL: https://issues.jboss.org/browse/DROOLS-1794
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Major
> Labels: reported-by-qe, verifier
>
> If a column uses (optional) value list to restrict possible _numeric_ values, some issues won't be reported, others are "wonky".
> My guess is the values in the (optional) value list are interpreted as String rather than the correct field type (e.g. int).
> (See 'Steps to Reproduce' for more detailed info.)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1803) single hit status lost
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1803?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1803:
---------------------------------
Labels: verifier (was: )
> single hit status lost
> ----------------------
>
> Key: DROOLS-1803
> URL: https://issues.jboss.org/browse/DROOLS-1803
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Affects Versions: 7.3.0.Final
> Reporter: Vijay Yadav
> Assignee: Toni Rikkola
> Priority: Major
> Labels: verifier
>
> rule "first rule"
> dialect "mvel"
> when
> pl: Player(score>=50)
> then
> //do something
> end
> rule "second rule"
> dialect "mvel"
> when
> pl:Player(score<50, score >=25)
> then
> //do something
> These rule results into "single hit status lost". This means more than one row from this table can fire at the same time and the table no longer has the single hit status.
> while we can see that only one rule can fire. Conditions aren't overlapping.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1807) Verification & Validation: Add three states for running the validation
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1807?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1807:
---------------------------------
Labels: drools-tools verifier (was: drools-tools)
> Verification & Validation: Add three states for running the validation
> -----------------------------------------------------------------------
>
> Key: DROOLS-1807
> URL: https://issues.jboss.org/browse/DROOLS-1807
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Anton Giertli
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools, verifier
>
> The statuses would be managed with system properties and extend the current on/off switch we have.
> It will be possible to change the status for each validation check type. Check types are for example redundancy, range, missing columns.
>
> * Reactive
> The "normal way" you make a change and the verification runs instantly
> * Off
> Verification is disabled
> * On demand
> Verification only runs when requested. Can be useful for large dtables where you for example change every value in a column and just really care about the verification status after all the changes.
> Few ideas to think about:
> # Might be worth it to also store the state per dtable.
> # If V&V runs for over X amount of seconds. Ask if the user wants to change the setting from "Reactive" to "On Demand" for this table.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months