[JBoss JIRA] (DROOLS-4724) [DMN Designer] Do not default to a LiteralExpression when no expression is defined
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4724?page=com.atlassian.jira.plugi... ]
Jozef Marko commented on DROOLS-4724:
-------------------------------------
[~manstis] [~tari_manga] hello, I created very simple DMN model [^m.dmn] where the context enrtry literal expression was added automatically after first close and reopen, however still getting validation error, is it expected?
!Screenshot from 2019-11-29 12-04-18.png|thumbnail!
> [DMN Designer] Do not default to a LiteralExpression when no expression is defined
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-4724
> URL: https://issues.jboss.org/browse/DROOLS-4724
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2019-11-29 12-04-18.png, error.log, image-2019-11-04-19-39-01-113.png, image-2019-11-04-19-40-27-201.png, m.dmn, save-context.webm, screenshot-1.png, screenshot-2.png
>
>
> Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user did not provide an expression for an element.
> However Error message is reported anyway to the user:
> !image-2019-11-04-19-39-01-113.png|thumbnail!
> This also as the (imho undesired) side-effect that if the user was to re-open later that file, instead of a empty element, it would be a blank LiteralExpression
> !image-2019-11-04-19-40-27-201.png|thumbnail!
> so the current behavior is not consistent across re-open of the editor.
> Let's revert this default.
> The DMN Editor on save should +not+ default to a blank LiteralExpression if the user did not provide an expression for the element.
> Once this change is applied from the f/e side, I am happy to be involved in order to assess which of the messages reported by the Validator or the Compiler are causing issue to the WB (if any).
> Currently, the DMN Compiler will throw 1 Warning.
> Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too).
> Currently, the DMN Validator schema check is not reporting any XSD violation.
> h2. Manual acceptance test
> Try to save default / empty
> h3. Business Central
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?) [^error.log] [^save-context.webm]
> - Invocation (?)
> h3. Kogito
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?)
> - Invocation (?)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-4724) [DMN Designer] Do not default to a LiteralExpression when no expression is defined
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4724?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-4724:
--------------------------------
Attachment: m.dmn
> [DMN Designer] Do not default to a LiteralExpression when no expression is defined
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-4724
> URL: https://issues.jboss.org/browse/DROOLS-4724
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2019-11-29 12-04-18.png, error.log, image-2019-11-04-19-39-01-113.png, image-2019-11-04-19-40-27-201.png, m.dmn, save-context.webm, screenshot-1.png, screenshot-2.png
>
>
> Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user did not provide an expression for an element.
> However Error message is reported anyway to the user:
> !image-2019-11-04-19-39-01-113.png|thumbnail!
> This also as the (imho undesired) side-effect that if the user was to re-open later that file, instead of a empty element, it would be a blank LiteralExpression
> !image-2019-11-04-19-40-27-201.png|thumbnail!
> so the current behavior is not consistent across re-open of the editor.
> Let's revert this default.
> The DMN Editor on save should +not+ default to a blank LiteralExpression if the user did not provide an expression for the element.
> Once this change is applied from the f/e side, I am happy to be involved in order to assess which of the messages reported by the Validator or the Compiler are causing issue to the WB (if any).
> Currently, the DMN Compiler will throw 1 Warning.
> Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too).
> Currently, the DMN Validator schema check is not reporting any XSD violation.
> h2. Manual acceptance test
> Try to save default / empty
> h3. Business Central
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?) [^error.log] [^save-context.webm]
> - Invocation (?)
> h3. Kogito
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?)
> - Invocation (?)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-4724) [DMN Designer] Do not default to a LiteralExpression when no expression is defined
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4724?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-4724:
--------------------------------
Attachment: Screenshot from 2019-11-29 12-04-18.png
> [DMN Designer] Do not default to a LiteralExpression when no expression is defined
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-4724
> URL: https://issues.jboss.org/browse/DROOLS-4724
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2019-11-29 12-04-18.png, error.log, image-2019-11-04-19-39-01-113.png, image-2019-11-04-19-40-27-201.png, m.dmn, save-context.webm, screenshot-1.png, screenshot-2.png
>
>
> Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user did not provide an expression for an element.
> However Error message is reported anyway to the user:
> !image-2019-11-04-19-39-01-113.png|thumbnail!
> This also as the (imho undesired) side-effect that if the user was to re-open later that file, instead of a empty element, it would be a blank LiteralExpression
> !image-2019-11-04-19-40-27-201.png|thumbnail!
> so the current behavior is not consistent across re-open of the editor.
> Let's revert this default.
> The DMN Editor on save should +not+ default to a blank LiteralExpression if the user did not provide an expression for the element.
> Once this change is applied from the f/e side, I am happy to be involved in order to assess which of the messages reported by the Validator or the Compiler are causing issue to the WB (if any).
> Currently, the DMN Compiler will throw 1 Warning.
> Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too).
> Currently, the DMN Validator schema check is not reporting any XSD violation.
> h2. Manual acceptance test
> Try to save default / empty
> h3. Business Central
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?) [^error.log] [^save-context.webm]
> - Invocation (?)
> h3. Kogito
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?)
> - Invocation (?)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-4795) [DMN Designer] User is unable to save model when structure is removed
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4795?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-4795:
--------------------------------
Attachment: edit-remove.webm
> [DMN Designer] User is unable to save model when structure is removed
> ---------------------------------------------------------------------
>
> Key: DROOLS-4795
> URL: https://issues.jboss.org/browse/DROOLS-4795
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.31.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2019-11-26 14-45-32.png, edit-and-remove.webm, edit-remove.webm
>
>
> There is scenario causing user is not able to save the DMN file anymore. If is editing some structure field, but he decides in the middle of editing to rmeove whole structure, the save button of the designer remains disabled.
> We should either fix this scenario or drop the *disable save button* feature.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-4762) [DMN Designer] Data Types - Tab index is not working on Data Type rows
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4762?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-4762:
--------------------------------
Attachment: edit-focus.webm
> [DMN Designer] Data Types - Tab index is not working on Data Type rows
> ----------------------------------------------------------------------
>
> Key: DROOLS-4762
> URL: https://issues.jboss.org/browse/DROOLS-4762
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: karreiro
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
> Attachments: constraints-focus.webm, edit-focus.webm
>
>
> There are a couple of keyboard problems related to tab index:
> - When adding or editing a row, you can't tab the focus onto the save/cancel buttons (/)
> - After selecting from the dropdown, the focus jumps back to the text field for some reason (/)
> - The focus ring is not shown on the list toggle (/)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-4762) [DMN Designer] Data Types - Tab index is not working on Data Type rows
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4762?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-4762:
--------------------------------
Attachment: constraints-focus.webm
> [DMN Designer] Data Types - Tab index is not working on Data Type rows
> ----------------------------------------------------------------------
>
> Key: DROOLS-4762
> URL: https://issues.jboss.org/browse/DROOLS-4762
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: karreiro
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
> Attachments: constraints-focus.webm
>
>
> There are a couple of keyboard problems related to tab index:
> - When adding or editing a row, you can't tab the focus onto the save/cancel buttons (/)
> - After selecting from the dropdown, the focus jumps back to the text field for some reason (/)
> - The focus ring is not shown on the list toggle (/)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-4762) [DMN Designer] Data Types - Tab index is not working on Data Type rows
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-4762?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-4762:
--------------------------------
Description:
There are a couple of keyboard problems related to tab index:
- When adding or editing a row, you can't tab the focus onto the save/cancel buttons (/)
- After selecting from the dropdown, the focus jumps back to the text field for some reason (/)
- The focus ring is not shown on the list toggle (/)
was:
There are a couple of keyboard problems related to tab index:
- When adding or editing a row, you can't tab the focus onto the save/cancel buttons
- After selecting from the dropdown, the focus jumps back to the text field for some reason
- The focus ring is not shown on the list toggle
> [DMN Designer] Data Types - Tab index is not working on Data Type rows
> ----------------------------------------------------------------------
>
> Key: DROOLS-4762
> URL: https://issues.jboss.org/browse/DROOLS-4762
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: karreiro
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
>
> There are a couple of keyboard problems related to tab index:
> - When adding or editing a row, you can't tab the focus onto the save/cancel buttons (/)
> - After selecting from the dropdown, the focus jumps back to the text field for some reason (/)
> - The focus ring is not shown on the list toggle (/)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-3957) Make verifier panel use docks
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-3957?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-3957:
--------------------------------
Description:
Pretty sure we had a ticket for this, but could not find it. Here it is.
h3. Acceptance test
On both Firefox and Chrome (/)
- Opening multiple decision tables, switching between them
- Repeated reopening of guided decision table
- Opening other asset that uses docks - scenario, data object
was:
Pretty sure we had a ticket for this, but could not find it. Here it is.
h3. Acceptance test
On both Firefox and Chrome (x)
- Opening multiple decision tables, switching between them
- Repeated reopening of guided decision table
- Opening other asset that uses docks - scenario, data object
> Make verifier panel use docks
> -----------------------------
>
> Key: DROOLS-3957
> URL: https://issues.jboss.org/browse/DROOLS-3957
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools
> Attachments: v&v.webm
>
>
> Pretty sure we had a ticket for this, but could not find it. Here it is.
> h3. Acceptance test
> On both Firefox and Chrome (/)
> - Opening multiple decision tables, switching between them
> - Repeated reopening of guided decision table
> - Opening other asset that uses docks - scenario, data object
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (DROOLS-4825) DMN v1.3 verify DMN13-132 type conversions
by Matteo Mortari (Jira)
[ https://issues.jboss.org/browse/DROOLS-4825?page=com.atlassian.jira.plugi... ]
Matteo Mortari updated DROOLS-4825:
-----------------------------------
Description:
Verify DMN13-132 type conversions are too spread out in Ch 10
This RTF JIRA consolidates implicit type conversions redactions paragraphs on the spec coming from previous releases.
was:
Verify DMN13-132
type conversions are too spread out in Ch 10
> DMN v1.3 verify DMN13-132 type conversions
> ------------------------------------------
>
> Key: DROOLS-4825
> URL: https://issues.jboss.org/browse/DROOLS-4825
> Project: Drools
> Issue Type: Task
> Components: dmn engine
> Reporter: Matteo Mortari
> Assignee: Matteo Mortari
> Priority: Major
>
> Verify DMN13-132 type conversions are too spread out in Ch 10
> This RTF JIRA consolidates implicit type conversions redactions paragraphs on the spec coming from previous releases.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months