[JBoss JIRA] (WFCORE-4674) Custom handlers, formatters and filters cause the server to crash if the log manager is on the boot class path
by James Perkins (Jira)
[ https://issues.redhat.com/browse/WFCORE-4674?page=com.atlassian.jira.plug... ]
James Perkins commented on WFCORE-4674:
---------------------------------------
[~janinko] We need to wait for [~dmlloyd] to cut a new release of JBoss Modules. Then integrate that with the scripts. Once JBoss Modules is released I can start on the integration portion.
> Custom handlers, formatters and filters cause the server to crash if the log manager is on the boot class path
> --------------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-4674
> URL: https://issues.redhat.com/browse/WFCORE-4674
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: James Perkins
> Assignee: James Perkins
> Priority: Critical
> Labels: OpenShift, jdk11
>
> If the log manager is on the boot class path with Java 11, {{-Xbootclasspath/a:jboss-logmanager.jar}}, and a custom handler, formatter or filter is used the server will fail to boot as the log manager can't see the types in jboss-modules. This seems due to the fact that the log manager is on the boot class path and jboss-modules is on the system class path.
> Example exception:
> {code}
> Failed to read or configure the org.jboss.logmanager.LogManager
> java.lang.IllegalArgumentException: Failed to load module "org.jboss.logmanager" for formatter "JSON"
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:65)
> at org.jboss.logmanager.config.FormatterConfigurationImpl.<init>(FormatterConfigurationImpl.java:30)
> at org.jboss.logmanager.config.LogContextConfigurationImpl.addFormatterConfiguration(LogContextConfigurationImpl.java:172)
> at org.jboss.logmanager.PropertyConfigurator.configureFormatter(PropertyConfigurator.java:631)
> at org.jboss.logmanager.PropertyConfigurator.configureHandler(PropertyConfigurator.java:701)
> at org.jboss.logmanager.PropertyConfigurator.configureLogger(PropertyConfigurator.java:583)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:521)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:97)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:170)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:132)
> at java.util.logging.LogManager$3.run(LogManager.java:399)
> at java.util.logging.LogManager$3.run(LogManager.java:396)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.readPrimordialConfiguration(LogManager.java:396)
> at java.util.logging.LogManager.access$800(LogManager.java:145)
> at java.util.logging.LogManager$2.run(LogManager.java:345)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.ensureLogManagerInitialized(LogManager.java:338)
> at java.util.logging.LogManager.getLogManager(LogManager.java:378)
> at org.jboss.modules.Main.main(Main.java:523)
> Caused by: java.lang.NoClassDefFoundError: org/jboss/modules/ModuleLoader
> at org.jboss.logmanager.config.AbstractPropertyConfiguration$ModuleFinder.getClassLoader(AbstractPropertyConfiguration.java:556)
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:63)
> ... 19 more
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 7 months
[JBoss JIRA] (DROOLS-4845) Fix error-popover position on simulation/model grids
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4845?page=com.atlassian.jira.plug... ]
Gabriele Cardosi edited comment on DROOLS-4845 at 12/5/19 10:49 AM:
--------------------------------------------------------------------
[~yamer]
This is the snippet
{code:java}
/* It determines if the popover should be draw on the RIGHT or in the LEFT of the cell */
if (xPosition + POPOVER_WIDTH > scenarioGrid.getLayer().getWidth()) {
xPosition = (int) cellXYMiddleCoordinates.getX() - xMiddleWidth;
position = PopoverView.Position.LEFT;
}
{code}
Error could be related to
1) {code:java}scenarioGrid.getLayer().getWidth(){code} - maybe it is not the correct "container" to consider
2) not considering {code:java}int scrollX = scenarioGridPanel.getScrollPanel().getElement().getScrollLeft();{code} in the `if` evaluation
3) both/any
was (Author: gabriolo):
[~yamer]
This is the snippet
{code:java}
/* It determines if the popover should be draw on the RIGHT or in the LEFT of the cell */
if (xPosition + POPOVER_WIDTH > scenarioGrid.getLayer().getWidth()) {
xPosition = (int) cellXYMiddleCoordinates.getX() - xMiddleWidth;
position = PopoverView.Position.LEFT;
}
{code}
Error could be related to
1) `scenarioGrid.getLayer().getWidth()` - maybe it is not the correct "container" to consider
2) not considering ` int scrollX = scenarioGridPanel.getScrollPanel().getElement().getScrollLeft();` in the `if` evaluation
3) both/any
> Fix error-popover position on simulation/model grids
> ----------------------------------------------------
>
> Key: DROOLS-4845
> URL: https://issues.redhat.com/browse/DROOLS-4845
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Jozef Marko
> Assignee: Yeser Amer
> Priority: Major
>
> The issue was found during DROOLS-4767 review. There we fixed position of error popup to have ordering "RIGHT -> LEFT -> ABOVE". However this ordering doesn't work on the main Model tab if your resize the properties panel/docks at right site.
> For more details see the [github comment|https://github.com/kiegroup/drools-wb/pull/1271#pullrequestreview...].
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 7 months
[JBoss JIRA] (DROOLS-4845) Fix error-popover position on simulation/model grids
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4845?page=com.atlassian.jira.plug... ]
Gabriele Cardosi edited comment on DROOLS-4845 at 12/5/19 10:48 AM:
--------------------------------------------------------------------
[~yamer]
This is the snippet
{code:java}
/* It determines if the popover should be draw on the RIGHT or in the LEFT of the cell */
if (xPosition + POPOVER_WIDTH > scenarioGrid.getLayer().getWidth()) {
xPosition = (int) cellXYMiddleCoordinates.getX() - xMiddleWidth;
position = PopoverView.Position.LEFT;
}
{code}
Error could be related to
1) `scenarioGrid.getLayer().getWidth()` - maybe it is not the correct "container" to consider
2) not considering ` int scrollX = scenarioGridPanel.getScrollPanel().getElement().getScrollLeft();` in the `if` evaluation
3) both/any
was (Author: gabriolo):
[~yamer]
This is the snippet
```/* It determines if the popover should be draw on the RIGHT or in the LEFT of the cell */
if (xPosition + POPOVER_WIDTH > scenarioGrid.getLayer().getWidth()) {
xPosition = (int) cellXYMiddleCoordinates.getX() - xMiddleWidth;
position = PopoverView.Position.LEFT;
}```
Error could be related to
1) `scenarioGrid.getLayer().getWidth()` - maybe it is not the correct "container" to consider
2) not considering ` int scrollX = scenarioGridPanel.getScrollPanel().getElement().getScrollLeft();` in the `if` evaluation
3) both/any
> Fix error-popover position on simulation/model grids
> ----------------------------------------------------
>
> Key: DROOLS-4845
> URL: https://issues.redhat.com/browse/DROOLS-4845
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Jozef Marko
> Assignee: Yeser Amer
> Priority: Major
>
> The issue was found during DROOLS-4767 review. There we fixed position of error popup to have ordering "RIGHT -> LEFT -> ABOVE". However this ordering doesn't work on the main Model tab if your resize the properties panel/docks at right site.
> For more details see the [github comment|https://github.com/kiegroup/drools-wb/pull/1271#pullrequestreview...].
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 7 months
[JBoss JIRA] (DROOLS-4845) Fix error-popover position on simulation/model grids
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4845?page=com.atlassian.jira.plug... ]
Gabriele Cardosi commented on DROOLS-4845:
------------------------------------------
[~yamer]
This is the snippet
```/* It determines if the popover should be draw on the RIGHT or in the LEFT of the cell */
if (xPosition + POPOVER_WIDTH > scenarioGrid.getLayer().getWidth()) {
xPosition = (int) cellXYMiddleCoordinates.getX() - xMiddleWidth;
position = PopoverView.Position.LEFT;
}```
Error could be related to
1) `scenarioGrid.getLayer().getWidth()` - maybe it is not the correct "container" to consider
2) not considering ` int scrollX = scenarioGridPanel.getScrollPanel().getElement().getScrollLeft();` in the `if` evaluation
3) both/any
> Fix error-popover position on simulation/model grids
> ----------------------------------------------------
>
> Key: DROOLS-4845
> URL: https://issues.redhat.com/browse/DROOLS-4845
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Jozef Marko
> Assignee: Yeser Amer
> Priority: Major
>
> The issue was found during DROOLS-4767 review. There we fixed position of error popup to have ordering "RIGHT -> LEFT -> ABOVE". However this ordering doesn't work on the main Model tab if your resize the properties panel/docks at right site.
> For more details see the [github comment|https://github.com/kiegroup/drools-wb/pull/1271#pullrequestreview...].
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 7 months
[JBoss JIRA] (DROOLS-4845) Fix error-popover position on simulation/model grids
by Jozef Marko (Jira)
Jozef Marko created DROOLS-4845:
-----------------------------------
Summary: Fix error-popover position on simulation/model grids
Key: DROOLS-4845
URL: https://issues.redhat.com/browse/DROOLS-4845
Project: Drools
Issue Type: Bug
Components: Scenario Simulation and Testing
Reporter: Jozef Marko
Assignee: Gabriele Cardosi
When there is only one column on the grid, the popover is show to the left. But if there is not enough space to the left, the popover is not visible.
Proposed solution, for this situation, is to show the popover _above_ the cell.
The final position preference order will be (respect the cell):
RIGHT -> LEFT -> ABOVE
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 7 months
[JBoss JIRA] (DROOLS-4845) Fix error-popover position on simulation/model grids
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-4845?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-4845:
--------------------------------
Steps to Reproduce: (was: Create a background grid with only one column.
Populate it with an invalid value (ex. map the column to Number and fill the cell with a string)
Execute the Run
The popover will be shown to the left of the cell but it would be barely visible)
> Fix error-popover position on simulation/model grids
> ----------------------------------------------------
>
> Key: DROOLS-4845
> URL: https://issues.redhat.com/browse/DROOLS-4845
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Reporter: Jozef Marko
> Assignee: Gabriele Cardosi
> Priority: Major
>
> When there is only one column on the grid, the popover is show to the left. But if there is not enough space to the left, the popover is not visible.
> Proposed solution, for this situation, is to show the popover _above_ the cell.
> The final position preference order will be (respect the cell):
> RIGHT -> LEFT -> ABOVE
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 7 months