[JBoss JIRA] (LOGMGR-263) Static Logger Lookup is much slower as with JDK 8
by James Perkins (Jira)
[ https://issues.jboss.org/browse/LOGMGR-263?page=com.atlassian.jira.plugin... ]
James Perkins commented on LOGMGR-263:
--------------------------------------
A static logger should have much better performance as the call stack would only be walked when the logger is initialized. I had also thought that the Java 9+ {{StackWalker}} was supposed to have better performance, but maybe not :).
Anyway so you're saying by removing the {{static}} keyword the performance is better?
> Static Logger Lookup is much slower as with JDK 8
> -------------------------------------------------
>
> Key: LOGMGR-263
> URL: https://issues.jboss.org/browse/LOGMGR-263
> Project: JBoss Log Manager
> Issue Type: Bug
> Environment: WildFly 17, OpenJDK 11
> Reporter: Andreas Liebscher
> Priority: Major
> Attachments: grafik1570016303722 (1).png, grafik1570016303722.png, grafik1570016791285.png
>
>
> During upgrading a Java EE application from WildFly 13 with JDK 8 to WildFly 17 with JDK 11 we had a serious performance issue. We identified the usage of the logging framework SLF4J with the pattern `static Logger log = LoggerFactory.getLogger(StatusChangeValidatorFactory.class)` was the reason when a lot of calls to `getLogger` occur in parallel. As workaround we removed `static` from some code hotspots to get back the performance we were used to. Also WildFly 13 with JDK 8 got a performance improvement with the removed `static` keyword.
> Please check the VisualVM output as prove of JDKSpecific got slower:
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4838) Create common producer for tests
by Gabriele Cardosi (Jira)
Gabriele Cardosi created DROOLS-4838:
----------------------------------------
Summary: Create common producer for tests
Key: DROOLS-4838
URL: https://issues.jboss.org/browse/DROOLS-4838
Project: Drools
Issue Type: Task
Components: Scenario Simulation and Testing
Reporter: Gabriele Cardosi
Assignee: Gabriele Cardosi
Inside the tests there is a whole bunch of mocked objects that are used in multiple places (especially the ones related to grid/cell/rendering stuff).
Scope of this ticket shuold be to put all of them inside a static producer; this would also reduce the needs for abstract/inheritance chains, simplifying the test environment
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4837) Abstract reflective accesses from RuleUnitDescription
by Edoardo Vacchi (Jira)
Edoardo Vacchi created DROOLS-4837:
--------------------------------------
Summary: Abstract reflective accesses from RuleUnitDescription
Key: DROOLS-4837
URL: https://issues.jboss.org/browse/DROOLS-4837
Project: Drools
Issue Type: Feature Request
Reporter: Edoardo Vacchi
Assignee: Edoardo Vacchi
RuleUnitDescription interface returns `Method`s; in Kogito we need a way to abstract over class definitions so that a RuleUnit can be materialized at later stages of the compilation process.
with this JIRA, we introduce an abstraction over RuleUnitDescription, so that different implementations can be provided. The default implementation is reflective (uses Methods), but a non-reflective implementation will be allowed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-12849) File upload (multipart) with Picketlink fails with sizes over 20k (using Apache Commons FileUpload)
by Bartosz Spyrko (Jira)
[ https://issues.jboss.org/browse/WFLY-12849?page=com.atlassian.jira.plugin... ]
Bartosz Spyrko updated WFLY-12849:
----------------------------------
Labels: downstream_dependency (was: )
> File upload (multipart) with Picketlink fails with sizes over 20k (using Apache Commons FileUpload)
> ---------------------------------------------------------------------------------------------------
>
> Key: WFLY-12849
> URL: https://issues.jboss.org/browse/WFLY-12849
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Bartosz Spyrko
> Assignee: Bartosz Spyrko
> Priority: Critical
> Labels: downstream_dependency
>
> This is a followup to JBEAP-17829 - WFLY-12705 - File upload fails with IllegalStateException when PicketLink SSO is enabled
> The patch resolved a portion of the file upload issues, but uploads over a certain size fail (appears to be ~20k but I don't have a precise number).
> This issue occurs only with picketlink security and doing file uploads
> The reproducer shows that the request class differs between successful uploads and unsuccessful uploads:
> Successful calls use SPFormAuthenticationRequestWrapper:
> [cdolphy@styx jboss-eap-7.2]$ 10:52:41,761 INFO [stdout] (default task-2) Class of Request - org.picketlink.identity.federation.bindings.wildfly.sp.SPFormAuthenticationRequestWrapper
> 10:52:41,764 INFO [stdout] (default task-2) item is name=jboss-fileupload-swallowed-exception.txt, StoreLocation=/home/cdolphy/gss/cases/02523510/jboss-eap-7.2/standalone/tmp/reproducer.war/upload_3c1122fc_16ea378ffdc__8000_00000003.tmp, size=9449bytes, isFormField=false, FieldName=fileupload
> But unsuccessful requests use HttpServletRequestImpl:
> 10:53:02,818 INFO [stdout] (default task-2) Class of Request - io.undertow.servlet.spec.HttpServletRequestImpl
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-12849) File upload (multipart) with Picketlink fails with sizes over 20k (using Apache Commons FileUpload)
by Bartosz Spyrko (Jira)
[ https://issues.jboss.org/browse/WFLY-12849?page=com.atlassian.jira.plugin... ]
Bartosz Spyrko moved JBEAP-18218 to WFLY-12849:
-----------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-12849 (was: JBEAP-18218)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Security
(was: Security)
Affects Version/s: (was: 7.3.0.GA)
QE Test Coverage: (was: +)
Fix Version/s: (was: 7.3.1.GA)
> File upload (multipart) with Picketlink fails with sizes over 20k (using Apache Commons FileUpload)
> ---------------------------------------------------------------------------------------------------
>
> Key: WFLY-12849
> URL: https://issues.jboss.org/browse/WFLY-12849
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Bartosz Spyrko
> Assignee: Bartosz Spyrko
> Priority: Critical
>
> This is a followup to JBEAP-17829 - WFLY-12705 - File upload fails with IllegalStateException when PicketLink SSO is enabled
> The patch resolved a portion of the file upload issues, but uploads over a certain size fail (appears to be ~20k but I don't have a precise number).
> This issue occurs only with picketlink security and doing file uploads
> The reproducer shows that the request class differs between successful uploads and unsuccessful uploads:
> Successful calls use SPFormAuthenticationRequestWrapper:
> [cdolphy@styx jboss-eap-7.2]$ 10:52:41,761 INFO [stdout] (default task-2) Class of Request - org.picketlink.identity.federation.bindings.wildfly.sp.SPFormAuthenticationRequestWrapper
> 10:52:41,764 INFO [stdout] (default task-2) item is name=jboss-fileupload-swallowed-exception.txt, StoreLocation=/home/cdolphy/gss/cases/02523510/jboss-eap-7.2/standalone/tmp/reproducer.war/upload_3c1122fc_16ea378ffdc__8000_00000003.tmp, size=9449bytes, isFormField=false, FieldName=fileupload
> But unsuccessful requests use HttpServletRequestImpl:
> 10:53:02,818 INFO [stdout] (default task-2) Class of Request - io.undertow.servlet.spec.HttpServletRequestImpl
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months