[JBoss JIRA] (DROOLS-4724) [DMN Designer] Do not default to a LiteralExpression when no expression is defined
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-4724?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-4724:
----------------------------------------
[~jomarko] PR updated.
> [DMN Designer] Do not default to a LiteralExpression when no expression is defined
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-4724
> URL: https://issues.jboss.org/browse/DROOLS-4724
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2019-11-29 12-04-18.png, error.log, image-2019-11-04-19-39-01-113.png, image-2019-11-04-19-40-27-201.png, m.dmn, save-context.webm, screenshot-1.png, screenshot-2.png
>
>
> Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user did not provide an expression for an element.
> However Error message is reported anyway to the user:
> !image-2019-11-04-19-39-01-113.png|thumbnail!
> This also as the (imho undesired) side-effect that if the user was to re-open later that file, instead of a empty element, it would be a blank LiteralExpression
> !image-2019-11-04-19-40-27-201.png|thumbnail!
> so the current behavior is not consistent across re-open of the editor.
> Let's revert this default.
> The DMN Editor on save should +not+ default to a blank LiteralExpression if the user did not provide an expression for the element.
> Once this change is applied from the f/e side, I am happy to be involved in order to assess which of the messages reported by the Validator or the Compiler are causing issue to the WB (if any).
> Currently, the DMN Compiler will throw 1 Warning.
> Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too).
> Currently, the DMN Validator schema check is not reporting any XSD violation.
> h2. Manual acceptance test
> Try to save default / empty
> h3. Business Central
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?) [^error.log] [^save-context.webm]
> - Invocation (?)
> h3. Kogito
> - Decision node (?)
> - BKM node (?)
> - Cleared Function (?)
> - Context entry (?)
> - Invocation (?)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-11567) Provide way to retrieve VirtualFile instance from url.openConnection()
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFLY-11567?page=com.atlassian.jira.plugin... ]
Richard Opalka resolved WFLY-11567.
-----------------------------------
Resolution: Done
> Provide way to retrieve VirtualFile instance from url.openConnection()
> ----------------------------------------------------------------------
>
> Key: WFLY-11567
> URL: https://issues.jboss.org/browse/WFLY-11567
> Project: WildFly
> Issue Type: Enhancement
> Components: VFS
> Reporter: Tomas Hofman
> Assignee: Tomas Hofman
> Priority: Major
> Fix For: 19.0.0.Beta1
>
>
> It is not possible to obtain VirtualFile (and by extensions it's physicalFile) instance wrapped in VirtualFileURLConnection without using reflection.
> Code snippet from Drools [1], where they try to get hold of {{VirtualFile#getPhysicalFile()}}:
> {code}
> private static Object findVirtualFile( URL url ) throws IOException {
> URLConnection urlConnection = url.openConnection();
> try {
> if ( urlConnection.getClass().getName().equals( "org.jboss.vfs.protocol.VirtualFileURLConnection" ) ) {
> Field f = urlConnection.getClass().getDeclaredField( "file" );
> f.setAccessible( true );
> return f.get( urlConnection );
> }
> } catch (NoSuchFieldException | IllegalAccessException e) {
> // ignored
> }
> return urlConnection.getContent();
> }
> {code}
> [1] https://github.com/kiegroup/drools/commit/2a36f67a29ed06d0f980a60ff1c81fa...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-11567) Provide way to retrieve VirtualFile instance from url.openConnection()
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFLY-11567?page=com.atlassian.jira.plugin... ]
Richard Opalka updated WFLY-11567:
----------------------------------
Component/s: VFS
> Provide way to retrieve VirtualFile instance from url.openConnection()
> ----------------------------------------------------------------------
>
> Key: WFLY-11567
> URL: https://issues.jboss.org/browse/WFLY-11567
> Project: WildFly
> Issue Type: Enhancement
> Components: VFS
> Reporter: Tomas Hofman
> Assignee: Tomas Hofman
> Priority: Major
> Fix For: 19.0.0.Beta1
>
>
> It is not possible to obtain VirtualFile (and by extensions it's physicalFile) instance wrapped in VirtualFileURLConnection without using reflection.
> Code snippet from Drools [1], where they try to get hold of {{VirtualFile#getPhysicalFile()}}:
> {code}
> private static Object findVirtualFile( URL url ) throws IOException {
> URLConnection urlConnection = url.openConnection();
> try {
> if ( urlConnection.getClass().getName().equals( "org.jboss.vfs.protocol.VirtualFileURLConnection" ) ) {
> Field f = urlConnection.getClass().getDeclaredField( "file" );
> f.setAccessible( true );
> return f.get( urlConnection );
> }
> } catch (NoSuchFieldException | IllegalAccessException e) {
> // ignored
> }
> return urlConnection.getContent();
> }
> {code}
> [1] https://github.com/kiegroup/drools/commit/2a36f67a29ed06d0f980a60ff1c81fa...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-11567) Provide way to retrieve VirtualFile instance from url.openConnection()
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFLY-11567?page=com.atlassian.jira.plugin... ]
Richard Opalka updated WFLY-11567:
----------------------------------
Fix Version/s: 19.0.0.Beta1
> Provide way to retrieve VirtualFile instance from url.openConnection()
> ----------------------------------------------------------------------
>
> Key: WFLY-11567
> URL: https://issues.jboss.org/browse/WFLY-11567
> Project: WildFly
> Issue Type: Enhancement
> Reporter: Tomas Hofman
> Assignee: Tomas Hofman
> Priority: Major
> Fix For: 19.0.0.Beta1
>
>
> It is not possible to obtain VirtualFile (and by extensions it's physicalFile) instance wrapped in VirtualFileURLConnection without using reflection.
> Code snippet from Drools [1], where they try to get hold of {{VirtualFile#getPhysicalFile()}}:
> {code}
> private static Object findVirtualFile( URL url ) throws IOException {
> URLConnection urlConnection = url.openConnection();
> try {
> if ( urlConnection.getClass().getName().equals( "org.jboss.vfs.protocol.VirtualFileURLConnection" ) ) {
> Field f = urlConnection.getClass().getDeclaredField( "file" );
> f.setAccessible( true );
> return f.get( urlConnection );
> }
> } catch (NoSuchFieldException | IllegalAccessException e) {
> // ignored
> }
> return urlConnection.getContent();
> }
> {code}
> [1] https://github.com/kiegroup/drools/commit/2a36f67a29ed06d0f980a60ff1c81fa...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-12836) Large allocations in EJBContextImpl#isCallerInRole
by Darran Lofthouse (Jira)
[ https://issues.jboss.org/browse/WFLY-12836?page=com.atlassian.jira.plugin... ]
Darran Lofthouse updated WFLY-12836:
------------------------------------
Component/s: Security
> Large allocations in EJBContextImpl#isCallerInRole
> --------------------------------------------------
>
> Key: WFLY-12836
> URL: https://issues.jboss.org/browse/WFLY-12836
> Project: WildFly
> Issue Type: Bug
> Components: EJB, Security
> Affects Versions: 18.0.1.Final
> Reporter: Philippe Marschall
> Assignee: Cheng Fang
> Priority: Major
> Attachments: elytron_allocations_redacted.PNG
>
>
> In our application we have the need to know the roles of the current user. We would like to do this using Java / Jakarta EE APIs rather than rely on WildFly implementation classes. We do this by iterating over all roles, which we know statically, and calling {{EJBContext#isCallerInRole}} for each one. This seem to be a common technique, see [How to get user roles in a JSP / Servlet|https://stackoverflow.com/questions/344117/how-to-get-user-roles-...].
> That's about 100 roles for us. We were expecting that would be a lookup into a {{HashMap}} or similar with O(1) complexity and almost no allocations.
> This however does not seem to be case as {{EJBContextImpl#isCallerInRole}} seems to do the role mapping for every call. This results in a large amount of allocations. In our case this completely dominates our allocation profile. See attached screenshot from JFR.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4785) DRL applies even if groupflow was not assigned 7.5
by Anna Dupliak (Jira)
[ https://issues.jboss.org/browse/DROOLS-4785?page=com.atlassian.jira.plugi... ]
Anna Dupliak updated DROOLS-4785:
---------------------------------
Affects Version/s: 7.30.0.Final
(was: 7.5.0.Final)
> DRL applies even if groupflow was not assigned 7.5
> --------------------------------------------------
>
> Key: DROOLS-4785
> URL: https://issues.jboss.org/browse/DROOLS-4785
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Affects Versions: 7.30.0.Final
> Reporter: Anna Dupliak
> Assignee: Daniele Zonca
> Priority: Major
>
> *For version 7.5*
> # Given Traffic repo
> # Edit DRL driver status rules
> {code}rule "Status 1: young driver"
> when
> driver: Driver(age <= 18)
> then
> driver.setStatus("young");
> end
> rule "Status 2: young adult driver"
> when
> driver: Driver(age > 18 && < 25)
> then
> driver.setStatus("young adult");
> end
> rule "Status 3: adult driver"
> when
> driver: Driver(age >= 25)
> then
> driver.setStatus("adult");
> end {code}
> # Go to Driver Status Rules Tests.scesim
> # Run the Tests
> Expected : Tests failed bcs the values null expected (no DRL rules are applied)
> Actual: Tests passed rules group was not updated
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months