[JBoss JIRA] (DROOLS-4296) Rewrite parsing of modified properties
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4296?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi commented on DROOLS-4296:
-------------------------------------------
Talked with Luca.
Case A)
{noformat}
{ modify($p) { age = $p.age+1 }; }
{noformat}
with mvel dialect
-> The expression is parsed to an AssignExpr inside a ModifyStatement. AssignExpr.getTarget() returns "age" so we can store such information and skip findModifiedProperties().
Case B)
{noformat}
{ modify($p) { setName($p.getName() + "30"); }
{noformat}
with mvel/java dialect
-> The expression is parsed to an ExpressionStmt inside a ModifyStatement. We cannot get "age" directly from the ExpressionStmt. So we will use findModifiedProperties() later.
Even if we add logic to store modified properties for the case A), we still keep findModifiedProperties() for case B). Also we would need to consider the case where a user mixes the expressions with mvel dialect. e.g.
{noformat}
{ modify($p) { age = $p.age+1, setName($p.getName() + "30"); }
{noformat}
The current implementation of findModifiedProperties() doesn't fully parse the modify block. It iterates MethodCallExpr so I think it's not inefficient. Rather, it's good to have one place to process for all the cases.
https://github.com/kiegroup/drools/blob/master/drools-model/drools-model-...
We concluded that we don't need to refactor it.
> Rewrite parsing of modified properties
> --------------------------------------
>
> Key: DROOLS-4296
> URL: https://issues.redhat.com/browse/DROOLS-4296
> Project: Drools
> Issue Type: Enhancement
> Reporter: Luca Molteni
> Assignee: Toshiya Kobayashi
> Priority: Minor
> Labels: good-first-issue
>
> See Consequence::findModifiedProperties
> Currently modified properties are parsed throughout the consequence, but that information is already present after the preprocessing of the ModifyStatement so it can be simplified a lot.
> This can be forward ported to Kogito also
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4870) Materialize consequences using Drools
by Luca Molteni (Jira)
Luca Molteni created DROOLS-4870:
------------------------------------
Summary: Materialize consequences using Drools
Key: DROOLS-4870
URL: https://issues.redhat.com/browse/DROOLS-4870
Project: Drools
Issue Type: Bug
Reporter: Luca Molteni
Assignee: Luca Molteni
Currently consequences using Drools are not materialized (extracted in a different lambda) because they are capturing, as they use the relative bitmask instance.
We should find a way to pass the bitmask instance to the consequence so that we can materialize them.
This means we should probably not change only the compiler, but also the interpreter of the DSL
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFCORE-4763) interface "any" tag not working as expected
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFCORE-4763?page=com.atlassian.jira.plug... ]
Brian Stansberry commented on WFCORE-4763:
------------------------------------------
Hi [~assylias] The `<any/>` behavior is by design. It's true, using `<any-address/>` is a workaround to achieve what you want, but with the downside of having the socket reachable via other addresses on the host.
I filed https://github.com/wildfly/wildfly/pull/12848 to help clarify this point in the WildFly docs.
> interface "any" tag not working as expected
> -------------------------------------------
>
> Key: WFCORE-4763
> URL: https://issues.redhat.com/browse/WFCORE-4763
> Project: WildFly Core
> Issue Type: Bug
> Components: Management
> Environment: Ubuntu 18.02
> Reporter: Yann Le Tallec
> Priority: Major
>
> The {{<any>}} tag in the {{interface}} configuration of {{standalone.xml}} should accept any connection that matches ANY of the provided rules. This is not the case as demonstrated by the example below.
> This configuration allows to run {{jboss-cli.sh -c}} from the machine where wildfly is running as expected:
> {code:xml}
> <interfaces>
> <interface name="management">
> <any>
> <inet-address value="127.0.0.1"/>
> </any>
> </interface>
> </interfaces>
> {code}
> But if I add another (VALID) IP address inside the any tag, I can't connect any more:
> {code:xml}
> <interfaces>
> <interface name="management">
> <any>
> <inet-address value="127.0.0.1"/>
> <inet-address value="10.20.230.26"/>
> </any>
> </interface>
> </interfaces>
> {code}
> With the latter configuration, {{connect}} fails with the following error:
> {noformat}
> >The controller is not available at localhost:9990: java.net.ConnectException: WFLYPRT0053: Could not connect to remote+http://localhost:9990. The connection failed: WFLYPRT0053: Could not connect to remote+http://localhost:9990. The connection failed: Connection refused
> {noformat}
> Note: to easily reproduce the problem from the cli, starting from a fresh standalone install:
> {code:bash}
> connect
> /interface=management:undefine-attribute(name=inet-address)
> /interface=management:undefine-attribute(name=any)
> /interface=management:write-attribute(name=any,value={inet-address=[127.0.0.1]})
> reload
> /interface=management:write-attribute(name=any,value={inet-address=[127.0.0.1,10.20.230.26]})
> reload
> {code}
> Notes:
> - 10.20.230.26 must be a reachable IP - if I use a random one I can connect normally.
> - if I use {{subnet-match}} I get the same issue
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-12877) Use descriptive error message for duplicate host/context deployments
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-12877?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFLY-12877:
-----------------------------------------
[~khermano] No need to apologize; thanks for looking into it!
> Use descriptive error message for duplicate host/context deployments
> --------------------------------------------------------------------
>
> Key: WFLY-12877
> URL: https://issues.redhat.com/browse/WFLY-12877
> Project: WildFly
> Issue Type: Enhancement
> Components: Web (Undertow)
> Reporter: Paul Ferraro
> Assignee: Katarina Hermanova
> Priority: Minor
>
> If a user attempts to deploy a web application to a host/context to which another application is deployed, this will fail for obvious reasons.
> What isn't obvious is the error message. Currently, users will see a DuplicateServiceException. Ideally, the error message should indicate that another application is deployed for the same host and context path.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4695) [DMN Designer] BC DOs as DMN DTs - Show a success message after the import operation
by Daniel José dos Santos (Jira)
[ https://issues.redhat.com/browse/DROOLS-4695?page=com.atlassian.jira.plug... ]
Daniel José dos Santos edited comment on DROOLS-4695 at 12/12/19 3:44 PM:
--------------------------------------------------------------------------
The message was changed to "The Data Object (Java class) was successfully converted to DMN data type and imported." as discussed in GChat.
was (Author: dadossan):
The message was changed to "The Data Object (java class) was successfully imported and converted to DMN data type." as discussed in GChat.
> [DMN Designer] BC DOs as DMN DTs - Show a success message after the import operation
> ------------------------------------------------------------------------------------
>
> Key: DROOLS-4695
> URL: https://issues.redhat.com/browse/DROOLS-4695
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Guilherme Gomes
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
> Attachments: success.png
>
>
> Show the following success message after the import operation:
> !success.png|width=600!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months