[JBoss JIRA] (DROOLS-3678) MVELConcequenceBuilder treats '#' within String incorrectly as a comment at 2nd appearance
by Hiroko Miura (Jira)
[ https://issues.jboss.org/browse/DROOLS-3678?page=com.atlassian.jira.plugi... ]
Hiroko Miura updated DROOLS-3678:
---------------------------------
Component/s: core engine
(was: build)
> MVELConcequenceBuilder treats '#' within String incorrectly as a comment at 2nd appearance
> -------------------------------------------------------------------------------------------
>
> Key: DROOLS-3678
> URL: https://issues.jboss.org/browse/DROOLS-3678
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.14.0.Final
> Environment: RHDM 7.2.0
> dialect mvel
> Reporter: Hiroko Miura
> Assignee: Ant Stephenson
> Priority: Major
>
> The rule below expects that "B#" is set to value of the fact. However, "B;#"(i.e. ';' added before '#") is set incorrectly
> {noformat}
> dialect "mvel"
>
> rule "testRule"
> when
> $fact : Fact();
> then
> $fact.name = "A#";"B#"
> $fact.value = "B#";
> System.out.println( $fact );
> end
> {noformat}
> Here is output.
> {noformat}
> Fact [name=A#, value=B;#]
> {noformat}
> '#' within the value at 2nd appearance is treated as a start of comment.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-3678) MVELConcequenceBuilder treats '#' within String incorrectly as a comment at 2nd appearance
by Hiroko Miura (Jira)
Hiroko Miura created DROOLS-3678:
------------------------------------
Summary: MVELConcequenceBuilder treats '#' within String incorrectly as a comment at 2nd appearance
Key: DROOLS-3678
URL: https://issues.jboss.org/browse/DROOLS-3678
Project: Drools
Issue Type: Bug
Components: build
Affects Versions: 7.14.0.Final
Environment: RHDM 7.2.0
dialect mvel
Reporter: Hiroko Miura
Assignee: Ant Stephenson
The rule below expects that "B#" is set to value of the fact. However, "B;#"(i.e. ';' added before '#") is set incorrectly
{noformat}
dialect "mvel"
rule "testRule"
when
$fact : Fact();
then
$fact.name = "A#";"B#"
$fact.value = "B#";
System.out.println( $fact );
end
{noformat}
Here is output.
{noformat}
Fact [name=A#, value=B;#]
{noformat}
'#' within the value at 2nd appearance is treated as a start of comment.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (WFLY-11678) ManagedExecutorService persists contextClassLoader reference to cause app classloader leaks
by Eduardo Martins (Jira)
[ https://issues.jboss.org/browse/WFLY-11678?page=com.atlassian.jira.plugin... ]
Eduardo Martins commented on WFLY-11678:
----------------------------------------
The issue could be prevented through managed executor service config, but we may enforce that managed threads are never created with app CL in context, and that's the goal of linked PR.
> ManagedExecutorService persists contextClassLoader reference to cause app classloader leaks
> -------------------------------------------------------------------------------------------
>
> Key: WFLY-11678
> URL: https://issues.jboss.org/browse/WFLY-11678
> Project: WildFly
> Issue Type: Bug
> Components: Concurrency Utilities
> Environment: -- EAP 7.1.4
> Reporter: Lei Yu
> Assignee: James Perkins
> Priority: Critical
> Fix For: 16.0.0.CR1
>
>
> managed executor:
> {code}
> <managed-executor-services>
> <managed-executor-service name="default" jndi-name="java:jboss/ee/concurrency/executor/default" context-service="default" hung-task-threshold="60000" keepalive-time="5000"/>
> </managed-executor-services>
> {code}
> With each undeploy, the application classloader is leaked and not released because contextClassLoader references persisted on the executor threads:
> {code}
> Class Name | Ref. Objects | Shallow Heap | Ref. Shallow Heap | Retained Heap
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> org.jboss.as.ee.concurrent.service.ElytronManagedThreadFactory$ElytronManagedThread @ 0xc3677570 EE-ManagedExecutorService-default-Thread-13 Thread| 1 | 160 | 88 | 1,344
> '- contextClassLoader org.jboss.modules.ModuleClassLoader @ 0xc32b9d98 | 1 | 88 | 88 | 366,800
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> {code}
> Tracing with byteman, what's strange is that it sets the app classloader on setup:
> {code}
> Thread.setContextClassLoader: Thread[EE-ManagedExecutorService-default-Thread-16,5,ServerService ThreadGroup] ModuleClassLoader for Module "deployment.services-1.0.4-rc1.war" from Service Module Loader
> java.lang.Thread.setContextClassLoader(Thread.java:1477)
> org.wildfly.security.manager.WildFlySecurityManager.setCurrentContextClassLoaderPrivileged(WildFlySecurityManager.java:1272)
> org.jboss.as.ee.concurrent.handle.ClassLoaderContextHandleFactory$ClassLoaderSetupContextHandle.setup(ClassLoaderContextHandleFactory.java:83)
> org.jboss.as.ee.concurrent.ConcurrentContext$ChainedSetupContextHandle.setup(ConcurrentContext.java:166)
> org.jboss.as.ee.concurrent.DefaultContextSetupProviderImpl.setup(DefaultContextSetupProviderImpl.java:58)
> org.glassfish.enterprise.concurrent.internal.ManagedFutureTask.setupContext(ManagedFutureTask.java:121)
> org.glassfish.enterprise.concurrent.internal.ManagedThreadPoolExecutor.beforeExecute(ManagedThreadPoolExecutor.java:109)
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> java.lang.Thread.run(Thread.java:748)
> {code}
> And still sets that app classloader after task execution in the reset:
> {code}
> Thread.setContextClassLoader: Thread[EE-ManagedExecutorService-default-Thread-16,5,ServerService ThreadGroup] ModuleClassLoader for Module "deployment.services-1.0.4-rc1.war" from Service Module Loader
> java.lang.Thread.setContextClassLoader(Thread.java:1477)
> org.wildfly.security.manager.WildFlySecurityManager.setCurrentContextClassLoaderPrivileged(WildFlySecurityManager.java:1272)
> org.jboss.as.ee.concurrent.handle.ClassLoaderContextHandleFactory$ClassLoaderResetContextHandle.reset(ClassLoaderContextHandleFactory.java:113)
> org.jboss.as.ee.concurrent.ConcurrentContext$ChainedResetContextHandle.reset(ConcurrentContext.java:284)
> org.jboss.as.ee.concurrent.DefaultContextSetupProviderImpl.reset(DefaultContextSetupProviderImpl.java:63)
> org.glassfish.enterprise.concurrent.internal.ManagedFutureTask.resetContext(ManagedFutureTask.java:134)
> org.glassfish.enterprise.concurrent.internal.ManagedThreadPoolExecutor.afterExecute(ManagedThreadPoolExecutor.java:90)
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1157)
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> java.lang.Thread.run(Thread.java:748)
> {code}
> So the thread is sitting in the pool with the app classloader. Is there some way we should be able to get the context loader cleared or unset from the app loader in the reset?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (WFCORE-4346) ChildFirstClassLoader and LegacyKernelServicesInitializer should allow exclusion of resources from the paren
by Brian Stansberry (Jira)
Brian Stansberry created WFCORE-4346:
----------------------------------------
Summary: ChildFirstClassLoader and LegacyKernelServicesInitializer should allow exclusion of resources from the paren
Key: WFCORE-4346
URL: https://issues.jboss.org/browse/WFCORE-4346
Project: WildFly Core
Issue Type: Enhancement
Components: Management, Test Suite
Reporter: Brian Stansberry
Assignee: Jeff Mesnil
ChildFirstClassLoader and LegacyKernelServicesInitializer have hooks to allow tests to prevent classes from being loaded from the parent CL, but there's no way to prevent resources being loaded. In particular META-INF/services files, which bit us with https://github.com/wildfly/wildfly-core/pull/3685 as a META-INF/services file in the parent was being found when trying to load services for an interface in the child CL. The impls in the parent could not implement the child CL version of the interface. Excluding loading of the META-INF/services file in the paren solved the problem.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-3659) DMN: UX for documentation reports
by Tiago Bento (Jira)
[ https://issues.jboss.org/browse/DROOLS-3659?page=com.atlassian.jira.plugi... ]
Tiago Bento commented on DROOLS-3659:
-------------------------------------
[~uxdlc] Did you mean [~tdolphine]? :)
> DMN: UX for documentation reports
> ---------------------------------
>
> Key: DROOLS-3659
> URL: https://issues.jboss.org/browse/DROOLS-3659
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Reporter: Liz Clayton
> Assignee: Liz Clayton
> Priority: Major
> Labels: UX, UXTeam, drools-tools
>
> User stories:
> * As a user I want to generate a PDF or HTML report of the DMN model, with documentation, so that I can hand it off to external team and/or business that needs information about the diagrams and the logic of the decisions being automated. The report can be printed out and used by business teams not involved with the modeling itself, to learn about content of the .dmn file.
> * As a user I need a means through the UI to input additional documentation, links and attachments to nodes.
> Notes:
> - Docs to help with docs formatting.
> - Might be able to leverage Case View docs widget.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-3659) DMN: UX for documentation reports
by Liz Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3659?page=com.atlassian.jira.plugi... ]
Liz Clayton commented on DROOLS-3659:
-------------------------------------
[~roger.martinez][~tfernand] It sounds like we'll be able to use your nice Documentation tab feature for DMN, [~manstis] said that should be possible. :) Just wondering if the label for that tab is open for consideration? [~stetson.robinson] mentioned a concern that it could be confused with other type of documentation (product), and we're wondering about using something like "Export" or "Report" instead, wdyt?
> DMN: UX for documentation reports
> ---------------------------------
>
> Key: DROOLS-3659
> URL: https://issues.jboss.org/browse/DROOLS-3659
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Reporter: Liz Clayton
> Assignee: Liz Clayton
> Priority: Major
> Labels: UX, UXTeam, drools-tools
>
> User stories:
> * As a user I want to generate a PDF or HTML report of the DMN model, with documentation, so that I can hand it off to external team and/or business that needs information about the diagrams and the logic of the decisions being automated. The report can be printed out and used by business teams not involved with the modeling itself, to learn about content of the .dmn file.
> * As a user I need a means through the UI to input additional documentation, links and attachments to nodes.
> Notes:
> - Docs to help with docs formatting.
> - Might be able to leverage Case View docs widget.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-3659) DMN: UX for documentation reports
by Liz Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3659?page=com.atlassian.jira.plugi... ]
Liz Clayton updated DROOLS-3659:
--------------------------------
Story Points: 5
> DMN: UX for documentation reports
> ---------------------------------
>
> Key: DROOLS-3659
> URL: https://issues.jboss.org/browse/DROOLS-3659
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Reporter: Liz Clayton
> Assignee: Liz Clayton
> Priority: Major
> Labels: UX, UXTeam, drools-tools
>
> User stories:
> * As a user I want to generate a PDF or HTML report of the DMN model, with documentation, so that I can hand it off to external team and/or business that needs information about the diagrams and the logic of the decisions being automated. The report can be printed out and used by business teams not involved with the modeling itself, to learn about content of the .dmn file.
> * As a user I need a means through the UI to input additional documentation, links and attachments to nodes.
> Notes:
> - Docs to help with docs formatting.
> - Might be able to leverage Case View docs widget.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-3077) Enhance data type restrictions UX - Decision Table/properties
by Liz Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-3077?page=com.atlassian.jira.plugi... ]
Liz Clayton commented on DROOLS-3077:
-------------------------------------
[~tirelli] I updated the Decision Table input clause constraints flow. The scenario example is if a user has selected a data type that already has constraints assigned and they want to "override" them with one-off constraints for the input clause.
https://redhat.invisionapp.com/share/WJQMEPWBRE9#/348010399_1
If they selected a data type without constraints, we could disable the respective radio button and have the one-off one selected by default.
[~karreiro] mentioned that you were suggesting not showing the Type in the decision table cell. Should I just remove that second line then? Thanks!
> Enhance data type restrictions UX - Decision Table/properties
> -------------------------------------------------------------
>
> Key: DROOLS-3077
> URL: https://issues.jboss.org/browse/DROOLS-3077
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Reporter: Liz Clayton
> Assignee: Liz Clayton
> Priority: Major
> Labels: UX, UXTeam, drools-tools
> Attachments: DataType selection ('Properties Panel' and 'in-grid').png, Screen Shot 2018-08-10 at 10.23.36 AM.png, Screen Shot 2018-08-24 at 8.38.37 AM.png, Screen Shot 2018-09-28 at 2.44.59 PM.png, date-time.png, date.png, enumration-widget.png, pop-overc.png, pop-overcSpecs.png, read-mode.png, select.png, time.png
>
>
> *Background*
> Persona: Business analyst or Rules practitioner
> Use Cases:
> * From the DMN canvas view - as a user I want to define data type restrictions (one-off instances) from a decision table .
> * From the Data Types dialog - as a user I want the ability to define constraints for the following types: https://docs.google.com/spreadsheets/d/1HLYwi5JrCEU6IxWRge7RCKANLiHCL0d2E...
> Functional considerations/ pre conditions:
> * Consider interaction in light of Property panel and consistency.
> * Underscore the notion of one-off constraints.
> Verification conditions:
> * Scrum team and PO review.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-3677) [DMN Designer] Change tabs order
by Guilherme Carreiro (Jira)
Guilherme Carreiro created DROOLS-3677:
------------------------------------------
Summary: [DMN Designer] Change tabs order
Key: DROOLS-3677
URL: https://issues.jboss.org/browse/DROOLS-3677
Project: Drools
Issue Type: Task
Components: DMN Editor
Reporter: Guilherme Carreiro
Assignee: Guilherme Carreiro
Currently the tabs in the DMN editor are being shown like this:
*Model | Overview | Data Types | Included Models*
And the expected result is:
*Model | Data Types | Included Models | Overview*
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months