[JBoss JIRA] (WFLY-11983) Unify line-endings of bat scripts (regression against WF15)
by Marek Kopecky (Jira)
Marek Kopecky created WFLY-11983:
------------------------------------
Summary: Unify line-endings of bat scripts (regression against WF15)
Key: WFLY-11983
URL: https://issues.jboss.org/browse/WFLY-11983
Project: WildFly
Issue Type: Bug
Components: Scripts
Reporter: Marek Kopecky
Line-endings of bat scripts should be unified. This is regression against WF15.
Some files in WF16 uses CRLF, another LF only. We need to clarify the recommended line ending and use this line ending in all Windows scripts.
WF16:
{noformat}
$ find | grep bat$ | xargs file
./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
./jboss-cli.bat: DOS batch file, ASCII text
./elytron-tool.bat: DOS batch file, ASCII text
./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./domain.conf.bat: ASCII text, with CRLF line terminators
./common.bat: DOS batch file, ASCII text, with CRLF line terminators
./jdr.bat: DOS batch file, ASCII text
./jconsole.bat: DOS batch file, ASCII text
./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
./appclient.conf.bat: ASCII text, with CRLF line terminators
./standalone.conf.bat: ASCII text, with CRLF line terminators
./add-user.bat: DOS batch file, ASCII text
$
{noformat}
WF15:
{noformat}
$ find | grep bat$ | xargs file
./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
./jboss-cli.bat: DOS batch file, ASCII text, with CRLF line terminators
./elytron-tool.bat: DOS batch file, ASCII text, with CRLF line terminators
./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
./domain.conf.bat: ASCII text, with CRLF line terminators
./common.bat: DOS batch file, ASCII text, with CRLF line terminators
./jdr.bat: DOS batch file, ASCII text, with CRLF line terminators
./jconsole.bat: DOS batch file, ASCII text, with CRLF line terminators
./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
./appclient.conf.bat: ASCII text, with CRLF line terminators
./standalone.conf.bat: ASCII text, with CRLF line terminators
./add-user.bat: DOS batch file, ASCII text, with CRLF line terminators
$
{noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (WFLY-11983) Unify line-endings of bat scripts (regression against WF15)
by Marek Kopecky (Jira)
[ https://issues.jboss.org/browse/WFLY-11983?page=com.atlassian.jira.plugin... ]
Marek Kopecky reassigned WFLY-11983:
------------------------------------
Assignee: James Perkins
> Unify line-endings of bat scripts (regression against WF15)
> -----------------------------------------------------------
>
> Key: WFLY-11983
> URL: https://issues.jboss.org/browse/WFLY-11983
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Reporter: Marek Kopecky
> Assignee: James Perkins
> Priority: Critical
>
> Line-endings of bat scripts should be unified. This is regression against WF15.
> Some files in WF16 uses CRLF, another LF only. We need to clarify the recommended line ending and use this line ending in all Windows scripts.
> WF16:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat: DOS batch file, ASCII text
> ./elytron-tool.bat: DOS batch file, ASCII text
> ./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat: ASCII text, with CRLF line terminators
> ./common.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat: DOS batch file, ASCII text
> ./jconsole.bat: DOS batch file, ASCII text
> ./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat: ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat: DOS batch file, ASCII text
> $
> {noformat}
> WF15:
> {noformat}
> $ find | grep bat$ | xargs file
> ./wsprovide.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jboss-cli.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./elytron-tool.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./domain.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./wsconsume.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./standalone.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./vault.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./domain.conf.bat: ASCII text, with CRLF line terminators
> ./common.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jdr.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./jconsole.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.bat: DOS batch file, ASCII text, with CRLF line terminators
> ./appclient.conf.bat: ASCII text, with CRLF line terminators
> ./standalone.conf.bat: ASCII text, with CRLF line terminators
> ./add-user.bat: DOS batch file, ASCII text, with CRLF line terminators
> $
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (JGRP-2337) DiagnosticsHandler without reflection
by Bela Ban (Jira)
[ https://issues.jboss.org/browse/JGRP-2337?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2337:
--------------------------------
We may only need 2 additional ProbeHandlers, which are initialized and registered with TP (overwriting previously registered ProbeHandlers) for "jmx" and "op".
If these are initialized in a static initializer, then reflection _can_ be used. For "jmx", the initailization could for example grab all fields of a class annotated with {{@Property}} or {{@ManagedAttribute}} / {{@ManagedOperation}} and generate a {{Supplier<Object>}} lambda and add them to a hashmap.
At run time, the name of the attribute would be looked up and the associated lambda would get invoked.
A simple test is attached (bla.java).
> DiagnosticsHandler without reflection
> -------------------------------------
>
> Key: JGRP-2337
> URL: https://issues.jboss.org/browse/JGRP-2337
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 4.1.0
>
> Attachments: bla.java
>
>
> Probe.sh sends commands to cluster nodes, and they are handled by each node's DiagnosticsHandler. {{"op"}} and {{"jmx"}} commands are handled via reflection.
> However, reflection is not allowed by the GraalVM running in native mode, unless all attributes and methods of all protocols would be listed in a JSON file. This is apparently very costly as the native image builder creates a transitive closure over all classes whose methods and/or fields are listed in the JSON file, and thus includes too many classes in the native image.
> Investigate creating a {{ProbeHandler}} for {{"jmx"}} and {{"op"}} commands, which does not use reflection. 2 alternatives come to mind:
> * Offline creation and compilation: point to a list of protocols for which code is generated (an alternative ProbeHandler class). This class is then instantiated and set in the channel at runtime by the application
> * Point to a running stack. The code uses reflection (obviously this needs to run in non-native mode) to generate the native {{ProbeHandler}} from the list of protocols running in the current stack. This code can then be compiled and used in native image generation.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (JGRP-2337) DiagnosticsHandler without reflection
by Bela Ban (Jira)
[ https://issues.jboss.org/browse/JGRP-2337?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-2337:
---------------------------
Attachment: bla.java
> DiagnosticsHandler without reflection
> -------------------------------------
>
> Key: JGRP-2337
> URL: https://issues.jboss.org/browse/JGRP-2337
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 4.1.0
>
> Attachments: bla.java
>
>
> Probe.sh sends commands to cluster nodes, and they are handled by each node's DiagnosticsHandler. {{"op"}} and {{"jmx"}} commands are handled via reflection.
> However, reflection is not allowed by the GraalVM running in native mode, unless all attributes and methods of all protocols would be listed in a JSON file. This is apparently very costly as the native image builder creates a transitive closure over all classes whose methods and/or fields are listed in the JSON file, and thus includes too many classes in the native image.
> Investigate creating a {{ProbeHandler}} for {{"jmx"}} and {{"op"}} commands, which does not use reflection. 2 alternatives come to mind:
> * Offline creation and compilation: point to a list of protocols for which code is generated (an alternative ProbeHandler class). This class is then instantiated and set in the channel at runtime by the application
> * Point to a running stack. The code uses reflection (obviously this needs to run in non-native mode) to generate the native {{ProbeHandler}} from the list of protocols running in the current stack. This code can then be compiled and used in native image generation.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (WFLY-11213) On release of batch it still contained JDBC statements logged
by Daniel Wehrle (Jira)
[ https://issues.jboss.org/browse/WFLY-11213?page=com.atlassian.jira.plugin... ]
Daniel Wehrle commented on WFLY-11213:
--------------------------------------
Hi [~smarlow],
the info message is still in WF 16.
2019-04-12 09:00:37,609 INFO [org.hibernate.engine.jdbc.batch.internal.AbstractBatchImpl] (default task-172) HHH000010: On release of batch it still contained JDBC statements
See also https://hibernate.atlassian.net/browse/HHH-13307
> On release of batch it still contained JDBC statements logged
> -------------------------------------------------------------
>
> Key: WFLY-11213
> URL: https://issues.jboss.org/browse/WFLY-11213
> Project: WildFly
> Issue Type: Bug
> Components: JPA / Hibernate
> Affects Versions: 14.0.1.Final
> Environment: Java 8_181
> Wildfly 14.0.1.Final
> Reporter: Cody Lerum
> Assignee: Scott Marlow
> Priority: Major
>
> After updating from Wildfly 11 (Hibernate 5.1.10) to Wildfly 14.0.1 (Hibernate 5.3.6) I've started seeing the following log messages
> I’m starting to see the log message
> {code:java}
> 2018-10-17 20:12:47,571 INFO [org.hibernate.engine.jdbc.batch.internal.AbstractBatchImpl] (default task-54) HHH000010: On release of batch it still contained JDBC statements
> 2018-10-17 20:12:47,572 ERROR [org.hibernate.engine.jdbc.batch.internal.AbstractBatchImpl] (default task-54) HHH000352: Unable to release batch statement...
> {code}
> I’ve debugged where that is getting logged and all I can find is a single statement at the time.
> insert into EventLog (entityId, entityType, ipAddress, message, time, user, id) values (?, ?, ?, ?, ?, ?, ?)
> The only insert that is being created is actually being persisted to the database so this may be a spurious message.
> From my early debugging this appears to happen when 1 entity is persisted which does not need an immediate inset (due to having a generated pk) and then in another method of the same transaction an entity is persisted that does need an immediate insert because of a auto increment pk.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (WFLY-11981) CLI not able to read backslash character correctly
by Saurabh Shriramwar (Jira)
[ https://issues.jboss.org/browse/WFLY-11981?page=com.atlassian.jira.plugin... ]
Saurabh Shriramwar updated WFLY-11981:
--------------------------------------
Steps to Reproduce:
* Start CLI and execute
{code:java}
/subsystem=mail/mail-session=default/server=smtp:write-attribute(name=username,value="auth\\SampleUser")
{code}
* /subsystem=mail/mail-session=default/server=smtp:read-attribute(name=username)
{code:java}
{
"outcome" => "success",
"result" => "auth\\SampleUser"
}
{code}
Whereas standalone.xml include the changes properly
{code:java}
<subsystem xmlns="urn:jboss:domain:mail:3.0">
<mail-session name="default" jndi-name="java:jboss/mail/Default">
<smtp-server outbound-socket-binding-ref="mail-smtp" username="auth\SampleUser"/>
</mail-session>
........
{code}
was:
* Start CLI and execute
{code:java}
/subsystem=mail/mail-session=default/server=smtp:write-attribute(name=username,value='auth\\SampleUser')
{code}
* /subsystem=mail/mail-session=default/server=smtp:read-attribute(name=username)
{code:java}
{
"outcome" => "success",
"result" => "auth\\SampleUser"
}
{code}
Whereas standalone.xml include the changes properly
{code:java}
<subsystem xmlns="urn:jboss:domain:mail:3.0">
<mail-session name="default" jndi-name="java:jboss/mail/Default">
<smtp-server outbound-socket-binding-ref="mail-smtp" username="auth\SampleUser"/>
</mail-session>
........
{code}
> CLI not able to read backslash character correctly
> --------------------------------------------------
>
> Key: WFLY-11981
> URL: https://issues.jboss.org/browse/WFLY-11981
> Project: WildFly
> Issue Type: Bug
> Components: CLI
> Affects Versions: 14.0.0.Final
> Reporter: Saurabh Shriramwar
> Priority: Minor
>
> The output for CLI read-attribute operation is confusing and not able to read/interpret backslash characters properly.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (WFLY-11981) CLI not able to read backslash character correctly
by Saurabh Shriramwar (Jira)
[ https://issues.jboss.org/browse/WFLY-11981?page=com.atlassian.jira.plugin... ]
Saurabh Shriramwar updated WFLY-11981:
--------------------------------------
Steps to Reproduce:
* Start CLI and execute
{code:java}
/subsystem=mail/mail-session=default/server=smtp:write-attribute(name=username,value="auth\\SampleUser")
{code}
* /subsystem=mail/mail-session=default/server=smtp:read-attribute(name=username)
{code:java}
{
"outcome" => "success",
"result" => "auth\\SampleUser"
}
{code}
was:
* Start CLI and execute
{code:java}
/subsystem=mail/mail-session=default/server=smtp:write-attribute(name=username,value="auth\\SampleUser")
{code}
* /subsystem=mail/mail-session=default/server=smtp:read-attribute(name=username)
{code:java}
{
"outcome" => "success",
"result" => "auth\\SampleUser"
}
{code}
Whereas standalone.xml include the changes properly
{code:java}
<subsystem xmlns="urn:jboss:domain:mail:3.0">
<mail-session name="default" jndi-name="java:jboss/mail/Default">
<smtp-server outbound-socket-binding-ref="mail-smtp" username="auth\SampleUser"/>
</mail-session>
........
{code}
> CLI not able to read backslash character correctly
> --------------------------------------------------
>
> Key: WFLY-11981
> URL: https://issues.jboss.org/browse/WFLY-11981
> Project: WildFly
> Issue Type: Bug
> Components: CLI
> Affects Versions: 14.0.0.Final
> Reporter: Saurabh Shriramwar
> Priority: Minor
>
> The output for CLI read-attribute operation is confusing and not able to read/interpret backslash characters properly.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months