[JBoss JIRA] (DROOLS-1072) Generate warning or error when Ruletemplate files specified in kmodule.xml does not exist
by Mario Fusco (Jira)
[ https://issues.jboss.org/browse/DROOLS-1072?page=com.atlassian.jira.plugi... ]
Mario Fusco updated DROOLS-1072:
--------------------------------
Story Points: 3
> Generate warning or error when Ruletemplate files specified in kmodule.xml does not exist
> -----------------------------------------------------------------------------------------
>
> Key: DROOLS-1072
> URL: https://issues.jboss.org/browse/DROOLS-1072
> Project: Drools
> Issue Type: Enhancement
> Components: decision tables
> Affects Versions: 6.4.0.Beta2
> Reporter: Alex Vincent
> Assignee: Mario Fusco
> Priority: Major
>
> When you specify a ruletemplate for a given kbase in the kmodule.xml, it does not generate a warning or an error if the template or dtable does not exist.
> For instance the following kmodule.xml:
> <?xml version="1.0" encoding="UTF-8"?>
> <kmodule xmlns="http://jboss.org/kie/6.0.0/kmodule">
> <kbase name="KBase1" packages="process, rules, decisiontables, ruletemplates">
> <ruleTemplate dtable="decisiontables/dt_duplicate_facts.xls"
> template="ruletemplates/tpl_duplicate_facts.drt"
> row="2" col="2"/>
> <ruleTemplate dtable="doesnotexist/dt_duplicate_facts.xls"
> template="doesnotexist/tpl_duplicate_facts.drt"
> row="2" col="2"/>
> <ksession name="KSession1"/>
> </kbase>
> </kmodule>
> This does not generate an error or warning even with trace log level. The user should be notified that these files don't exist (doesnotexist/dt_duplicate_facts.xls and doesnotexist/tpl_duplicate_facts.drt).
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (DROOLS-3198) kie maven plugin fails to build kjar if kmodule contains a ruleTemplate
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-3198?page=com.atlassian.jira.plugi... ]
Luca Molteni reassigned DROOLS-3198:
------------------------------------
Assignee: Mario Fusco (was: Luca Molteni)
> kie maven plugin fails to build kjar if kmodule contains a ruleTemplate
> -----------------------------------------------------------------------
>
> Key: DROOLS-3198
> URL: https://issues.jboss.org/browse/DROOLS-3198
> Project: Drools
> Issue Type: Bug
> Components: tools
> Affects Versions: 7.8.0.Final
> Reporter: Webster Homer
> Assignee: Mario Fusco
> Priority: Major
>
> If I have a maven pom that uses the kie maven plugin org.kie:kie-maven-plugin to build the kljar for deployment, and the project kjar has a ruleTemplate:
> <ruleTemplate dtable="rules/business/TermSearchQFRules.xls"
> template="rules/business/templates/TermSearchQF.drt"
> row="2" col="1"/>
> The build will fail with an error:
> ERROR] Failed to execute goal org.kie:kie-maven-plugin:7.8.0.Final:build (default-build) on project ba-search-kjar: Execution default-build of goal org.kie:kie-maven-plugin:7.8.0.Final:build failed: No RuleTable cells in spreadsheet. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.kie:kie-maven-plugin:7.8.0.Final:build (default-build) on project ba-search-kjar: Execution default-build of goal org.kie:kie-maven-plugin:7.8.0.Final:build failed: No RuleTable cells in spreadsheet.
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-build of goal org.kie:kie-maven-plugin:7.8.0.Final:build failed: No RuleTable cells in spreadsheet.
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.drools.template.parser.DecisionTableParseException: No RuleTable cells in spreadsheet.
> This is because the plugin doesn't understand the rule template, and treats the xls file as a decision table spreadsheet rather than a template spreadsheet.
> The kie-maven-plugin is a useful tool that compiles the kjar are build time rather than load time, and gives good diagnostics.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (DROOLS-3825) Model compiler should not duplicate files across runs
by Edoardo Vacchi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3825?page=com.atlassian.jira.plugi... ]
Edoardo Vacchi updated DROOLS-3825:
-----------------------------------
Sprint: 2019 Week 17-19 (was: 2019 Week 14-16)
> Model compiler should not duplicate files across runs
> -----------------------------------------------------
>
> Key: DROOLS-3825
> URL: https://issues.jboss.org/browse/DROOLS-3825
> Project: Drools
> Issue Type: Bug
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
>
> If you don't {{mvn clean}} each time you generate the executable model, new files will be generated at each run.
> These seem to be the culprit:
> {{PackageModel#getPackageUUID}}
> {code}
> private String generateRulesFileName() {
> return RULES_FILE_NAME + generateUUID();
> }
> {code}
> solution: use a counter; the compiler is single-threaded, two runs produce the same output, existing files will be just overwritten
> deliverable: test case verifying files do not grow in number across runs
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months
[JBoss JIRA] (DROOLS-3882) Align Drools Submarine API to jBPM Submarine API, provide bridge between the two
by Edoardo Vacchi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3882?page=com.atlassian.jira.plugi... ]
Edoardo Vacchi updated DROOLS-3882:
-----------------------------------
Sprint: 2019 Week 17-19 (was: 2019 Week 14-16)
> Align Drools Submarine API to jBPM Submarine API, provide bridge between the two
> --------------------------------------------------------------------------------
>
> Key: DROOLS-3882
> URL: https://issues.jboss.org/browse/DROOLS-3882
> Project: Drools
> Issue Type: Enhancement
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core, submarine
> Fix For: 8.0.0.Final
>
>
> Currently, the Maven plugin generates a Module in the *org.drools* namespace; jBPM uses the *groupId;* we should either merge the 2 modules into one generated Application (and remove the generate Module), or find a way to delegate. We should also add support to configuration in Drools as well. jBPM already supports configuring WorkItems through a typed API.
> Deliverable: a PR
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 3 months