[JBoss JIRA] (DROOLS-2254) Automate .proto files rebuild in pom.xml
by Michael Biarnes Kiefer (Jira)
[ https://issues.jboss.org/browse/DROOLS-2254?page=com.atlassian.jira.plugi... ]
Michael Biarnes Kiefer updated DROOLS-2254:
-------------------------------------------
Fix Version/s: 7.23.0.Final
(was: 7.22.0.Final)
> Automate .proto files rebuild in pom.xml
> ----------------------------------------
>
> Key: DROOLS-2254
> URL: https://issues.jboss.org/browse/DROOLS-2254
> Project: Drools
> Issue Type: Task
> Components: tools
> Affects Versions: 7.5.0.Final
> Reporter: Dmitry Volodin
> Assignee: Dmitry Volodin
> Priority: Minor
> Fix For: 7.23.0.Final
>
>
> According to contribution guide, any .proto file or protobuf version changes it's necessary to download protoc utility and regenerate Java classes based on .proto files.
> This will add automation for downloading protoc utility and Java classes generation based on Maven Protocol Buffers Plugin. There is no timestamps and other build related info inside generated Java files and no changes will be added on each new build.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (WFLY-11613) Deleting JMS temporary destination with a closed session should throw an exception
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFLY-11613?page=com.atlassian.jira.plugin... ]
James Perkins resolved WFLY-11613.
----------------------------------
Fix Version/s: 17.0.0.Beta1
Resolution: Done
> Deleting JMS temporary destination with a closed session should throw an exception
> ----------------------------------------------------------------------------------
>
> Key: WFLY-11613
> URL: https://issues.jboss.org/browse/WFLY-11613
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Affects Versions: 15.0.1.Final
> Reporter: Emmanuel Hugonnet
> Assignee: Emmanuel Hugonnet
> Priority: Major
> Fix For: 17.0.0.Beta1
>
>
> If a client closes its JMS session (intentionally or not) and then invokes javax.jms.TemporaryQueue.delete() or javax.jms.TemporaryTopic.delete() these methods will return without actually deleting the destination (because the underlying session was closed). This can be confusing and/or mask programming errors.
> The JavaDoc for{{ javax.jms.TemporaryQueue }}states that a JMSException should be thrown, "if the JMS provider fails to delete the temporary queue due to some internal error."
> Options
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-4039) Columns can be bound inappropriately
by Yeser Amer (Jira)
[ https://issues.jboss.org/browse/DROOLS-4039?page=com.atlassian.jira.plugi... ]
Yeser Amer updated DROOLS-4039:
-------------------------------
Story Points: 1 (was: 3)
> Columns can be bound inappropriately
> -------------------------------------
>
> Key: DROOLS-4039
> URL: https://issues.jboss.org/browse/DROOLS-4039
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Affects Versions: 7.22.0.Final
> Reporter: Jozef Marko
> Assignee: Yeser Amer
> Priority: Major
> Labels: ScenarioSimulation
> Attachments: bind-column.webm
>
>
> There exist a way how user can bind scenario column inappropriately. For example property column of object A, can be bound to the property of totally different object. The way is shown in the attached video.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (WFLY-11608) Improve validation of MDB activation config properties values
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFLY-11608?page=com.atlassian.jira.plugin... ]
James Perkins closed WFLY-11608.
--------------------------------
Fix Version/s: 17.0.0.Beta1
Resolution: Done
> Improve validation of MDB activation config properties values
> -------------------------------------------------------------
>
> Key: WFLY-11608
> URL: https://issues.jboss.org/browse/WFLY-11608
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Reporter: Emmanuel Hugonnet
> Assignee: Romain Pelisse
> Priority: Major
> Fix For: 17.0.0.Beta1
>
>
> Most of activation config properties values are not validated during MDB deploy. This might lead to successful deployment of misconfigured MDB without any warning.
> *Customer scenario*: Customer deploys MDB with misconfigured activation config property(wrong type, unsupported value). MDB deploys without any warning message. However, it doesn't work as expected. In worst case, MDB can not read any message.
> *Current validation status*
> Values of activation config properties are validated in {{ActiveMQActivationSpec.validate()}} method. Validation covers only 3 scenarios
> * not specified destination
> * wrong destination type (other than Queue / Topic)
> * no subscription name when MDB is durable topic subscriber
> Some {{ActiveMQActivationSpec}} properties try to validate supported values in setters. For example {{setAcknowledgeMode()}} throws {{IllegalArgumentException}}. However these exceptions only log message on {{finest}} level, which usually doesn't attract user's attention (see {{BeenUtils.mapJavaBeanProperties}} in {{jboss-common-beans}})
> Other parameters are not validated.
> *Possible issues*
> Not validated activation config properties can be set to any value without warning. There is a possibility of misconfiguration which can be detected during deploy time.
> _Examples_
> Value of {{acknowledgeMode}} can be set to any string or number without warning. If that is the case, server uses default auto acknowledge. However, it doesn't warn user.
> If property {{maxSessions}} is configured with negative value, no warning is logged and MDB is unable to consume messages.
> If {{destination}} property specifies unknown destination, new destination with provided name is created. User should be informed about that at least on INFO log level (Currently it is debug in {{ActiveMQActivation.setupDestination()}}).
> MDB unable to consume messages should not successfully deploy, and user should be informed about the misconfigured values.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (WFLY-9595) Incorrect Journal filesize calculation where specified size is lest that the block size when using AIO
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFLY-9595?page=com.atlassian.jira.plugin.... ]
James Perkins resolved WFLY-9595.
---------------------------------
Fix Version/s: 17.0.0.Beta1
Resolution: Done
> Incorrect Journal filesize calculation where specified size is lest that the block size when using AIO
> ------------------------------------------------------------------------------------------------------
>
> Key: WFLY-9595
> URL: https://issues.jboss.org/browse/WFLY-9595
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Affects Versions: 11.0.0.Final, 14.0.0.Final
> Reporter: Darran Lofthouse
> Assignee: Emmanuel Hugonnet
> Priority: Major
> Fix For: 17.0.0.Beta1
>
>
> This issue was discovered as a side effect of: -
> https://github.com/wildfly/wildfly/commit/df9e16241207ebc412ddd16c790c4b7...
> This change updated the size to be 1024 for the tests as a large file was not necessary. For continuous integration the agents have a blocksize of 512 so as the configured size is a multiple of the blocksize this was fine.
> However running the test 'org.jboss.as.test.integration.domain.ExpressionSupportSmokeTestCase' on a machine with a blocksize of 4096 this test would fail as the servers would fail to boot.
> After some debugging it became aparant this was the underlying error: -
> {noformat}
> {"jboss.messaging-activemq.default.jms.manager" => "java.lang.IllegalArgumentException: File size cannot be less than 1024 bytes
> Caused by: java.lang.IllegalArgumentException: File size cannot be less than 1024 bytes"}
> {noformat}
> After further debugging I have tracked it down to this class 'org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager' - I can confirm the configured value does make it to this class but it is the following block of code which then looses the value: -
> {code:java}
> int fileSize = config.getJournalFileSize();
> // we need to correct the file size if its not a multiple of the alignement
> int modulus = fileSize % journalFF.getAlignment();
> if (modulus != 0) {
> int difference = modulus;
> int low = config.getJournalFileSize() - difference;
> int high = low + journalFF.getAlignment();
> fileSize = difference < journalFF.getAlignment() / 2 ? low : high;
> ActiveMQServerLogger.LOGGER.invalidJournalFileSize(config.getJournalFileSize(), fileSize, journalFF.getAlignment());
> }
> Journal localMessage = new JournalImpl(ioExecutors, fileSize, config.getJournalMinFiles(), config.getJournalPoolFiles(), config.getJournalCompactMinFiles(), config.getJournalCompactPercentage(), journalFF, "activemq-data", "amq", journalFF.getMaxIO(), 0);
> {code}
> The file size comes in as 1024, the default is AIO so getAlignment returns the blocksize which in this case is 4096. So modulus and subsequently difference become 1024.
> The file size and difference are both 1024 so low becomes 0, high becomes 4096. Due to the difference being less than half the block size low is selected and the file size is set to 0.
> To select a correct filesize it looks like if low is less than the alignment always select high should be an option.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months
[JBoss JIRA] (DROOLS-4039) Columns can be bound inappropriately
by Yeser Amer (Jira)
[ https://issues.jboss.org/browse/DROOLS-4039?page=com.atlassian.jira.plugi... ]
Yeser Amer updated DROOLS-4039:
-------------------------------
Story Points: 3 (was: 1)
> Columns can be bound inappropriately
> -------------------------------------
>
> Key: DROOLS-4039
> URL: https://issues.jboss.org/browse/DROOLS-4039
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Affects Versions: 7.22.0.Final
> Reporter: Jozef Marko
> Assignee: Yeser Amer
> Priority: Major
> Labels: ScenarioSimulation
> Attachments: bind-column.webm
>
>
> There exist a way how user can bind scenario column inappropriately. For example property column of object A, can be bound to the property of totally different object. The way is shown in the attached video.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 2 months