[JBoss JIRA] (WFCORE-4525) Fix failing tests on IBM JDK
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFCORE-4525?page=com.atlassian.jira.plugi... ]
Richard Opalka edited comment on WFCORE-4525 at 6/13/19 8:46 AM:
-----------------------------------------------------------------
I was able to fix some tests applying the following patch on maven surefire upstream:
{quote}
blackhole][/home/opalka/git/apache/maven-surefire]>git diff
diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
index ebc1b276..5ec0e4ea 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
@@ -83,9 +83,9 @@ private void setupBooter( String tmpDir, String dumpFileName, String surefirePro
{
BooterDeserializer booterDeserializer =
new BooterDeserializer( createSurefirePropertiesIfFileExists( tmpDir, surefirePropsFileName ) );
+ setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
// todo: print PID in debug console logger in version 2.21.2
pingScheduler = isDebugging() ? null : listenToShutdownCommands( booterDeserializer.getPluginPid() );
- setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
providerConfiguration = booterDeserializer.deserialize();
DumpErrorSingleton.getSingleton()
{quote}
was (Author: ropalka):
I was able to fix some tests applying the following patch on maven surefire upstream:
---
blackhole][/home/opalka/git/apache/maven-surefire]>git diff
diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
index ebc1b276..5ec0e4ea 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
@@ -83,9 +83,9 @@ private void setupBooter( String tmpDir, String dumpFileName, String surefirePro
{
BooterDeserializer booterDeserializer =
new BooterDeserializer( createSurefirePropertiesIfFileExists( tmpDir, surefirePropsFileName ) );
+ setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
// todo: print PID in debug console logger in version 2.21.2
pingScheduler = isDebugging() ? null : listenToShutdownCommands( booterDeserializer.getPluginPid() );
- setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
providerConfiguration = booterDeserializer.deserialize();
DumpErrorSingleton.getSingleton()
---
> Fix failing tests on IBM JDK
> ----------------------------
>
> Key: WFCORE-4525
> URL: https://issues.jboss.org/browse/WFCORE-4525
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: Richard Opalka
> Assignee: James Perkins
> Priority: Major
> Fix For: 9.0.2.Final
>
> Attachments: forked-booter.png, ibm-jdk8.png, oracle-jdk.png
>
>
> The following tests are failing on latest IBM JDK 8:
> ---
> # testsuite/standalone
> SilentModeTestCase
> # testsuite/manualmode
> CLIEmbedHostControllerTestCase
> CLIEmbedServerTestCase
> ---
> Tested on:
> ---
> java version "1.8.0_211"
> Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
> IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
> OpenJ9 - 46e57f9
> OMR - 06a046a
> IBM - 0b909bf)
> JCL - 20190409_01 based on Oracle jdk8u211-b25
> ---
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4525) Fix failing tests on IBM JDK
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFCORE-4525?page=com.atlassian.jira.plugi... ]
Richard Opalka commented on WFCORE-4525:
----------------------------------------
I was able to fix some tests applying the following patch on maven surefire upstream:
---
blackhole][/home/opalka/git/apache/maven-surefire]>git diff
diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
index ebc1b276..5ec0e4ea 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
@@ -83,9 +83,9 @@ private void setupBooter( String tmpDir, String dumpFileName, String surefirePro
{
BooterDeserializer booterDeserializer =
new BooterDeserializer( createSurefirePropertiesIfFileExists( tmpDir, surefirePropsFileName ) );
+ setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
// todo: print PID in debug console logger in version 2.21.2
pingScheduler = isDebugging() ? null : listenToShutdownCommands( booterDeserializer.getPluginPid() );
- setSystemProperties( new File( tmpDir, effectiveSystemPropertiesFileName ) );
providerConfiguration = booterDeserializer.deserialize();
DumpErrorSingleton.getSingleton()
---
> Fix failing tests on IBM JDK
> ----------------------------
>
> Key: WFCORE-4525
> URL: https://issues.jboss.org/browse/WFCORE-4525
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: Richard Opalka
> Assignee: James Perkins
> Priority: Major
> Fix For: 9.0.2.Final
>
> Attachments: forked-booter.png, ibm-jdk8.png, oracle-jdk.png
>
>
> The following tests are failing on latest IBM JDK 8:
> ---
> # testsuite/standalone
> SilentModeTestCase
> # testsuite/manualmode
> CLIEmbedHostControllerTestCase
> CLIEmbedServerTestCase
> ---
> Tested on:
> ---
> java version "1.8.0_211"
> Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
> IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
> OpenJ9 - 46e57f9
> OMR - 06a046a
> IBM - 0b909bf)
> JCL - 20190409_01 based on Oracle jdk8u211-b25
> ---
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4525) Fix failing tests on IBM JDK
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFCORE-4525?page=com.atlassian.jira.plugi... ]
Richard Opalka commented on WFCORE-4525:
----------------------------------------
I debugged this problem and I identified some of these tests fail because of late system properties setup in ForkedBooter class when surefire plugin runs on top of IBM JDK.
ForkedBooter sets up system properties for forked process on line 95 in method ForkedBooter.setupBooter() method.
But on IBM JDK (see ibm-jdk8.png) the Java system logger is initialized before jboss logging properties are setup (this happens on line 94 in method ForkedBooter.setupBooter())
Detailed explanation:
* ForkedBooter.isDebugging() method call on line 94 behaves differently on IBM JDK and on Oracle JDK from java system logger configuration point of view.
* Oracle's ManagementFactory.getRuntimeMXBean() method invocation doesn't force java system logging initialization because its MX bean isn't using logging.
* But IBM's ManagementFactory.getRuntimeMXBean() method invocation forces java system logging initialization because its MX bean is using logging.
The problem is system properties are configured for forked process on line 95 in ForkedBooter (see forked-booter.png) and so on IBM JDK jboss logging
properties are not configured which results in Apache Log4j being used. On Oracle JDK JBoss log manager is used instead.
On Oracle JDK system properties are properly set up and later used for logging configuration (see oracle-jdk.png).
> Fix failing tests on IBM JDK
> ----------------------------
>
> Key: WFCORE-4525
> URL: https://issues.jboss.org/browse/WFCORE-4525
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: Richard Opalka
> Assignee: James Perkins
> Priority: Major
> Fix For: 9.0.2.Final
>
> Attachments: forked-booter.png, ibm-jdk8.png, oracle-jdk.png
>
>
> The following tests are failing on latest IBM JDK 8:
> ---
> # testsuite/standalone
> SilentModeTestCase
> # testsuite/manualmode
> CLIEmbedHostControllerTestCase
> CLIEmbedServerTestCase
> ---
> Tested on:
> ---
> java version "1.8.0_211"
> Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
> IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
> OpenJ9 - 46e57f9
> OMR - 06a046a
> IBM - 0b909bf)
> JCL - 20190409_01 based on Oracle jdk8u211-b25
> ---
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (DROOLS-4174) Test Scenario: Add support to recursive types in DMN
by Daniele Zonca (Jira)
Daniele Zonca created DROOLS-4174:
-------------------------------------
Summary: Test Scenario: Add support to recursive types in DMN
Key: DROOLS-4174
URL: https://issues.jboss.org/browse/DROOLS-4174
Project: Drools
Issue Type: Task
Components: Scenario Simulation and Testing
Reporter: Daniele Zonca
Assignee: Daniele Zonca
Review DMN data type extraction (DMNTypeService) and DMN test scenario template creation (DMNSimulationCreationStrategy) to be sure it works with recursive types.
Please consider that template creation should not expand recursive types at all
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4525) Fix failing tests on IBM JDK
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFCORE-4525?page=com.atlassian.jira.plugi... ]
Richard Opalka updated WFCORE-4525:
-----------------------------------
Attachment: forked-booter.png
ibm-jdk8.png
oracle-jdk.png
> Fix failing tests on IBM JDK
> ----------------------------
>
> Key: WFCORE-4525
> URL: https://issues.jboss.org/browse/WFCORE-4525
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: Richard Opalka
> Assignee: James Perkins
> Priority: Major
> Fix For: 9.0.2.Final
>
> Attachments: forked-booter.png, ibm-jdk8.png, oracle-jdk.png
>
>
> The following tests are failing on latest IBM JDK 8:
> ---
> # testsuite/standalone
> SilentModeTestCase
> # testsuite/manualmode
> CLIEmbedHostControllerTestCase
> CLIEmbedServerTestCase
> ---
> Tested on:
> ---
> java version "1.8.0_211"
> Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
> IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
> OpenJ9 - 46e57f9
> OMR - 06a046a
> IBM - 0b909bf)
> JCL - 20190409_01 based on Oracle jdk8u211-b25
> ---
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4525) Fix failing tests on IBM JDK
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFCORE-4525?page=com.atlassian.jira.plugi... ]
Richard Opalka updated WFCORE-4525:
-----------------------------------
Description:
The following tests are failing on latest IBM JDK 8:
---
# testsuite/standalone
SilentModeTestCase
# testsuite/manualmode
CLIEmbedHostControllerTestCase
CLIEmbedServerTestCase
---
Tested on:
---
java version "1.8.0_211"
Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
OpenJ9 - 46e57f9
OMR - 06a046a
IBM - 0b909bf)
JCL - 20190409_01 based on Oracle jdk8u211-b25
---
was:
The following tests are failing on latest IBM JDK 8:
---
# testsuite/standalone
SilentModeTestCase
# testsuite/manualmode
CLIEmbedHostControllerTestCase
CLIEmbedServerTestCase
---
Tested on:
---
java version "1.8.0_211"
Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
OpenJ9 - 46e57f9
OMR - 06a046a
IBM - 0b909bf)
JCL - 20190409_01 based on Oracle jdk8u211-b25
---
> Fix failing tests on IBM JDK
> ----------------------------
>
> Key: WFCORE-4525
> URL: https://issues.jboss.org/browse/WFCORE-4525
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: Richard Opalka
> Assignee: James Perkins
> Priority: Major
> Fix For: 9.0.2.Final
>
>
> The following tests are failing on latest IBM JDK 8:
> ---
> # testsuite/standalone
> SilentModeTestCase
> # testsuite/manualmode
> CLIEmbedHostControllerTestCase
> CLIEmbedServerTestCase
> ---
> Tested on:
> ---
> java version "1.8.0_211"
> Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
> IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
> OpenJ9 - 46e57f9
> OMR - 06a046a
> IBM - 0b909bf)
> JCL - 20190409_01 based on Oracle jdk8u211-b25
> ---
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4525) Fix failing tests on IBM JDK
by Richard Opalka (Jira)
Richard Opalka created WFCORE-4525:
--------------------------------------
Summary: Fix failing tests on IBM JDK
Key: WFCORE-4525
URL: https://issues.jboss.org/browse/WFCORE-4525
Project: WildFly Core
Issue Type: Bug
Components: Logging
Reporter: Richard Opalka
Assignee: James Perkins
Fix For: 9.0.2.Final
The following tests are failing on latest IBM JDK 8:
---
# testsuite/standalone
SilentModeTestCase
# testsuite/manualmode
CLIEmbedHostControllerTestCase
CLIEmbedServerTestCase
---
Tested on:
---
java version "1.8.0_211"
Java(TM) SE Runtime Environment (build 8.0.5.36 - pxa6480sr5fp36-20190510_01(SR5 FP36))
IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190502_415899 (JIT enabled, AOT enabled)
OpenJ9 - 46e57f9
OMR - 06a046a
IBM - 0b909bf)
JCL - 20190409_01 based on Oracle jdk8u211-b25
---
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (DROOLS-4171) rule filtering by folder-type packages attribute does not work after upgrading to 7.11.0.Final
by Mario Fusco (Jira)
[ https://issues.jboss.org/browse/DROOLS-4171?page=com.atlassian.jira.plugi... ]
Mario Fusco commented on DROOLS-4171:
-------------------------------------
This issue has been fixed in 7.23.0.Final as a side-effect of this https://issues.jboss.org/browse/DROOLS-4043
Note that in order to configure the "drools.groupDRLsInKieBasesByFolder" property you should do in kmodule.xml file as it follows.
<?xml version="1.0" encoding="UTF-8"?>
<kmodule xmlns="http://jboss.org/kie/6.0.0/kmodule">
<configuration>
<property key="drools.groupDRLsInKieBasesByFolder" value="true"/>
</configuration>
<kbase name="rules" packages="rules.aws">
<ksession name="ksession-rules"/>
</kbase>
</kmodule>
> rule filtering by folder-type packages attribute does not work after upgrading to 7.11.0.Final
> ------------------------------------------------------------------------------------------------
>
> Key: DROOLS-4171
> URL: https://issues.jboss.org/browse/DROOLS-4171
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.11.0.Final, 7.14.0.Final, 7.18.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: buildKjarTest.zip
>
>
> In kjar project, there are many rules per folder under resources directory and
> filtered these rules by using packages attribute in kmodule.xml.
> e.g.
> - file structure
> {noformat}
> src/main/resources/
> ├── logback-test.xml
> ├── META-INF
> │ ├── kmodule.xml
> │ └── maven
> │ └── pom.properties
> └── rules
> ├── aws
> │ └── Sample1.drl
> ├── test1
> │ └── Sample1.drl
> └── test2
> └── Sample2.drl
> {noformat}
> - kmodule.xml
> {noformat}
> <?xml version="1.0" encoding="UTF-8"?>
> <kmodule xmlns="http://jboss.org/kie/6.0.0/kmodule">
> <kbase name="rules" packages="rules.aws">
> <ksession name="ksession-rules"/>
> </kbase>
> </kmodule>
> {noformat}
> This could be built with library version 7.5.0.Final.
> But after upgrading 7.11.0.Final or later, it fails.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (DROOLS-4171) rule filtering by folder-type packages attribute does not work after upgrading to 7.11.0.Final
by Mario Fusco (Jira)
[ https://issues.jboss.org/browse/DROOLS-4171?page=com.atlassian.jira.plugi... ]
Mario Fusco resolved DROOLS-4171.
---------------------------------
Resolution: Done
> rule filtering by folder-type packages attribute does not work after upgrading to 7.11.0.Final
> ------------------------------------------------------------------------------------------------
>
> Key: DROOLS-4171
> URL: https://issues.jboss.org/browse/DROOLS-4171
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.11.0.Final, 7.14.0.Final, 7.18.0.Final
> Reporter: Hiroko Miura
> Assignee: Mario Fusco
> Priority: Major
> Labels: support
> Attachments: buildKjarTest.zip
>
>
> In kjar project, there are many rules per folder under resources directory and
> filtered these rules by using packages attribute in kmodule.xml.
> e.g.
> - file structure
> {noformat}
> src/main/resources/
> ├── logback-test.xml
> ├── META-INF
> │ ├── kmodule.xml
> │ └── maven
> │ └── pom.properties
> └── rules
> ├── aws
> │ └── Sample1.drl
> ├── test1
> │ └── Sample1.drl
> └── test2
> └── Sample2.drl
> {noformat}
> - kmodule.xml
> {noformat}
> <?xml version="1.0" encoding="UTF-8"?>
> <kmodule xmlns="http://jboss.org/kie/6.0.0/kmodule">
> <kbase name="rules" packages="rules.aws">
> <ksession name="ksession-rules"/>
> </kbase>
> </kmodule>
> {noformat}
> This could be built with library version 7.5.0.Final.
> But after upgrading 7.11.0.Final or later, it fails.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month