[JBoss JIRA] (DROOLS-4137) KIE Maven Plugin Fails to Load Dependencies for KieBase when Serializing KieBase During Build
by Justin Holmes (Jira)
[ https://issues.jboss.org/browse/DROOLS-4137?page=com.atlassian.jira.plugi... ]
Justin Holmes edited comment on DROOLS-4137 at 6/10/19 12:43 PM:
-----------------------------------------------------------------
Only 5.
Are there runtime optimizations that we may be forgetting?
was (Author: jholmessr):
Only 5.
> KIE Maven Plugin Fails to Load Dependencies for KieBase when Serializing KieBase During Build
> ---------------------------------------------------------------------------------------------
>
> Key: DROOLS-4137
> URL: https://issues.jboss.org/browse/DROOLS-4137
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.22.0.Final
> Reporter: Justin Holmes
> Assignee: Mario Fusco
> Priority: Major
>
> I would like to have kie-maven-plugin build the KJar with a serialized KieBase so that it takes less time to boot strap drools. It appears that the maven configuration used by the kie-maven-plugin is broken, or at least there is not sufficient documentation to set it up.
> See https://groups.google.com/forum/#!topic/drools-setup/0TZvE5lpcto for more information.
> Documentation is VERY limited / scattered in different areas. It probably needs updates. If we can get help to get the build working / bug fixed, we would be happy to submit a doc fix.
> We are trying to use drools in a severless environment (though not quite ready for Quarkus). If we are unable to use this build feature, we may be unable to use drools.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (DROOLS-4137) KIE Maven Plugin Fails to Load Dependencies for KieBase when Serializing KieBase During Build
by Mario Fusco (Jira)
[ https://issues.jboss.org/browse/DROOLS-4137?page=com.atlassian.jira.plugi... ]
Mario Fusco commented on DROOLS-4137:
-------------------------------------
[~jholmessr] It does (sort of) make sense. How many rules do you have in your rule base?
> KIE Maven Plugin Fails to Load Dependencies for KieBase when Serializing KieBase During Build
> ---------------------------------------------------------------------------------------------
>
> Key: DROOLS-4137
> URL: https://issues.jboss.org/browse/DROOLS-4137
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.22.0.Final
> Reporter: Justin Holmes
> Assignee: Mario Fusco
> Priority: Major
>
> I would like to have kie-maven-plugin build the KJar with a serialized KieBase so that it takes less time to boot strap drools. It appears that the maven configuration used by the kie-maven-plugin is broken, or at least there is not sufficient documentation to set it up.
> See https://groups.google.com/forum/#!topic/drools-setup/0TZvE5lpcto for more information.
> Documentation is VERY limited / scattered in different areas. It probably needs updates. If we can get help to get the build working / bug fixed, we would be happy to submit a doc fix.
> We are trying to use drools in a severless environment (though not quite ready for Quarkus). If we are unable to use this build feature, we may be unable to use drools.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4474) Missing path validation of a log file while update path
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFCORE-4474?page=com.atlassian.jira.plugi... ]
James Perkins edited comment on WFCORE-4474 at 6/10/19 12:21 PM:
-----------------------------------------------------------------
I don't think there is much we can really do here TBH. There is a [{{FileCorrector}}|https://github.com/wildfly/wildfly-core/blob/5a12c1bad47db0bfbf836b279d262bdf352d16c7/logging/src/main/java/org/jboss/as/logging/correctors/FileCorrector.java#L33-L44] that sets the {{relative-to}} attribute if it was previously set and the {{path}} was deemed *not* to be an absolute path. It's been like that for a long time so I don't think we can really change that behavior at this point.
For some of the failures you'd need to quote the path in the operation so CLI can parse it. For example the {{C:*server.log}} in CLI should be
{code}
/subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path="C:*server.log"})
{code}
That would result in the {{relative-to}} being set though so you'd end up with a path like : {{C:\servers\wildfly\standalone\logs\C:*server.log}}
was (Author: jamezp):
I don't think there is much we can really do here TBH. There is a [{{FileCorrect}}|https://github.com/wildfly/wildfly-core/blob/5a12c1bad47db0bfbf836b279d262bdf352d16c7/logging/src/main/java/org/jboss/as/logging/correctors/FileCorrector.java#L33-L44] that sets the {{relative-to}} attribute if it was previously set and the {{path}} was deemed *not* to be an absolute path. It's been like that for a long time so I don't think we can really change that behavior at this point.
For some of the failures you'd need to quote the path in the operation so CLI can parse it. For example the {{C:*server.log}} in CLI should be
{code}
/subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path="C:*server.log"})
{code}
That would result in the {{relative-to}} being set though so you'd end up with a path like : {{C:\servers\wildfly\standalone\logs\C:*server.log}}
> Missing path validation of a log file while update path
> --------------------------------------------------------
>
> Key: WFCORE-4474
> URL: https://issues.jboss.org/browse/WFCORE-4474
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Affects Versions: 9.0.0.Beta4
> Reporter: Vratislav Marek
> Assignee: James Perkins
> Priority: Major
>
> After the first successful set of a valid path, you can set an invalid path.
> It is can be relative to that while "relative-to" parameter is overridden, the validator doesn't validate it.
> Discovered on Windows.
> A code block is divided, but it is holding sequence to reproduce.
> _This works as expected._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> :> at index 61: D:\\Tests\\clear\\wildfly-17.0.0.Beta1-SNAPSHOT\\standalone\\log\\C:/server.log",
> "rolled-back" => true
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> :> at index 61: D:\\Tests\\clear\\wildfly-17.0.0.Beta1-SNAPSHOT\\standalone\\log\\C:server.log",
> "rolled-back" => true
> }
> {code}
> _Still works as expected. But After this successful write-attribute command, it that changing._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\\server.log})
> {"outcome" => "success"}
> {code}
> *Now there is a problem, it that not works as expected. The validator accepts invalid path.*
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> {code}
> _But not accept all invalid paths._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:*server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> *> at index 2: C:*server.log",
> "rolled-back" => true
> }
> {code}
> _Verification if the unsuccessful update changes something. But not._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\\server.log})
> {"outcome" => "success"}
> {code}
> _Verification if is really set in the property value. Yes_
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:\\server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:/server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:server.log"}
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4474) Missing path validation of a log file while update path
by James Perkins (Jira)
[ https://issues.jboss.org/browse/WFCORE-4474?page=com.atlassian.jira.plugi... ]
James Perkins commented on WFCORE-4474:
---------------------------------------
I'm not sure I completely follow completely, but yes if we changed the {{relative-to}} to not be undefined when the {{write-attribute}} value does not define it that would fix this error. I'm not sure we should do this however as it's worked this way for a long time and it could break scripts that assume this behavior. The best solution is to ensure using the correct path separators. So instead of using {{C:/server.log}} the {{\}} Windows path separator should be used {{C:\server.log}}.
> Missing path validation of a log file while update path
> --------------------------------------------------------
>
> Key: WFCORE-4474
> URL: https://issues.jboss.org/browse/WFCORE-4474
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Affects Versions: 9.0.0.Beta4
> Reporter: Vratislav Marek
> Assignee: James Perkins
> Priority: Major
>
> After the first successful set of a valid path, you can set an invalid path.
> It is can be relative to that while "relative-to" parameter is overridden, the validator doesn't validate it.
> Discovered on Windows.
> A code block is divided, but it is holding sequence to reproduce.
> _This works as expected._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> :> at index 61: D:\\Tests\\clear\\wildfly-17.0.0.Beta1-SNAPSHOT\\standalone\\log\\C:/server.log",
> "rolled-back" => true
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> :> at index 61: D:\\Tests\\clear\\wildfly-17.0.0.Beta1-SNAPSHOT\\standalone\\log\\C:server.log",
> "rolled-back" => true
> }
> {code}
> _Still works as expected. But After this successful write-attribute command, it that changing._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\\server.log})
> {"outcome" => "success"}
> {code}
> *Now there is a problem, it that not works as expected. The validator accepts invalid path.*
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> {code}
> _But not accept all invalid paths._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:*server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> *> at index 2: C:*server.log",
> "rolled-back" => true
> }
> {code}
> _Verification if the unsuccessful update changes something. But not._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\\server.log})
> {"outcome" => "success"}
> {code}
> _Verification if is really set in the property value. Yes_
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:\\server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:/server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:server.log"}
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (DROOLS-4137) KIE Maven Plugin Fails to Load Dependencies for KieBase when Serializing KieBase During Build
by Justin Holmes (Jira)
[ https://issues.jboss.org/browse/DROOLS-4137?page=com.atlassian.jira.plugi... ]
Justin Holmes commented on DROOLS-4137:
---------------------------------------
[~mfusco] We've change a few things and confirmed that we generate the model source, and that it compiles down to class files. Can you confirm the below benchmark times make sense? This all running on a mac book pro in unit test in a maven build:
* ~200-250ms to load classpath kie container (specify the releaseID and newClasspathKieContainer seem to have the same performace)
* ~200-350ms to create the first session
* ~50ms to fire the first session
Sessions and firing rules are < 1 ms after the first one.
> KIE Maven Plugin Fails to Load Dependencies for KieBase when Serializing KieBase During Build
> ---------------------------------------------------------------------------------------------
>
> Key: DROOLS-4137
> URL: https://issues.jboss.org/browse/DROOLS-4137
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.22.0.Final
> Reporter: Justin Holmes
> Assignee: Mario Fusco
> Priority: Major
>
> I would like to have kie-maven-plugin build the KJar with a serialized KieBase so that it takes less time to boot strap drools. It appears that the maven configuration used by the kie-maven-plugin is broken, or at least there is not sufficient documentation to set it up.
> See https://groups.google.com/forum/#!topic/drools-setup/0TZvE5lpcto for more information.
> Documentation is VERY limited / scattered in different areas. It probably needs updates. If we can get help to get the build working / bug fixed, we would be happy to submit a doc fix.
> We are trying to use drools in a severless environment (though not quite ready for Quarkus). If we are unable to use this build feature, we may be unable to use drools.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFLY-12181) wildfly-clustering-web-hotrod contains unreferenced classes
by Paul Ferraro (Jira)
Paul Ferraro created WFLY-12181:
-----------------------------------
Summary: wildfly-clustering-web-hotrod contains unreferenced classes
Key: WFLY-12181
URL: https://issues.jboss.org/browse/WFLY-12181
Project: WildFly
Issue Type: Bug
Components: Clustering
Affects Versions: 17.0.0.Final
Reporter: Paul Ferraro
Assignee: Paul Ferraro
HotRodMarshaller was refactored into wildfly-clustering-infinispan-extension.
RemoteCacheContainerConfiguration and RemoteCacheContainerFactory were made obsolete as part of WFLY-7719
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month
[JBoss JIRA] (WFCORE-4474) Missing path validation of a log file while update path
by Marek Kopecky (Jira)
[ https://issues.jboss.org/browse/WFCORE-4474?page=com.atlassian.jira.plugi... ]
Marek Kopecky commented on WFCORE-4474:
---------------------------------------
bq. ... FileCorrect that sets the relative-to attribute if it was previously set and the path was deemed not to be an absolute path.
Hi [~jamezp]. So the bug can be fixed, if "s/was previously/is currently/g" would be applied to FileCorrect, right?
> Missing path validation of a log file while update path
> --------------------------------------------------------
>
> Key: WFCORE-4474
> URL: https://issues.jboss.org/browse/WFCORE-4474
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Affects Versions: 9.0.0.Beta4
> Reporter: Vratislav Marek
> Assignee: James Perkins
> Priority: Major
>
> After the first successful set of a valid path, you can set an invalid path.
> It is can be relative to that while "relative-to" parameter is overridden, the validator doesn't validate it.
> Discovered on Windows.
> A code block is divided, but it is holding sequence to reproduce.
> _This works as expected._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> :> at index 61: D:\\Tests\\clear\\wildfly-17.0.0.Beta1-SNAPSHOT\\standalone\\log\\C:/server.log",
> "rolled-back" => true
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> :> at index 61: D:\\Tests\\clear\\wildfly-17.0.0.Beta1-SNAPSHOT\\standalone\\log\\C:server.log",
> "rolled-back" => true
> }
> {code}
> _Still works as expected. But After this successful write-attribute command, it that changing._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\\server.log})
> {"outcome" => "success"}
> {code}
> *Now there is a problem, it that not works as expected. The validator accepts invalid path.*
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> {code}
> _But not accept all invalid paths._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:*server.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.nio.file.InvalidPathException: Illegal char <
> *> at index 2: C:*server.log",
> "rolled-back" => true
> }
> {code}
> _Verification if the unsuccessful update changes something. But not._
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\\server.log})
> {"outcome" => "success"}
> {code}
> _Verification if is really set in the property value. Yes_
> {code:bash}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:\\server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:/server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:/server.log"}
> }
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:write-attribute(name=file,value={path=C:\server.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/periodic-rotating-file-handler=FILE:read-attribute(name=file)
> {
> "outcome" => "success",
> "result" => {"path" => "C:server.log"}
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 1 month