June 2019 - jboss-jira - Jboss List Archives

[JBoss JIRA] (DROOLS-4253) Fix SonarCloud report problems in kogito-codegen

by Tibor Zimanyi (Jira)

Tibor Zimanyi created DROOLS-4253: ------------------------------------- Summary: Fix SonarCloud report problems in kogito-codegen Key: DROOLS-4253 URL: https://issues.jboss.org/browse/DROOLS-4253 Project: Drools Issue Type: Task Components: core engine Reporter: Tibor Zimanyi Assignee: Tibor Zimanyi Fix For: 8.0.0.Final When SonarCloud analysis is run on kogito-codegen, it reports 122 problems. It could be common bugs, coding and performance recommendations, etc. These problems should be checked and fixes done where appropriate. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4251) [DMN Designer] User can not save diagram with validation errors

by Edson Tirelli (Jira)

[ https://issues.jboss.org/browse/DROOLS-4251?page=com.atlassian.jira.plugi... ] Edson Tirelli commented on DROOLS-4251: --------------------------------------- [~manstis] my general understanding of editors is that they should never preventing a file from being saved. The overall scenario is like this: if the user is building a model, maybe he is half-way through the changes and the model is still not consistent (has validation and/or compilation errors), but it is ok. He should be able to save his work to not risk losing anything, and continue after. So, definitively option 2. Also, if stunner is doing that, I think stunner is wrong and should be fixed. > [DMN Designer] User can not save diagram with validation errors > --------------------------------------------------------------- > > Key: DROOLS-4251 > URL: https://issues.jboss.org/browse/DROOLS-4251 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Affects Versions: 7.24.0.Final > Reporter: Jozef Marko > Assignee: Michael Anstis > Priority: Major > Labels: drools-tools > > User is unable to save the DMN diagram if there is a validation error, for example non existing variable reference. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4217) Test Scenario: corrupted scenario when user accepts error suggestion for collection

by Daniele Zonca (Jira)

[ https://issues.jboss.org/browse/DROOLS-4217?page=com.atlassian.jira.plugi... ] Daniele Zonca updated DROOLS-4217: ---------------------------------- Sprint: (was: 2019 Week 26-28) > Test Scenario: corrupted scenario when user accepts error suggestion for collection > ----------------------------------------------------------------------------------- > > Key: DROOLS-4217 > URL: https://issues.jboss.org/browse/DROOLS-4217 > Project: Drools > Issue Type: Bug > Reporter: Daniele Zonca > Assignee: Daniele Zonca > Priority: Blocker > Labels: ScenarioSimulation > > If a scenario fails with a wrong expect value on a collection the actual value suggested to accept is wrong and if accepted the scenario corrupts -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4217) Test Scenario: corrupted scenario when user accepts error suggestion for collection

by Daniele Zonca (Jira)

[ https://issues.jboss.org/browse/DROOLS-4217?page=com.atlassian.jira.plugi... ] Daniele Zonca closed DROOLS-4217. --------------------------------- Resolution: Done > Test Scenario: corrupted scenario when user accepts error suggestion for collection > ----------------------------------------------------------------------------------- > > Key: DROOLS-4217 > URL: https://issues.jboss.org/browse/DROOLS-4217 > Project: Drools > Issue Type: Bug > Reporter: Daniele Zonca > Assignee: Daniele Zonca > Priority: Blocker > Labels: ScenarioSimulation > > If a scenario fails with a wrong expect value on a collection the actual value suggested to accept is wrong and if accepted the scenario corrupts -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4252) Kie Drools benchmark tune logging config

by Matteo Mortari (Jira)

Matteo Mortari created DROOLS-4252: -------------------------------------- Summary: Kie Drools benchmark tune logging config Key: DROOLS-4252 URL: https://issues.jboss.org/browse/DROOLS-4252 Project: Drools Issue Type: Enhancement Components: core engine Reporter: Matteo Mortari Assignee: Matteo Mortari Attachments: image-2019-06-25-14-04-36-854.png I observe that logback config inside Kie Drools benchmark is set with both {{%method}} and {{%line}} which from the logback manual: {quote}L / line Outputs the line number from where the logging request was issued. Generating the line number information is not particularly fast. Thus, its use should be avoided unless execution speed is not an issue. ... M / method Outputs the method name where the logging request was issued. Generating the method name is not particularly fast. Thus, its use should be avoided unless execution speed is not an issue.{quote} In fact case in point for an introduced benchmark the symptom was normal logger/error message caused log of synthetic stacktrace being generated: !image-2019-06-25-14-04-36-854.png|thumbnail! The generation of the synthetic stacktrace by the logback logging framework should not influence the benchmark result, although I wanted to maintain the business logic that error, infos etc still get reported via SLF4j logging. Changing the Kie Drools benchmark configuration on the specific benchmark I was chasing after, given an ~9x improvement: {code:java} BASELINE Benchmark (numberOfElements) (sparseness) Mode Cnt Score Error Units DMNEvaluateDecisionTablesSparseBenchmark.evaluateDecision 100 10 ss 250 18.447 ± 0.633 ms/op AFTER Benchmark (numberOfElements) (sparseness) Mode Cnt Score Error Units DMNEvaluateDecisionTablesSparseBenchmark.evaluateDecision 100 10 ss 250 2.744 ± 0.180 ms/op {code} I believe the logback config should be changed in order to avoid introducing the degradation of execution time caused just by the logging framework, at least for those use-case when by standard we report Info, Error, etc. /cc [~tirelli] [~mfusco] -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4251) [DMN Designer] User can not save diagram with validation errors

by Michael Anstis (Jira)

[ https://issues.jboss.org/browse/DROOLS-4251?page=com.atlassian.jira.plugi... ] Michael Anstis commented on DROOLS-4251: ---------------------------------------- [~tirelli] [~tari_manga] FYI.. using _standard_ Stunner behaviour a DMN diagram that contains validation ERRORs *cannot* be saved. Our options are: # Map {{kie-dmn-validation}} ERRORs to Stunner WARNINGs # Relax the DMN editors use of Stunner to allow saving with ERRORs Which do you prefer? I have also linked [DROOLS-4187|https://issues.jboss.org/browse/DROOLS-4187] that is related; as it means *any* DMN diagram authored with our editor that imports another DMN file cannot be saved as an ERROR is reported (IMO, wrongly) by {{kie-dmn-validation}}. > [DMN Designer] User can not save diagram with validation errors > --------------------------------------------------------------- > > Key: DROOLS-4251 > URL: https://issues.jboss.org/browse/DROOLS-4251 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Affects Versions: 7.24.0.Final > Reporter: Jozef Marko > Assignee: Michael Anstis > Priority: Major > Labels: drools-tools > > User is unable to save the DMN diagram if there is a validation error, for example non existing variable reference. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4251) [DMN Designer] User can not save diagram with validation errors

by Jozef Marko (Jira)

Jozef Marko created DROOLS-4251: ----------------------------------- Summary: [DMN Designer] User can not save diagram with validation errors Key: DROOLS-4251 URL: https://issues.jboss.org/browse/DROOLS-4251 Project: Drools Issue Type: Bug Components: DMN Editor Affects Versions: 7.24.0.Final Reporter: Jozef Marko Assignee: Michael Anstis User is unable to save the DMN diagram if there is a validation error, for example non existing variable reference. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ELY-1832) Credential store updates

by Darran Lofthouse (Jira)

Darran Lofthouse created ELY-1832: ------------------------------------- Summary: Credential store updates Key: ELY-1832 URL: https://issues.jboss.org/browse/ELY-1832 Project: WildFly Elytron Issue Type: Enhancement Components: Credential Store Reporter: Darran Lofthouse For KeyStores we have implementations that can monitor for modification to the underlying file, we should review what could be applicable to credential store to potentially support automatic reloads if the file is modified and also monitor the last modified time to try and avoid writing to a store modified by a different process. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4250) Improve data source type resolving in OOPath

by Edoardo Vacchi (Jira)

[ https://issues.jboss.org/browse/DROOLS-4250?page=com.atlassian.jira.plugi... ] Edoardo Vacchi updated DROOLS-4250: ----------------------------------- Tester: Tibor Zimanyi > Improve data source type resolving in OOPath > -------------------------------------------- > > Key: DROOLS-4250 > URL: https://issues.jboss.org/browse/DROOLS-4250 > Project: Drools > Issue Type: Bug > Reporter: Edoardo Vacchi > Assignee: Edoardo Vacchi > Priority: Major > > Raise better errors when parsing OOPath and refactor some type-handling -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-4250) Improve data source type resolving in OOPath

by Edoardo Vacchi (Jira)

Edoardo Vacchi created DROOLS-4250: -------------------------------------- Summary: Improve data source type resolving in OOPath Key: DROOLS-4250 URL: https://issues.jboss.org/browse/DROOLS-4250 Project: Drools Issue Type: Bug Reporter: Edoardo Vacchi Assignee: Edoardo Vacchi Raise better errors when parsing OOPath and refactor some type-handling -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira June 2019