[JBoss JIRA] (DROOLS-4186) Guided Rules does not output parenthesis in DRL
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-4186?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-4186:
---------------------------------
Story Points: 3
> Guided Rules does not output parenthesis in DRL
> -----------------------------------------------
>
> Key: DROOLS-4186
> URL: https://issues.jboss.org/browse/DROOLS-4186
> Project: Drools
> Issue Type: Bug
> Components: Guided Template Editor
> Environment: RHDM 7.3
> Reporter: Karina Varela
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools, guided_rule_editor
>
> The Guided Rule is omitting one parenthesis from the generated DRL source. This behavior only happens on LHS.
> No errors are raised on the server logs.
> Expected source code:
> {code:java}
> Silverware( type in ("Spoon", "Spoon (fancy)") )
> {code}
> Generated source code:
> {code:java}
> Silverware( type in ("Spoon", "Spoon (fancy") )
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (WFLY-12194) Add a testcase that checks remote client transaction afinity in case of failed server
by Ondrej Chaloupka (Jira)
[ https://issues.jboss.org/browse/WFLY-12194?page=com.atlassian.jira.plugin... ]
Ondrej Chaloupka commented on WFLY-12194:
-----------------------------------------
for stateful bean there is such testcase in as testsuite here: https://github.com/wildfly/wildfly/blob/17.0.0.Final/testsuite/integratio...
The SFSB affinity works fine, the test should be enhanced for SLSB affinity as well.
> Add a testcase that checks remote client transaction afinity in case of failed server
> -------------------------------------------------------------------------------------
>
> Key: WFLY-12194
> URL: https://issues.jboss.org/browse/WFLY-12194
> Project: WildFly
> Issue Type: Enhancement
> Components: Test Suite
> Affects Versions: 17.0.0.Final
> Reporter: Ondrej Chaloupka
> Assignee: Ondrej Chaloupka
> Priority: Major
>
> The remote client transaction affinity is not well covered in testsuite.
> Particularly, it would be good to test what happens when a transaction starts on a standalone client. The call goes to a stateless bean. There are two servers started in server that the client can choose. The client starts transaction, calls the bean and then the server fails. Will be the next call to bean fails correctly? (as it could be expected as the affinity points to the non-existent server, despite the fact there is another server deploying the same stateless bean)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (DROOLS-4186) Guided Rules does not output parenthesis in DRL
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-4186?page=com.atlassian.jira.plugi... ]
Toni Rikkola moved RHDM-987 to DROOLS-4186:
-------------------------------------------
Project: Drools (was: Red Hat Decision Manager)
Key: DROOLS-4186 (was: RHDM-987)
Workflow: GIT Pull Request workflow (was: CDW with docs v1)
Docs QE Status: NEW
Component/s: Guided Template Editor
(was: Decision Central)
Affects Version/s: (was: 7.3.0.GA)
(was: 7.3.1.GA)
QE Status: NEW
> Guided Rules does not output parenthesis in DRL
> -----------------------------------------------
>
> Key: DROOLS-4186
> URL: https://issues.jboss.org/browse/DROOLS-4186
> Project: Drools
> Issue Type: Bug
> Components: Guided Template Editor
> Environment: RHDM 7.3
> Reporter: Karina Varela
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools, guided_rule_editor
>
> The Guided Rule is omitting one parenthesis from the generated DRL source. This behavior only happens on LHS.
> No errors are raised on the server logs.
> Expected source code:
> {code:java}
> Silverware( type in ("Spoon", "Spoon (fancy)") )
> {code}
> Generated source code:
> {code:java}
> Silverware( type in ("Spoon", "Spoon (fancy") )
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (DROOLS-4185) KieBuilder incremental compilation does not return Warns, infos
by Matteo Mortari (Jira)
Matteo Mortari created DROOLS-4185:
--------------------------------------
Summary: KieBuilder incremental compilation does not return Warns, infos
Key: DROOLS-4185
URL: https://issues.jboss.org/browse/DROOLS-4185
Project: Drools
Issue Type: Enhancement
Components: core engine
Reporter: Matteo Mortari
Assignee: Mario Fusco
Compiling with something like
{code:java}
final KieAssemblersImpl assemblers = (KieAssemblersImpl) ServiceRegistry.getInstance().get(KieAssemblers.class);
assemblers.accept(new DMNAssemblerService());
KieServices ks = KieServices.Factory.get();
KieFileSystem kfs = ks.newKieFileSystem();
kfs.write("src/main/resources/org/acme/test_scorecard.pmml", ks.getResources().newClassPathResource("test_scorecard.pmml", DMNRuntimeKiePMMLTest.class));
KieBuilder kieBuilder = ks.newKieBuilder(kfs).buildAll();
assertEquals(0, kieBuilder.getResults().getMessages(org.kie.api.builder.Message.Level.ERROR).size());
kfs.write("src/main/resources/org/acme/KiePMMLScoreCard_NOPMMLmodelName.dmn", ks.getResources().newClassPathResource("KiePMMLScoreCard_NOPMMLmodelName.dmn", DMNRuntimeKiePMMLTest.class));
IncrementalResults addResults = ((InternalKieBuilder) kieBuilder).createFileSet("src/main/resources/org/acme/KiePMMLScoreCard_NOPMMLmodelName.dmn").build();
LOG.debug("getAddedMessages: {}", addResults.getAddedMessages());
assertTrue(addResults.getAddedMessages().size() > 0);
{code}
would fail on the last assertion, as the WARN message is effectively generated as part of the build, but is not available in returned the list.
A full reproducer can be found with this PR:
https://github.com/kiegroup/drools/pull/2389
Suggestion: parametrize InternalKieBuilder#build to also return list of Warn or Info, besides of just returning list of errors?
More suggestions here: https://github.com/kiegroup/drools/pull/2389#discussion_r294185056
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (DROOLS-4169) Can't compile large .drl files with security manager turned on in tomcat
by Anthony Bruno (Jira)
[ https://issues.jboss.org/browse/DROOLS-4169?page=com.atlassian.jira.plugi... ]
Anthony Bruno commented on DROOLS-4169:
---------------------------------------
Hey [~tzimanyi],
Thanks for the response, and good pick up on the rules.policy file! Unfortunately, correcting the file does not fix the issue.
To clarify, this problem *only* happens when running in Tomcat. It works fine running standalone, as exemplified in the JUnit test you created.
> Can't compile large .drl files with security manager turned on in tomcat
> ------------------------------------------------------------------------
>
> Key: DROOLS-4169
> URL: https://issues.jboss.org/browse/DROOLS-4169
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.22.0.Final
> Environment: Java 11
> Tomcat 9
> Ubuntu 18.10/Amazon Linux AMI
> Reporter: Anthony Bruno
> Assignee: Mario Fusco
> Priority: Major
>
> Reproduction repository: https://github.com/AussieGuy0/drools-bug
> *Summary*
> When large rule (.drl) files are complied **with** the security manager turned
> on in a servlet container (e.g. Tomcat), it causes `AccessControlExceptions`, which causes `NoClassDefFoundErrors`.
> *Steps*
> Prereqs: Program is run in servlet context (e.g .war file in tomcat)
> 1. Turn on security manager
> 2. Provide policy files through the properties `java.security.policy` and `kie.security.policy`
> 3. Compile a `.drl` file that has more than `parallelRulesBuildThreshold` (default: 10) rules
> *Expected Result*
> Rules are compiled successfully
> *Actual Result*
> No class def error
> *Cause*
> In `KnowledgeBuilderImpl`, a `ForkJoinPool` is created and used for parallel building.
> A `ForkJoinPool` with no `ForkJoinWorkerThreadFactory` specified, it will use a default factory
> that provides it's own permissions. These permissions are not sufficient for compiling
> drl files in a servlet context.
> *Potential Fix*
> A potential fix is to allow the user to provide their own `ForkJoinWorkerThreadFactory` as a
> configuration option for drools.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months