[JBoss JIRA] (WFCORE-4565) Use ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFCORE-4565?page=com.atlassian.jira.plugi... ]
Brian Stansberry moved WFLY-12285 to WFCORE-4565:
-------------------------------------------------
Project: WildFly Core (was: WildFly)
Key: WFCORE-4565 (was: WFLY-12285)
Component/s: Management
(was: Management)
> Use ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG
> ---------------------------------------------------------------------------
>
> Key: WFCORE-4565
> URL: https://issues.jboss.org/browse/WFCORE-4565
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Management
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Priority: Major
>
> ModelNode declares constants ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG. Save memory and a bit of runtime cost by using these instead of the hundreds of 'new ModelNode(true)' etc.
> This kind of thing does the trick for me:
> find ~/dev/wildfly/wildfly -type f -name "*.java" -exec grep -i "new ModelNode(false)" -l {} \; -exec sed -i "" 's/new ModelNode(false)/ModelNode.FALSE/g' {} \;
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years
[JBoss JIRA] (WFCORE-4565) Use ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFCORE-4565?page=com.atlassian.jira.plugi... ]
Brian Stansberry updated WFCORE-4565:
-------------------------------------
Description:
ModelNode declares constants ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG. Save memory and a bit of runtime cost by using these instead of the hundreds of 'new ModelNode(true)' etc.
This kind of thing does the trick for me:
find ~/dev/wildfly/wildfly-core -type f -name "*.java" -exec grep -i "new ModelNode(false)" -l {} \; -exec sed -i "" 's/new ModelNode(false)/ModelNode.FALSE/g' {} \;
was:
ModelNode declares constants ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG. Save memory and a bit of runtime cost by using these instead of the hundreds of 'new ModelNode(true)' etc.
This kind of thing does the trick for me:
find ~/dev/wildfly/wildfly -type f -name "*.java" -exec grep -i "new ModelNode(false)" -l {} \; -exec sed -i "" 's/new ModelNode(false)/ModelNode.FALSE/g' {} \;
> Use ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG
> ---------------------------------------------------------------------------
>
> Key: WFCORE-4565
> URL: https://issues.jboss.org/browse/WFCORE-4565
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Management
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Priority: Major
>
> ModelNode declares constants ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG. Save memory and a bit of runtime cost by using these instead of the hundreds of 'new ModelNode(true)' etc.
> This kind of thing does the trick for me:
> find ~/dev/wildfly/wildfly-core -type f -name "*.java" -exec grep -i "new ModelNode(false)" -l {} \; -exec sed -i "" 's/new ModelNode(false)/ModelNode.FALSE/g' {} \;
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years
[JBoss JIRA] (WFLY-12284) Use ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG
by Brian Stansberry (Jira)
Brian Stansberry created WFLY-12284:
---------------------------------------
Summary: Use ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG
Key: WFLY-12284
URL: https://issues.jboss.org/browse/WFLY-12284
Project: WildFly
Issue Type: Enhancement
Components: Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
ModelNode declares constants ModelNode.TRUE, ModelNode.FALSE, ModelNode.ZERO and ModelNode.ZERO_LONG. Save memory and a bit of runtime cost by using these instead of the hundreds of 'new ModelNode(true)' etc.
This kind of thing does the trick for me:
find ~/dev/wildfly/wildfly -type f -name "*.java" -exec grep -i "new ModelNode(false)" -l {} \; -exec sed -i "" 's/new ModelNode(false)/ModelNode.FALSE/g' {} \;
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years
[JBoss JIRA] (WFLY-12031) Memory leak in wildfly transaction client
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFLY-12031?page=com.atlassian.jira.plugin... ]
Brian Stansberry resolved WFLY-12031.
-------------------------------------
Fix Version/s: 18.0.0.Beta1
Resolution: Done
Fixed via https://github.com/wildfly/wildfly/pull/12424
> Memory leak in wildfly transaction client
> -----------------------------------------
>
> Key: WFLY-12031
> URL: https://issues.jboss.org/browse/WFLY-12031
> Project: WildFly
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 15.0.1.Final
> Environment: wildfly-transaction-client-1.1.3.Final
> wildfly.15.0.1.Final
> Windows 10
> Reporter: Joachim Petrich
> Assignee: Cheng Fang
> Priority: Critical
> Fix For: 18.0.0.Beta1
>
>
> After a volume run of our system we recognized millions of entries in the openFilePaths Object of class FileSystemXAResourceRegistry. When enabling traces for org.wildfly.transaction it seems that for adding an entry a xid string is used
> {code:java}
> XAResourceRegistryFile(Xid xid) throws SystemException {
> xaRecoveryPath.toFile().mkdir(); // create dir if non existent
> final String xidString = SimpleXid.of(xid).toHexString('_');
> this.filePath = xaRecoveryPath.resolve(xidString);
> openFilePaths.add(*xidString*);
> {code}
> and for removing the entire file path:
> {code:java}
> protected void removeResource(XAResource resource) throws XAException {
> if (resources.remove(resource)) {
> if (resources.isEmpty()) {
> // delete file
> try {
> if (fileChannel != null) {
> fileChannel.close();
> }
> Files.delete(filePath);
> // deleting using the filepath as key caused a memory leak,
> // if xid string have been added, therefore build the xid string for removing
> openFilePaths.remove(*filePath.toString()*);
> {code}
> We didn't find any code where this xid are cleaned up.
> As workaround we additionally extract the xid String from the file path and remove the corresponding entry.
> {code:java}
> String xidString = filePath.toString().substring(filePath.toString().indexOf(
> xaRecoveryPath.toString()) + xaRecoveryPath.toString().length() + 1);
> openFilePaths.remove(xidString);
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years
[JBoss JIRA] (DROOLS-4142) [GSS-RFE] UX design: Find feature in GDST/DMN 7.5
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-4142?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-4142:
-------------------------------------------
[~aglass] When [~bdellasc] and I were discussing the icons we were trying to make a distinction between the function of Find and the function of Search. The former (in the near term for DMN) will just find text string matches within the canvas viewport of a specific tab and highlight it. Search feels a bit broader and would probably show results across contexts and provide a list of results with navigation (links) to them.
> [GSS-RFE] UX design: Find feature in GDST/DMN 7.5
> -------------------------------------------------
>
> Key: DROOLS-4142
> URL: https://issues.jboss.org/browse/DROOLS-4142
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Affects Versions: 7.23.0.Final
> Reporter: Elizabeth Clayton
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: UX, UXTeam, drools-tools
> Attachments: Example.png, Screen Shot 2019-05-30 at 5.14.30 PM.png
>
>
> This is a community epic for the [BAPL-1279|https://issues.jboss.org/browse/BAPL-1279]. The epic was created according to the [definition of ready|https://docs.google.com/document/d/1WKv_Cx7jCts7gCQCGt_323ANH_H7dv4...] that advices what needs to be agreed before each feature implementation.
> h1. Requirements
> See referenced document: https://docs.google.com/document/d/1VX_KhMhPgs2ZoOv7_jpfbl2o2-Y528UEImGk9...
> h1. Documentation
> - Replace picture of GDT and DMN editor where they become obsolete
> h1. Acceptance test
> - Enter to large amount of data in search box
> - Search is possible when you type only the part of indicated word. For example, if you type text like 'test', the words 'testing', 'tester' should be displayed.
> - Searching for non-existing result
> - Result appearing once
> - Result appearing multiple times
> - Set of inputs:
> *- A-Z
> *- a-z
> *- 0-9
> *- Symbols: } { ] [ ) ( ~ ! @ # $ % ^ & ` | \ : " ; ' < > ? , . ⁄ - +
> *- Blank spaces
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years