[JBoss JIRA] (WFLY-12299) More fine grain dependency for galleon basic layers
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFLY-12299?page=com.atlassian.jira.plugin... ]
Brian Stansberry commented on WFLY-12299:
-----------------------------------------
bstansberry 8 days ago Member
@jfdenise A question then would be whether we would provide other layers that depend on transactions but which don't also involve an a servlet container.
Not just whether they might exist in theory, but whether we would provide them. If we don't provide them, then the user who would want that would be somehow doing fairly complex provisioning config manipulation anyway, and excluding the servlet container / undertow parts would just be another part of that. Not unreasonable.
So what layer that would use transactions would we provide that doesn't have an HTTP endpoint? It would have to be something that involves some other remote access protocol (e.g. native remoting or IIOP or QPID.) Or something that doesn't involve listening for outside connections at all.
For the 'other remote access protocol' case, I don't see us providing such a layer. Our standard configs aim toward having a single HTTP socket for application use with HTTP Upgrade used if needed.
The "doesn't involve listening for outside connections at all" case is valid though. A server set up for batch jobs. Or a server that runs MDBs, where the messages processed by the MDB are pulled from a remote broker over a client socket, not a server socket.
> More fine grain dependency for galleon basic layers
> ---------------------------------------------------
>
> Key: WFLY-12299
> URL: https://issues.jboss.org/browse/WFLY-12299
> Project: WildFly
> Issue Type: Enhancement
> Components: Build System
> Reporter: Jean Francois Denise
> Assignee: Jean Francois Denise
> Priority: Major
>
> Having basic layers to only depend on the layers (and features) they do require will offer more flexibility than depending on web-server layer.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years
[JBoss JIRA] (WFLY-12299) More fine grain dependency for galleon basic layers
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFLY-12299?page=com.atlassian.jira.plugin... ]
Brian Stansberry commented on WFLY-12299:
-----------------------------------------
bstansberry 10 days ago Member
@jfdenise Does this need to depend on this aggregation layer, as opposed to specific detail layers from servlet f-p?
There are a few in this category. Here's what depends on web-server:
{code}
$ git grep "layer name=\"web-server\""
galleon-pack/src/main/resources/layers/standalone/cdi/layer-spec.xml: <layer name="web-server"/>
galleon-pack/src/main/resources/layers/standalone/h2-database/layer-spec.xml: <layer name="web-server"/>
galleon-pack/src/main/resources/layers/standalone/jaxrs/layer-spec.xml: <layer name="web-server"/>
galleon-pack/src/main/resources/layers/standalone/jms-activemq/layer-spec.xml: <layer name="web-server"/>
galleon-pack/src/main/resources/layers/standalone/jpa/layer-spec.xml: <layer name="web-server"/>
galleon-pack/src/main/resources/layers/standalone/observability/layer-spec.xml: <layer name="web-server"/>
galleon-pack/src/main/resources/layers/standalone/resource-adapters/layer-spec.xml: <layer name="web-server"/>
{code}
Obviously jaxrs needs web-server. The others it's less obvious that HTTP is required.
The advantage of doing it this way is for a servlet app with jpa support you can just say "jpa" instead of "web-server, jpa". And perhaps for compatibility reasons we have to leave it that way for the existing layers. But that doesn't apply to this 'transactions' one, since it is new.
Apologies if we've discussed this and I've forgotten. The wildfly-dev "Wildfly layers" doesn't have any discussion, other than your initial post that stated it would work this way.
> More fine grain dependency for galleon basic layers
> ---------------------------------------------------
>
> Key: WFLY-12299
> URL: https://issues.jboss.org/browse/WFLY-12299
> Project: WildFly
> Issue Type: Enhancement
> Components: Build System
> Reporter: Jean Francois Denise
> Assignee: Jean Francois Denise
> Priority: Major
>
> Having basic layers to only depend on the layers (and features) they do require will offer more flexibility than depending on web-server layer.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years
[JBoss JIRA] (WFLY-12299) More fine grain dependency for galleon basic layers
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFLY-12299?page=com.atlassian.jira.plugin... ]
Brian Stansberry commented on WFLY-12299:
-----------------------------------------
jfdenise 10 days ago Author Member
The idea was that web-server would be the minimal layer any "full feature (cdi, ...)" would require. Making the layer "runnable" and reachable from http.
transactions only requires elytron, so we could define the layer to only depend on elytron, but doing so it would have to be combined with other full features (if used outside cloud-profile or other layers that depend on it).
transaction is perhaps not a feature you add alone in your config, it is a dependency for top level layers. I agree that having it depend on elytron should be sufficient. It should be still runnable and you could combine it with smaller layers.
I would be ready to revisit them all and change documentation. They are not yet supported so changes can occur.
> More fine grain dependency for galleon basic layers
> ---------------------------------------------------
>
> Key: WFLY-12299
> URL: https://issues.jboss.org/browse/WFLY-12299
> Project: WildFly
> Issue Type: Enhancement
> Components: Build System
> Reporter: Jean Francois Denise
> Assignee: Jean Francois Denise
> Priority: Major
>
> Having basic layers to only depend on the layers (and features) they do require will offer more flexibility than depending on web-server layer.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years
[JBoss JIRA] (WFCORE-4570) PathAddress.toCLIStyleString() can output badly formatted values
by Kabir Khan (Jira)
[ https://issues.jboss.org/browse/WFCORE-4570?page=com.atlassian.jira.plugi... ]
Kabir Khan commented on WFCORE-4570:
------------------------------------
I think what confuses it is the appearance of "/" or "=" in the value
> PathAddress.toCLIStyleString() can output badly formatted values
> ----------------------------------------------------------------
>
> Key: WFCORE-4570
> URL: https://issues.jboss.org/browse/WFCORE-4570
> Project: WildFly Core
> Issue Type: Bug
> Reporter: Kabir Khan
> Assignee: Jeff Mesnil
> Priority: Major
>
> Trying PathAddress.toCLIStyleString() on the output operations from https://github.com/keycloak/keycloak/blob/master/adapters/oidc/wildfly/wi... I end up with addresses with strange characters like
> {code}
> /subsystem=keycloak/secure-deployment=web-console/redirect-rewrite-rule=^/wsmaster/api/(.*)$
> {code}
> If I try to add a system property with the same name in CLI I get an error, e.g.:
> {code}
> [standalone@embedded /] /system-property=^/wsmaster/api/(.*)$:add(value=xyx)
> Node path format is wrong around 'wsmaster' (index=19).
> {code}
> It seems that these need to be quoted and it all works
> {code}
> [standalone@embedded /] /system-property="^/wsmaster/api/(.*)$":add(value=xyx)
> {"outcome" => "success"}
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years