[JBoss JIRA] (WFLY-12374) Transactions store attributes have wrong configuration
by Michal Petrov (Jira)
Michal Petrov created WFLY-12374:
------------------------------------
Summary: Transactions store attributes have wrong configuration
Key: WFLY-12374
URL: https://issues.jboss.org/browse/WFLY-12374
Project: WildFly
Issue Type: Bug
Components: Transactions
Affects Versions: 17.0.1.Final
Reporter: Michal Petrov
Assignee: Michal Petrov
Transactions subsystem has these attributes:
* use-hornetq-store
* use-journal-store
* use-jdbc store
each of those has the other two set up as alternatives, however "journal" is an alias of "hornetq" and so those two shouldn't be treated as mutually exclusive.
(As far as I know this doesn't break anything because of the way the attributes are handled, but it poses a problem for WFCORE-4287)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (WFWIP-167) EAP Operator handling ConfigMap internally
by Ken Wills (Jira)
[ https://issues.jboss.org/browse/WFWIP-167?page=com.atlassian.jira.plugin.... ]
Ken Wills commented on WFWIP-167:
---------------------------------
As I recall in the past, the problem with using a ConfigMap for standalone.xml was that as configmaps are unversioned, a change could be made that invalidates the config and not have a way to roll back. I haven't looked closely at the plan for the operatior, but having the operator manage the available versions would potentially avoid this concern and allow rollback etc. (The spec supports a specific name, so this could include a version.)
WRT to restarts, a simple approach would be to configure EAP to have a deployment trigger on the ConfigMap (which I think is supported, thought I'm not 100% sure) -- but in any case the operator is in a position to handle the deployment strategy.
[~mchoma] FWIW, the kubectl / oc tools may be an appropriate way to manage an external update of the standalone.xml in the ConfigMap, that would be a more appropriate way of fetching and importing the content from whatever source (URL, local file) the user would like to use.
> EAP Operator handling ConfigMap internally
> ------------------------------------------
>
> Key: WFWIP-167
> URL: https://issues.jboss.org/browse/WFWIP-167
> Project: WildFly WIP
> Issue Type: Bug
> Components: OpenShift
> Reporter: Martin Choma
> Assignee: Jeff Mesnil
> Priority: Major
>
> If I understand description in [1] correctly. To specify custom standalone.xml I have to create ConfigMap with standalone.xml first and afterwards link operator to this ConfigMap.
> Is it possible to handle creation of ConfigMap and storing standalone.xml for me? Ideally I just specify file URI where custom standalone.xml is located. This location have to be accessible from operator pod. In this way we can look at it as hiding internals (implementation details) from users.
> Currently when user wants to change standalone.xml he does in ConfigMap, not operator. When changing standalone.xml through config map, I assume pod have to be restarted manually. Operator could do that for me.
> However this can be triggered by storing newer version of standalone.xml under another key, eg `standalone.xml.v2` and changing `StandaloneConfigMapSpec.key` in operator.
> What do you think? Have you considered this approach?
> [1] https://github.com/wildfly/wildfly-operator/blob/master/doc/apis.adoc#sta...
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (DROOLS-4245) [DMN Designer] Documentation - Enhance presentation
by Brian Dellascio (Jira)
[ https://issues.jboss.org/browse/DROOLS-4245?page=com.atlassian.jira.plugi... ]
Brian Dellascio commented on DROOLS-4245:
-----------------------------------------
I'll make the changes to the mockups. Anyone know where I can get a the Drools logo to incorporate into my mockup? A vector file would be preferable.
> [DMN Designer] Documentation - Enhance presentation
> ---------------------------------------------------
>
> Key: DROOLS-4245
> URL: https://issues.jboss.org/browse/DROOLS-4245
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Elizabeth Clayton
> Assignee: Brian Dellascio
> Priority: Major
> Labels: UX, UXTeam, VisualDesign, drools-tools
> Attachments: RedHat_KIE_logo.eps, RedHat_KIE_logo.png, RedHat_KIE_logo.svg, doc.pdf, logo.png, new_doc.pdf
>
>
> Enhance styles and presentation of the Documentation output.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (WFLY-12373) Fix contended MSC Supplier.get() call in Jsr299BindingsInterceptor.processInvocation
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFLY-12373?page=com.atlassian.jira.plugin... ]
Brian Stansberry updated WFLY-12373:
------------------------------------
Summary: Fix contended MSC Supplier.get() call in Jsr299BindingsInterceptor.processInvocation (was: Fix contended MSC Supplier.get() call in Jsr299BindingsInterceptor.processInvocation()
> Fix contended MSC Supplier.get() call in Jsr299BindingsInterceptor.processInvocation
> ------------------------------------------------------------------------------------
>
> Key: WFLY-12373
> URL: https://issues.jboss.org/browse/WFLY-12373
> Project: WildFly
> Issue Type: Sub-task
> Components: CDI / Weld
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Priority: Major
>
> WFLY-11381 changed Jsr299BindingsInterceptor.processInvocation from using InjectValue.getValue() to using Supplier.get() resulting in the kind of concurrency problem noted in the parent issue.
> Possible solutions are to revert some part of that change or to cache the value in the interceptor.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (WFLY-12373) Fix contended MSC Supplier.get() call in Jsr299BindingsInterceptor.processInvocation(
by Brian Stansberry (Jira)
Brian Stansberry created WFLY-12373:
---------------------------------------
Summary: Fix contended MSC Supplier.get() call in Jsr299BindingsInterceptor.processInvocation(
Key: WFLY-12373
URL: https://issues.jboss.org/browse/WFLY-12373
Project: WildFly
Issue Type: Sub-task
Components: CDI / Weld
Reporter: Brian Stansberry
Assignee: Brian Stansberry
WFLY-11381 changed Jsr299BindingsInterceptor.processInvocation from using InjectValue.getValue() to using Supplier.get() resulting in the kind of concurrency problem noted in the parent issue.
Possible solutions are to revert some part of that change or to cache the value in the interceptor.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (WFLY-12372) Performance impact of moving from InjectedValue.getValue() reads to MSC Supplier impl get() reads
by Brian Stansberry (Jira)
Brian Stansberry created WFLY-12372:
---------------------------------------
Summary: Performance impact of moving from InjectedValue.getValue() reads to MSC Supplier impl get() reads
Key: WFLY-12372
URL: https://issues.jboss.org/browse/WFLY-12372
Project: WildFly
Issue Type: Bug
Components: MSC, Server
Affects Versions: 17.0.1.Final
Reporter: Brian Stansberry
Assignee: Richard Opalka
A byproduct of the move from the deprecated MSC org.jboss.msc.service.Service API to the new org.jboss.msc.Service API is that service wiring is shifted from a service getting refs to dependencies via InjectedValue.getValue() to Supplier.get() calls where the supplier is obtained from a ServiceBuilder.requires(....) call.
The concurrency characteristics of these two calls are different, which can result in performance changes if the calls are frequent; i.e. are part of high volume user request handling call paths. For example:
{code}
org.jboss.msc.service.ServiceRegistrationImpl.getValue()
org.jboss.msc.service.ReadableValueImpl.get()
org.jboss.as.weld.interceptors.Jsr299BindingsInterceptor.processInvocation(InterceptorContext) org.jboss.as.ee.component.interceptors.UserInterceptorFactory$1.processInvocation(InterceptorContext)
org.jboss.invocation.InterceptorContext.proceed()
{code}
An InjectedValue.getValue() call involves a read of a volatile field, followed by a read of the getValue() method of the service impl, which is typically also a read of a volatile field. The stack trace above shows how the Supplier.get() call is handled. The issue is the ServiceRegistrationImpl.getValue() call includes a synchronization lock on the ServiceRegistrationImpl value, which means the call is a concurrency chokepoint if it's used by many requests.
We need to examine the changes we've made related to this MSC API switch and identify and correct cases where this kind of thing has crept in.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (DROOLS-4245) [DMN Designer] Documentation - Enhance presentation
by Stetson Robinson (Jira)
[ https://issues.jboss.org/browse/DROOLS-4245?page=com.atlassian.jira.plugi... ]
Stetson Robinson commented on DROOLS-4245:
------------------------------------------
I still vote KIE and Red Hat as the options, even if just "supported by Red Hat". Rather than getting specific with product logos. Just to keep it simple and applicable for other product components too, so it's easier to be consistent. My two cents.
> [DMN Designer] Documentation - Enhance presentation
> ---------------------------------------------------
>
> Key: DROOLS-4245
> URL: https://issues.jboss.org/browse/DROOLS-4245
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Elizabeth Clayton
> Assignee: Brian Dellascio
> Priority: Major
> Labels: UX, UXTeam, VisualDesign, drools-tools
> Attachments: RedHat_KIE_logo.eps, RedHat_KIE_logo.png, RedHat_KIE_logo.svg, doc.pdf, logo.png, new_doc.pdf
>
>
> Enhance styles and presentation of the Documentation output.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (DROOLS-4245) [DMN Designer] Documentation - Enhance presentation
by Edson Tirelli (Jira)
[ https://issues.jboss.org/browse/DROOLS-4245?page=com.atlassian.jira.plugi... ]
Edson Tirelli commented on DROOLS-4245:
---------------------------------------
I will make the call then. :)
* Please use the Drools logo on this report instead of Kie, make it less pronounced (maybe a bit smaller?).
* The most important item on the whole cover page is the model name: "Loan Comparison". So whenever someone looks at this page, the one thing they need to see first is that name. Suggestion: remove the "DMN Model Documentation" title, replacing it with the model name.
Thank you, everything else looks great!
> [DMN Designer] Documentation - Enhance presentation
> ---------------------------------------------------
>
> Key: DROOLS-4245
> URL: https://issues.jboss.org/browse/DROOLS-4245
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Elizabeth Clayton
> Assignee: Brian Dellascio
> Priority: Major
> Labels: UX, UXTeam, VisualDesign, drools-tools
> Attachments: RedHat_KIE_logo.eps, RedHat_KIE_logo.png, RedHat_KIE_logo.svg, doc.pdf, logo.png, new_doc.pdf
>
>
> Enhance styles and presentation of the Documentation output.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (SWSQE-925) Allow to specify a branch for UI tests
by Filip Brychta (Jira)
Filip Brychta created SWSQE-925:
-----------------------------------
Summary: Allow to specify a branch for UI tests
Key: SWSQE-925
URL: https://issues.jboss.org/browse/SWSQE-925
Project: Kiali QE
Issue Type: QE Task
Reporter: Filip Brychta
Assignee: Filip Brychta
There are some UI differences between kiali v1.0 branch (GA branch) and the master so the UI tests are different. We need to specify branch for UI tests to run correct set of tests.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months