[JBoss JIRA] (DROOLS-4257) DMN UX - overlay information about an entire simulation execution
by Elizabeth Clayton (Jira)
[ https://issues.jboss.org/browse/DROOLS-4257?page=com.atlassian.jira.plugi... ]
Elizabeth Clayton commented on DROOLS-4257:
-------------------------------------------
Thanks [~kkufova], I wasn't sure if this jira reflected the latest direction. Sounds like it does. As such, [~mmenestr] let's work together to coordinate the design for both editors.
> DMN UX - overlay information about an entire simulation execution
> -----------------------------------------------------------------
>
> Key: DROOLS-4257
> URL: https://issues.jboss.org/browse/DROOLS-4257
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Affects Versions: 7.24.0.Final
> Reporter: Daniele Zonca
> Assignee: Margot Menestrot
> Priority: Major
> Labels: ScenarioSimulation, UX, UXTeam, drools-tools
>
> Related to https://issues.jboss.org/browse/DROOLS-3731
> This task will cover this use case:
> - user creates a DMN model
> - user creates a Test Scenario with some scenarios
> - user executes the Test Scenario
> - user open Coverage Report
> - user wants to analyze coverage information of {color:red}the *whole* simulation{color}
> - user clicks on "a link" near global coverage information
> - user lands on DMN editor with overlay information about number of time each decision has been executed, number of time each decision succeed/fail (maybe with different colors?)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4382) Executable-model build error with "matches" and fuction with a fact property as an argument
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-4382?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-4382:
---------------------------------
Tester: Tibor Zimanyi
Story Points: 3
> Executable-model build error with "matches" and fuction with a fact property as an argument
> -------------------------------------------------------------------------------------------
>
> Key: DROOLS-4382
> URL: https://issues.jboss.org/browse/DROOLS-4382
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.24.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Major
> Labels: support
>
> When a rule uses "matches" and class function and its argument is a property of the fact,
> for example)
> {noformat}
> import org.drools.modelcompiler.domain.Person;
> import static org.drools.modelcompiler.domain.MyFunctions.*;
> rule R when
> $a : Person( name matches testMatch(likes) )
> then
> end
> {noformat}
> It fails to build in executable-model
> {noformat}
> [ERROR] testMatchesClassFunctionWithArg[FLOW_DSL](org.drools.modelcompiler.CompilerTest) Time elapsed: 0.346 s <<< ERROR!
> java.lang.IllegalArgumentException: Cannot get expression type by name _this!
> at org.drools.modelcompiler.builder.generator.DrlxParseUtil.lambda$expressionTypeNameExpr$2(DrlxParseUtil.java:246)
> at java.util.Optional.orElseThrow(Optional.java:290)
> at org.drools.modelcompiler.builder.generator.DrlxParseUtil.expressionTypeNameExpr(DrlxParseUtil.java:246)
> at org.drools.modelcompiler.builder.generator.DrlxParseUtil.getExpressionType(DrlxParseUtil.java:180)
> at org.drools.modelcompiler.builder.generator.expressiontyper.ExpressionTyper.processFirstNode(ExpressionTyper.java:549)
> {noformat}
> It works with non-executable-model.
> Additonal note: When running kie-maven-plugin with -DgenerateModel=YES in 7.23.0.Final-redhat-00002 (RHDM 7.4.0), the error message is "No value present".
> {noformat}
> [ERROR] Failed to execute goal org.kie:kie-maven-plugin:7.23.0.Final-redhat-00002:generateModel (default-generateModel) on project model-map-evaluation-rule: Execution default-generateModel of goal org.kie:kie-maven-plugin:7.23.0.Final-redhat-00002:generateModel failed: No value present -> [Help 1]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4375) BigDecimal in from accumulate with MVEL with executable-model
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-4375?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-4375:
---------------------------------
Tester: Tibor Zimanyi
Story Points: 3
> BigDecimal in from accumulate with MVEL with executable-model
> -------------------------------------------------------------
>
> Key: DROOLS-4375
> URL: https://issues.jboss.org/browse/DROOLS-4375
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.24.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Major
> Labels: support
>
> When "from accumulate" uses BigDecimal with Mvel syntax,
> for example)
> {noformat}
> import org.drools.modelcompiler.domain.Person;
> import java.math.BigDecimal;
> global java.util.List list;
> dialect "mvel"
> rule R when
> $b : BigDecimal() from accumulate (
> Person( $money : money ),
> init( BigDecimal sum = 0; ),
> action( sum += $money; ),
> reverse( sum -= $money; ),
> result( sum )
> )
> then
> list.add($b);
> end
> {noformat}
> It works with non executable-model but fails with executable-model.
> {noformat}
> [ERROR] Failures:
> [ERROR] AccumulateTest.testFromAccumulateBigDecimalMvel:1273->BaseModelTest.getKieSession:99->BaseModelTest.getKieSession:103->BaseModelTest.getKieContainer:107->BaseModelTest.getKieContainer:114->BaseModelTest.createKieBuilder:125->BaseModelTest.createKieBuilder:152 [Message [id=1, level=ERROR, path=src/main/java/defaultpkg/RAccumulate6.java, line=28, column=20
> text=incompatible types: int cannot be converted to java.math.BigDecimal], Message [id=2, level=ERROR, path=src/main/java/defaultpkg/RAccumulate6.java, line=32, column=18
> text=bad operand types for binary operator '+'
> first type: java.math.BigDecimal
> second type: java.math.BigDecimal], Message [id=3, level=ERROR, path=src/main/java/defaultpkg/RAccumulate6.java, line=36, column=18
> text=bad operand types for binary operator '-'
> first type: java.math.BigDecimal
> second type: java.math.BigDecimal], Message [id=4, level=ERROR, path=src/main/java/defaultpkg/RAccumulate6.java, line=0, column=0
> text=Java source of src/main/java/defaultpkg/RAccumulate6.java in error:
> package defaultpkg
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4381) BigDecimal and primitive comparison error in executable-model build
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-4381?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-4381:
---------------------------------
Tester: Tibor Zimanyi
Story Points: 3
> BigDecimal and primitive comparison error in executable-model build
> -------------------------------------------------------------------
>
> Key: DROOLS-4381
> URL: https://issues.jboss.org/browse/DROOLS-4381
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.24.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Major
> Labels: support
>
> When you compare BigDecimal (but the field type is Object) with primitive int,
> {noformat}
> import org.drools.modelcompiler.domain.Result;
> rule "rule1"
> when
> $r : Result( value <= 20 )
> then
> end
> {noformat}
> executable-model build fails.
> {noformat}
> [ERROR] Failures:
> [ERROR] CompilerTest.testBigDecimalIntCoercion:1901->BaseModelTest.getKieSession:99->BaseModelTest.getKieSession:103->BaseModelTest.getKieContainer:107->BaseModelTest.getKieContainer:114->BaseModelTest.createKieBuilder:125->BaseModelTest.createKieBuilder:152 [Message [id=1, level=ERROR, path=src/main/java/defaultpkg/RulesC992C95703C3473926B5B025D30097DARuleMethods0.java, line=24, column=122
> text=no suitable method found for lessOrEqualNumbers(java.lang.Object,int)
> method org.drools.modelcompiler.util.EvaluationUtil.lessOrEqualNumbers(java.lang.Number,java.lang.Number) is not applicable
> (argument mismatch; java.lang.Object cannot be converted to java.lang.Number)
> method org.drools.modelcompiler.util.EvaluationUtil.lessOrEqualNumbers(java.lang.Long,java.lang.Long) is not applicable
> (argument mismatch; java.lang.Object cannot be converted to java.lang.Long)], Message [id=2, level=ERROR, path=src/main/java/defaultpkg/RulesC992C95703C3473926B5B025D30097DARuleMethods0.java, line=0, column=0
> text=Java source of src/main/java/defaultpkg/RulesC992C95703C3473926B5B025D30097DARuleMethods0.java in error:
> {noformat}
> Non executable-model works with the rule.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4374) Compilation error for "from accumulate" init() with executable-model or not
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-4374?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-4374:
---------------------------------
Tester: Tibor Zimanyi
Story Points: 3
> Compilation error for "from accumulate" init() with executable-model or not
> ---------------------------------------------------------------------------
>
> Key: DROOLS-4374
> URL: https://issues.jboss.org/browse/DROOLS-4374
> Project: Drools
> Issue Type: Bug
> Components: core engine, executable model
> Affects Versions: 7.24.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Minor
> Labels: support
>
> If we miss a semicolon in init() of "from accumulate",
> for example)
> {noformat}
> import org.drools.modelcompiler.domain.Person;
> rule R when
> $sum : Integer() from accumulate (
> Person( age > 18, $age : age ),
> init( int sum = 0 ),
> action( sum += $age; ),
> reverse( sum -= $age; ),
> result( sum )
> )
> then
> insert($sum);
> end
> {noformat}
> - Not executable-model -> The DRL is compiled and executed successfully
> - Executable-model -> Throws ParseProblemException
> {noformat}
> com.github.javaparser.ParseProblemException: (line 1,col 12) Parse error. Found "}", expected one of "!=" "%" "%=" "&" "&&" "&=" "*" "*=" "+" "+=" "," "-" "-=" "->" "/" "/=" "::" ";" "<" "<<=" "<=" "=" "==" ">" ">=" ">>=" ">>>=" "?" "^" "^=" "instanceof" "|" "|=" "||"
> Problem stacktrace :
> com.github.javaparser.GeneratedJavaParser.generateParseException(GeneratedJavaParser.java:10567)
> com.github.javaparser.GeneratedJavaParser.jj_consume_token(GeneratedJavaParser.java:10426)
> com.github.javaparser.GeneratedJavaParser.BlockStatement(GeneratedJavaParser.java:3847)
> com.github.javaparser.GeneratedJavaParser.Statements(GeneratedJavaParser.java:1644)
> com.github.javaparser.GeneratedJavaParser.Block(GeneratedJavaParser.java:3822)
> com.github.javaparser.GeneratedJavaParser.BlockParseStart(GeneratedJavaParser.java:5687)
> com.github.javaparser.JavaParser.parse(JavaParser.java:115)
> com.github.javaparser.JavaParser.parseBlock(JavaParser.java:309)
> com.github.javaparser.StaticJavaParser.parseBlock(StaticJavaParser.java:240)
> org.drools.modelcompiler.builder.generator.visitor.accumulate.AccumulateVisitor.visitAccInlineCustomCode(AccumulateVisitor.java:434)
> ...
> {noformat}
> I'm not very sure how it should be fixed. I filed this because of discrepancy between Executable-model and Not executable-model
> Poosible choices are:
> - Fail even in case of Not executable-model
> - Success in case of Executable-model
> Additonal Note: If we miss a semicolon in action(), a more understandable error message is thrown.
> {noformat}
> [Message [id=1, kieBase=defaultKieBase, level=ERROR, path=r0.drl, line=2, column=0
> text=Rule Compilation error Syntax error, insert ":: IdentifierOrNew" to complete Expression
> Syntax error, insert ";" to complete Statement]]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4377) Comparison error with primitive and Map in executable-model
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-4377?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-4377:
---------------------------------
Story Points: 3
> Comparison error with primitive and Map in executable-model
> -----------------------------------------------------------
>
> Key: DROOLS-4377
> URL: https://issues.jboss.org/browse/DROOLS-4377
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.24.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Major
> Labels: support
>
> When comparing a primitive int with an Integer inside a Map,
> {noformat}
> import java.util.Map;
> import org.drools.modelcompiler.domain.Person;
> rule R1 when
> $m : Map()
> Person(age == $m['age'] )
> then
> end
> {noformat}
> executable-model build fails with "Comparison operation requires compatible types. Found int and class java.lang.Object" even though the Map's value is Integer.
> {noformat}
> [ERROR] Failures:
> [ERROR] CompilerTest.testMapPrimitiveComparison:1905->BaseModelTest.getKieSession:99->BaseModelTest.getKieSession:103->BaseModelTest.getKieContainer:107->BaseModelTest.getKieContainer:114->BaseModelTest.createKieBuilder:125->BaseModelTest.createKieBuilder:152 [Message [id=1, kieBase=defaultKieBase, level=ERROR, path=r0.drl, line=-1, column=0
> text=Comparison operation requires compatible types. Found int and class java.lang.Object]]
> {noformat}
> Non executable-model has no issue with the rule.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4377) Comparison error with primitive and Map in executable-model
by Luca Molteni (Jira)
[ https://issues.jboss.org/browse/DROOLS-4377?page=com.atlassian.jira.plugi... ]
Luca Molteni updated DROOLS-4377:
---------------------------------
Tester: Tibor Zimanyi
> Comparison error with primitive and Map in executable-model
> -----------------------------------------------------------
>
> Key: DROOLS-4377
> URL: https://issues.jboss.org/browse/DROOLS-4377
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.24.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Major
> Labels: support
>
> When comparing a primitive int with an Integer inside a Map,
> {noformat}
> import java.util.Map;
> import org.drools.modelcompiler.domain.Person;
> rule R1 when
> $m : Map()
> Person(age == $m['age'] )
> then
> end
> {noformat}
> executable-model build fails with "Comparison operation requires compatible types. Found int and class java.lang.Object" even though the Map's value is Integer.
> {noformat}
> [ERROR] Failures:
> [ERROR] CompilerTest.testMapPrimitiveComparison:1905->BaseModelTest.getKieSession:99->BaseModelTest.getKieSession:103->BaseModelTest.getKieContainer:107->BaseModelTest.getKieContainer:114->BaseModelTest.createKieBuilder:125->BaseModelTest.createKieBuilder:152 [Message [id=1, kieBase=defaultKieBase, level=ERROR, path=r0.drl, line=-1, column=0
> text=Comparison operation requires compatible types. Found int and class java.lang.Object]]
> {noformat}
> Non executable-model has no issue with the rule.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (WFCORE-4592) WildFly Core doesn't compile on Open JDK 14 anymore
by Richard Opalka (Jira)
[ https://issues.jboss.org/browse/WFCORE-4592?page=com.atlassian.jira.plugi... ]
Richard Opalka commented on WFCORE-4592:
----------------------------------------
Caused by: https://bugs.openjdk.java.net/browse/JDK-8191138
> WildFly Core doesn't compile on Open JDK 14 anymore
> ---------------------------------------------------
>
> Key: WFCORE-4592
> URL: https://issues.jboss.org/browse/WFCORE-4592
> Project: WildFly Core
> Issue Type: Task
> Components: Security
> Environment: Since Open JDK 14 EA build 8 including
> Reporter: Richard Opalka
> Assignee: Darran Lofthouse
> Priority: Blocker
> Fix For: 10.0.0.Beta3
>
>
> [INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR] /home/opalka/git/redhat/wildfly-core/domain-management/src/main/java/org/jboss/as/domain/management/security/JaasCallbackHandler.java:[224,51] cannot access java.security.acl.Group
> class file for java.security.acl.Group not found
> [INFO] 1 error
> [INFO] -------------------------------------------------------------
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (WFCORE-4592) WildFly Core doesn't compile on Open JDK 14 anymore
by Richard Opalka (Jira)
Richard Opalka created WFCORE-4592:
--------------------------------------
Summary: WildFly Core doesn't compile on Open JDK 14 anymore
Key: WFCORE-4592
URL: https://issues.jboss.org/browse/WFCORE-4592
Project: WildFly Core
Issue Type: Task
Components: Security
Environment: Since Open JDK 14 EA build 8 including
Reporter: Richard Opalka
Assignee: Darran Lofthouse
Fix For: 10.0.0.Beta3
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/opalka/git/redhat/wildfly-core/domain-management/src/main/java/org/jboss/as/domain/management/security/JaasCallbackHandler.java:[224,51] cannot access java.security.acl.Group
class file for java.security.acl.Group not found
[INFO] 1 error
[INFO] -------------------------------------------------------------
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (WFLY-12337) Wildfly Transaction REQUIRES_NEW not working
by Hao Chen (Jira)
[ https://issues.jboss.org/browse/WFLY-12337?page=com.atlassian.jira.plugin... ]
Hao Chen commented on WFLY-12337:
---------------------------------
I already created asked https://developer.jboss.org/message/990310, but the only response was suggesting me to create a jira.
> Wildfly Transaction REQUIRES_NEW not working
> --------------------------------------------
>
> Key: WFLY-12337
> URL: https://issues.jboss.org/browse/WFLY-12337
> Project: WildFly
> Issue Type: Bug
> Components: JCA, Transactions
> Affects Versions: 16.0.0.Final
> Reporter: Hao Chen
> Assignee: Thomas Jenkinson
> Priority: Major
>
> We recently upgraded from jboss-eap-6.4 to Wildfly 16. Most things worked fine until we find one issue in the case that a method that is called using TransactionTemplate with TransactionDefinition.PROPAGATION_REQUIRES_NEW is not working...
> The case is that: we use this PROPAGATION_REQUIRES_NEW transaction to commit a log of login failure, while the main transaction is rolled back due login exception.
> This used to work without problem in jboss-eap-6.4 though we were seeing warnings like:
> Trying to change transaction TransactionImple < ac, BasicAction: 0:ffff0a004b01:513406f2:5d37ce0b:2a0 status: ActionStatus.RUNNING > in enlist!
> But in Wildfly 16 PROPAGATION_REQUIRES_NEW doesn't work any more -- the new transaction seems to rolled back together with the main transaction. After spending quite some time debugging into the Wildfly/Jboss code, I found that in org.jboss.jca.core.connectionmanager.listener.TxConnectionListener.enlist method, there is a new line:
> if (isEnlisted() || getState().equals(ConnectionState.DESTROY) || getState().equals(ConnectionState.DESTROYED))
> return;
> And in our case, the TxConnectionListener object is the same in the new transaction as in the old transaction, so it's already marked as "enlisted". And therefore the rest of enlist is never executed for the new transaction, so Wildfly never issued a "XA Start" command for the new transaction.
> So the question is: is the added isEnlisted() check a bug introduced or there is something wrong we did to configure Wildfly and/or Spring? How should the REUIRES_NEW case work?
> Here is a trace except I captured:
> TransactionTemplate.execute(TransactionCallback<T>) line: 130 JtaTransactionManager(AbstractPlatformTransactionManager).getTransaction(TransactionDefinition) line: 353 JtaTransactionManager(AbstractPlatformTransactionManager).handleExistingTransaction(TransactionDefinition, Object, boolean) line: 433
> JtaTransactionManager.doBegin(Object, TransactionDefinition) line: 831
> JtaTransactionManager.doJtaBegin(JtaTransactionObject, TransactionDefinition) line: 872
> LocalUserTransaction.begin() line: 48
> ContextTransactionManager.begin(CreationListener$CreatedBy) line: 62
> LocalTransactionContext.beginTransaction(int, boolean, CreationListener$CreatedBy) line: 188 JBossJTALocalTransactionProvider(JBossLocalTransactionProvider).createNewTransaction(int)
> ...
> ContextTransactionManager.resume(AbstractTransaction) line: 158
> LocalTransaction.resume() line: 248
> TransactionManagerDelegate(BaseTransactionManagerDelegate).resume(Transaction) line: 122
> TransactionManagerImple.resume(Transaction) line: 111
> AtomicAction.resume(AtomicAction) line: 361
> LocalTransaction(AbstractTransaction).notifyAssociationListeners(boolean) line: 115
> TransactionManagerService$2.associationChanged(AbstractTransaction, boolean) line: 97
> UserTransactionRegistry.userTransactionStarted() line: 119
> UserTransactionListenerImpl.userTransactionStarted() line: 52
> CachedConnectionManagerImpl.userTransactionStarted() line: 249
> TxConnectionManagerImpl.transactionStarted(Collection<ConnectionRecord>) line: 460
> TxConnectionListener.enlist() line: 264
> !-- changed in ironjacamar-core-impl-1.2
> // If we are already enlisted there is no reason to check again, as this method
> // could be called multiple times during a transaction lifecycle.
> // We know that we can only be inside this method if we are allowed to
> if (isEnlisted() || getState().equals(ConnectionState.DESTROY) || getState().equals(ConnectionState.DESTROYED))
> return;
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months