[JBoss JIRA] (DROOLS-4314) [DMN Designer] Rename 1.1 package to a generic name (since it covers DMN 1.2 too)
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-4314?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-4314:
-----------------------------------
Sprint: 2019 Week 29-31, 2019 Week 32-34 (was: 2019 Week 29-31)
> [DMN Designer] Rename 1.1 package to a generic name (since it covers DMN 1.2 too)
> ---------------------------------------------------------------------------------
>
> Key: DROOLS-4314
> URL: https://issues.jboss.org/browse/DROOLS-4314
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Guilherme Gomes
> Assignee: Guilherme Gomes
> Priority: Major
> Labels: drools-tools
> Attachments: Vacation Day Count - Solution 1.dmn
>
>
> h3. Acceptance test
> - Build the kie-wb-common
> - Build the kie-wb-distributions/business-central-parent/business-central-webapp
> - Deploy the obtained war on eap
> - Create new project, create new DMN asset, create some nodes in this asset, build the project
> - Try to import and open [^Vacation Day Count - Solution 1.dmn] that comes from external DMN modeler
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4321) [DMN Designer] Search feature - DMN Data Types must be searchable elements
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-4321?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-4321:
-----------------------------------
Sprint: 2019 Week 29-31, 2019 Week 32-34 (was: 2019 Week 29-31)
> [DMN Designer] Search feature - DMN Data Types must be searchable elements
> ---------------------------------------------------------------------------
>
> Key: DROOLS-4321
> URL: https://issues.jboss.org/browse/DROOLS-4321
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Guilherme Gomes
> Assignee: Guilherme Gomes
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot from 2019-08-02 10-47-30.png, Screenshot from 2019-08-02 10-49-33.png, collapsed.webm, search-edit.webm
>
>
> Currently, the search component indexes only GDT cells, DRG elements, and Boxed Expressions. It must index Data Types too.
> h3. Acceptance test
> On both Firefox and Chrome
> - Search when data types collapsed (x) [^collapsed.webm]
> - Search in nested structures, Structure in Structure (/)
> - Search _Constraints_ (x) !Screenshot from 2019-08-02 10-47-30.png|thumbnail!
> - Search _Is List_ (x) !Screenshot from 2019-08-02 10-49-33.png|thumbnail!
> - Search data type, edit it, save, continue search (x) [^search-edit.webm]
> - Search data type, remove it (x) same as above
> - Search data type, matches that needs scrolling (/)
> - Search Data Type, Search Model, Search Data Type (x)
> -- the issue of switching search context is that it assumes the context of previous screen until you press enter
> - Search DataType, Switch to Model->Expression, keyboard shortcuts need to work (/)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4374) Compilation error for "from accumulate" init() with executable-model or not
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-4374?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-4374:
-----------------------------------
Sprint: 2019 Week 29-31, 2019 Week 32-34 (was: 2019 Week 29-31)
> Compilation error for "from accumulate" init() with executable-model or not
> ---------------------------------------------------------------------------
>
> Key: DROOLS-4374
> URL: https://issues.jboss.org/browse/DROOLS-4374
> Project: Drools
> Issue Type: Bug
> Components: core engine, executable model
> Affects Versions: 7.24.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Minor
> Labels: support
>
> If we miss a semicolon in init() of "from accumulate",
> for example)
> {noformat}
> import org.drools.modelcompiler.domain.Person;
> rule R when
> $sum : Integer() from accumulate (
> Person( age > 18, $age : age ),
> init( int sum = 0 ),
> action( sum += $age; ),
> reverse( sum -= $age; ),
> result( sum )
> )
> then
> insert($sum);
> end
> {noformat}
> - Not executable-model -> The DRL is compiled and executed successfully
> - Executable-model -> Throws ParseProblemException
> {noformat}
> com.github.javaparser.ParseProblemException: (line 1,col 12) Parse error. Found "}", expected one of "!=" "%" "%=" "&" "&&" "&=" "*" "*=" "+" "+=" "," "-" "-=" "->" "/" "/=" "::" ";" "<" "<<=" "<=" "=" "==" ">" ">=" ">>=" ">>>=" "?" "^" "^=" "instanceof" "|" "|=" "||"
> Problem stacktrace :
> com.github.javaparser.GeneratedJavaParser.generateParseException(GeneratedJavaParser.java:10567)
> com.github.javaparser.GeneratedJavaParser.jj_consume_token(GeneratedJavaParser.java:10426)
> com.github.javaparser.GeneratedJavaParser.BlockStatement(GeneratedJavaParser.java:3847)
> com.github.javaparser.GeneratedJavaParser.Statements(GeneratedJavaParser.java:1644)
> com.github.javaparser.GeneratedJavaParser.Block(GeneratedJavaParser.java:3822)
> com.github.javaparser.GeneratedJavaParser.BlockParseStart(GeneratedJavaParser.java:5687)
> com.github.javaparser.JavaParser.parse(JavaParser.java:115)
> com.github.javaparser.JavaParser.parseBlock(JavaParser.java:309)
> com.github.javaparser.StaticJavaParser.parseBlock(StaticJavaParser.java:240)
> org.drools.modelcompiler.builder.generator.visitor.accumulate.AccumulateVisitor.visitAccInlineCustomCode(AccumulateVisitor.java:434)
> ...
> {noformat}
> I'm not very sure how it should be fixed. I filed this because of discrepancy between Executable-model and Not executable-model
> Poosible choices are:
> - Fail even in case of Not executable-model
> - Success in case of Executable-model
> Additonal Note: If we miss a semicolon in action(), a more understandable error message is thrown.
> {noformat}
> [Message [id=1, kieBase=defaultKieBase, level=ERROR, path=r0.drl, line=2, column=0
> text=Rule Compilation error Syntax error, insert ":: IdentifierOrNew" to complete Expression
> Syntax error, insert ";" to complete Statement]]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4291) ModelWriter: refactor to smaller classes
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-4291?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-4291:
-----------------------------------
Sprint: 2019 Week 26-28, 2019 Week 29-31, 2019 Week 32-34 (was: 2019 Week 26-28, 2019 Week 29-31)
> ModelWriter: refactor to smaller classes
> ----------------------------------------
>
> Key: DROOLS-4291
> URL: https://issues.jboss.org/browse/DROOLS-4291
> Project: Drools
> Issue Type: Enhancement
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core
>
> ModelWriter performs most of the logic translating PackageModel into source files; then it writes the result to a virtual FS. This makes it harder to reuse common source-to-file logic. In this PR we refactor each part of the PackageModel-to-individual-source-files into separate classes, taking each one single component.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4208) [DMN Designer] Documentation - Widget for links persisting links
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-4208?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-4208:
-----------------------------------
Sprint: 2019 Week 26-28, 2019 Week 29-31, 2019 Week 32-34 (was: 2019 Week 26-28, 2019 Week 29-31)
> [DMN Designer] Documentation - Widget for links persisting links
> ----------------------------------------------------------------
>
> Key: DROOLS-4208
> URL: https://issues.jboss.org/browse/DROOLS-4208
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Reporter: Guilherme Gomes
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools
> Attachments: DROOLS-4208.png
>
>
> Every {{DRGElement}} ({{BusinessKnowledgeModel}}, {{Decision}}, {{DecisionService}}, {{InputData}}, {{KnowledgeSource}}) must have into its properties panel a widget for adding links.
> The widget must be just like this one:
> https://redhat.invisionapp.com/share/JSQRRG2ZU8K#/screens/349635889
> (A list which is populated by the popover).
> Each item in this list is a {{DMNExternalLink}}*, this entity as only two string fields ({{name}} and {{URL}}).
> !DROOLS-4208.png|thumbnail!
> * This is just a suggestion, the entity name can be improved.
> h3. Acceptance test
> On both Firefox and Chrome
> - Multiple links - scroll to view all (/)
> - Add multiple, delete some (/)
> - Open the link (/)
> - Switch between nodes (/)
> - Link name - long (/)
> - Link name - multibyte characters (/)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months