[JBoss JIRA] (JGRP-2273) ASYM_ENCRYPT: deprecate encrypt_entire_message
by Bela Ban (Jira)
[ https://issues.jboss.org/browse/JGRP-2273?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2273:
--------------------------------
How about we exclude GMS headers from (de-)serialization?
> ASYM_ENCRYPT: deprecate encrypt_entire_message
> ----------------------------------------------
>
> Key: JGRP-2273
> URL: https://issues.jboss.org/browse/JGRP-2273
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 4.1.3
>
>
> In {{ASYM_ENCRYPT}}, {{encrypt_entire_message}} encrypts not only the payload, but also metadata such as destination and sender's address, headers and flags.
> The rationale was to prevent replay attacks. However, this is not an issue, as replayed messages will simply get dropped by the retransmission layer (e.g. NAKACK2 or UNICAST3).
> If people still want this feature, they can write a protocol _above_ {{ASYM_ENCRYPT}}, which serializes the entire message into the payload of a new message, and this would be exactly the same as setting {{encrypt_entire_message}} to {{true}}.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4393) expire facts before fire rules
by Alberto Fanjul Alonso (Jira)
[ https://issues.jboss.org/browse/DROOLS-4393?page=com.atlassian.jira.plugi... ]
Alberto Fanjul Alonso reopened DROOLS-4393:
-------------------------------------------
After asking cu the issue was bad explained, although the reproducer is still valid:
There's a rule RG_SAME_ID and a rule RG_COLLECT. After advance the clock 3 hours, a fact with same id than previous one is added
```
DummyFact firstFact = new DummyFact(1, now);
```
and
```
DummyFact thirdFact = new DummyFact(1, now + TimeUnit.HOURS.toMillis(3));
```
While third fact is expired and do not fire the RG_SAME_ID rule, it is present on collect(DummyFact) from RG_COLLECT rule.
[~mfusco] Let us know if that makes a difference and there's anything to improve on collect function.
> expire facts before fire rules
> ------------------------------
>
> Key: DROOLS-4393
> URL: https://issues.jboss.org/browse/DROOLS-4393
> Project: Drools
> Issue Type: Feature Request
> Components: core engine
> Affects Versions: 7.24.0.Final
> Reporter: Alberto Fanjul Alonso
> Assignee: Mario Fusco
> Priority: Major
> Attachments: reproducer-02425402.zip
>
>
> Is there any option to expire the facts before fireAllRules()?
> A reproducer for drools 6.5.0.Final-redhat-25 (tested too on 7.23.0.Final-redhat-00002 and 7.24.0.Final) shows that facts are not expired until we run fireAllRules().
> Trying reproducer:
> Show facts are expired after fireAllRules():
> ```
> unzip -d reproducer reproducer-02425402.zip
> cd reproducer
> git checkout master
> ./run.sh
> ```
> Show facts are not expired before fireAllRules():
> ```
> git checkout original
> ./run.sh
> ```
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4393) Expired events can be present in the collect result
by Alberto Fanjul Alonso (Jira)
[ https://issues.jboss.org/browse/DROOLS-4393?page=com.atlassian.jira.plugi... ]
Alberto Fanjul Alonso updated DROOLS-4393:
------------------------------------------
Summary: Expired events can be present in the collect result (was: expire facts before fire rules)
> Expired events can be present in the collect result
> ---------------------------------------------------
>
> Key: DROOLS-4393
> URL: https://issues.jboss.org/browse/DROOLS-4393
> Project: Drools
> Issue Type: Feature Request
> Components: core engine
> Affects Versions: 7.24.0.Final
> Reporter: Alberto Fanjul Alonso
> Assignee: Mario Fusco
> Priority: Major
> Attachments: reproducer-02425402.zip
>
>
> Is there any option to expire the facts before fireAllRules()?
> A reproducer for drools 6.5.0.Final-redhat-25 (tested too on 7.23.0.Final-redhat-00002 and 7.24.0.Final) shows that facts are not expired until we run fireAllRules().
> Trying reproducer:
> Show facts are expired after fireAllRules():
> ```
> unzip -d reproducer reproducer-02425402.zip
> cd reproducer
> git checkout master
> ./run.sh
> ```
> Show facts are not expired before fireAllRules():
> ```
> git checkout original
> ./run.sh
> ```
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-4400) Can not open a Scenario Simulation model version 1.5
by Gabriele Cardosi (Jira)
[ https://issues.jboss.org/browse/DROOLS-4400?page=com.atlassian.jira.plugi... ]
Gabriele Cardosi closed DROOLS-4400.
------------------------------------
Resolution: Done
The format of the file is unconsistent.
Version 1.5 expected to be
{code:xml}
<Scenario>
<factMappingValues>
...
</factMappingValues>
<simulationDescriptor reference="../../../simulationDescriptor"/>
</Scenario>
{code}
while inside Test (Passenger Check-In).scesim I see:
{code:xml}
<Scenario>
<factMappingValues>
...
</factMappingValues>
<simulationDescriptor>
...
</simulationDescriptor>
</Scenario>
{code}
> Can not open a Scenario Simulation model version 1.5
> ----------------------------------------------------
>
> Key: DROOLS-4400
> URL: https://issues.jboss.org/browse/DROOLS-4400
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Affects Versions: 7.25.0.Final
> Reporter: Jozef Marko
> Assignee: Gabriele Cardosi
> Priority: Critical
> Attachments: PlaneBoarding3629284258846927242.zip, Screenshot from 2019-08-05 09-39-26.png, error.log
>
>
> The latest version (1.6) of Scenario Simulation model is not compatible with previous Scenario Simulation model (1.5). If user tries to open Scenario Simulation created on older product version, an error is thrown. For more detail see the attache Plane Boarding project. There are *.scesim* files with Scenario Simulation model version 1.5, however they can not be opened in business central that has the latest Scenario Simulation model version 1.6.
> h2. Reproducer/Accepetance test
> https://github.com/jboss-integration/bxms-qe-tests/blob/master/test-kie-w...
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (DROOLS-3923) (C)DI detection should be more reliable/standard for codegen
by Edoardo Vacchi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3923?page=com.atlassian.jira.plugi... ]
Edoardo Vacchi updated DROOLS-3923:
-----------------------------------
Sprint: 2019 Week 23-25, 2019 Week 26-28 (was: 2019 Week 23-25, 2019 Week 26-28, 2019 Week 32-34)
> (C)DI detection should be more reliable/standard for codegen
> ------------------------------------------------------------
>
> Key: DROOLS-3923
> URL: https://issues.jboss.org/browse/DROOLS-3923
> Project: Drools
> Issue Type: Bug
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core, submarine
>
> we are currently doing {{ try { Class.forName("...ApplicationScoped") } }} which is
> (1) pretty hackish (2) won't work in Maven because maven's ClassPath is not the same of the target application
> We should rather use a config param or any better way to detect if we're going to use DI. Currently we have added a config param + "auto detect" using the technique above (in maven only the config param works) but auto-detect should be better.
> Besides ApplicationScoped only work for CDI, while JSR-330 @Inject is independent from CDI so using ApplicationScoped as a signal is too limited.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months