[JBoss JIRA] (WFWIP-202) Runtime changes to disableHTTPRoute are not reflected in Route object
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFWIP-202?page=com.atlassian.jira.plugin.... ]
Jeff Mesnil resolved WFWIP-202.
-------------------------------
Resolution: Done
Fixed in upstream
> Runtime changes to disableHTTPRoute are not reflected in Route object
> ---------------------------------------------------------------------
>
> Key: WFWIP-202
> URL: https://issues.jboss.org/browse/WFWIP-202
> Project: WildFly WIP
> Issue Type: Bug
> Components: OpenShift
> Reporter: Martin Choma
> Assignee: Jeff Mesnil
> Priority: Blocker
> Labels: operator
>
> Any changes (adding, removing or updating) made to disableHTTPRoute attribute after WildFlyServer CR was created are not reflected in underlying Route object.
> Reproducer:
> # create CR
> {code}
> apiVersion: wildfly.org/v1alpha1
> kind: WildFlyServer
> metadata:
> generation: 1
> name: eap-cd
> namespace: default
> spec:
> applicationImage: >-
> brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/jboss-eap-7-tech-preview/eap-cd-openshift-rhel8:17.0-4
> size: 1
> disableHTTPRoute: false
> {code}
> # Edit CR with disableHTTPRoute: true. I would expect Route object will be deleted.
> {code}
> apiVersion: wildfly.org/v1alpha1
> kind: WildFlyServer
> metadata:
> generation: 1
> name: eap-cd
> namespace: default
> spec:
> applicationImage: >-
> brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/jboss-eap-7-tech-preview/eap-cd-openshift-rhel8:17.0-4
> size: 1
> disableHTTPRoute: true
> {code}
> # Route object eap-cd is not disabled/deleted
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (WFLY-12584) Name of Chunk BatchJob is saved in parameters of its execution if exception was thrown in readItem
by serg polchevski (Jira)
[ https://issues.jboss.org/browse/WFLY-12584?page=com.atlassian.jira.plugin... ]
serg polchevski commented on WFLY-12584:
----------------------------------------
Hi, thank You very much for quick response!
> Name of Chunk BatchJob is saved in parameters of its execution if exception was thrown in readItem
> --------------------------------------------------------------------------------------------------
>
> Key: WFLY-12584
> URL: https://issues.jboss.org/browse/WFLY-12584
> Project: WildFly
> Issue Type: Bug
> Components: Batch
> Affects Versions: 17.0.0.Final, 17.0.1.Final
> Environment: wildfly-17.0.1.Final
> Reporter: serg polchevski
> Assignee: Cheng Fang
> Priority: Major
>
> If a Exception is thrown during execution of Batch Chunk Job in method implementing readItem() of class ItemReader than parameter "jberet.jobXmlName" with name of BatchJob is added/saved in jobparameters of table job_execution and this parameter is than shown in the execution of BatchJob. Saved parameters for example (originally just id=4):
> {code:java}
> jberet.jobXmlName = testJob.xml
> id = 4
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (WFLY-12584) Name of Chunk BatchJob is saved in parameters of its execution if exception was thrown in readItem
by Cheng Fang (Jira)
[ https://issues.jboss.org/browse/WFLY-12584?page=com.atlassian.jira.plugin... ]
Cheng Fang commented on WFLY-12584:
-----------------------------------
This is by design. This param {{jberet.jobXmlName}} can be safely ignored by the application. Some batch jobs have job names that are different from the job xml file name. So this param is used to track the the job xml name for restarting purpose.
> Name of Chunk BatchJob is saved in parameters of its execution if exception was thrown in readItem
> --------------------------------------------------------------------------------------------------
>
> Key: WFLY-12584
> URL: https://issues.jboss.org/browse/WFLY-12584
> Project: WildFly
> Issue Type: Bug
> Components: Batch
> Affects Versions: 17.0.0.Final, 17.0.1.Final
> Environment: wildfly-17.0.1.Final
> Reporter: serg polchevski
> Assignee: Cheng Fang
> Priority: Major
>
> If a Exception is thrown during execution of Batch Chunk Job in method implementing readItem() of class ItemReader than parameter "jberet.jobXmlName" with name of BatchJob is added/saved in jobparameters of table job_execution and this parameter is than shown in the execution of BatchJob. Saved parameters for example (originally just id=4):
> {code:java}
> jberet.jobXmlName = testJob.xml
> id = 4
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (DROOLS-3002) Redo PMML scorecards rules to use executable model
by Lance Leverich (Jira)
[ https://issues.jboss.org/browse/DROOLS-3002?page=com.atlassian.jira.plugi... ]
Lance Leverich updated DROOLS-3002:
-----------------------------------
Description:
Re-factoring of the classes and mechanisms that generate rules and classes from a PMML resource that contains a Scorecard model.
# Make further usage of POJOs to replace any types declared within the rule file
# Change the rules generated so that the rules are Java, based on the executable model
was:
Re-factoring of the classes and mechanisms that generate rules and classes from a PMML resource that contains a Scorecard model.
# Make further usage of POJOs to replace any types declared within the rule file
# Make the generation of rules and classes be more direct (i.e. reduce/remove the rules engine use in generating rules and classes)
# Reduce the rules generated so that the number of steps required to apply a model is minimized
> Redo PMML scorecards rules to use executable model
> --------------------------------------------------
>
> Key: DROOLS-3002
> URL: https://issues.jboss.org/browse/DROOLS-3002
> Project: Drools
> Issue Type: Enhancement
> Components: PMML
> Affects Versions: 7.12.0.Final
> Reporter: Lance Leverich
> Assignee: Lance Leverich
> Priority: Major
> Labels: PMMLRefactor, drools-core
>
> Re-factoring of the classes and mechanisms that generate rules and classes from a PMML resource that contains a Scorecard model.
> # Make further usage of POJOs to replace any types declared within the rule file
> # Change the rules generated so that the rules are Java, based on the executable model
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (DROOLS-3002) Redo PMML scorecards rules to use executable model
by Lance Leverich (Jira)
[ https://issues.jboss.org/browse/DROOLS-3002?page=com.atlassian.jira.plugi... ]
Lance Leverich updated DROOLS-3002:
-----------------------------------
Summary: Redo PMML scorecards rules to use executable model (was: Enhance performance of PMML using scorecards)
> Redo PMML scorecards rules to use executable model
> --------------------------------------------------
>
> Key: DROOLS-3002
> URL: https://issues.jboss.org/browse/DROOLS-3002
> Project: Drools
> Issue Type: Enhancement
> Components: PMML
> Affects Versions: 7.12.0.Final
> Reporter: Lance Leverich
> Assignee: Lance Leverich
> Priority: Major
> Labels: PMMLRefactor, drools-core
>
> Re-factoring of the classes and mechanisms that generate rules and classes from a PMML resource that contains a Scorecard model.
> # Make further usage of POJOs to replace any types declared within the rule file
> # Make the generation of rules and classes be more direct (i.e. reduce/remove the rules engine use in generating rules and classes)
> # Reduce the rules generated so that the number of steps required to apply a model is minimized
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (WFWIP-207) UX: Force removal of Operator upon delete - do not hang due to finalizers
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFWIP-207?page=com.atlassian.jira.plugin.... ]
Jeff Mesnil commented on WFWIP-207:
-----------------------------------
A simple way to look at that is that `oc delete` means to remove the resource as soon as possible.
If the users wants to finish properly any work before removal, he can scale down to 0 before deleting the resource.
> UX: Force removal of Operator upon delete - do not hang due to finalizers
> -------------------------------------------------------------------------
>
> Key: WFWIP-207
> URL: https://issues.jboss.org/browse/WFWIP-207
> Project: WildFly WIP
> Issue Type: Bug
> Components: OpenShift
> Reporter: Petr Kremensky
> Assignee: Ondrej Chaloupka
> Priority: Blocker
> Labels: operator
>
> We run yet into another use case where finalizers prevent users from deleting the project - the delete operation hangs.
> pods:
> {noformat}
> $ oc get all
> NAME READY STATUS RESTARTS AGE
> pod/simple-jaxrs-operator-0 0/1 ImagePullBackOff 0 9m11s
> pod/simple-jaxrs-operator-1 0/1 ImagePullBackOff 0 9m11s
> pod/wildfly-operator-686846d6fb-db9sj 1/1 Running
> $ oc delete wildflyserver simple-jaxrs-operator
> wildflyserver.wildfly.org "simple-jaxrs-operator" deleted
> ... hangs forever
> {noformat}
> operator log:
> {noformat}
> {"level":"info","ts":1569308322.2926116,"logger":"controller_wildflyserver","msg":"Reconciling WildFlyServer","Request.Namespace":"pkremens-namespace","Request.Name":"simple-jaxrs-operator"}
> {"level":"info","ts":1569308322.2927597,"logger":"controller_wildflyserver","msg":"WildflyServer is marked for deletion. Waiting for finalizers to clean the workspace","Request.Namespace":"pkremens-namespace","Request.Name":"simple-jaxrs-operator"}
> {"level":"info","ts":1569308322.2929516,"logger":"controller_wildflyserver","msg":"Transaction recovery scaledown processing","Request.Namespace":"pkremens-namespace","Request.Name":"simple-jaxrs-operator","Pod Name":"simple-jaxrs-operator-0","IP Address":"10.128.0.227","Pod State":"SCALING_DOWN_RECOVERY_INVESTIGATION","Pod Phase":"Pending"}
> {"level":"info","ts":1569308322.2931426,"logger":"controller_wildflyserver","msg":"Transaction recovery scaledown processing","Request.Namespace":"pkremens-namespace","Request.Name":"simple-jaxrs-operator","Pod Name":"simple-jaxrs-operator-1","IP Address":"10.128.0.226","Pod State":"SCALING_DOWN_RECOVERY_INVESTIGATION","Pod Phase":"Pending"}
> {"level":"error","ts":1569308322.294659,"logger":"kubebuilder.controller","msg":"Reconciler error","controller":"wildflyserver-controller","request":"pkremens-namespace/simple-jaxrs-operator","error":"Finalizer processing: failed transaction recovery for WildflyServer pkremens-namespace:simple-jaxrs-operator name Error: Found 2 errors:\n [[Pod 'simple-jaxrs-operator-0' / 'simple-jaxrs-operator' is in pending phase Pending. It will be hopefully started in a while. Transaction recovery needs the pod being fully started to be capable to mark it as clean for the scale down.]], [[Pod 'simple-jaxrs-operator-1' / 'simple-jaxrs-operator' is in pending phase Pending. It will be hopefully started in a while. Transaction recovery needs the pod being fully started to be capable to mark it as clean for the scale down.]],","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-l..."}
> {noformat}
> This is a call between safety vs. usability, but we believe that these issues (hanging delete command due to EAP7-1192) could be a serious usability problem for users.
> *actual*
> * scale down can require manual user interaction forced by finalizers
> * delete can hang, requiring manual user interaction (delete deployment object, remove finalizer from operator CR, run delete again)
> *expected*
> * scale down can require manual user interaction forced by finalizers
> * delete should never hang, it should be treated like a pulling a plug (rm -rf), in case users needs to make s graceful shutdown, he make a proper scale down to 0 prior the project deletion - this should be properly documented
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months