[JBoss JIRA] (WFCORE-3948) Potential race condition on deployment of EAR when Class-Path manifest entry is in use
by Scott Marlow (Jira)
[ https://issues.jboss.org/browse/WFCORE-3948?page=com.atlassian.jira.plugi... ]
Scott Marlow commented on WFCORE-3948:
--------------------------------------
Could it help to get the "topLevelDeployment.addToAttachmentList(Attachments.ADDITIONAL_MODULES, module)" call to happen before the subdeployers are called?
Alternative could be to have readers (and writer) of Attachments.ADDITIONAL_MODULES synchronize, which slows deployment down but might help complex deployments that might be hitting this but not reporting it.
[~yersan] have you looked at this before?
> Potential race condition on deployment of EAR when Class-Path manifest entry is in use
> --------------------------------------------------------------------------------------
>
> Key: WFCORE-3948
> URL: https://issues.jboss.org/browse/WFCORE-3948
> Project: WildFly Core
> Issue Type: Bug
> Components: Server
> Reporter: Stuart Douglas
> Priority: Major
>
> Attachments#ADDITIONAL_MODULES is attached to the top level DU, but modified by sub deployments in ManifestClassPathProcessor#createAdditionalModule without any sort of synchronisation. This can result in ConcurrentModificationException when the list is read/written to by other sub deployments at the same time.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (JGRP-2274) ASYM_ENCRYPT: deprecate sign_msgs
by Nick Sawadsky (Jira)
[ https://issues.jboss.org/browse/JGRP-2274?page=com.atlassian.jira.plugin.... ]
Nick Sawadsky commented on JGRP-2274:
-------------------------------------
[~belaban] Realizing that it may take some time to add TLS support to TCP and TCP_NIO2, I have picked this up again, and am tackling the work to support the CBC cipher mode in Encrypt. I entered an Enhancement ticket for this (JGRP-2386) and am preparing a pull request.
> ASYM_ENCRYPT: deprecate sign_msgs
> ---------------------------------
>
> Key: JGRP-2274
> URL: https://issues.jboss.org/browse/JGRP-2274
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 4.0.12
>
>
> In {{ASYM_ENCRYPT}}, signing messages means that the checksum of an encrypted message is computed and used together with the secret key of the sender to sign the message. On the receiver side, the public key of the sender is used to validate the signature.
> However, this is redundant, as decryption of a message will fail if the contents have been changed.
> If needed, signing of messages can be done in a separate protocol.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (JGRP-2386) Support for encryption ciphers that require an initialization vector
by Nick Sawadsky (Jira)
[ https://issues.jboss.org/browse/JGRP-2386?page=com.atlassian.jira.plugin.... ]
Nick Sawadsky updated JGRP-2386:
--------------------------------
Summary: Support for encryption ciphers that require an initialization vector (was: Support for encryption ciphers that require an IV)
> Support for encryption ciphers that require an initialization vector
> --------------------------------------------------------------------
>
> Key: JGRP-2386
> URL: https://issues.jboss.org/browse/JGRP-2386
> Project: JGroups
> Issue Type: Enhancement
> Affects Versions: 4.1.5, 3.6.19
> Reporter: Nick Sawadsky
> Assignee: Bela Ban
> Priority: Minor
>
> By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts the same plaintext block to the same ciphertext every time, which can give attackers insight into the types of messages being exchanged.
> Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
> It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (JGRP-2386) Support for encryption ciphers that require an initialization vector
by Nick Sawadsky (Jira)
[ https://issues.jboss.org/browse/JGRP-2386?page=com.atlassian.jira.plugin.... ]
Nick Sawadsky updated JGRP-2386:
--------------------------------
Description:
By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts a given plaintext block to the same ciphertext every time, which can give attackers insight into the types of messages being exchanged.
Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
was:
By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts the same plaintext block to the same ciphertext every time, which can give attackers insight into the types of messages being exchanged.
Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
> Support for encryption ciphers that require an initialization vector
> --------------------------------------------------------------------
>
> Key: JGRP-2386
> URL: https://issues.jboss.org/browse/JGRP-2386
> Project: JGroups
> Issue Type: Enhancement
> Affects Versions: 4.1.5, 3.6.19
> Reporter: Nick Sawadsky
> Assignee: Bela Ban
> Priority: Minor
>
> By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts a given plaintext block to the same ciphertext every time, which can give attackers insight into the types of messages being exchanged.
> Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
> It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (JGRP-2386) Support for encryption ciphers that require an initialization vector
by Nick Sawadsky (Jira)
[ https://issues.jboss.org/browse/JGRP-2386?page=com.atlassian.jira.plugin.... ]
Nick Sawadsky updated JGRP-2386:
--------------------------------
Description:
By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts a given plaintext block to the same ciphertext every time, which can give attackers insight into the [types of messages being exchanged|https://crypto.stackexchange.com/questions/20941/why-shouldnt-i...].
Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
was:
By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts a given plaintext block to the same ciphertext every time, which can give attackers insight into the types of messages being exchanged.
Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
> Support for encryption ciphers that require an initialization vector
> --------------------------------------------------------------------
>
> Key: JGRP-2386
> URL: https://issues.jboss.org/browse/JGRP-2386
> Project: JGroups
> Issue Type: Enhancement
> Affects Versions: 4.1.5, 3.6.19
> Reporter: Nick Sawadsky
> Assignee: Bela Ban
> Priority: Minor
>
> By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts a given plaintext block to the same ciphertext every time, which can give attackers insight into the [types of messages being exchanged|https://crypto.stackexchange.com/questions/20941/why-shouldnt-i...].
> Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
> It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (JGRP-2386) Support for encryption algorithms that require an IV
by Nick Sawadsky (Jira)
Nick Sawadsky created JGRP-2386:
-----------------------------------
Summary: Support for encryption algorithms that require an IV
Key: JGRP-2386
URL: https://issues.jboss.org/browse/JGRP-2386
Project: JGroups
Issue Type: Enhancement
Affects Versions: 3.6.19, 4.1.5
Reporter: Nick Sawadsky
Assignee: Bela Ban
By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts the same plaintext block to the same ciphertext every time, which can give attackers insight into the types of messages being exchanged.
Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (JGRP-2386) Support for encryption ciphers that require an IV
by Nick Sawadsky (Jira)
[ https://issues.jboss.org/browse/JGRP-2386?page=com.atlassian.jira.plugin.... ]
Nick Sawadsky updated JGRP-2386:
--------------------------------
Summary: Support for encryption ciphers that require an IV (was: Support for encryption algorithms that require an IV)
> Support for encryption ciphers that require an IV
> -------------------------------------------------
>
> Key: JGRP-2386
> URL: https://issues.jboss.org/browse/JGRP-2386
> Project: JGroups
> Issue Type: Enhancement
> Affects Versions: 4.1.5, 3.6.19
> Reporter: Nick Sawadsky
> Assignee: Bela Ban
> Priority: Minor
>
> By default, Encrypt sets sym_algorithm to "AES". As a result, the default cipher mode is used, which is ECB. ECB encrypts the same plaintext block to the same ciphertext every time, which can give attackers insight into the types of messages being exchanged.
> Modes like CBC, that use a random initialization vector (IV) are not susceptible to this problem, except in the case where a given IV is reused with the same key.
> It would be good to modify Encrypt to support ciphers that require an IV, such as AES/CBC/PKCS5Padding.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months
[JBoss JIRA] (WFCORE-3948) Potential race condition on deployment of EAR when Class-Path manifest entry is in use
by Cheng Fang (Jira)
[ https://issues.jboss.org/browse/WFCORE-3948?page=com.atlassian.jira.plugi... ]
Cheng Fang commented on WFCORE-3948:
------------------------------------
{code}
at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:183) [wildfly-server-10.0.0.Beta9.jar:10.0.0.Beta9]
at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739) [jboss-msc-1.4.11.Final.jar:1.4.11.Final]
at org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701) [jboss-msc-1.4.11.Final.jar:1.4.11.Final]
at org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559) [jboss-msc-1.4.11.Final.jar:1.4.11.Final]
at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) [jboss-threads-2.3.3.Final.jar:2.3.3.Final]
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1982) [jboss-threads-2.3.3.Final.jar:2.3.3.Final]
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) [jboss-threads-2.3.3.Final.jar:2.3.3.Final]
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1363) [jboss-threads-2.3.3.Final.jar:2.3.3.Final]
at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_191]
Caused by: java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:909) [rt.jar:1.8.0_191]
at java.util.ArrayList$Itr.next(ArrayList.java:859) [rt.jar:1.8.0_191]
at java.util.Collections$CheckedCollection$1.next(Collections.java:3076) [rt.jar:1.8.0_191]
at org.jboss.as.server.deployment.module.ManifestDependencyProcessor.deploy(ManifestDependencyProcessor.java:73) [wildfly-server-10.0.0.Beta9.jar:10.0.0.Beta9]
at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:176) [wildfly-server-10.0.0.Beta9.jar:10.0.0.Beta9]
... 8 more
[0m[31m23:12:56,985 ERROR [org.jboss.as] (Controller Boot Thread) WFLYSRV0026: WildFly Full 18.0.0.Final-SNAPSHOT (WildFly Core 10.0.0.Beta9) started (with errors) in 10276ms - Started 468 of 478 services (3 services failed or missing dependencies, 301 services are lazy, passive or on-demand)
{code}
> Potential race condition on deployment of EAR when Class-Path manifest entry is in use
> --------------------------------------------------------------------------------------
>
> Key: WFCORE-3948
> URL: https://issues.jboss.org/browse/WFCORE-3948
> Project: WildFly Core
> Issue Type: Bug
> Components: Server
> Reporter: Stuart Douglas
> Priority: Major
>
> Attachments#ADDITIONAL_MODULES is attached to the top level DU, but modified by sub deployments in ManifestClassPathProcessor#createAdditionalModule without any sort of synchronisation. This can result in ConcurrentModificationException when the list is read/written to by other sub deployments at the same time.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 10 months