[JBoss JIRA] (ELY-1745) The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
by Farah Juma (Jira)
[ https://issues.redhat.com/browse/ELY-1745?page=com.atlassian.jira.plugin.... ]
Farah Juma updated ELY-1745:
----------------------------
Fix Version/s: 1.11.0.CR5
(was: 1.11.0.CR4)
> The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
> ----------------------------------------------------------------------------------------------
>
> Key: ELY-1745
> URL: https://issues.redhat.com/browse/ELY-1745
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Reporter: Darran Lofthouse
> Priority: Major
> Fix For: 1.11.0.CR5
>
>
> The NPE is due to the following code: -
> {noformat}
> } else if (callback instanceof AvailableRealmsCallback) {
> Collection<String> names = stateRef.get().getMechanismConfiguration().getMechanismRealmNames();
> if (log.isTraceEnabled()) {
> log.tracef("Handling AvailableRealmsCallback: realms = [%s]", String.join(", ", names));
> }
> if (! names.isEmpty()) {
> ((AvailableRealmsCallback) callback).setRealmNames(names.toArray(new String[names.size()]));
> }
> handleOne(callbacks, idx + 1);
> {noformat}
> If mechanism configuration is mandatory this should report an appropriate error, if not it should fallback to specifying an empty list.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (DROOLS-1448) [XLS Decision Table] Integer values for Double attributes causes validation error
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-1448?page=com.atlassian.jira.plug... ]
Mario Fusco resolved DROOLS-1448.
---------------------------------
Resolution: Won't Fix
I reproduced the problem, but since the SpreadsheetCompiler is unaware of the underlying domain model, there is nothing we can do about it. In other words, in order to generate a drl that is compatible with the model, the SpreadsheetCompiler should know the type of the object accepted by the setter method and rewrite the consequence accordingly, but this is not possible because that compiler purely translate the xls into a drl without any knowledge of the actual classes used in the domain. That said I don't think this is a big issue since either changing the type accepted by the setter from Double to a primitive double or modifying the decision table to have doubles in the consequence's column fix the problem.
> [XLS Decision Table] Integer values for Double attributes causes validation error
> ---------------------------------------------------------------------------------
>
> Key: DROOLS-1448
> URL: https://issues.redhat.com/browse/DROOLS-1448
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.0.0.Beta6
> Reporter: Jozef Marko
> Assignee: Mario Fusco
> Priority: Minor
> Labels: dtable_testday_preparation, qe-test-day, reported-by-qe
> Attachments: Driver.java, ExamplePolicyPricing.xls, Policy.java, Screenshot from 2017-02-02 10-22-21.png
>
>
> If the XLS decision contains Integer values for column ( attribute ) that is Double data type, then the XLS decision table is not validated successfully. After conversion to guided decision table is the table validated successfully.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months