[JBoss JIRA] (WFCORE-4812) Consolidate instances of DefaultValueAttributeConverter
by Paul Ferraro (Jira)
[ https://issues.redhat.com/browse/WFCORE-4812?page=com.atlassian.jira.plug... ]
Paul Ferraro updated WFCORE-4812:
---------------------------------
Description: DefaultValueAttributeConverter is perhaps the most commonly used attribute converter, used when the default value of a given attribute changes. The implementation in WFCORE uses a separate instance for each attribute. The default implementation can be implemented more concisely, such that a single instance can be used for any attribute. (was: DefaultValueAttributeConverter is perhaps the most common attribute converter, used when the default value of a given attribute changes. The implementation in WFCORE uses a separate instance for each attribute. The default implementation can be implemented more concisely, such that a single instance can be used for any attribute.)
> Consolidate instances of DefaultValueAttributeConverter
> -------------------------------------------------------
>
> Key: WFCORE-4812
> URL: https://issues.redhat.com/browse/WFCORE-4812
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Management
> Affects Versions: 11.0.0.Beta7
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
> Priority: Major
>
> DefaultValueAttributeConverter is perhaps the most commonly used attribute converter, used when the default value of a given attribute changes. The implementation in WFCORE uses a separate instance for each attribute. The default implementation can be implemented more concisely, such that a single instance can be used for any attribute.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFLY-13014) Consolidate instances of DefaultValueAttributeConverter
by Paul Ferraro (Jira)
[ https://issues.redhat.com/browse/WFLY-13014?page=com.atlassian.jira.plugi... ]
Paul Ferraro moved WFCORE-4813 to WFLY-13014:
---------------------------------------------
Project: WildFly (was: WildFly Core)
Key: WFLY-13014 (was: WFCORE-4813)
Component/s: Management
(was: Management)
Affects Version/s: 19.0.0.Beta1
(was: 11.0.0.Beta7)
> Consolidate instances of DefaultValueAttributeConverter
> -------------------------------------------------------
>
> Key: WFLY-13014
> URL: https://issues.redhat.com/browse/WFLY-13014
> Project: WildFly
> Issue Type: Enhancement
> Components: Management
> Affects Versions: 19.0.0.Beta1
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
> Priority: Major
>
> DefaultValueAttributeConverter is perhaps the most common attribute converter, used when the default value of a given attribute changes. The implementation in WFCORE uses a separate instance for each attribute. The default implementation can be implemented more concisely, such that a single instance can be used for any attribute.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFLY-13014) Consolidate instances of DefaultValueAttributeConverter
by Paul Ferraro (Jira)
[ https://issues.redhat.com/browse/WFLY-13014?page=com.atlassian.jira.plugi... ]
Paul Ferraro updated WFLY-13014:
--------------------------------
Description: Follows up on WFCORE-4812. Update instances of (was: DefaultValueAttributeConverter is perhaps the most common attribute converter, used when the default value of a given attribute changes. The implementation in WFCORE uses a separate instance for each attribute. The default implementation can be implemented more concisely, such that a single instance can be used for any attribute.)
> Consolidate instances of DefaultValueAttributeConverter
> -------------------------------------------------------
>
> Key: WFLY-13014
> URL: https://issues.redhat.com/browse/WFLY-13014
> Project: WildFly
> Issue Type: Enhancement
> Components: Management
> Affects Versions: 19.0.0.Beta1
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
> Priority: Major
>
> Follows up on WFCORE-4812. Update instances of
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFCORE-4812) Consolidate instances of DefaultValueAttributeConverter
by Paul Ferraro (Jira)
Paul Ferraro created WFCORE-4812:
------------------------------------
Summary: Consolidate instances of DefaultValueAttributeConverter
Key: WFCORE-4812
URL: https://issues.redhat.com/browse/WFCORE-4812
Project: WildFly Core
Issue Type: Enhancement
Components: Management
Affects Versions: 11.0.0.Beta7
Reporter: Paul Ferraro
Assignee: Paul Ferraro
DefaultValueAttributeConverter is perhaps the most common attribute converter, used when the default value of a given attribute changes. The implementation in WFCORE uses a separate instance for each attribute. The default implementation can be implemented more concisely, such that a single instance can be used for any attribute.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFCORE-4813) Consolidate instances of DefaultValueAttributeConverter
by Paul Ferraro (Jira)
Paul Ferraro created WFCORE-4813:
------------------------------------
Summary: Consolidate instances of DefaultValueAttributeConverter
Key: WFCORE-4813
URL: https://issues.redhat.com/browse/WFCORE-4813
Project: WildFly Core
Issue Type: Enhancement
Components: Management
Affects Versions: 11.0.0.Beta7
Reporter: Paul Ferraro
Assignee: Paul Ferraro
DefaultValueAttributeConverter is perhaps the most common attribute converter, used when the default value of a given attribute changes. The implementation in WFCORE uses a separate instance for each attribute. The default implementation can be implemented more concisely, such that a single instance can be used for any attribute.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFLY-13013) Elytron LDAP can't set-password in Active Directory or react to external changes
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFLY-13013?page=com.atlassian.jira.plugi... ]
Darran Lofthouse reassigned WFLY-13013:
---------------------------------------
Assignee: (was: Darran Lofthouse)
> Elytron LDAP can't set-password in Active Directory or react to external changes
> --------------------------------------------------------------------------------
>
> Key: WFLY-13013
> URL: https://issues.redhat.com/browse/WFLY-13013
> Project: WildFly
> Issue Type: Feature Request
> Components: Security
> Affects Versions: 18.0.1.Final, 19.0.0.Beta1
> Reporter: David Guthrie
> Priority: Major
> Labels: active-directory, cache, elytron, ldap
>
> The caching realm seems to work as advertised with open ldap and Red Hat Directory Server when I add a user-password-mapper after setting:
> <user-password-mapper from="userPassword" writable="true" verifiable="true" />
> When I change the password in LDAP, the caching realm reacts, and I can login with the new password. Also when I call `set-password`:
> /subsystem=elytron/ldap-realm=ldap-realm:set-password(identity=testUser, clear=
> {password="1A3b6w"}
> )
> It changes the password correctly in LDAP.
> Neither of these work in Active Directory. Active Directory stores the password, by default using the field "UnicodePwd" rather than "userPassword", so I tried having them map the user password to that field:
> /subsystem=elytron/ldap-realm=ldap-realm:write-attribute(name=identity-mapping.user-password-mapper.from, value=UnicodePwd)
> But it it can't set the password because the password code needs to write it with a different character set when writing to active directory. See the different between the code in ldap/UserPasswordCredentialLoader.java and in the special case for Active Directory in Keycloak[1]
> It can't react to external changes to the directory because Active Directory doesn't support the listening mechanism used.
> There is a potential to be able to change the active directory settings so "userPassword" runs in compatibility mode[2], but that's not a normal thing to be able to do is most environments.
> [1] Keycloak - AD UnicodePWD https://github.com/keycloak/keycloak/blob/e12c245355f5fcbabab4a6807a9975f...
> [2] https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/f3ad...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFLY-11566) ConstraintDeclarationException on JAX-RS/EJB Methods with List/Set query parameter
by Tomasz Adamski (Jira)
[ https://issues.redhat.com/browse/WFLY-11566?page=com.atlassian.jira.plugi... ]
Tomasz Adamski commented on WFLY-11566:
---------------------------------------
[~guillaume.smet] I have made the updates that you mentioned and a fix to make integration tests pass. Now I can see that the reproducer above works correctly and our integration tests are passing. From my side it's OK to push it to upstream.
> ConstraintDeclarationException on JAX-RS/EJB Methods with List/Set query parameter
> ----------------------------------------------------------------------------------
>
> Key: WFLY-11566
> URL: https://issues.redhat.com/browse/WFLY-11566
> Project: WildFly
> Issue Type: Bug
> Components: Bean Validation, EJB, REST
> Affects Versions: 14.0.0.Final, 15.0.1.Final
> Reporter: Alexander Wagner
> Assignee: Tomasz Adamski
> Priority: Critical
> Labels: downstream_dependency
> Attachments: WFLY-11566-3.tar
>
>
> You got an exception if you call methods on JAX-RS endpoints which are also e.g. a stateless EJB and have Set or List as query parameters.
> As a workaround we use the "@Context UriInfo info" as parameter an read the parameter manually. As a downside this parameters are missing than in automated api generation with e.g. swagger. Without the @NotEmpty annotation it works fine. Without the generic type parameter ie just List it works fine. Making it a simple CDI bean makes it work fine.
> This issue is caused by [commit - WFLY-9628 Allow to switch to Hibernate Validator 6.0 / Bean Validation 2.0|https://github.com/wildfly/wildfly/commit/02f230d91f55f86ee6cadf53832...]
> Steps to reproduce:
> {code:java}
> @Stateless
> @Path("/")
> public class Resource {
> @POST
> @Path("put/list")
> @Consumes(MediaType.APPLICATION_JSON)
> public String putList(@NotEmpty List<String> a) {
> return "Hello bars " + a.stream().collect(Collectors.joining(", "));
> }
> }
> {code}
> {noformat}
> [mkopecky@dhcp-10-40-5-71 bin]$ curl -d '["a","b","c"]' -H "Content-Type: application/json" -X POST http://localhost:8080/jaxrs-wf/put/list
> javax.validation.ConstraintDeclarationException: HV000151: A method overriding another method must not redefine the parameter constraint configuration, but method Resource$$$view1#putList(List) redefines the configuration of Resource#putList(List).
> [mkopecky@dhcp-10-40-5-71 bin]$
> {noformat}
> {noformat}
> javax.validation.ConstraintDeclarationException: HV000151: A method overriding another method must not redefine the parameter constraint configuration, but method Resource$$$view1#putList(List) redefines the configuration of Resource#putList(List).
> at org.hibernate.validator.internal.metadata.aggregated.rule.OverridingMethodMustNotAlterParameterConstraints.apply(OverridingMethodMustNotAlterParameterConstraints.java:24)
> at org.hibernate.validator.internal.metadata.aggregated.ExecutableMetaData$Builder.assertCorrectnessOfConfiguration(ExecutableMetaData.java:461)
> at org.hibernate.validator.internal.metadata.aggregated.ExecutableMetaData$Builder.build(ExecutableMetaData.java:377)
> at org.hibernate.validator.internal.metadata.aggregated.BeanMetaDataImpl$BuilderDelegate.build(BeanMetaDataImpl.java:788)
> at org.hibernate.validator.internal.metadata.aggregated.BeanMetaDataImpl$BeanMetaDataBuilder.build(BeanMetaDataImpl.java:648)
> at org.hibernate.validator.internal.metadata.BeanMetaDataManager.createBeanMetaData(BeanMetaDataManager.java:192)
> at org.hibernate.validator.internal.metadata.BeanMetaDataManager.lambda$getBeanMetaData$0(BeanMetaDataManager.java:160)
> at java.util.concurrent.ConcurrentMap.computeIfAbsent(ConcurrentMap.java:324)
> at org.hibernate.validator.internal.metadata.BeanMetaDataManager.getBeanMetaData(BeanMetaDataManager.java:159)
> at org.hibernate.validator.internal.engine.ValidationContext$ValidationContextBuilder.forValidateParameters(ValidationContext.java:619)
> at org.hibernate.validator.internal.engine.ValidatorImpl.validateParameters(ValidatorImpl.java:254)
> at org.hibernate.validator.internal.engine.ValidatorImpl.validateParameters(ValidatorImpl.java:224)
> at org.jboss.resteasy.plugins.validation.GeneralValidatorImpl.validateAllParameters(GeneralValidatorImpl.java:177)
> at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:118)
> at org.jboss.resteasy.core.ResourceMethodInvoker.internalInvokeOnTarget(ResourceMethodInvoker.java:509)
> at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTargetAfterFilter(ResourceMethodInvoker.java:399)
> at org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invokeOnTarget$0(ResourceMethodInvoker.java:363)
> at org.jboss.resteasy.core.interception.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:355)
> at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTarget(ResourceMethodInvoker.java:365)
> at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:337)
> at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:310)
> at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:439)
> at org.jboss.resteasy.core.SynchronousDispatcher.lambda$invoke$4(SynchronousDispatcher.java:229)
> at org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:135)
> at org.jboss.resteasy.core.interception.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:355)
> at org.jboss.resteasy.core.SynchronousDispatcher.preprocess(SynchronousDispatcher.java:138)
> at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:215)
> at org.jboss.resteasy.plugins.server.servlet.ServletContainerDispatcher.service(ServletContainerDispatcher.java:227)
> at org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:56)
> at org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:51)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
> at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
> at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
> at io.opentracing.contrib.jaxrs2.server.SpanFinishingFilter.doFilter(SpanFinishingFilter.java:55)
> at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
> at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
> at io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84)
> at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
> at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
> at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
> at org.wildfly.extension.undertow.security.SecurityContextAssociationHandler.handleRequest(SecurityContextAssociationHandler.java:78)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:132)
> at io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
> at io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
> at io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60)
> at io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77)
> at io.undertow.security.handlers.NotificationReceiverHandler.handleRequest(NotificationReceiverHandler.java:50)
> at io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:61)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:68)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:292)
> at io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:81)
> at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:138)
> at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135)
> at io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
> at io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
> at org.wildfly.extension.undertow.security.SecurityContextThreadSetupAction.lambda$create$0(SecurityContextThreadSetupAction.java:105)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1502)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1502)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1502)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1502)
> at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:272)
> at io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:81)
> at io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:104)
> at io.undertow.server.Connectors.executeRootHandler(Connectors.java:360)
> at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830)
> at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
> at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1378)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> Links:
> * [forum|https://developer.jboss.org/thread/278822]
> * WFLY-11566
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFLY-13013) Elytron LDAP can't set-password in Active Directory or react to external changes
by David Guthrie (Jira)
David Guthrie created WFLY-13013:
------------------------------------
Summary: Elytron LDAP can't set-password in Active Directory or react to external changes
Key: WFLY-13013
URL: https://issues.redhat.com/browse/WFLY-13013
Project: WildFly
Issue Type: Feature Request
Components: Security
Affects Versions: 19.0.0.Beta1, 18.0.1.Final
Reporter: David Guthrie
Assignee: Darran Lofthouse
The caching realm seems to work as advertised with open ldap and Red Hat Directory Server when I add a user-password-mapper after setting:
<user-password-mapper from="userPassword" writable="true" verifiable="true" />
When I change the password in LDAP, the caching realm reacts, and I can login with the new password. Also when I call `set-password`:
/subsystem=elytron/ldap-realm=ldap-realm:set-password(identity=testUser, clear=
{password="1A3b6w"}
)
It changes the password correctly in LDAP.
Neither of these work in Active Directory. Active Directory stores the password, by default using the field "UnicodePwd" rather than "userPassword", so I tried having them map the user password to that field:
/subsystem=elytron/ldap-realm=ldap-realm:write-attribute(name=identity-mapping.user-password-mapper.from, value=UnicodePwd)
But it it can't set the password because the password code needs to write it with a different character set when writing to active directory. See the different between the code in ldap/UserPasswordCredentialLoader.java and in the special case for Active Directory in Keycloak[1]
It can't react to external changes to the directory because Active Directory doesn't support the listening mechanism used.
There is a potential to be able to change the active directory settings so "userPassword" runs in compatibility mode[2], but that's not a normal thing to be able to do is most environments.
[1] Keycloak - AD UnicodePWD https://github.com/keycloak/keycloak/blob/e12c245355f5fcbabab4a6807a9975f...
[2] https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/f3ad...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months