[JBoss JIRA] (DROOLS-4965) [DMN Designer] Dragged structure fields nest in a counterintuitive way
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-4965?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-4965:
-----------------------------------
Labels: drools-tools (was: )
> [DMN Designer] Dragged structure fields nest in a counterintuitive way
> ----------------------------------------------------------------------
>
> Key: DROOLS-4965
> URL: https://issues.redhat.com/browse/DROOLS-4965
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.32.0.Final
> Reporter: Edoardo Vacchi
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: drag-1.gif
>
>
> Because the handle is aligned leftmost, I tend to keep it aligned to the left;
> but this causes the field to be "unnested" and moved to toplevel.
> I suggest to draw the handle aligned to label, instead of the border, suggesting that drag has to start from that point
> !drag-1.gif!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (DROOLS-4966) [DMN Designer] Dragging a field at the bottom of type designer
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-4966?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-4966:
-----------------------------------
Labels: drools-tools (was: )
> [DMN Designer] Dragging a field at the bottom of type designer
> ---------------------------------------------------------------
>
> Key: DROOLS-4966
> URL: https://issues.redhat.com/browse/DROOLS-4966
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.32.0.Final
> Reporter: Edoardo Vacchi
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: drag-2.gif
>
>
> - add several fields/structures so that the list exceeds the viewport
> - scroll down to the bottom of the editor
> - try dragging the bottom field
> - the view does not scroll, but the field will jump "up" at seemingly random positions at the top
> it's nearly impossible to reorder a field when it's at the bottom
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (DROOLS-4968) Guided Rule Editor removes matches statement from rule
by Daniel José dos Santos (Jira)
[ https://issues.redhat.com/browse/DROOLS-4968?page=com.atlassian.jira.plug... ]
Daniel José dos Santos updated DROOLS-4968:
-------------------------------------------
Tester: Jozef Marko (was: Anna Dupliak)
> Guided Rule Editor removes matches statement from rule
> ------------------------------------------------------
>
> Key: DROOLS-4968
> URL: https://issues.redhat.com/browse/DROOLS-4968
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Affects Versions: 7.31.0.Final
> Reporter: Daniel José dos Santos
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools, support
>
> A rdrl file containing the following constraint is changed after being opened with the Guided Rule Editor in business central:
> * before:
> {code}
> FactA(type == "A", (symbol != null && matches "P.*") || (symbol != null && matches "p.*") )
> {code}
> * after:
> {code}
> FactA(type == "A", (symbol != null && ) || (symbol != null && ) )
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (DROOLS-4968) Guided Rule Editor removes matches statement from rule
by Daniel José dos Santos (Jira)
[ https://issues.redhat.com/browse/DROOLS-4968?page=com.atlassian.jira.plug... ]
Daniel José dos Santos moved RHPAM-2652 to DROOLS-4968:
-------------------------------------------------------
Project: Drools (was: Red Hat Process Automation Manager)
Key: DROOLS-4968 (was: RHPAM-2652)
Workflow: GIT Pull Request workflow (was: CDW with docs v1)
Docs QE Status: NEW
Component/s: Guided Decision Table Editor
(was: Business Central)
Affects Version/s: 7.31.0.Final
(was: 7.5.1.GA)
QE Status: NEW
> Guided Rule Editor removes matches statement from rule
> ------------------------------------------------------
>
> Key: DROOLS-4968
> URL: https://issues.redhat.com/browse/DROOLS-4968
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Affects Versions: 7.31.0.Final
> Reporter: Daniel José dos Santos
> Assignee: Daniel José dos Santos
> Priority: Major
> Labels: drools-tools, support
>
> A rdrl file containing the following constraint is changed after being opened with the Guided Rule Editor in business central:
> * before:
> {code}
> FactA(type == "A", (symbol != null && matches "P.*") || (symbol != null && matches "p.*") )
> {code}
> * after:
> {code}
> FactA(type == "A", (symbol != null && ) || (symbol != null && ) )
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (DROOLS-4967) decision table rules are not loaded into kiebase
by Volodymyr Shymkiv (Jira)
Volodymyr Shymkiv created DROOLS-4967:
-----------------------------------------
Summary: decision table rules are not loaded into kiebase
Key: DROOLS-4967
URL: https://issues.redhat.com/browse/DROOLS-4967
Project: Drools
Issue Type: Bug
Components: decision tables
Affects Versions: 7.31.0.Final, 7.30.0.Final, 7.29.0.Final, 7.28.0.Final, 7.27.0.Final, 7.26.0.Final, 7.25.0.Final, 7.24.0.Final, 7.23.0.Final, 7.22.0.Final, 7.21.0.Final
Reporter: Volodymyr Shymkiv
Assignee: Mario Fusco
When compiling xls decision table, wrong ruleset name is parsed from the xls file. This can lead to multiple issues, like rules being filtered out by kmodule.xml configuration.
According to documentation, decision table begins with a cell at second or third column, having value RuleSet. The cell on the right of this one contains the name of the rule set, which we want to use as a package name.
The problem lies in naive approach to parsing the package name from the xls file. As you can see in project drools-compiler, class org.drools.compiler.kie.builder.impl.KieBuilderImpl method packageNameFromDtable, it execute as follows:
# find "RuleSet" string in the binary data
# find and return the nearest string which can act as a valid java package name
The problem is, the string returned from packageNameFromDtable is NOT the value of the cell next to the RuleSet. It is actually a value of a random cell.
To understand the problem, we need to understand the binary content of the actual xls file. Every cell is presented as a few bytes, containing cell's value, position, and other information. The "problematic" thing here is, the _order_ of the cells in the binary data is NOT constant. BUT the code really just reads the cell _binary_ next to the "RuleSet" cell.
Problem is present since version 7.21 as it is caused by a fix for DROOLS-3888 - commit 9a179b6e6b955889200b0258ccd18cd1a5f14b46
In our case, this results in rules not being loaded, as they are filtered out by kmodule.xml configuration. We have a lot of decision tables we want to migrate from an older drools version, and most of them are now ignored due to this bug.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months