[Red Hat JIRA] (WFLY-14132) jboss-ejb3.xml is ignored for exploded deployments
by Cheng Fang (Jira)
[ https://issues.redhat.com/browse/WFLY-14132?page=com.atlassian.jira.plugi... ]
Cheng Fang edited comment on WFLY-14132 at 12/8/20 11:06 AM:
-------------------------------------------------------------
[~jgmeligmeyling] when deploying an exploded directory (copying to {{.../deployments}}) that does not end with valid extensions (.jar, .war, etc), do you see any other errors/warnings, besides ejb-jar.xml and jboss-ejb3.xml being ignored? From my above comment, other parts would also fail, for example,
{code}
2020-12-07 23:56:54,063 ERROR [org.jboss.as.server.deployment.scanner] (DeploymentScanner-threads - 2) WFLYDS0011: The deployment scanner found a directory named META-INF that was not inside a directory whose name ends with .ear, .jar, .rar, .sar or .war. This is likely the result of unzipping an archive directly inside the xxx/build/target/wildfly-22.0.0.Beta1-SNAPSHOT/standalone/deployments directory, which is a user error. The META-INF directory will not be scanned for deployments, but it is possible that the scanner may find other files from the unzipped archive and attempt to deploy them, leading to errors.
{code}
We could fix ejb3 {{EjbJarParsingDeploymentUnitProcessor}} with {{deploymentUnit.getName()}, but errors/warning from other parts will still prevent you from reliably deploying such exploded content without proper extension.
was (Author: cfang):
[~jgmeligmeyling] when deploying an exploded directory (copying to {{.../deployments}}) that does not end with valid extensions (.jar, .war, etc), do you see any other errors/warnings, besides ejb-jar.xml and jboss-ejb3.xml being ignored? From my above comment, other parts would also fail, for example,
{code}
2020-12-07 23:56:54,063 ERROR [org.jboss.as.server.deployment.scanner] (DeploymentScanner-threads - 2) WFLYDS0011: The deployment scanner found a directory named META-INF that was not inside a directory whose name ends with .ear, .jar, .rar, .sar or .war. This is likely the result of unzipping an archive directly inside the xxx/build/target/wildfly-22.0.0.Beta1-SNAPSHOT/standalone/deployments directory, which is a user error. The META-INF directory will not be scanned for deployments, but it is possible that the scanner may find other files from the unzipped archive and attempt to deploy them, leading to errors.
{code}
> jboss-ejb3.xml is ignored for exploded deployments
> --------------------------------------------------
>
> Key: WFLY-14132
> URL: https://issues.redhat.com/browse/WFLY-14132
> Project: WildFly
> Issue Type: Bug
> Components: EJB
> Affects Versions: 14.0.1.Final, JBoss AS7 7.1.1.Final, 21.0.1.Final
> Reporter: Jan-Willem Gmelig Meyling
> Assignee: Cheng Fang
> Priority: Major
> Labels: ejb-jar.xml, jboss-ejb3.xml
>
> {{EjbJarParsingDeploymentUnitProcessor}} distinguishes between a WAR and JAR deployment based on the file extension of the name of the deployment root. For exploded deployments however, this deployment root may be a folder without any file extension. As a result the logic fails to detect either a JAR or WAR file and the {{ejb-jar.xml}} and {{jboss-ejb3.xml}} files are ignored. A better way could be to determine the extension from the name of {{DeploymentUnit}} instead.
> Code from: [https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jbo...]
> {code:java}
> private static VirtualFile getDescriptor(final VirtualFile deploymentRoot, final String descriptorName) {
> // Locate the descriptor
> final VirtualFile descriptor;
> // EJB 3.1 FR 20.4 Enterprise Beans Packaged in a .war
> if (isWar(deploymentRoot)) {
> // it's a .war file, so look for the ejb-jar.xml in WEB-INF
> descriptor = deploymentRoot.getChild(WEB_INF + "/" + descriptorName);
> } else if (deploymentRoot.getName().toLowerCase(Locale.ENGLISH).endsWith(JAR_FILE_EXTENSION)) {
> descriptor = deploymentRoot.getChild(META_INF + "/" + descriptorName);
> } else {
> // neither a .jar nor a .war. Return
> return null;
> }
> if (descriptor == null || !descriptor.exists()) {
> // no descriptor found, nothing to do!
> return null;
> }
> return descriptor;
> }
> {code}
>
> I encountered this issue on WildFly 14.0.1.Final, but the code is also present in the current master and goes back to versions as early as 7.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (WFLY-14132) jboss-ejb3.xml is ignored for exploded deployments
by Cheng Fang (Jira)
[ https://issues.redhat.com/browse/WFLY-14132?page=com.atlassian.jira.plugi... ]
Cheng Fang commented on WFLY-14132:
-----------------------------------
[~jgmeligmeyling] when deploying an exploded directory (copying to {{.../deployments}}) that does not end with valid extensions (.jar, .war, etc), do you see any other errors/warnings, besides ejb-jar.xml and jboss-ejb3.xml being ignored? From my above comment, other parts would also fail, for example,
{code}
2020-12-07 23:56:54,063 ERROR [org.jboss.as.server.deployment.scanner] (DeploymentScanner-threads - 2) WFLYDS0011: The deployment scanner found a directory named META-INF that was not inside a directory whose name ends with .ear, .jar, .rar, .sar or .war. This is likely the result of unzipping an archive directly inside the xxx/build/target/wildfly-22.0.0.Beta1-SNAPSHOT/standalone/deployments directory, which is a user error. The META-INF directory will not be scanned for deployments, but it is possible that the scanner may find other files from the unzipped archive and attempt to deploy them, leading to errors.
{code}
> jboss-ejb3.xml is ignored for exploded deployments
> --------------------------------------------------
>
> Key: WFLY-14132
> URL: https://issues.redhat.com/browse/WFLY-14132
> Project: WildFly
> Issue Type: Bug
> Components: EJB
> Affects Versions: 14.0.1.Final, JBoss AS7 7.1.1.Final, 21.0.1.Final
> Reporter: Jan-Willem Gmelig Meyling
> Assignee: Cheng Fang
> Priority: Major
> Labels: ejb-jar.xml, jboss-ejb3.xml
>
> {{EjbJarParsingDeploymentUnitProcessor}} distinguishes between a WAR and JAR deployment based on the file extension of the name of the deployment root. For exploded deployments however, this deployment root may be a folder without any file extension. As a result the logic fails to detect either a JAR or WAR file and the {{ejb-jar.xml}} and {{jboss-ejb3.xml}} files are ignored. A better way could be to determine the extension from the name of {{DeploymentUnit}} instead.
> Code from: [https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jbo...]
> {code:java}
> private static VirtualFile getDescriptor(final VirtualFile deploymentRoot, final String descriptorName) {
> // Locate the descriptor
> final VirtualFile descriptor;
> // EJB 3.1 FR 20.4 Enterprise Beans Packaged in a .war
> if (isWar(deploymentRoot)) {
> // it's a .war file, so look for the ejb-jar.xml in WEB-INF
> descriptor = deploymentRoot.getChild(WEB_INF + "/" + descriptorName);
> } else if (deploymentRoot.getName().toLowerCase(Locale.ENGLISH).endsWith(JAR_FILE_EXTENSION)) {
> descriptor = deploymentRoot.getChild(META_INF + "/" + descriptorName);
> } else {
> // neither a .jar nor a .war. Return
> return null;
> }
> if (descriptor == null || !descriptor.exists()) {
> // no descriptor found, nothing to do!
> return null;
> }
> return descriptor;
> }
> {code}
>
> I encountered this issue on WildFly 14.0.1.Final, but the code is also present in the current master and goes back to versions as early as 7.1.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (DROOLS-5885) [DMN Designer] Decision Table Column width is not preserved
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5885?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-5885:
--------------------------------
Description: The column width of the decision table boxed expression is not preserved after save and reopen operation. The issue is probably the same for all expression types (context, function ...) (was: The validation messages are shown multiple times when user switch between DRDs of the DMN model.)
> [DMN Designer] Decision Table Column width is not preserved
> -----------------------------------------------------------
>
> Key: DROOLS-5885
> URL: https://issues.redhat.com/browse/DROOLS-5885
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.48.0.Final
> Reporter: Jozef Marko
> Assignee: Guilherme Gomes
> Priority: Major
> Attachments: borders crossing.dmn, column-width.webm
>
>
> The column width of the decision table boxed expression is not preserved after save and reopen operation. The issue is probably the same for all expression types (context, function ...)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (DROOLS-5885) [DMN Designer] Decision Table Column width is not preserved
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5885?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-5885:
--------------------------------
Steps to Reproduce:
# Import the attached [^borders crossing.dmn] to any business central project
# Open the dmn file
# Open the 'returning to home country -> Can Pass Borders' Decision table
# Change some column width
# Save and reopen the DMN file
# Navigate to the same Decision Table
Current: Column width will be reset to the default
Expected: The column width will be preserved according to the state during saving
was:
# Import the attached [^borders crossing.dmn] to any business central project
# Open the dmn file
# Validate
# Select another DRD, validate => (two validation result notifications)
# Select another DRD, validate => (three validation result notifications)
Expected just one validation result notification
> [DMN Designer] Decision Table Column width is not preserved
> -----------------------------------------------------------
>
> Key: DROOLS-5885
> URL: https://issues.redhat.com/browse/DROOLS-5885
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.48.0.Final
> Reporter: Jozef Marko
> Assignee: Guilherme Gomes
> Priority: Major
> Attachments: borders crossing.dmn, column-width.webm
>
>
> The validation messages are shown multiple times when user switch between DRDs of the DMN model.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[Red Hat JIRA] (WFLY-14107) EJBInvocationStatistics TestCase Failures
by Cheng Fang (Jira)
[ https://issues.redhat.com/browse/WFLY-14107?page=com.atlassian.jira.plugi... ]
Cheng Fang commented on WFLY-14107:
-----------------------------------
Linked to the previously fixed issue in the same testcase (WFLY-10173).
> EJBInvocationStatistics TestCase Failures
> -----------------------------------------
>
> Key: WFLY-14107
> URL: https://issues.redhat.com/browse/WFLY-14107
> Project: WildFly
> Issue Type: Bug
> Components: EJB, Test Suite
> Reporter: Darran Lofthouse
> Assignee: Cheng Fang
> Priority: Major
>
> I have been seeing test failures running this test locally quite often:
> {code:java}
> [ERROR] Failures:
> [ERROR] EjbInvocationStatisticsTestCase.testSingletonWaitTime:147->validateWaitTimeStatistic:175 Expecting wait-time attribute value > 0, but got {
> "async-methods" => undefined,
> "business-local" => undefined,
> "business-remote" => ["org.jboss.as.test.integration.ejb.management.deployments.BusinessInterface"],
> "component-class-name" => "org.jboss.as.test.integration.ejb.management.deployments.WaitTimeSingletonBean",
> "concurrency-management-type" => undefined,
> "declared-roles" => [],
> "depends-on" => undefined,
> "execution-time" => 2L,
> "init-on-startup" => false,
> "invocations" => 4L,
> "jndi-names" => [
> "java:app/ejb-management/WaitTimeSingletonBean!org.jboss.as.test.integration.ejb.management.deployments.BusinessInterface",
> "java:module/WaitTimeSingletonBean!org.jboss.as.test.integration.ejb.management.deployments.BusinessInterface",
> "java:global/ejb-management/WaitTimeSingletonBean",
> "java:app/ejb-management/WaitTimeSingletonBean",
> "java:global/ejb-management/WaitTimeSingletonBean!org.jboss.as.test.integration.ejb.management.deployments.BusinessInterface",
> "java:module/WaitTimeSingletonBean"
> ],
> "methods" => {
> "doIt" => {
> "execution-time" => 2L,
> "invocations" => 3L,
> "wait-time" => 0L
> },
> "remove" => {
> "execution-time" => 0L,
> "invocations" => 1L,
> "wait-time" => 0L
> }
> },
> "peak-concurrent-invocations" => 1L,
> "run-as-role" => undefined,
> "security-domain" => "other",
> "timeout-method" => "private void org.jboss.as.test.integration.ejb.management.deployments.WaitTimeSingletonBean.timeout(javax.ejb.Timer)",
> "timers" => [],
> "transaction-type" => "BEAN",
> "wait-time" => 0L,
> "service" => {"timer-service" => undefined}
> } {code}
> My desktop PC is quite fast so I don't know if this means invocations are passing faster than the test expects.
>
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months